125551 2013-12-10 16:58:30 -0800 Add a HashMap constructor that takes an initializer list 2013-12-12 00:04:36 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin cmarcelo commit-queue oldest_to_newest 958574 0 andersca 2013-12-10 16:58:30 -0800 Add a HashMap constructor that takes an initializer list 958575 1 218925 andersca 2013-12-10 17:01:47 -0800 Created attachment 218925 Patch 958577 2 andersca 2013-12-10 17:05:28 -0800 Committed r160400: <http://trac.webkit.org/changeset/160400> 959073 3 218925 darin 2013-12-12 00:04:36 -0800 Comment on attachment 218925 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218925&action=review > Source/WTF/wtf/HashMap.h:79 > + HashMap(std::initializer_list<KeyValuePairType> initializerList) > + { > + for (const auto& keyValuePair : initializerList) > + add(keyValuePair.key, keyValuePair.value); > + } Can we do better efficiency-wise? 218925 2013-12-10 17:01:47 -0800 2013-12-12 00:04:35 -0800 Patch bug-125551-20131210170146.patch text/plain 2941 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMzk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGViNzYwYjMyYzY4ZDM0YjcxOTM1ZmU5 MzA0NjkzOWZhMWM2ZDkzODUuLjY2YmQwZGRiMDE1NjI5YjRhODRjOWYyN2I1Y2E3OGRlNjkxM2Mw NjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMTItMTAgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgYSBIYXNoTWFwIGNvbnN0cnVjdG9yIHRo YXQgdGFrZXMgYW4gaW5pdGlhbGl6ZXIgbGlzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1NTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvSGFzaE1hcC5oOgorICAgICAgICAoV1RGOjpIYXNo TWFwOjpIYXNoTWFwKToKKwogMjAxMy0xMi0xMCAgTGFzemxvIFZpZGFjcyAgPGxhY0BpbmYudS1z emVnZWQuaHU+CiAKICAgICAgICAgVXNlIHN0ZDo6YXJyYXkgd2hlbiBjb21wdXRpbmcgTUQ1IGNo ZWNrc3VtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9IYXNoTWFwLmggYi9Tb3VyY2UvV1RG L3d0Zi9IYXNoTWFwLmgKaW5kZXggYzQ2Zjc2ZTM5OTI3YzBkNDUzMGM3YzMwMTllZDUyMDAxNzNj YWVlMy4uMGMyZTYwNDNmZjNlOGM1ZmQzYjIwZjQ2ZjBhOTQ5NTA2NWQ3OWRhYyAxMDA2NDQKLS0t IGEvU291cmNlL1dURi93dGYvSGFzaE1hcC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0hhc2hNYXAu aApAQCAtNjcsNiArNjcsMTggQEAgcHVibGljOgogICAgIHR5cGVkZWYgdHlwZW5hbWUgSGFzaFRh YmxlVHlwZTo6QWRkUmVzdWx0IEFkZFJlc3VsdDsKIAogcHVibGljOgorICAgIEhhc2hNYXAoKQor ICAgIHsKKyAgICB9CisKKyNpZiBDT01QSUxFUl9TVVBQT1JUUyhDWFhfR0VORVJBTElaRURfSU5J VElBTElaRVJTKQorICAgIEhhc2hNYXAoc3RkOjppbml0aWFsaXplcl9saXN0PEtleVZhbHVlUGFp clR5cGU+IGluaXRpYWxpemVyTGlzdCkKKyAgICB7CisgICAgICAgIGZvciAoY29uc3QgYXV0byYg a2V5VmFsdWVQYWlyIDogaW5pdGlhbGl6ZXJMaXN0KQorICAgICAgICAgICAgYWRkKGtleVZhbHVl UGFpci5rZXksIGtleVZhbHVlUGFpci52YWx1ZSk7CisgICAgfQorI2VuZGlmCisKICAgICB2b2lk IHN3YXAoSGFzaE1hcCYpOwogCiAgICAgaW50IHNpemUoKSBjb25zdDsKZGlmZiAtLWdpdCBhL1Rv b2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1NmRmNDE3M2EwNzYxMmI0MDIy MGE3ZmU4MzYwMTBhM2I2YWExZTcxLi5jZDg5NDNlZmYwNjZmMzE4NTgzYzJjMjk3NjVhMTAwZjc5 ZWU0ZDM3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMTItMTAgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2Nh QGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgYSBIYXNoTWFwIGNvbnN0cnVjdG9yIHRoYXQgdGFr ZXMgYW4gaW5pdGlhbGl6ZXIgbGlzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTI1NTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9IYXNoTWFwLmNwcDoKKyAg ICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDEzLTEyLTEwICBMYXN6bG8gVmlkYWNz ICA8bGFjQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBVc2Ugc3RkOjphcnJheSB3aGVuIGNv bXB1dGluZyBNRDUgY2hlY2tzdW0KZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvV1RGL0hhc2hNYXAuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvSGFzaE1h cC5jcHAKaW5kZXggZTQ0YjZhM2EyOGUyMDI4MDI5NzQ4YmZjYzI3MzhhMzA1ZDdhOGY5OS4uNDcx Njg3Njg3MDQ5M2ViYTVkMTdmNWFjYWMxOGY2ZTQ0MGU5ZTExNiAxMDA2NDQKLS0tIGEvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvSGFzaE1hcC5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XVEYvSGFzaE1hcC5jcHAKQEAgLTI2LDYgKzI2LDcgQEAKICNpbmNsdWRlICJj b25maWcuaCIKIAogI2luY2x1ZGUgIk1vdmVPbmx5LmgiCisjaW5jbHVkZSA8c3RyaW5nPgogI2lu Y2x1ZGUgPHd0Zi9IYXNoTWFwLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5nSGFzaC5oPgog CkBAIC0xMjksNCArMTMwLDI0IEBAIFRFU1QoV1RGX0hhc2hNYXAsIE1vdmVPbmx5S2V5cykKICAg ICBBU1NFUlRfVFJVRShtb3ZlT25seUtleXMuaXNFbXB0eSgpKTsKIH0KIAorI2lmIENPTVBJTEVS X1NVUFBPUlRTKENYWF9HRU5FUkFMSVpFRF9JTklUSUFMSVpFUlMpCitURVNUKFdURl9IYXNoTWFw LCBJbml0aWFsaXplckxpc3QpCit7CisgICAgSGFzaE1hcDx1bnNpZ25lZCwgc3RkOjpzdHJpbmc+ IG1hcCA9IHsKKyAgICAgICAgeyAxLCAib25lIiB9LAorICAgICAgICB7IDIsICJ0d28iIH0sCisg ICAgICAgIHsgMywgInRocmVlIiB9LAorICAgICAgICB7IDQsICJmb3VyIiB9LAorICAgIH07CisK KyAgICBFWFBFQ1RfRVEoNCwgbWFwLnNpemUoKSk7CisKKyAgICBFWFBFQ1RfRVEoIm9uZSIsIG1h cC5nZXQoMSkpOworICAgIEVYUEVDVF9FUSgidHdvIiwgbWFwLmdldCgyKSk7CisgICAgRVhQRUNU X0VRKCJ0aHJlZSIsIG1hcC5nZXQoMykpOworICAgIEVYUEVDVF9FUSgiZm91ciIsIG1hcC5nZXQo NCkpOworICAgIEVYUEVDVF9FUShzdGQ6OnN0cmluZygpLCBtYXAuZ2V0KDUpKTsKK30KKyNlbmRp ZgorCiB9IC8vIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJCg==