125550 2013-12-10 16:22:45 -0800 Horizontal rubber-banding without a horizontal scrollbar is distracting 2014-02-26 09:56:24 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin jonlee kling mehmet.sahin simon.fraser thorton oldest_to_newest 958557 0 bdakin 2013-12-10 16:22:45 -0800 Horizontal rubber-banding without a horizontal scrollbar is distracting. We should only allow horizontal rubber-banding when there is content to scroll to. <rdar://problem/14137306> 958559 1 218919 bdakin 2013-12-10 16:26:13 -0800 Created attachment 218919 Patch 958564 2 bdakin 2013-12-10 16:51:36 -0800 http://trac.webkit.org/changeset/160397 958837 3 kling 2013-12-11 11:42:51 -0800 This is my favorite change ever. 984432 4 mehmet.sahin 2014-02-25 12:30:15 -0800 @Beth Dakin: Is this reverted again in latest Webkit? I do not see the fix any longer in Webkit r164641 :-( 984446 5 bdakin 2014-02-25 12:40:26 -0800 (In reply to comment #4) > @Beth Dakin: Is this reverted again in latest Webkit? I do not see the fix any longer in Webkit r164641 :-( It is, sorry about that. I reverted the change as a part of http://trac.webkit.org/changeset/163180 We are still having an ongoing discussion about the best behavior here, so it's not all said and done quite yet. Actually it would probably be best to formalize that discussion in a bug report where multiple people can weigh in (so far it has mostly been in-person discussions). 984460 6 mehmet.sahin 2014-02-25 13:10:38 -0800 (In reply to comment #5) > (In reply to comment #4) > > @Beth Dakin: Is this reverted again in latest Webkit? I do not see the fix any longer in Webkit r164641 :-( > > It is, sorry about that. I reverted the change as a part of http://trac.webkit.org/changeset/163180 > > We are still having an ongoing discussion about the best behavior here, so it's not all said and done quite yet. Actually it would probably be best to formalize that discussion in a bug report where multiple people can weigh in (so far it has mostly been in-person discussions). Thanks for the information. Should I open a bug report for the discussion? 984520 7 bdakin 2014-02-25 15:55:43 -0800 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > @Beth Dakin: Is this reverted again in latest Webkit? I do not see the fix any longer in Webkit r164641 :-( > > > > It is, sorry about that. I reverted the change as a part of http://trac.webkit.org/changeset/163180 > > > > We are still having an ongoing discussion about the best behavior here, so it's not all said and done quite yet. Actually it would probably be best to formalize that discussion in a bug report where multiple people can weigh in (so far it has mostly been in-person discussions). > > Thanks for the information. Should I open a bug report for the discussion? That would be great! Thanks! 984777 8 mehmet.sahin 2014-02-26 09:56:24 -0800 (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > (In reply to comment #4) > > > > @Beth Dakin: Is this reverted again in latest Webkit? I do not see the fix any longer in Webkit r164641 :-( > > > > > > It is, sorry about that. I reverted the change as a part of http://trac.webkit.org/changeset/163180 > > > > > > We are still having an ongoing discussion about the best behavior here, so it's not all said and done quite yet. Actually it would probably be best to formalize that discussion in a bug report where multiple people can weigh in (so far it has mostly been in-person discussions). > > > > Thanks for the information. Should I open a bug report for the discussion? > > That would be great! Thanks! Bug 129374 :-) 218919 2013-12-10 16:26:13 -0800 2013-12-10 16:42:47 -0800 Patch for-review.txt text/plain 1317 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MDM5NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEzLTEyLTEwICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBIb3Jpem9udGFsIHJ1YmJlci1iYW5k aW5nIHdpdGhvdXQgYSBob3Jpem9udGFsIHNjcm9sbGJhciBpcyBkaXN0cmFjdGluZworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1NTUwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2V0dGluZyB0aGUgU2Ny b2xsRWxhc3RpY2l0eSB0byBTY3JvbGxFbGFzdGljaXR5QXV0b21hdGljIHdpbGwgbWFrZSBzdXJl IHdlIG9ubHkgCisgICAgICAgIHJ1YmJlci1iYW5kIGhvcml6b250YWxseSB3aGVuIHRoZXJlIGlz IGEgaG9yaXpvbnRhbCBzY3JvbGxiYXIuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OkZyYW1lVmlldyk6CisKIDIwMTMtMTItMTAg IFJvYiBCdWlzICA8cm9iLmJ1aXNAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgQ2xlYW4gdXAgU1ZH U2NyaXB0RWxlbWVudApJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAkocmV2aXNpb24g MTYwMzg0KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0yMDUsNyArMjA1LDcgQEAgRnJhbWVWaWV3OjpGcmFtZVZpZXcoRnJhbWUmIGZyYW1l KQogCiAgICAgaWYgKGZyYW1lLmlzTWFpbkZyYW1lKCkpIHsKICAgICAgICAgU2Nyb2xsYWJsZUFy ZWE6OnNldFZlcnRpY2FsU2Nyb2xsRWxhc3RpY2l0eShTY3JvbGxFbGFzdGljaXR5QWxsb3dlZCk7 Ci0gICAgICAgIFNjcm9sbGFibGVBcmVhOjpzZXRIb3Jpem9udGFsU2Nyb2xsRWxhc3RpY2l0eShT Y3JvbGxFbGFzdGljaXR5QWxsb3dlZCk7CisgICAgICAgIFNjcm9sbGFibGVBcmVhOjpzZXRIb3Jp em9udGFsU2Nyb2xsRWxhc3RpY2l0eShTY3JvbGxFbGFzdGljaXR5QXV0b21hdGljKTsKICAgICB9 CiB9CiAK