125541 2013-12-10 13:30:43 -0800 [WebGL] Fix build on GL ES 2.0 targets after r160119 2013-12-16 21:53:16 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 110936 1 ralpht+bugs webkit-unassigned alex.christensen changseok commit-queue dino kondapallykalyan noam roger_fong oldest_to_newest 958498 0 ralpht+bugs 2013-12-10 13:30:43 -0800 [WebGL] Fix build on GL ES 2.0 targets after r160119 958499 1 218903 ralpht+bugs 2013-12-10 13:32:15 -0800 Created attachment 218903 Patch 958500 2 ralpht+bugs 2013-12-10 13:35:38 -0800 This is needed to fix compilation on GL ES 2.0 targets. I haven't tested half float functionality through WebGL on any GL ES 2.0 devices yet, though. 958866 3 alex.christensen 2013-12-11 12:53:34 -0800 I proposed the same solution in https://bugs.webkit.org/show_bug.cgi?id=125464 but peavo got to it before I did. Should r160119 be removed and this be added in the same patch? 958867 4 alex.christensen 2013-12-11 12:55:42 -0800 I mean should r160324 be removed and this be added in the same patch? r160119 is ok except for this little quirk. 958869 5 ralpht+bugs 2013-12-11 12:57:42 -0800 (In reply to comment #4) > I mean should r160324 be removed and this be added in the same patch? r160119 is ok except for this little quirk. Yes, I think so. Let me see if I can do that. 958872 6 218997 ralpht+bugs 2013-12-11 13:11:11 -0800 Created attachment 218997 Patch 958894 7 alex.christensen 2013-12-11 14:09:51 -0800 Looks good to me. There's a reason that's not defined in our GLES headers, and it fixes the compiling error. I'm not a reviewer yet, though... 958901 8 218997 bfulgham 2013-12-11 14:19:39 -0800 Comment on attachment 218997 Patch Looks good to me. r=me 958923 9 218997 commit-queue 2013-12-11 14:43:44 -0800 Comment on attachment 218997 Patch Clearing flags on attachment: 218997 Committed r160458: <http://trac.webkit.org/changeset/160458> 958924 10 commit-queue 2013-12-11 14:43:47 -0800 All reviewed patches have been landed. Closing bug. 960397 11 changseok 2013-12-16 21:53:16 -0800 *** Bug 125293 has been marked as a duplicate of this bug. *** 218903 2013-12-10 13:32:15 -0800 2013-12-11 13:11:06 -0800 Patch bug-125541-20131210133214.patch text/plain 1772 ralpht+bugs U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTc2ZGJlZGUzYzQxMzRk MWRkMThlNTNiOTczYzAxYzYxZDVjNmMyZS4uMjIwYjQ5NDU2OGY3NmYxM2NjMjYyNDJmNjlkMzg5 OWYzYzA0MDRkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTEyLTEwICBSYWxw aCBUaG9tYXMgIDxyYWxwaHRAZ21haWwuY29tPgorCisgICAgICAgIFtXZWJHTF0gRml4IGJ1aWxk IG9uIEdMIEVTIDIuMCB0YXJnZXRzIGFmdGVyIHIxNjAxMTkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTU0MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdMIEVTIDIuMCBkb2Vzbid0IGRlZmluZSBHTF9I QUxGX0ZMT0FUX0FSQiwgc28gcGFzcyB0aHJvdWdoIEhBTEZfRkxPQVRfT0VTICh3aGljaCBpcyBk ZWZpbmVkIGZvciBHTCBFUyAyLjApLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gY2hhbmdl IGluIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wv R3JhcGhpY3NDb250ZXh0M0RPcGVuR0xDb21tb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3Jh cGhpY3NDb250ZXh0M0Q6OnRleFN1YkltYWdlMkQpOgorCiAyMDEzLTEyLTEwICBNYXJpbyBTYW5j aGV6IFByYWRhICA8bWFyaW8ucHJhZGFAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0FUS10gRXhw b3NlIHNwbGl0dGVyIGVsZW1lbnRzIHdpdGggQVRLX1JPTEVfU0VQQVJBVE9SCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0 M0RPcGVuR0xDb21tb24uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3Bl bmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29tbW9uLmNwcAppbmRleCBhYmY0ZmIyYmZmOTk4 MGFkMWFlMjRhNmNiN2YxNjc1MzU5MzE3MzY5Li5jNDYwMGMyMDliM2Y5NWEyZTkxYzBjYTk2ZGJi NDM1MWJmMDVhYTA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0xDb21tb24uY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTENv bW1vbi5jcHAKQEAgLTEzNjUsOCArMTM2NSwxMCBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjp0 ZXhTdWJJbWFnZTJEKEdDM0RlbnVtIHRhcmdldCwgR0MzRGludCBsZXZlbCwgR0MzRGludCB4bwog ewogICAgIG1ha2VDb250ZXh0Q3VycmVudCgpOwogCisjaWYgIVVTRShPUEVOR0xfRVNfMikKICAg ICBpZiAodHlwZSA9PSBIQUxGX0ZMT0FUX09FUykKICAgICAgICAgdHlwZSA9IEdMX0hBTEZfRkxP QVRfQVJCOworI2VuZGlmCiAKICAgICAvLyBGSVhNRTogd2Ugd2lsbCBuZWVkIHRvIGRlYWwgd2l0 aCBQaXhlbFN0b3JlIHBhcmFtcyB3aGVuIGRlYWxpbmcgd2l0aCBpbWFnZSBidWZmZXJzIHRoYXQg ZGlmZmVyIGZyb20gdGhlIHN1YmltYWdlIHNpemUuCiAgICAgOjpnbFRleFN1YkltYWdlMkQodGFy Z2V0LCBsZXZlbCwgeG9mZiwgeW9mZiwgd2lkdGgsIGhlaWdodCwgZm9ybWF0LCB0eXBlLCBwaXhl bHMpOwo= 218997 2013-12-11 13:11:11 -0800 2013-12-11 14:43:44 -0800 Patch bug-125541-20131211131111.patch text/plain 2623 ralpht+bugs U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwNDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2IwNTljYmM3YjM1ZTQ3 MGNhMDM4MDg0MzEyMjgyMzhmMWJkZWRlMy4uMTJkNTI4NzNhNWE0Y2MzMzZiZDY1YzJhNTgwODU5 ODZmYzczZTZkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTEyLTExICBSYWxw aCBUaG9tYXMgIDxyYWxwaHRAZ21haWwuY29tPgorCisgICAgICAgIFtXZWJHTF0gRml4IGJ1aWxk IG9uIEdMIEVTIDIuMCB0YXJnZXRzIGFmdGVyIHIxNjAxMTkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTU0MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdMIEVTIDIuMCBkb2Vzbid0IGRlZmluZSBHTF9I QUxGX0ZMT0FUX0FSQiwgc28gcGFzcyB0aHJvdWdoIEhBTEZfRkxPQVRfT0VTICh3aGljaCBpcyBk ZWZpbmVkIGZvciBHTCBFUyAyLjApLgorICAgICAgICBUaGlzIGNoYW5nZSBhbHNvIHJldmVydHMg cjE2MDMyNCB3aGljaCBpbmNvcnJlY3RseSBkZWZpbmVkIEdMX0hBTEZfRkxPQVRfQVJCIGZvciB0 aGUgV2luZG93cyBBTkdMRSB0YXJnZXQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBjaGFu Z2UgaW4gZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5n bC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpH cmFwaGljc0NvbnRleHQzRDo6dGV4U3ViSW1hZ2UyRCk6CisKIDIwMTMtMTItMTEgIE1hcmlvIFNh bmNoZXogUHJhZGEgIDxtYXJpby5wcmFkYUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbQVRLXSBF eHBvc2UgYWNjZXNzaWJpbGl0eSBvYmplY3RzIFdBSS1BUklBIGxhbmRtYXJrIHJvbGVzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9u czNET3BlbkdMRVMuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9F eHRlbnNpb25zM0RPcGVuR0xFUy5oCmluZGV4IGMxOGZiZDM1ZjdlNTMxYzkyMDkzMzg2OTRhZjVi ZjlhMjAxOTIwMGEuLmU0MTFmYmVmNTdhMzE1YjkwMDM1MGFkNGUzZjVjZGY2ZTk4NDMyZDQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNp b25zM0RPcGVuR0xFUy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29w ZW5nbC9FeHRlbnNpb25zM0RPcGVuR0xFUy5oCkBAIC0zOSwxMiArMzksNiBAQAogI2RlZmluZSBQ Rk5HTFJFTkRFUkJVRkZFUlNUT1JBR0VNVUxUSVNBTVBMRUlNRyBQRk5HTFJFTkRFUkJVRkZFUlNU T1JBR0VNVUxUSVNBTVBMRUlNR1BST0MKICNlbmRpZgogCi0jaWYgUExBVEZPUk0oV0lOKSAmJiBV U0UoT1BFTkdMX0VTXzIpCi0jaWZuZGVmIEdMX0FSQl9oYWxmX2Zsb2F0X3BpeGVsCi0jZGVmaW5l IEdMX0hBTEZfRkxPQVRfQVJCICAgICAgICAgICAgICAgICAweDE0MEIKLSNlbmRpZgotI2VuZGlm Ci0KICNpZm5kZWYgR0xfRVhUX3JvYnVzdG5lc3MKIC8qIHJldXNlIEdMX05PX0VSUk9SICovCiAj ZGVmaW5lIEdMX0dVSUxUWV9DT05URVhUX1JFU0VUX0VYVCAweDgyNTMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9w ZW5HTENvbW1vbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wv R3JhcGhpY3NDb250ZXh0M0RPcGVuR0xDb21tb24uY3BwCmluZGV4IGFiZjRmYjJiZmY5OTgwYWQx YWUyNGE2Y2I3ZjE2NzUzNTkzMTczNjkuLmM0NjAwYzIwOWIzZjk1YTJlOTFjMGNhOTZkYmI0MzUx YmYwNWFhMDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29w ZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29tbW9u LmNwcApAQCAtMTM2NSw4ICsxMzY1LDEwIEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OnRleFN1 YkltYWdlMkQoR0MzRGVudW0gdGFyZ2V0LCBHQzNEaW50IGxldmVsLCBHQzNEaW50IHhvCiB7CiAg ICAgbWFrZUNvbnRleHRDdXJyZW50KCk7CiAKKyNpZiAhVVNFKE9QRU5HTF9FU18yKQogICAgIGlm ICh0eXBlID09IEhBTEZfRkxPQVRfT0VTKQogICAgICAgICB0eXBlID0gR0xfSEFMRl9GTE9BVF9B UkI7CisjZW5kaWYKIAogICAgIC8vIEZJWE1FOiB3ZSB3aWxsIG5lZWQgdG8gZGVhbCB3aXRoIFBp eGVsU3RvcmUgcGFyYW1zIHdoZW4gZGVhbGluZyB3aXRoIGltYWdlIGJ1ZmZlcnMgdGhhdCBkaWZm ZXIgZnJvbSB0aGUgc3ViaW1hZ2Ugc2l6ZS4KICAgICA6OmdsVGV4U3ViSW1hZ2UyRCh0YXJnZXQs IGxldmVsLCB4b2ZmLCB5b2ZmLCB3aWR0aCwgaGVpZ2h0LCBmb3JtYXQsIHR5cGUsIHBpeGVscyk7 Cg==