125538 2013-12-10 13:14:12 -0800 Simplify CSE's treatment of NodeRelevantToOSR 2013-12-10 18:07:56 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff nrotem oliver sam oldest_to_newest 958486 0 fpizlo 2013-12-10 13:14:12 -0800 CSE does a simplification over Phantoms based on whether the source of the Phantom is relevant to OSR. It does this in a way that totally makes sense if node references are block-local, and I can sort of convince myself that it kind of ought to sort of work for SSA, but it's confusing in its current form. We should simplify this so that it obviously works: if there is any MovHint on a node then the node is relevant to OSR. 958489 1 218900 fpizlo 2013-12-10 13:16:03 -0800 Created attachment 218900 the patch 958590 2 fpizlo 2013-12-10 18:07:56 -0800 Landed in http://trac.webkit.org/changeset/160407 218900 2013-12-10 13:16:03 -0800 2013-12-10 13:20:18 -0800 the patch blah.patch text/plain 4534 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwMzgyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEzLTEyLTEwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg U2ltcGxpZnkgQ1NFJ3MgdHJlYXRtZW50IG9mIE5vZGVSZWxldmFudFRvT1NSCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjU1MzgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIE1ha2UgdGhlIE5v ZGVSZWxldmFudFRvT1NSIHRoaW5nIG9idmlvdXM6IGlmIHRoZXJlIGlzIGFueSBNb3ZIaW50IG9u IGEgbm9kZSB0aGVuIHRoZQorICAgICAgICBub2RlIGlzIHJlbGV2YW50IHRvIE9TUi4KKworICAg ICAgICAqIGRmZy9ERkdDU0VQaGFzZS5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6Q1NFUGhhc2U6 OnJ1bik6CisgICAgICAgIChKU0M6OkRGRzo6Q1NFUGhhc2U6OnBlcmZvcm1Ob2RlQ1NFKToKKyAg ICAgICAgKEpTQzo6REZHOjpDU0VQaGFzZTo6cGVyZm9ybUJsb2NrQ1NFKToKKwogMjAxMy0xMi0x MCAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIEFT U0VSVCAhaGVhcC52bSgpLT5pc0luaXRpYWxpemluZ09iamVjdCgpIHdoZW4gZmluaXNoaW5nIERG RyBjb21waWxhdGlvbiBhdCBiZWdpbm5pbmcgb2YgR0MKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHQ1NFUGhhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHQ1NFUGhhc2UuY3BwCShyZXZpc2lvbiAxNjAzNzIpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR0NTRVBoYXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTUsNiAr NTUsNDcgQEAgcHVibGljOgogICAgICAgICAKICAgICAgICAgbV9ncmFwaC5jbGVhclJlcGxhY2Vt ZW50cygpOwogICAgICAgICAKKyAgICAgICAgZm9yIChCbG9ja0luZGV4IGJsb2NrSW5kZXggPSBt X2dyYXBoLm51bUJsb2NrcygpOyBibG9ja0luZGV4LS07KSB7CisgICAgICAgICAgICBCYXNpY0Js b2NrKiBibG9jayA9IG1fZ3JhcGguYmxvY2soYmxvY2tJbmRleCk7CisgICAgICAgICAgICBpZiAo IWJsb2NrKQorICAgICAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICAgICAgCisgICAgICAg ICAgICAvLyBBbGwgUGhpcyBuZWVkIHRvIGFscmVhZHkgYmUgbWFya2VkIGFzIHJlbGV2YW50IHRv IE9TUi4KKyAgICAgICAgICAgIGlmICghQVNTRVJUX0RJU0FCTEVEKSB7CisgICAgICAgICAgICAg ICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGJsb2NrLT5waGlzLnNpemUoKTsgKytpKQorICAg ICAgICAgICAgICAgICAgICBBU1NFUlQoYmxvY2stPnBoaXNbaV0tPmZsYWdzKCkgJiBOb2RlUmVs ZXZhbnRUb09TUik7CisgICAgICAgICAgICB9CisgICAgICAgICAgICAKKyAgICAgICAgICAgIGZv ciAodW5zaWduZWQgaSA9IGJsb2NrLT5zaXplKCk7IGktLTspIHsKKyAgICAgICAgICAgICAgICBO b2RlKiBub2RlID0gYmxvY2stPmF0KGkpOworICAgICAgICAgICAgICAgIAorICAgICAgICAgICAg ICAgIHN3aXRjaCAobm9kZS0+b3AoKSkgeworICAgICAgICAgICAgICAgIGNhc2UgU2V0TG9jYWw6 CisgICAgICAgICAgICAgICAgY2FzZSBHZXRMb2NhbDogLy8gRklYTUU6IFRoZSBHZXRMb2NhbCBj YXNlIGlzIG9ubHkgbmVjZXNzYXJ5IHVudGlsIHdlIGRvIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMDY3MDcuCisgICAgICAgICAgICAgICAgICAgIG5vZGUtPm1lcmdl RmxhZ3MoTm9kZVJlbGV2YW50VG9PU1IpOworICAgICAgICAgICAgICAgICAgICBicmVhazsKKyAg ICAgICAgICAgICAgICBkZWZhdWx0OgorICAgICAgICAgICAgICAgICAgICBub2RlLT5jbGVhckZs YWdzKE5vZGVSZWxldmFudFRvT1NSKTsKKyAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAg ICAgICAgICAgICAgfQorICAgICAgICAgICAgfQorICAgICAgICB9CisgICAgICAgIAorICAgICAg ICBmb3IgKEJsb2NrSW5kZXggYmxvY2tJbmRleCA9IG1fZ3JhcGgubnVtQmxvY2tzKCk7IGJsb2Nr SW5kZXgtLTspIHsKKyAgICAgICAgICAgIEJhc2ljQmxvY2sqIGJsb2NrID0gbV9ncmFwaC5ibG9j ayhibG9ja0luZGV4KTsKKyAgICAgICAgICAgIGlmICghYmxvY2spCisgICAgICAgICAgICAgICAg Y29udGludWU7CisgICAgICAgICAgICAKKyAgICAgICAgICAgIGZvciAodW5zaWduZWQgaSA9IGJs b2NrLT5zaXplKCk7IGktLTspIHsKKyAgICAgICAgICAgICAgICBOb2RlKiBub2RlID0gYmxvY2st PmF0KGkpOworICAgICAgICAgICAgICAgIGlmICghbm9kZS0+Y29udGFpbnNNb3ZIaW50KCkpCisg ICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICAgICAgICAgIAorICAgICAgICAg ICAgICAgIEFTU0VSVChub2RlLT5vcCgpICE9IFpvbWJpZUhpbnQpOworICAgICAgICAgICAgICAg IG5vZGUtPmNoaWxkMSgpLT5tZXJnZUZsYWdzKE5vZGVSZWxldmFudFRvT1NSKTsKKyAgICAgICAg ICAgIH0KKyAgICAgICAgfQorICAgICAgICAKICAgICAgICAgaWYgKG1fZ3JhcGgubV9mb3JtID09 IFNTQSkgewogICAgICAgICAgICAgVmVjdG9yPEJhc2ljQmxvY2sqPiBkZXB0aEZpcnN0OwogICAg ICAgICAgICAgbV9ncmFwaC5nZXRCbG9ja3NJbkRlcHRoRmlyc3RPcmRlcihkZXB0aEZpcnN0KTsK QEAgLTEwMjIsMTEgKzEwNjMsNiBAQCBwcml2YXRlOgogICAgICAgICBpZiAoY3NlTW9kZSA9PSBO b3JtYWxDU0UpCiAgICAgICAgICAgICBtX2dyYXBoLnBlcmZvcm1TdWJzdGl0dXRpb24obm9kZSk7 CiAgICAgICAgIAotICAgICAgICBpZiAobm9kZS0+Y29udGFpbnNNb3ZIaW50KCkpIHsKLSAgICAg ICAgICAgIEFTU0VSVChub2RlLT5vcCgpICE9IFpvbWJpZUhpbnQpOwotICAgICAgICAgICAgbm9k ZS0+Y2hpbGQxKCktPm1lcmdlRmxhZ3MoTm9kZVJlbGV2YW50VG9PU1IpOwotICAgICAgICB9Ci0g ICAgICAgIAogICAgICAgICBzd2l0Y2ggKG5vZGUtPm9wKCkpIHsKICAgICAgICAgCiAgICAgICAg IGNhc2UgSWRlbnRpdHk6CkBAIC0xMzc0LDI4ICsxNDEwLDYgQEAgcHJpdmF0ZToKICAgICAgICAg Zm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IExhc3ROb2RlVHlwZTsgKytpKQogICAgICAgICAgICAg bV9sYXN0U2VlbltpXSA9IFVJTlRfTUFYOwogICAgICAgICAKLSAgICAgICAgLy8gQWxsIFBoaXMg bmVlZCB0byBhbHJlYWR5IGJlIG1hcmtlZCBhcyByZWxldmFudCB0byBPU1IuCi0gICAgICAgIGlm ICghQVNTRVJUX0RJU0FCTEVEKSB7Ci0gICAgICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBp IDwgYmxvY2stPnBoaXMuc2l6ZSgpOyArK2kpCi0gICAgICAgICAgICAgICAgQVNTRVJUKGJsb2Nr LT5waGlzW2ldLT5mbGFncygpICYgTm9kZVJlbGV2YW50VG9PU1IpOwotICAgICAgICB9Ci0gICAg ICAgIAotICAgICAgICAvLyBNYWtlIGFsbCBvZiBteSBTZXRMb2NhbCBhbmQgR2V0TG9jYWwgbm9k ZXMgcmVsZXZhbnQgdG8gT1NSLCBhbmQgZG8gc29tZSBvdGhlcgotICAgICAgICAvLyBuZWNlc3Nh cnkgYm9va2tlZXBpbmcuCi0gICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBibG9jay0+ c2l6ZSgpOyArK2kpIHsKLSAgICAgICAgICAgIE5vZGUqIG5vZGUgPSBibG9jay0+YXQoaSk7Ci0g ICAgICAgICAgICAKLSAgICAgICAgICAgIHN3aXRjaCAobm9kZS0+b3AoKSkgewotICAgICAgICAg ICAgY2FzZSBTZXRMb2NhbDoKLSAgICAgICAgICAgIGNhc2UgR2V0TG9jYWw6IC8vIEZJWE1FOiBU aGUgR2V0TG9jYWwgY2FzZSBpcyBvbmx5IG5lY2Vzc2FyeSB1bnRpbCB3ZSBkbyBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA2NzA3LgotICAgICAgICAgICAgICAgIG5v ZGUtPm1lcmdlRmxhZ3MoTm9kZVJlbGV2YW50VG9PU1IpOwotICAgICAgICAgICAgICAgIGJyZWFr OwotICAgICAgICAgICAgZGVmYXVsdDoKLSAgICAgICAgICAgICAgICBub2RlLT5jbGVhckZsYWdz KE5vZGVSZWxldmFudFRvT1NSKTsKLSAgICAgICAgICAgICAgICBicmVhazsKLSAgICAgICAgICAg IH0KLSAgICAgICAgfQotCiAgICAgICAgIGZvciAobV9pbmRleEluQmxvY2sgPSAwOyBtX2luZGV4 SW5CbG9jayA8IGJsb2NrLT5zaXplKCk7ICsrbV9pbmRleEluQmxvY2spIHsKICAgICAgICAgICAg IG1fY3VycmVudE5vZGUgPSBibG9jay0+YXQobV9pbmRleEluQmxvY2spOwogICAgICAgICAgICAg cGVyZm9ybU5vZGVDU0UobV9jdXJyZW50Tm9kZSk7Cg==