125534 2013-12-10 12:43:54 -0800 check-webkit-style shouldn't check spacing in #if preprocessor lines 2013-12-11 17:23:01 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmaxfield mmaxfield commit-queue darin dino gbalogh.u-szeged glenn jonlee llango.u-szeged simon.fraser thorton oldest_to_newest 958465 0 mmaxfield 2013-12-10 12:43:54 -0800 check-webkit-style shouldn't check spacing in preprocessor macros 958469 1 218896 mmaxfield 2013-12-10 12:50:57 -0800 Created attachment 218896 Patch 958984 2 218896 commit-queue 2013-12-11 17:22:59 -0800 Comment on attachment 218896 Patch Clearing flags on attachment: 218896 Committed r160466: <http://trac.webkit.org/changeset/160466> 958985 3 commit-queue 2013-12-11 17:23:01 -0800 All reviewed patches have been landed. Closing bug. 218896 2013-12-10 12:50:57 -0800 2013-12-11 17:22:59 -0800 Patch bug-125534-20131210125056.patch text/plain 2753 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMzc4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTE1MzIxNGZmMmUxOTRjMGI2NjFjODUxNzQ4NTdiY2Y4 ODQyYTNkOC4uMmJjZTc2NWY4MGFlZmQ5NmQ5MDlhNWRiYWE0YjA2YWM2NjA4NzE2MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEzLTEyLTEwICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+ CisKKyAgICAgICAgY2hlY2std2Via2l0LXN0eWxlIHNob3VsZG4ndCBjaGVjayBzcGFjaW5nIGlu ICNpZiBwcmVwcm9jZXNzb3IgbGluZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyNTUzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFByZXByb2Nlc3NvciBsaW5lcyB0aGF0IHN0YXJ0IHdpdGggI2lmIHNo b3VsZG4ndCBoYXZlIHRvIGFkaGVyZSB0bworICAgICAgICB0aGUgc2FtZSBzcGFjaW5nIHJlcXVp cmVtZW50cyB0aGF0IHJlZ3VsYXIgY29kZSBkb2VzCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weToKKyAgICAgICAgKGNoZWNrX3NwYWNpbmcpOgorICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5Ogor ICAgICAgICAoQ3BwU3R5bGVUZXN0LnRlc3Rfc3BhY2luZ19mb3JfYmluYXJ5X29wcyk6CisgICAg ICAgIChXZWJLaXRTdHlsZVRlc3QudGVzdF9saW5lX2JyZWFraW5nKToKKwogMjAxMy0xMi0xMCAg TGFzemxvIFZpZGFjcyAgPGxhY0BpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgQWRkIC0tbWFr ZWFyZ3Mgb3B0aW9uIHRvIGJ1aWxkLWpzYwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcC5weQppbmRleCBiNjg2OThiNDVkODNlMjgxODA0MTNkYWUxMWZkYTdlYzYz NDRmMGFmLi4zMWMzMDE2MTA1ZDU1OGRmMjI1YTU3ZDRiZDIyNjJiYTRkYTgxN2IyIDEwMDY0NAot LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAtMTgzNCw5ICsx ODM0LDkgQEAgZGVmIGNoZWNrX3NwYWNpbmcoZmlsZV9leHRlbnNpb24sIGNsZWFuX2xpbmVzLCBs aW5lX251bWJlciwgZXJyb3IpOgogCiAgICAgIyBEb24ndCB0cnkgdG8gZG8gc3BhY2luZyBjaGVj a3MgZm9yIG9wZXJhdG9yIG1ldGhvZHMKICAgICBsaW5lID0gc3ViKHInb3BlcmF0b3IoPT18IT18 PHw8PHw8PXw+PXw+Pnw+fFwrPXwtPXxcKj18Lz18JT18Jj18XHw9fF49fDw8PXw+Pj18LylcKCcs ICdvcGVyYXRvclwoJywgbGluZSkKLSAgICAjIERvbid0IHRyeSB0byBkbyBzcGFjaW5nIGNoZWNr cyBmb3IgI2luY2x1ZGUgb3IgI2ltcG9ydCBzdGF0ZW1lbnRzIGF0CisgICAgIyBEb24ndCB0cnkg dG8gZG8gc3BhY2luZyBjaGVja3MgZm9yICNpbmNsdWRlLCAjaW1wb3J0LCBvciAjaWYgc3RhdGVt ZW50cyBhdAogICAgICMgbWluaW11bSBiZWNhdXNlIGl0IG1lc3NlcyB1cCBjaGVja3MgZm9yIHNw YWNpbmcgYXJvdW5kIC8KLSAgICBpZiBtYXRjaChyJ1xzKiNccyooPzppbmNsdWRlfGltcG9ydCkn LCBsaW5lKToKKyAgICBpZiBtYXRjaChyJ1xzKiNccyooPzppbmNsdWRlfGltcG9ydHxpZiknLCBs aW5lKToKICAgICAgICAgcmV0dXJuCiAgICAgaWYgc2VhcmNoKHInW1x3Ll09W1x3Ll0nLCBsaW5l KToKICAgICAgICAgZXJyb3IobGluZV9udW1iZXIsICd3aGl0ZXNwYWNlL29wZXJhdG9ycycsIDQs CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91 bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3Vu aXR0ZXN0LnB5CmluZGV4IDI3YWI2OWY2YjUyNDZlZGFmNGFlOWY4OWY2M2NlNzNjMWI4ZDRjMjQu LjllNjdjZTg0ODA1MmU0MmY4ODZmYzllNGEyNDgxOTg1NGQ1NzA0OGIgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CkBA IC0xNzY2LDYgKzE3NjYsNyBAQCBjbGFzcyBDcHBTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6 CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ2lmIChhID0gYiA9PSAxKScsICcnKQogICAgICAg ICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQoJyNpbmNsdWRlIDxzeXMvaW8uaD5cbicsICcn KQogICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQoJyNpbXBvcnQgPGZvby9iYXIu aD5cbicsICcnKQorICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQoJyNpZiBfX2hh c19pbmNsdWRlKDxBcHBsaWNhdGlvblNlcnZpY2VzL0FwcGxpY2F0aW9uU2VydmljZXNQcml2Lmg+ KVxuJywgJycpCiAKICAgICBkZWYgdGVzdF9vcGVyYXRvcl9tZXRob2RzKHNlbGYpOgogICAgICAg ICBzZWxmLmFzc2VydF9saW50KCdTdHJpbmcgb3BlcmF0b3IrKGNvbnN0IFN0cmluZyYsIGNvbnN0 IFN0cmluZyYpOycsICcnKQo=