<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>125521</bug_id>
          
          <creation_ts>2013-12-10 10:56:03 -0800</creation_ts>
          <short_desc>[ATK] Elements with role &apos;alertdialog&apos; should be ATK_ROLE_ALERT</short_desc>
          <delta_ts>2013-12-10 12:08:20 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Accessibility</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mario Sanchez Prada">mario</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>aboxhall</cc>
    
    <cc>apinheiro</cc>
    
    <cc>cfleizach</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dmazzoni</cc>
    
    <cc>jcraig</cc>
    
    <cc>jdiggs</cc>
    
    <cc>samuel_white</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>958418</commentid>
    <comment_count>0</comment_count>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2013-12-10 10:56:03 -0800</bug_when>
    <thetext>As per discussion with Joanie in the hackfest</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>958422</commentid>
    <comment_count>1</comment_count>
      <attachid>218883</attachid>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2013-12-10 11:11:56 -0800</bug_when>
    <thetext>Created attachment 218883
Patch proposal</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>958439</commentid>
    <comment_count>2</comment_count>
      <attachid>218883</attachid>
    <who name="Mario Sanchez Prada">mario</who>
    <bug_when>2013-12-10 11:41:40 -0800</bug_when>
    <thetext>Comment on attachment 218883
Patch proposal

Thanks for the quick review</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>958451</commentid>
    <comment_count>3</comment_count>
      <attachid>218883</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-12-10 12:08:17 -0800</bug_when>
    <thetext>Comment on attachment 218883
Patch proposal

Clearing flags on attachment: 218883

Committed r160379: &lt;http://trac.webkit.org/changeset/160379&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>958452</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-12-10 12:08:20 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>218883</attachid>
            <date>2013-12-10 11:11:56 -0800</date>
            <delta_ts>2013-12-10 12:08:17 -0800</delta_ts>
            <desc>Patch proposal</desc>
            <filename>0001-ATK-Elements-with-role-alertdialog-should-be-ATK_ROL.patch</filename>
            <type>text/plain</type>
            <size>3438</size>
            <attacher name="Mario Sanchez Prada">mario</attacher>
            
              <data encoding="base64">RnJvbSAzNTIyM2Q2MzM0ZDBlOGE2MmE0NjNiMTgwYjUzMzY5MzRiZGE0NDYzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtYXJpby5wcmFkYUBzYW1z
dW5nLmNvbT4KRGF0ZTogVHVlLCAxMCBEZWMgMjAxMyAxOTo0Mjo1OSArMDEwMApTdWJqZWN0OiBb
UEFUQ0ggMS8zXSAgICAgICAgIFtBVEtdIEVsZW1lbnRzIHdpdGggcm9sZSAnYWxlcnRkaWFsb2cn
IHNob3VsZCBiZQogQVRLX1JPTEVfQUxFUlQgICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9MTI1NTIxCgotLS0KIExheW91dFRlc3RzL0NoYW5nZUxvZyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTEgKysrKysrKysrKysKIExheW91
dFRlc3RzL2FjY2Vzc2liaWxpdHkvYXJpYS1tYXBwaW5ncy1leHBlY3RlZC50eHQgICAgICAgIHwg
IDIgKy0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIHwgMTMgKysrKysrKysrKysrKwogLi4uL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktp
dEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcCAgICAgICAgfCAgMiArLQogNCBmaWxlcyBjaGFuZ2Vk
LCAyNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0xheW91dFRl
c3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjNDMwMmU0Li41ZDY5
ODgzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv
Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMTItMTAgIE1hcmlvIFNhbmNoZXogUHJh
ZGEgIDxtYXJpby5wcmFkYUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbQVRLXSBFbGVtZW50cyB3
aXRoIHJvbGUgJ2FsZXJ0ZGlhbG9nJyBzaG91bGQgYmUgQVRLX1JPTEVfQUxFUlQKKyAgICAgICAg
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTUyMQorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSBleHBlY3RlZCBy
ZXN1bHQgaW4gbGF5b3V0IHRlc3QuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2FyaWEtbWFw
cGluZ3MtZXhwZWN0ZWQudHh0OgorCiAyMDEzLTEyLTA5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3
ZWJraXQub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjEzNjI4MCk6IGlucHV0W3R5cGU9aW1h
Z2VdIHNob3VsZCBhc3N1bWUgY29vcmRzIG9mIDAsMCB3aGVuIGFjdGl2YXRlZCB3aXRob3V0IHBo
eXNpY2FsbHkgY2xpY2tpbmcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkv
YXJpYS1tYXBwaW5ncy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2Fy
aWEtbWFwcGluZ3MtZXhwZWN0ZWQudHh0CmluZGV4IDYxMGVhMWEuLjM2ZDYzMjggMTAwNjQ0Ci0t
LSBhL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvYXJpYS1tYXBwaW5ncy1leHBlY3RlZC50eHQK
KysrIGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9hcmlhLW1hcHBpbmdzLWV4cGVjdGVkLnR4
dApAQCAtMjEsNyArMjEsNyBAQCBSb2xlIGZvciAnYWxlcnQnIGRpdiBpczogQVhSb2xlOiBBWEFs
ZXJ0CiAKIAogcm9sZT0iYWxlcnRkaWFsb2ciIGlzIGEgZGlhbG9nIHdoaWNoIGNvbnRhaW5zIGFu
IGFsZXJ0IG1lc3NhZ2UuCi1Sb2xlIGZvciAnYWxlcnRkaWFsb2cnIGRpdiBpczogQVhSb2xlOiBB
WERpYWxvZworUm9sZSBmb3IgJ2FsZXJ0ZGlhbG9nJyBkaXYgaXM6IEFYUm9sZTogQVhBbGVydAog
CiAKIHJvbGU9ImFydGljbGUiIGlzIGEgIHNlY3Rpb24gb2YgYSBwYWdlIHRoYXQgY29uc2lzdHMg
b2YgYSBjb21wb3NpdGlvbiB0aGF0IGZvcm1zIGFuIGluZGVwZW5kZW50IHBhcnQgb2YgYSBkb2N1
bWVudCwgcGFnZSwgb3Igc2l0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n
IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDliMDcwNjkuLmE1YTFlNDcgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu
Z2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0xMi0xMCAgTWFyaW8gU2FuY2hleiBQcmFkYSAg
PG1hcmlvLnByYWRhQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtBVEtdIEVsZW1lbnRzIHdpdGgg
cm9sZSAnYWxlcnRkaWFsb2cnIHNob3VsZCBiZSBBVEtfUk9MRV9BTEVSVAorICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1NTIxCisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3RvcCBleHBvc2luZyBhbGVydCBk
aWFsb2dzIGFzIEFUS19ST0xFX0RJQUxPRyBhbmQgZG8gaXQgYXMKKyAgICAgICAgQVRLX1JPTEVf
QUxFUlQgaW5zdGVhZC4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vz
c2libGVXcmFwcGVyQXRrLmNwcDoKKyAgICAgICAgKGF0a1JvbGUpOgorCiAyMDEzLTEyLTA5ICBB
bmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBDbGVhciBvdXQgZm9u
dCB3aWR0aCBtZWFzdXJlbWVudCBjYWNoZXMgb24gbWVtb3J5IHByZXNzdXJlLgpkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBw
ZXJBdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNz
aWJsZVdyYXBwZXJBdGsuY3BwCmluZGV4IDI5NzZkMzYwLi4xMGQyZTBmIDEwMDY0NAotLS0gYS9T
b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlV3JhcHBlckF0
ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNz
aWJsZVdyYXBwZXJBdGsuY3BwCkBAIC01MzQsMTAgKzUzNCwxMCBAQCBzdGF0aWMgQXRrQXR0cmli
dXRlU2V0KiB3ZWJraXRBY2Nlc3NpYmxlR2V0QXR0cmlidXRlcyhBdGtPYmplY3QqIG9iamVjdCkK
IHN0YXRpYyBBdGtSb2xlIGF0a1JvbGUoQWNjZXNzaWJpbGl0eVJvbGUgcm9sZSkKIHsKICAgICBz
d2l0Y2ggKHJvbGUpIHsKKyAgICBjYXNlIEFwcGxpY2F0aW9uQWxlcnREaWFsb2dSb2xlOgogICAg
IGNhc2UgQXBwbGljYXRpb25BbGVydFJvbGU6CiAgICAgICAgIHJldHVybiBBVEtfUk9MRV9BTEVS
VDsKICAgICBjYXNlIEFwcGxpY2F0aW9uRGlhbG9nUm9sZToKLSAgICBjYXNlIEFwcGxpY2F0aW9u
QWxlcnREaWFsb2dSb2xlOgogICAgICAgICByZXR1cm4gQVRLX1JPTEVfRElBTE9HOwogICAgIGNh
c2UgQXBwbGljYXRpb25TdGF0dXNSb2xlOgogICAgICAgICByZXR1cm4gQVRLX1JPTEVfU1RBVFVT
QkFSOwotLSAKMS44LjMuMgoK
</data>

          </attachment>
      

    </bug>

</bugzilla>