125514 2013-12-10 07:20:12 -0800 PrettyPatch.rb should be more descriptive for "git diff -M" styled patches 2014-02-25 04:39:17 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy webkit-unassigned commit-queue darin oldest_to_newest 958359 0 ossy 2013-12-10 07:20:12 -0800 here is an example: https://bugs.webkit.org/attachment.cgi?id=218793 https://bugs.webkit.org/attachment.cgi?id=218793&action=review ---------------------------------------------------------------------------- diff --git a/Source/WebKit2/Shared/mac/CertificateInfo.mm b/Source/WebCore/platform/network/mac/CertificateInfoMac.mm similarity index 75% rename from Source/WebKit2/Shared/mac/CertificateInfo.mm rename to Source/WebCore/platform/network/mac/CertificateInfoMac.mm ... ---------------------------------------------------------------------------- Source/WebKit2/Shared/mac/CertificateInfo.mm was moved to Source/WebCore/platform/network/mac/CertificateInfoMac.mm and then some lines changed, but the pretty diff shows if you changed only Source/WebCore/platform/network/mac/CertificateInfoMac.mm. In this case it would be better to show exactly the diff header: rename from Source/WebKit2/Shared/mac/CertificateInfo.mm rename to Source/WebCore/platform/network/mac/CertificateInfoMac.mm 983947 1 225074 jberta.u-szeged 2014-02-24 10:51:00 -0800 Created attachment 225074 PrettyPatch now shows renames 984019 2 225074 ossy 2014-02-24 12:57:09 -0800 Comment on attachment 225074 PrettyPatch now shows renames The patch looks good to me, but please add changelog entry. 984228 3 225128 jberta.u-szeged 2014-02-25 01:17:06 -0800 Created attachment 225128 Added changelog 984260 4 225128 commit-queue 2014-02-25 04:39:15 -0800 Comment on attachment 225128 Added changelog Clearing flags on attachment: 225128 Committed r164642: <http://trac.webkit.org/changeset/164642> 984261 5 commit-queue 2014-02-25 04:39:17 -0800 All reviewed patches have been landed. Closing bug. 225074 2014-02-24 10:51:00 -0800 2014-02-25 01:17:06 -0800 PrettyPatch now shows renames patch.diff text/plain 2263 jberta.u-szeged ZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9QcmV0dHlQYXRjaC9QcmV0dHlQ YXRjaC5yYiBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9QcmV0dHlQYXRjaC9QcmV0dHlQYXRj aC5yYgppbmRleCA4MzdkYmZhLi4xY2NmODc3IDEwMDY0NAotLS0gYS9XZWJzaXRlcy9idWdzLndl YmtpdC5vcmcvUHJldHR5UGF0Y2gvUHJldHR5UGF0Y2gucmIKKysrIGIvV2Vic2l0ZXMvYnVncy53 ZWJraXQub3JnL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCkBAIC02MSw2ICs2MSw4IEBAIHBy aXZhdGUKICAgICAgICAgL15kaWZmLwogICAgIF0KIAorICAgIFJFTkFNRV9GUk9NID0gL15yZW5h bWUgZnJvbSAoLiopLworCiAgICAgQklOQVJZX0ZJTEVfTUFSS0VSX0ZPUk1BVCA9IC9eQ2Fubm90 IGRpc3BsYXk6IGZpbGUgbWFya2VkIGFzIGEgYmluYXJ5IHR5cGUuJC8KIAogICAgIElNQUdFX0ZJ TEVfTUFSS0VSX0ZPUk1BVCA9IC9ec3ZuOm1pbWUtdHlwZSA9IGltYWdlXC9wbmckLwpAQCAtMTUw LDEwICsxNTIsMTMgQEAgcHJpdmF0ZQogICAgICAgICBbbmlsLCBmaWxlX3BhdGhdCiAgICAgZW5k CiAKLSAgICBkZWYgc2VsZi5saW5raWZ5RmlsZW5hbWUoZmlsZW5hbWUpCi0gICAgICAgIHVybCwg cGF0aEJlbmVhdGhUcnVuayA9IGZpbmRfdXJsX2FuZF9wYXRoKGZpbGVuYW1lKQotCi0gICAgICAg IHVybC5uaWw/ID8gZmlsZW5hbWUgOiAiPGEgaHJlZj0nI3t1cmx9YnJvd3Nlci90cnVuay8je3Bh dGhCZW5lYXRoVHJ1bmt9Jz4je2ZpbGVuYW1lfTwvYT4iCisgICAgZGVmIHNlbGYubGlua2lmeUZp bGVuYW1lKGZpbGVuYW1lLCBmb3JjZSkKKyAgICAgICAgaWYgZm9yY2UKKyAgICAgICAgICAiPGEg aHJlZj0nI3tPUEVOU09VUkNFX1RSQUNfVVJMfWJyb3dzZXIvdHJ1bmsvI3tmaWxlbmFtZX0nPiN7 ZmlsZW5hbWV9PC9hPiIKKyAgICAgICAgZWxzZQorICAgICAgICAgIHVybCwgcGF0aEJlbmVhdGhU cnVuayA9IGZpbmRfdXJsX2FuZF9wYXRoKGZpbGVuYW1lKQorICAgICAgICAgIHVybC5uaWw/ID8g ZmlsZW5hbWUgOiAiPGEgaHJlZj0nI3t1cmx9YnJvd3Nlci90cnVuay8je3BhdGhCZW5lYXRoVHJ1 bmt9Jz4je2ZpbGVuYW1lfTwvYT4iCisgICAgICAgIGVuZAogICAgIGVuZAogCiAKQEAgLTE4NCw3 ICsxODksNyBAQCBoMSB7CiAgICAgZm9udC1mYW1pbHk6IHNhbnMtc2VyaWY7CiAgICAgZm9udC1z aXplOiAxZW07CiAgICAgbWFyZ2luLWxlZnQ6IDAuNWVtOwotICAgIGRpc3BsYXk6IHRhYmxlLWNl bGw7CisgICAgZGlzcGxheTogaW5saW5lOwogICAgIHdpZHRoOiAxMDAlOwogICAgIHBhZGRpbmc6 IDAuNWVtOwogfQpAQCAtNTYwLDYgKzU2NSw4IEBAIEVPRgogICAgICAgICAgICAgICAgICAgICAg ICAgc3RhcnRPZlNlY3Rpb25zID0gaSArIDEKICAgICAgICAgICAgICAgICAgICAgZW5kCiAgICAg ICAgICAgICAgICAgICAgIGJyZWFrCisgICAgICAgICAgICAgICAgd2hlbiBSRU5BTUVfRlJPTQor ICAgICAgICAgICAgICAgICAgICBAcmVuYW1lRnJvbSA9IFJFTkFNRV9GUk9NLm1hdGNoKGxpbmVz W2ldKVsxXQogICAgICAgICAgICAgICAgIGVuZAogICAgICAgICAgICAgZW5kCiAgICAgICAgICAg ICBsaW5lc193aXRoX2NvbnRlbnRzID0gbGluZXNbc3RhcnRPZlNlY3Rpb25zLi4ubGluZXMubGVu Z3RoXQpAQCAtNjE2LDcgKzYyMywxMyBAQCBFT0YKIAogICAgICAgICBkZWYgdG9faHRtbAogICAg ICAgICAgICAgc3RyID0gIjxkaXYgY2xhc3M9J0ZpbGVEaWZmJz5cbiIKLSAgICAgICAgICAgIHN0 ciArPSAiPGgxPiN7UHJldHR5UGF0Y2gubGlua2lmeUZpbGVuYW1lKEBmaWxlbmFtZSl9PC9oMT5c biIKKyAgICAgICAgICAgIGlmIEByZW5hbWVGcm9tCisgICAgICAgICAgICAgICAgc3RyICs9ICI8 aDE+I3tAZmlsZW5hbWV9PC9oMT4iCisgICAgICAgICAgICAgICAgc3RyICs9ICJ3YXMgcmVuYW1l ZCBmcm9tIgorICAgICAgICAgICAgICAgIHN0ciArPSAiPGgxPiN7UHJldHR5UGF0Y2gubGlua2lm eUZpbGVuYW1lKEByZW5hbWVGcm9tLnRvX3MsIHRydWUpfTwvaDE+IgorICAgICAgICAgICAgZWxz ZQorICAgICAgICAgICAgICAgIHN0ciArPSAiPGgxPiN7UHJldHR5UGF0Y2gubGlua2lmeUZpbGVu YW1lKEBmaWxlbmFtZSwgZmFsc2UpfTwvaDE+XG4iCisgICAgICAgICAgICBlbmQKICAgICAgICAg ICAgIGlmIEBpbWFnZSB0aGVuCiAgICAgICAgICAgICAgICAgc3RyICs9IHNlbGYuaW1hZ2VfdG9f aHRtbAogICAgICAgICAgICAgZWxzaWYgQGdpdF9pbWFnZSB0aGVuCg== 225128 2014-02-25 01:17:06 -0800 2014-02-25 04:39:15 -0800 Added changelog patch.diff text/plain 2992 jberta.u-szeged ZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cgYi9XZWJzaXRl cy9idWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDY4ZTU1ZmYuLmFiNTY2MzEgMTAwNjQ0 Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIvV2Vic2l0ZXMv YnVncy53ZWJraXQub3JnL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0LTAyLTI1ICBK b3pzZWYgQmVydGEgIDxqYmVydGEudS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNvbT4KKworICAg ICAgICBQcmV0dHlQYXRjaC5yYiBzaG91bGQgYmUgbW9yZSBkZXNjcmlwdGl2ZSBmb3IgImdpdCBk aWZmIC1NIiBzdHlsZWQgcGF0Y2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTI1NTE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBQcmV0dHlQYXRjaC9QcmV0dHlQYXRjaC5yYjogUHJldHR5UGF0Y2gu cmIgaXMgbW9kaWZpZWQgdG8gc2hvdyB3aGljaCBmaWxlIHdhcyByZW5hbWVkIG9yIG1vdmVkLgor CiAyMDEzLTEyLTE2ICBEw6FuaWVsIELDoXR5YWkgIDxCYXR5YWkuRGFuaWVsQHN0dWQudS1zemVn ZWQuaHU+CiAKICAgICAgICAgUHJldHR5UGF0Y2gucmIgZG9lc24ndCBoYW5kbGUgZGlmZnMgd2hl cmUgbGluZXMgbWF0Y2hpbmcgL14tLS8gYXJlIG1pc3NpbmcgcHJvcGVybHkKZGlmZiAtLWdpdCBh L1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9QcmV0dHlQYXRjaC9QcmV0dHlQYXRjaC5yYiBiL1dl YnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9QcmV0dHlQYXRjaC9QcmV0dHlQYXRjaC5yYgppbmRleCA4 MzdkYmZhLi4xY2NmODc3IDEwMDY0NAotLS0gYS9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvUHJl dHR5UGF0Y2gvUHJldHR5UGF0Y2gucmIKKysrIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL1By ZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCkBAIC02MSw2ICs2MSw4IEBAIHByaXZhdGUKICAgICAg ICAgL15kaWZmLwogICAgIF0KIAorICAgIFJFTkFNRV9GUk9NID0gL15yZW5hbWUgZnJvbSAoLiop LworCiAgICAgQklOQVJZX0ZJTEVfTUFSS0VSX0ZPUk1BVCA9IC9eQ2Fubm90IGRpc3BsYXk6IGZp bGUgbWFya2VkIGFzIGEgYmluYXJ5IHR5cGUuJC8KIAogICAgIElNQUdFX0ZJTEVfTUFSS0VSX0ZP Uk1BVCA9IC9ec3ZuOm1pbWUtdHlwZSA9IGltYWdlXC9wbmckLwpAQCAtMTUwLDEwICsxNTIsMTMg QEAgcHJpdmF0ZQogICAgICAgICBbbmlsLCBmaWxlX3BhdGhdCiAgICAgZW5kCiAKLSAgICBkZWYg c2VsZi5saW5raWZ5RmlsZW5hbWUoZmlsZW5hbWUpCi0gICAgICAgIHVybCwgcGF0aEJlbmVhdGhU cnVuayA9IGZpbmRfdXJsX2FuZF9wYXRoKGZpbGVuYW1lKQotCi0gICAgICAgIHVybC5uaWw/ID8g ZmlsZW5hbWUgOiAiPGEgaHJlZj0nI3t1cmx9YnJvd3Nlci90cnVuay8je3BhdGhCZW5lYXRoVHJ1 bmt9Jz4je2ZpbGVuYW1lfTwvYT4iCisgICAgZGVmIHNlbGYubGlua2lmeUZpbGVuYW1lKGZpbGVu YW1lLCBmb3JjZSkKKyAgICAgICAgaWYgZm9yY2UKKyAgICAgICAgICAiPGEgaHJlZj0nI3tPUEVO U09VUkNFX1RSQUNfVVJMfWJyb3dzZXIvdHJ1bmsvI3tmaWxlbmFtZX0nPiN7ZmlsZW5hbWV9PC9h PiIKKyAgICAgICAgZWxzZQorICAgICAgICAgIHVybCwgcGF0aEJlbmVhdGhUcnVuayA9IGZpbmRf dXJsX2FuZF9wYXRoKGZpbGVuYW1lKQorICAgICAgICAgIHVybC5uaWw/ID8gZmlsZW5hbWUgOiAi PGEgaHJlZj0nI3t1cmx9YnJvd3Nlci90cnVuay8je3BhdGhCZW5lYXRoVHJ1bmt9Jz4je2ZpbGVu YW1lfTwvYT4iCisgICAgICAgIGVuZAogICAgIGVuZAogCiAKQEAgLTE4NCw3ICsxODksNyBAQCBo MSB7CiAgICAgZm9udC1mYW1pbHk6IHNhbnMtc2VyaWY7CiAgICAgZm9udC1zaXplOiAxZW07CiAg ICAgbWFyZ2luLWxlZnQ6IDAuNWVtOwotICAgIGRpc3BsYXk6IHRhYmxlLWNlbGw7CisgICAgZGlz cGxheTogaW5saW5lOwogICAgIHdpZHRoOiAxMDAlOwogICAgIHBhZGRpbmc6IDAuNWVtOwogfQpA QCAtNTYwLDYgKzU2NSw4IEBAIEVPRgogICAgICAgICAgICAgICAgICAgICAgICAgc3RhcnRPZlNl Y3Rpb25zID0gaSArIDEKICAgICAgICAgICAgICAgICAgICAgZW5kCiAgICAgICAgICAgICAgICAg ICAgIGJyZWFrCisgICAgICAgICAgICAgICAgd2hlbiBSRU5BTUVfRlJPTQorICAgICAgICAgICAg ICAgICAgICBAcmVuYW1lRnJvbSA9IFJFTkFNRV9GUk9NLm1hdGNoKGxpbmVzW2ldKVsxXQogICAg ICAgICAgICAgICAgIGVuZAogICAgICAgICAgICAgZW5kCiAgICAgICAgICAgICBsaW5lc193aXRo X2NvbnRlbnRzID0gbGluZXNbc3RhcnRPZlNlY3Rpb25zLi4ubGluZXMubGVuZ3RoXQpAQCAtNjE2 LDcgKzYyMywxMyBAQCBFT0YKIAogICAgICAgICBkZWYgdG9faHRtbAogICAgICAgICAgICAgc3Ry ID0gIjxkaXYgY2xhc3M9J0ZpbGVEaWZmJz5cbiIKLSAgICAgICAgICAgIHN0ciArPSAiPGgxPiN7 UHJldHR5UGF0Y2gubGlua2lmeUZpbGVuYW1lKEBmaWxlbmFtZSl9PC9oMT5cbiIKKyAgICAgICAg ICAgIGlmIEByZW5hbWVGcm9tCisgICAgICAgICAgICAgICAgc3RyICs9ICI8aDE+I3tAZmlsZW5h bWV9PC9oMT4iCisgICAgICAgICAgICAgICAgc3RyICs9ICJ3YXMgcmVuYW1lZCBmcm9tIgorICAg ICAgICAgICAgICAgIHN0ciArPSAiPGgxPiN7UHJldHR5UGF0Y2gubGlua2lmeUZpbGVuYW1lKEBy ZW5hbWVGcm9tLnRvX3MsIHRydWUpfTwvaDE+IgorICAgICAgICAgICAgZWxzZQorICAgICAgICAg ICAgICAgIHN0ciArPSAiPGgxPiN7UHJldHR5UGF0Y2gubGlua2lmeUZpbGVuYW1lKEBmaWxlbmFt ZSwgZmFsc2UpfTwvaDE+XG4iCisgICAgICAgICAgICBlbmQKICAgICAgICAgICAgIGlmIEBpbWFn ZSB0aGVuCiAgICAgICAgICAgICAgICAgc3RyICs9IHNlbGYuaW1hZ2VfdG9faHRtbAogICAgICAg ICAgICAgZWxzaWYgQGdpdF9pbWFnZSB0aGVuCg==