125505 2013-12-10 05:49:37 -0800 [WK2][SOUP] WebContext::setIgnoreTLSErrors should send SetIgnoreTLSErrors to the network process when network process is enabled 2013-12-10 07:36:54 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108832 1 skyul skyul brian.holt cgarcia commit-queue gustavo mrobinson ossy svillar oldest_to_newest 958310 0 skyul 2013-12-10 05:49:37 -0800 This is a follow-up patch of r160355 (Bug 125490) 958320 1 218861 skyul 2013-12-10 06:02:46 -0800 Created attachment 218861 Patch 958339 2 218861 cgarcia 2013-12-10 06:31:33 -0800 Comment on attachment 218861 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218861&action=review > Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp:151 > + sendToNetworkingProcess(Messages::NetworkProcess::SetIgnoreTLSErrors(m_ignoreTLSErrors)); Here you already know you want to send the message to the network process, so you can call directly networkProcess()->send(Messages::NetworkProcess::SetIgnoreTLSErrors(m_ignoreTLSErrors)); You should probably check also that networkProcess is not null if (usesNetworkProcess() && networkProcess()) networkProcess()->send(Messages::NetworkProcess::SetIgnoreTLSErrors(m_ignoreTLSErrors)); 958345 3 218868 skyul 2013-12-10 07:00:06 -0800 Created attachment 218868 Patch 958363 4 218868 commit-queue 2013-12-10 07:36:51 -0800 Comment on attachment 218868 Patch Clearing flags on attachment: 218868 Committed r160364: <http://trac.webkit.org/changeset/160364> 958364 5 commit-queue 2013-12-10 07:36:54 -0800 All reviewed patches have been landed. Closing bug. 218861 2013-12-10 06:02:46 -0800 2013-12-10 07:00:01 -0800 Patch bug-125505-20131210230244.patch text/plain 1833 skyul U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMzU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTg5Nzg5NWNlNTUyODlm NjM1ZTk1OGZjYTY4NGQ5ODdiYWJjNTA2ZC4uNjRiYzU1YzUxMzJlZTY5MjVhYmNkZTc4NDZlZWQ0 YmE3OTVjNDVlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEyLTEwICBLd2Fu ZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgW1dLMl1bU09VUF0g V2ViQ29udGV4dDo6c2V0SWdub3JlVExTRXJyb3JzIHNob3VsZCBzZW5kIFNldElnbm9yZVRMU0Vy cm9ycyB0byB0aGUgbmV0d29yayBwcm9jZXNzIHdoZW4gbmV0d29yayBwcm9jZXNzIGlzIGVuYWJs ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTUw NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg aXMgYSBmb2xsb3ctdXAgcGF0Y2ggZm9yIHIxNjAzNTUuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv Z3RrL1dlYkNvbnRleHRHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0OjpzZXRJ Z25vcmVUTFNFcnJvcnMpOgorCiAyMDEzLTEyLTA4ICBCcmlhbiBIb2x0ICA8YnJpYW4uaG9sdEBz YW1zdW5nLmNvbT4KIAogICAgICAgICBbV0syXSBHdWFyZCBNYWMgc3BlY2lmaWMgbmV0d29yayBw cm9jZXNzIGNvZGUgd2l0aCBQTEFURk9STShNQUMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvZ3RrL1dlYkNvbnRleHRHdGsuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL2d0ay9XZWJDb250ZXh0R3RrLmNwcAppbmRleCA2MDI0NjhkYjU1ZTcyNmZmMzkyMjViY2Vl YmM0N2UxNDFhNGNmNmFkLi4wOTg3YWZiZGRjNTdiOWU1NGU1MTEwOTYwY2ZkOTU2NGMxY2JmNTA1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYkNvbnRleHRHdGsu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2ViQ29udGV4dEd0ay5jcHAK QEAgLTQwLDYgKzQwLDEwIEBACiAjaW5jbHVkZSA8d3RmL2dvYmplY3QvR093blB0ci5oPgogI2lu Y2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KIAorI2lmIEVOQUJMRShORVRXT1JLX1BST0NFU1Mp CisjaW5jbHVkZSAiTmV0d29ya1Byb2Nlc3NNZXNzYWdlcy5oIgorI2VuZGlmCisKIG5hbWVzcGFj ZSBXZWJLaXQgewogCiBzdGF0aWMgdm9pZCBpbml0SW5zcGVjdG9yU2VydmVyKCkKQEAgLTE0Miw2 ICsxNDYsMTIgQEAgU3RyaW5nIFdlYkNvbnRleHQ6OnBsYXRmb3JtRGVmYXVsdENvb2tpZVN0b3Jh Z2VEaXJlY3RvcnkoKSBjb25zdAogdm9pZCBXZWJDb250ZXh0OjpzZXRJZ25vcmVUTFNFcnJvcnMo Ym9vbCBpZ25vcmVUTFNFcnJvcnMpCiB7CiAgICAgbV9pZ25vcmVUTFNFcnJvcnMgPSBpZ25vcmVU TFNFcnJvcnM7CisjaWYgRU5BQkxFKE5FVFdPUktfUFJPQ0VTUykKKyAgICBpZiAobV91c2VzTmV0 d29ya1Byb2Nlc3MpIHsKKyAgICAgICAgc2VuZFRvTmV0d29ya2luZ1Byb2Nlc3MoTWVzc2FnZXM6 Ok5ldHdvcmtQcm9jZXNzOjpTZXRJZ25vcmVUTFNFcnJvcnMobV9pZ25vcmVUTFNFcnJvcnMpKTsK KyAgICAgICAgcmV0dXJuOworICAgIH0KKyNlbmRpZgogICAgIHNlbmRUb0FsbFByb2Nlc3NlcyhN ZXNzYWdlczo6V2ViUHJvY2Vzczo6U2V0SWdub3JlVExTRXJyb3JzKG1faWdub3JlVExTRXJyb3Jz KSk7CiB9CiAK 218868 2013-12-10 07:00:06 -0800 2013-12-10 07:36:51 -0800 Patch bug-125505-20131211000004.patch text/plain 1909 skyul U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMzU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTk5ZTI5ZTk1MDY5ZWE5 NzQxMGM4ZDJhNDY0YzI5MmJmZTg0YjAzMS4uNGJlMjI4ZGJhNDA3YjVmZDIwODc2ZGI1MTg1ZGJk YzMxZGNkYTEwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEzLTEyLTEwICBLd2Fu ZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CiAKKyAgICAgICAgW1dLMl1bU09VUF0g V2ViQ29udGV4dDo6c2V0SWdub3JlVExTRXJyb3JzIHNob3VsZCBzZW5kIFNldElnbm9yZVRMU0Vy cm9ycyB0byB0aGUgbmV0d29yayBwcm9jZXNzIHdoZW4gbmV0d29yayBwcm9jZXNzIGlzIGVuYWJs ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTUw NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg aXMgYSBmb2xsb3ctdXAgcGF0Y2ggZm9yIHIxNjAzNTUuCisKKyAgICAgICAgKiBVSVByb2Nlc3Mv Z3RrL1dlYkNvbnRleHRHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0OjpzZXRJ Z25vcmVUTFNFcnJvcnMpOgorCisyMDEzLTEyLTEwICBLd2FuZyBZdWwgU2VvICA8c2t5dWxAY29t cGFueTEwMC5uZXQ+CisKICAgICAgICAgQWxsb3cgdXMgdG8gdXNlIG5ldHdvcmsgcHJvY2VzcyB3 aXRoIGEgc2luZ2xlIHByb2Nlc3MgbW9kZWwKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyNTUwNwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvZ3RrL1dlYkNvbnRleHRHdGsuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L2d0ay9XZWJDb250ZXh0R3RrLmNwcAppbmRleCA2MDI0NjhkYjU1ZTcyNmZmMzkyMjViY2VlYmM0 N2UxNDFhNGNmNmFkLi43ODEzMWFjNjI2ZDJlYzhhNjAzN2ZiOTFjODQ1YmQ2ZmE5MWMwODVjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYkNvbnRleHRHdGsuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2ViQ29udGV4dEd0ay5jcHAKQEAg LTQwLDYgKzQwLDEwIEBACiAjaW5jbHVkZSA8d3RmL2dvYmplY3QvR093blB0ci5oPgogI2luY2x1 ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KIAorI2lmIEVOQUJMRShORVRXT1JLX1BST0NFU1MpCisj aW5jbHVkZSAiTmV0d29ya1Byb2Nlc3NNZXNzYWdlcy5oIgorI2VuZGlmCisKIG5hbWVzcGFjZSBX ZWJLaXQgewogCiBzdGF0aWMgdm9pZCBpbml0SW5zcGVjdG9yU2VydmVyKCkKQEAgLTE0Miw2ICsx NDYsMTIgQEAgU3RyaW5nIFdlYkNvbnRleHQ6OnBsYXRmb3JtRGVmYXVsdENvb2tpZVN0b3JhZ2VE aXJlY3RvcnkoKSBjb25zdAogdm9pZCBXZWJDb250ZXh0OjpzZXRJZ25vcmVUTFNFcnJvcnMoYm9v bCBpZ25vcmVUTFNFcnJvcnMpCiB7CiAgICAgbV9pZ25vcmVUTFNFcnJvcnMgPSBpZ25vcmVUTFNF cnJvcnM7CisjaWYgRU5BQkxFKE5FVFdPUktfUFJPQ0VTUykKKyAgICBpZiAodXNlc05ldHdvcmtQ cm9jZXNzKCkgJiYgbmV0d29ya1Byb2Nlc3MoKSkgeworICAgICAgICBuZXR3b3JrUHJvY2Vzcygp LT5zZW5kKE1lc3NhZ2VzOjpOZXR3b3JrUHJvY2Vzczo6U2V0SWdub3JlVExTRXJyb3JzKG1faWdu b3JlVExTRXJyb3JzKSwgMCk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisjZW5kaWYKICAgICBz ZW5kVG9BbGxQcm9jZXNzZXMoTWVzc2FnZXM6OldlYlByb2Nlc3M6OlNldElnbm9yZVRMU0Vycm9y cyhtX2lnbm9yZVRMU0Vycm9ycykpOwogfQogCg==