125473 2013-12-09 16:24:38 -0800 CStack Branch: Change nativeForGenerator fallBack bool to an enum 2013-12-09 16:36:04 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 958129 0 msaboff 2013-12-09 16:24:38 -0800 The "bool fallBack" parameter recently added to nativeForGenerator() should be an enum to convey more information per WebKit coding guidelines. 958130 1 218810 msaboff 2013-12-09 16:31:00 -0800 Created attachment 218810 Patch for landing Already reviewed. 958134 2 msaboff 2013-12-09 16:36:04 -0800 Committed r160343: <http://trac.webkit.org/changeset/160343> 218810 2013-12-09 16:31:00 -0800 2013-12-09 16:31:00 -0800 Patch for landing 125473.patch text/plain 3504 msaboff SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2MDM0 MikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEzLTEy LTA5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIE5lZWQg YSBzaG9ydCBkZXNjcmlwdGlvbiAoT09QUyEpLgorICAgICAgICBOZWVkIHRoZSBidWcgVVJMIChP T1BTISkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTb3VyY2UvV1RGL3d0Zi9EYXRhTG9nLmNwcDoKKwogMjAxMy0xMi0wNiAgQWxiZXJ0byBHYXJj aWEgIDxiZXJ0b0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEVuYWJsZSB3ZWIgYXVkaW8g YnkgZGVmYXVsdApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNjAzNDIp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTcgQEAKKzIwMTMtMTItMDkgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5j b20+CisKKyAgICAgICAgQ1N0YWNrIEJyYW5jaDogQ2hhbmdlIG5hdGl2ZUZvckdlbmVyYXRvciBm YWxsQmFjayBib29sIHRvIGFuIGVudW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyNTQ3MworCisgICAgICAgIFJldmlld2VkIGJ5IEZpbGlwIFBpemxv LgorCisgICAgICAgIENoYW5nZSB0aGUgImJvb2wgZmFsbEJhY2siIHRvIGFuIGVudW0gbmFtZSBU aHVua0VudHJ5VHlwZSB3aXRoIHZhbHVlcworICAgICAgICBFbnRlclZpYUNhbGwgYW5kIEVudGVy VmlhSnVtcCB0byBpbmRpY2F0ZSBob3cgdGhlIHRodW5rIHdpbGwgYmUgZW50ZXJlZC4KKworICAg ICAgICAqIGppdC9UaHVua0dlbmVyYXRvcnMuY3BwOgorICAgICAgICAoSlNDOjpuYXRpdmVGb3JH ZW5lcmF0b3IpOgorICAgICAgICAoSlNDOjpuYXRpdmVDYWxsRmFsbGJhY2tHZW5lcmF0b3IpOgor CiAyMDEzLTEyLTA5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAg ICAgIENTdGFjayBCcmFuY2g6IEZpeCBiYXNlbGluZSBKSVQgZm9yIGJhc2ljIG9wZXJhdGlvbgpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UaHVua0dlbmVyYXRvcnMuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvVGh1bmtHZW5lcmF0b3JzLmNwcAko cmV2aXNpb24gMTYwMzQwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UaHVua0dlbmVy YXRvcnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNDAsMTMgKzI0MCwxNSBAQCBNYWNyb0Fzc2Vt YmxlckNvZGVSZWYgdmlydHVhbENvbnN0cnVjdFRoCiAgICAgcmV0dXJuIHZpcnR1YWxGb3JUaHVu a0dlbmVyYXRvcih2bSwgQ29kZUZvckNvbnN0cnVjdCk7CiB9CiAKLXN0YXRpYyBNYWNyb0Fzc2Vt YmxlckNvZGVSZWYgbmF0aXZlRm9yR2VuZXJhdG9yKFZNKiB2bSwgQ29kZVNwZWNpYWxpemF0aW9u S2luZCBraW5kLCBib29sIGZhbGxCYWNrID0gZmFsc2UpCitlbnVtIFRodW5rRW50cnlUeXBlIHsg RW50ZXJWaWFDYWxsLCBFbnRlclZpYUp1bXAgfTsKKworc3RhdGljIE1hY3JvQXNzZW1ibGVyQ29k ZVJlZiBuYXRpdmVGb3JHZW5lcmF0b3IoVk0qIHZtLCBDb2RlU3BlY2lhbGl6YXRpb25LaW5kIGtp bmQsIFRodW5rRW50cnlUeXBlIGVudHJ5VHlwZSA9IEVudGVyVmlhQ2FsbCkKIHsKICAgICBpbnQg ZXhlY3V0YWJsZU9mZnNldFRvRnVuY3Rpb24gPSBOYXRpdmVFeGVjdXRhYmxlOjpvZmZzZXRPZk5h dGl2ZUZ1bmN0aW9uRm9yKGtpbmQpOwogICAgIAogICAgIEpTSW50ZXJmYWNlSklUIGppdCh2bSk7 CiAKLSAgICBpZiAoIWZhbGxCYWNrKQorICAgIGlmIChlbnRyeVR5cGUgPT0gRW50ZXJWaWFDYWxs KQogICAgICAgICBqaXQuZW1pdEZ1bmN0aW9uUHJvbG9ndWUoKTsKIAogICAgIGppdC5lbWl0UHV0 SW1tZWRpYXRlVG9DYWxsRnJhbWVIZWFkZXIoMCwgSlNTdGFjazo6Q29kZUJsb2NrKTsKQEAgLTQw Niw3ICs0MDgsNyBAQCBzdGF0aWMgTWFjcm9Bc3NlbWJsZXJDb2RlUmVmIG5hdGl2ZUZvckdlCiAg ICAgaml0Lmp1bXBUb0V4Y2VwdGlvbkhhbmRsZXIoKTsKIAogICAgIExpbmtCdWZmZXIgcGF0Y2hC dWZmZXIoKnZtLCAmaml0LCBHTE9CQUxfVEhVTktfSUQpOwotICAgIHJldHVybiBGSU5BTElaRV9D T0RFKHBhdGNoQnVmZmVyLCAoIm5hdGl2ZSAlcyAlc3RyYW1wb2xpbmUiLCB0b0NTdHJpbmcoa2lu ZCkuZGF0YSgpLCBmYWxsQmFjayA/ICJmYWxsYmFjayAiIDogIiIpKTsKKyAgICByZXR1cm4gRklO QUxJWkVfQ09ERShwYXRjaEJ1ZmZlciwgKCJuYXRpdmUgJXMgJXN0cmFtcG9saW5lIiwgdG9DU3Ry aW5nKGtpbmQpLmRhdGEoKSwgZW50cnlUeXBlID09IEVudGVyVmlhSnVtcCA/ICJGYWxsYmFjayAi IDogIiIpKTsKIH0KIAogTWFjcm9Bc3NlbWJsZXJDb2RlUmVmIG5hdGl2ZUNhbGxHZW5lcmF0b3Io Vk0qIHZtKQpAQCAtNDE2LDcgKzQxOCw3IEBAIE1hY3JvQXNzZW1ibGVyQ29kZVJlZiBuYXRpdmVD YWxsR2VuZXJhdG8KIAogTWFjcm9Bc3NlbWJsZXJDb2RlUmVmIG5hdGl2ZUNhbGxGYWxsYmFja0dl bmVyYXRvcihWTSogdm0pCiB7Ci0gICAgcmV0dXJuIG5hdGl2ZUZvckdlbmVyYXRvcih2bSwgQ29k ZUZvckNhbGwsIHRydWUpOworICAgIHJldHVybiBuYXRpdmVGb3JHZW5lcmF0b3Iodm0sIENvZGVG b3JDYWxsLCBFbnRlclZpYUp1bXApOwogfQogCiBNYWNyb0Fzc2VtYmxlckNvZGVSZWYgbmF0aXZl Q29uc3RydWN0R2VuZXJhdG9yKFZNKiB2bSkKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL0RhdGFMb2cu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0RhdGFMb2cuY3BwCShyZXZpc2lvbiAx NjAzMTIpCisrKyBTb3VyY2UvV1RGL3d0Zi9EYXRhTG9nLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NDAsNyArNDAsNyBAQAogI2VuZGlmCiAjZW5kaWYKIAotI2RlZmluZSBEQVRBX0xPR19UT19GSUxF IDAKKyNkZWZpbmUgREFUQV9MT0dfVE9fRklMRSAxCiAKIC8vIFVuY29tbWVudCB0byBmb3JjZSBs b2dnaW5nIHRvIHRoZSBnaXZlbiBmaWxlIHJlZ2FyZGxlc3Mgb2Ygd2hhdCB0aGUgZW52aXJvbm1l bnQgdmFyaWFibGUgc2F5cy4gTm90ZSB0aGF0CiAvLyB3ZSB3aWxsIGFwcGVuZCAiLjxwaWQ+LnR4 dCIgd2hlcmUgPHBpZD4gaXMgdGhlIFBJRC4K