125469 2013-12-09 15:07:26 -0800 Avoid divide by zero in scrollbar code, and protect against Obj-C exceptions 2013-12-09 15:25:34 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser bdakin simon.fraser thorton oldest_to_newest 958104 0 simon.fraser 2013-12-09 15:07:26 -0800 Avoid divide by zero in scrollbar code, and protect against Obj-C exceptions 958105 1 218807 simon.fraser 2013-12-09 15:12:56 -0800 Created attachment 218807 Patch 958109 2 simon.fraser 2013-12-09 15:25:34 -0800 https://trac.webkit.org/r160335 218807 2013-12-09 15:12:56 -0800 2013-12-09 15:15:34 -0800 Patch bug-125469-20131209151255.patch text/plain 5408 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMzI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjAyMzk1MGQxYzE2YzI0 MmFlM2EzMDczZTMwMTBjNThkMTA4YjAyZC4uZjlhNmY5ZmNlNmZmYjRhYTliMjdjOWM5NjBhZmJj OWI5YzIyMDNiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEzLTEyLTA5ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEF2b2lkIGRpdmlk ZSBieSB6ZXJvIGluIHNjcm9sbGJhciBjb2RlLCBhbmQgcHJvdGVjdCBhZ2FpbnN0IE9iai1DIGV4 Y2VwdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyNTQ2OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTU1MzU3NzI+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBJbiBTY3JvbGxiYXJU aGVtZU1hYzo6c2V0UGFpbnRDaGFyYWN0ZXJpc3RpY3NGb3JTY3JvbGxiYXIoKSwgcHJvcG9ydGlv biBjb3VsZAorICAgICAgICBlbmQgdXAgYXMgTmFOIGlmIHNjcm9sbGJhci0+dG90YWxTaXplKCkg d2VyZSB6ZXJvLiBQcm90ZWN0IGFnYWluc3QgdGhhdC4KKyAgICAgICAgCisgICAgICAgIEFsc28g d3JhcCBmdW5jdGlvbnMgdGhhdCBjYWxsIGludG8gT2JqZWN0aXZlLUMgd2l0aCBCRUdJTl9CTE9D S19PQkpDX0VYQ0VQVElPTlMvCisgICAgICAgIEVORF9CTE9DS19PQkpDX0VYQ0VQVElPTlMuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvU2Nyb2xsYmFyVGhlbWVNYWMubW06CisgICAgICAgIChX ZWJDb3JlOjpTY3JvbGxiYXJUaGVtZU1hYzo6c2Nyb2xsYmFyVGhpY2tuZXNzKToKKyAgICAgICAg KFdlYkNvcmU6OlNjcm9sbGJhclRoZW1lTWFjOjp1cGRhdGVTY3JvbGxiYXJPdmVybGF5U3R5bGUp OgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyVGhlbWVNYWM6Om1pbmltdW1UaHVtYkxlbmd0 aCk6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxiYXJUaGVtZU1hYzo6dXBkYXRlRW5hYmxlZFN0 YXRlKToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGJhclRoZW1lTWFjOjpzZXRQYWludENoYXJh Y3RlcmlzdGljc0ZvclNjcm9sbGJhcik6CisgICAgICAgIChXZWJDb3JlOjpzY3JvbGxiYXJQYWlu dGVyUGFpbnQpOgorCiAyMDEzLTEyLTA5ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNv bT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIxNjAyNjApOiBNZW1vcnkgcHJlc3N1cmUgc2lnbmFs IGNhdXNlcyB3ZWIgcHJvY2VzcyB0byBoYW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbWFjL1Njcm9sbGJhclRoZW1lTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWFjL1Njcm9sbGJhclRoZW1lTWFjLm1tCmluZGV4IDZmZjczZjRjODE3NjQxOTRhYTcxYzY4 MWRhYTk1Njg5M2FhOGI2OTkuLjZiY2QwYmRiNWFmNjZkY2NkNjBjMWNkNjRmZGM3YjU5OTU2MTUw ZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxiYXJUaGVt ZU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsYmFyVGhlbWVN YWMubW0KQEAgLTI2LDYgKzI2LDcgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJT Y3JvbGxiYXJUaGVtZU1hYy5oIgogCisjaW5jbHVkZSAiQmxvY2tFeGNlcHRpb25zLmgiCiAjaW5j bHVkZSAiQ29sb3JNYWMuaCIKICNpbmNsdWRlICJJbWFnZUJ1ZmZlci5oIgogI2luY2x1ZGUgIkdy YXBoaWNzTGF5ZXIuaCIKQEAgLTIyMSwxMCArMjIyLDEyIEBAIHZvaWQgU2Nyb2xsYmFyVGhlbWVN YWM6OnByZWZlcmVuY2VzQ2hhbmdlZCgpCiAKIGludCBTY3JvbGxiYXJUaGVtZU1hYzo6c2Nyb2xs YmFyVGhpY2tuZXNzKFNjcm9sbGJhckNvbnRyb2xTaXplIGNvbnRyb2xTaXplKQogeworICAgIEJF R0lOX0JMT0NLX09CSkNfRVhDRVBUSU9OUzsKICAgICBTY3JvbGxiYXJQYWludGVyIHNjcm9sbGJh clBhaW50ZXIgPSBbTlNDbGFzc0Zyb21TdHJpbmcoQCJOU1Njcm9sbGVySW1wIikgc2Nyb2xsZXJJ bXBXaXRoU3R5bGU6cmVjb21tZW5kZWRTY3JvbGxlclN0eWxlKCkgY29udHJvbFNpemU6Y29udHJv bFNpemUgaG9yaXpvbnRhbDpOTyByZXBsYWNpbmdTY3JvbGxlckltcDpuaWxdOwogICAgIGlmIChz dXBwb3J0c0V4cGFuZGVkU2Nyb2xsYmFycygpKQogICAgICAgICBbc2Nyb2xsYmFyUGFpbnRlciBz ZXRFeHBhbmRlZDpZRVNdOwogICAgIHJldHVybiBbc2Nyb2xsYmFyUGFpbnRlciB0cmFja0JveFdp ZHRoXTsKKyAgICBFTkRfQkxPQ0tfT0JKQ19FWENFUFRJT05TOwogfQogCiBib29sIFNjcm9sbGJh clRoZW1lTWFjOjp1c2VzT3ZlcmxheVNjcm9sbGJhcnMoKSBjb25zdApAQCAtMjM5LDYgKzI0Miw3 IEBAIHZvaWQgU2Nyb2xsYmFyVGhlbWVNYWM6OnVzZXNPdmVybGF5U2Nyb2xsYmFyc0NoYW5nZWQo KQogCiB2b2lkIFNjcm9sbGJhclRoZW1lTWFjOjp1cGRhdGVTY3JvbGxiYXJPdmVybGF5U3R5bGUo U2Nyb2xsYmFyVGhlbWVDbGllbnQqIHNjcm9sbGJhcikKIHsKKyAgICBCRUdJTl9CTE9DS19PQkpD X0VYQ0VQVElPTlM7CiAgICAgU2Nyb2xsYmFyUGFpbnRlciBwYWludGVyID0gcGFpbnRlckZvclNj cm9sbGJhcihzY3JvbGxiYXIpOwogICAgIHN3aXRjaCAoc2Nyb2xsYmFyLT5zY3JvbGxiYXJPdmVy bGF5U3R5bGUoKSkgewogICAgIGNhc2UgU2Nyb2xsYmFyT3ZlcmxheVN0eWxlRGVmYXVsdDoKQEAg LTI1MSw2ICsyNTUsNyBAQCB2b2lkIFNjcm9sbGJhclRoZW1lTWFjOjp1cGRhdGVTY3JvbGxiYXJP dmVybGF5U3R5bGUoU2Nyb2xsYmFyVGhlbWVDbGllbnQqIHNjcm9sbAogICAgICAgICBbcGFpbnRl ciBzZXRLbm9iU3R5bGU6TlNTY3JvbGxlcktub2JTdHlsZUxpZ2h0XTsKICAgICAgICAgYnJlYWs7 CiAgICAgfQorICAgIEVORF9CTE9DS19PQkpDX0VYQ0VQVElPTlM7CiB9CiAKIGRvdWJsZSBTY3Jv bGxiYXJUaGVtZU1hYzo6aW5pdGlhbEF1dG9zY3JvbGxUaW1lckRlbGF5KCkKQEAgLTQyMCw3ICs0 MjUsOSBAQCBJbnRSZWN0IFNjcm9sbGJhclRoZW1lTWFjOjp0cmFja1JlY3QoU2Nyb2xsYmFyVGhl bWVDbGllbnQqIHNjcm9sbGJhciwgYm9vbCBwYWludAogCiBpbnQgU2Nyb2xsYmFyVGhlbWVNYWM6 Om1pbmltdW1UaHVtYkxlbmd0aChTY3JvbGxiYXJUaGVtZUNsaWVudCogc2Nyb2xsYmFyKQogewor ICAgIEJFR0lOX0JMT0NLX09CSkNfRVhDRVBUSU9OUzsKICAgICByZXR1cm4gW3Njcm9sbGJhck1h cCgpLT5nZXQoc2Nyb2xsYmFyKSBrbm9iTWluTGVuZ3RoXTsKKyAgICBFTkRfQkxPQ0tfT0JKQ19F WENFUFRJT05TOwogfQogCiBib29sIFNjcm9sbGJhclRoZW1lTWFjOjpzaG91bGRDZW50ZXJPblRo dW1iKFNjcm9sbGJhclRoZW1lQ2xpZW50KiwgY29uc3QgUGxhdGZvcm1Nb3VzZUV2ZW50JiBldnQp CkBAIC00NTcsMjYgKzQ2NCwzMSBAQCBpbnQgU2Nyb2xsYmFyVGhlbWVNYWM6OnNjcm9sbGJhclBh cnRUb0hJUHJlc3NlZFN0YXRlKFNjcm9sbGJhclBhcnQgcGFydCkKIAogdm9pZCBTY3JvbGxiYXJU aGVtZU1hYzo6dXBkYXRlRW5hYmxlZFN0YXRlKFNjcm9sbGJhclRoZW1lQ2xpZW50KiBzY3JvbGxi YXIpCiB7CisgICAgQkVHSU5fQkxPQ0tfT0JKQ19FWENFUFRJT05TOwogICAgIFtzY3JvbGxiYXJN YXAoKS0+Z2V0KHNjcm9sbGJhcikgc2V0RW5hYmxlZDpzY3JvbGxiYXItPmVuYWJsZWQoKV07Cisg ICAgRU5EX0JMT0NLX09CSkNfRVhDRVBUSU9OUzsKIH0KIAogdm9pZCBTY3JvbGxiYXJUaGVtZU1h Yzo6c2V0UGFpbnRDaGFyYWN0ZXJpc3RpY3NGb3JTY3JvbGxiYXIoU2Nyb2xsYmFyVGhlbWVDbGll bnQqIHNjcm9sbGJhcikKIHsKKyAgICBCRUdJTl9CTE9DS19PQkpDX0VYQ0VQVElPTlM7CiAgICAg U2Nyb2xsYmFyUGFpbnRlciBwYWludGVyID0gcGFpbnRlckZvclNjcm9sbGJhcihzY3JvbGxiYXIp OwogCiAgICAgZmxvYXQgdmFsdWU7CiAgICAgZmxvYXQgb3Zlcmhhbmc7CiAgICAgU2Nyb2xsYWJs ZUFyZWE6OmNvbXB1dGVTY3JvbGxiYXJWYWx1ZUFuZE92ZXJoYW5nKHNjcm9sbGJhci0+Y3VycmVu dFBvcygpLCBzY3JvbGxiYXItPnRvdGFsU2l6ZSgpLCBzY3JvbGxiYXItPnZpc2libGVTaXplKCks IHZhbHVlLCBvdmVyaGFuZyk7Ci0gICAgZmxvYXQgcHJvcG9ydGlvbiA9IChzdGF0aWNfY2FzdDxD R0Zsb2F0PihzY3JvbGxiYXItPnZpc2libGVTaXplKCkpIC0gb3ZlcmhhbmcpIC8gc2Nyb2xsYmFy LT50b3RhbFNpemUoKTsKKyAgICBmbG9hdCBwcm9wb3J0aW9uID0gc2Nyb2xsYmFyLT50b3RhbFNp emUoKSA+IDAgPyAoc3RhdGljX2Nhc3Q8Q0dGbG9hdD4oc2Nyb2xsYmFyLT52aXNpYmxlU2l6ZSgp KSAtIG92ZXJoYW5nKSAvIHNjcm9sbGJhci0+dG90YWxTaXplKCkgOiAxOwogCiAgICAgW3BhaW50 ZXIgc2V0RW5hYmxlZDpzY3JvbGxiYXItPmVuYWJsZWQoKV07CiAgICAgW3BhaW50ZXIgc2V0Qm91 bmRzU2l6ZTpzY3JvbGxiYXItPmZyYW1lUmVjdCgpLnNpemUoKV07CiAgICAgW3BhaW50ZXIgc2V0 RG91YmxlVmFsdWU6dmFsdWVdOwogICAgIFtwYWludGVyIHNldEtub2JQcm9wb3J0aW9uOnByb3Bv cnRpb25dOworICAgIEVORF9CTE9DS19PQkpDX0VYQ0VQVElPTlM7CiB9CiAKIHN0YXRpYyB2b2lk IHNjcm9sbGJhclBhaW50ZXJQYWludChTY3JvbGxiYXJQYWludGVyIHNjcm9sbGJhclBhaW50ZXIs IGJvb2wgZW5hYmxlZCkKIHsKKyAgICBCRUdJTl9CTE9DS19PQkpDX0VYQ0VQVElPTlM7CiAgICAg Ly8gVXNlIHJlY3RGb3JQYXJ0OiBoZXJlOyBpdCB3aWxsIHRha2UgdGhlIGV4cGFuc2lvbiB0cmFu c2l0aW9uIHByb2dyZXNzIGludG8gYWNjb3VudC4KICAgICBOU1JlY3QgdHJhY2tSZWN0ID0gW3Nj cm9sbGJhclBhaW50ZXIgcmVjdEZvclBhcnQ6TlNTY3JvbGxlcktub2JTbG90XTsKICAgICBbc2Ny b2xsYmFyUGFpbnRlciBkcmF3S25vYlNsb3RJblJlY3Q6dHJhY2tSZWN0IGhpZ2hsaWdodDpOT107 CkBAIC00ODUsNiArNDk3LDcgQEAgc3RhdGljIHZvaWQgc2Nyb2xsYmFyUGFpbnRlclBhaW50KFNj cm9sbGJhclBhaW50ZXIgc2Nyb2xsYmFyUGFpbnRlciwgYm9vbCBlbmFibGUKICAgICAvLyBjYWxs IGRyYXdLbm9iLgogICAgIGlmIChlbmFibGVkKQogICAgICAgICBbc2Nyb2xsYmFyUGFpbnRlciBk cmF3S25vYl07CisgICAgRU5EX0JMT0NLX09CSkNfRVhDRVBUSU9OUzsKIH0KIAogYm9vbCBTY3Jv bGxiYXJUaGVtZU1hYzo6cGFpbnQoU2Nyb2xsYmFyVGhlbWVDbGllbnQqIHNjcm9sbGJhciwgR3Jh cGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBJbnRSZWN0JiBkYW1hZ2VSZWN0KQo=