125467 2013-12-09 14:31:32 -0800 PATH needs to include cygwin for WebKitVersion 2013-12-11 15:35:21 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows 8 RESOLVED FIXED P2 Trivial --- 1 alex.christensen webkit-unassigned bfulgham commit-queue oldest_to_newest 958089 0 alex.christensen 2013-12-09 14:31:32 -0800 http://trac.webkit.org/changeset/159768 broke my build. I guess everyone else has c:\cygwin\bin in their path. That's not a requirement. Here's the fix. 958091 1 218801 alex.christensen 2013-12-09 14:35:03 -0800 Created attachment 218801 Patch 958939 2 218801 bfulgham 2013-12-11 15:06:44 -0800 Comment on attachment 218801 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218801&action=review r=me > Source/WebKit/WebKit.vcxproj/WebKit/WebKitVersion.cmd:5 > +set PATH=%SystemDrive%\cygwin\bin;%PATH% This assumes that Cygwin is always installed in "C:\cygwin", which may not be the case on all user's systems. Still, it's a reasonable assumption for most people. We might want to check "HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Cygwin\setup\rootdir" to get the true location. 958953 3 218801 commit-queue 2013-12-11 15:35:19 -0800 Comment on attachment 218801 Patch Clearing flags on attachment: 218801 Committed r160465: <http://trac.webkit.org/changeset/160465> 958954 4 commit-queue 2013-12-11 15:35:21 -0800 All reviewed patches have been landed. Closing bug. 218801 2013-12-09 14:35:03 -0800 2013-12-11 15:35:19 -0800 Patch bug-125467-20131209153502.patch text/plain 1346 alex.christensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNjAzMzApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTEyLTA5ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1dpbl0gQnVpbGQg Zml4IGFmdGVyIHIxNTk3NjguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjU0NjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFdlYktpdC52Y3hwcm9qL1dlYktpdC9XZWJLaXRWZXJzaW9uLmNtZDoKKyAg ICAgICAgU2V0IFBBVEggZW52aXJvbm1lbnQgdmFyaWFibGUgdG8gaW5jbHVkZSBjeWd3aW4gYmlu IGRpcmVjdG9yeS4KKwogMjAxMy0xMi0wNiAgUm9nZXIgRm9uZyA8cm9nZXJfZm9uZ0BhcHBsZS5j b20+IGFuZCBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtX aW5dIFN1cHBvcnQgY29tcGlsaW5nIHdpdGggVlMyMDEzLgpJbmRleDogU291cmNlL1dlYktpdC9X ZWJLaXQudmN4cHJvai9XZWJLaXQvV2ViS2l0VmVyc2lvbi5jbWQKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdC9XZWJLaXQudmN4cHJvai9XZWJLaXQvV2ViS2l0VmVyc2lvbi5jbWQJKHJldmlz aW9uIDE2MDI1OCkKKysrIFNvdXJjZS9XZWJLaXQvV2ViS2l0LnZjeHByb2ovV2ViS2l0L1dlYktp dFZlcnNpb24uY21kCSh3b3JraW5nIGNvcHkpCkBAIC0yLDUgKzIsNiBAQCBzZXQgV0VCS0lUVkVS U0lPTlNDUklQVD0lUFJPSkVDVERJUiUuLlwuCiBzZXQgV0VCS0lUVkVSU0lPTkNPTkZJRz0lUFJP SkVDVERJUiUuLlwuLlxtYWNcQ29uZmlndXJhdGlvbnNcVmVyc2lvbi54Y2NvbmZpZwogc2V0IFdF QktJVFZFUlNJT05ESVI9JUNPTkZJR1VSQVRJT05CVUlMRERJUiVcaW5jbHVkZVxXZWJLaXQKIHNl dCBXRUJLSVRWRVJTSU9ORklMRT0lV0VCS0lUVkVSU0lPTkRJUiVcV2ViS2l0VmVyc2lvbi5oCitz ZXQgUEFUSD0lU3lzdGVtRHJpdmUlXGN5Z3dpblxiaW47JVBBVEglCiAKIGJhc2ggLWMgJ3Blcmwg IiVXRUJLSVRWRVJTSU9OU0NSSVBUJSIgLS1jb25maWcgIiVXRUJLSVRWRVJTSU9OQ09ORklHJSIg IC0tb3V0cHV0RGlyICIlV0VCS0lUVkVSU0lPTkRJUiUiJwo=