125464 2013-12-09 12:01:20 -0800 GL_HALF_FLOAT_ARB not defined 2013-12-09 12:22:55 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC Windows 7 RESOLVED DUPLICATE 125383 P2 Minor --- 1 alex.christensen webkit-unassigned bfulgham commit-queue dino kondapallykalyan noam roger_fong oldest_to_newest 958031 0 alex.christensen 2013-12-09 12:01:20 -0800 I'm not sure where GL_HALF_FLOAT_ARB is defined, but http://trac.webkit.org/changeset/160119 broke WebGL on Windows. Is putting PLATFORM(MAC) around it the right thing to do? Maybe #if !USE(OPENGL_ES_2), or maybe I should just find the definition and include it. 958034 1 218786 alex.christensen 2013-12-09 12:06:01 -0800 Created attachment 218786 Patch 958035 2 218786 darin 2013-12-09 12:11:03 -0800 Comment on attachment 218786 Patch Is this a better fix than the one in bug 125383? 958036 3 218787 alex.christensen 2013-12-09 12:12:36 -0800 Created attachment 218787 Patch 958042 4 alex.christensen 2013-12-09 12:15:56 -0800 I'm not sure what would happen if you gave glTexSubImage2D a value it didn't recognize. I'm not sure what happens when you give the GLES implementation of glTexSubImage2D 0x140B as the type, or if this problem will ever come up, or why this change was added in the first place. 958043 5 alex.christensen 2013-12-09 12:16:44 -0800 *** This bug has been marked as a duplicate of bug 125383 *** 218786 2013-12-09 12:06:01 -0800 2013-12-09 12:12:32 -0800 Patch bug-125464-20131209130620.patch text/plain 1476 alex.christensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MDMyMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTEyLTA5ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1dpbkNhaXJv XSBCdWlsZCBmaXggYWZ0ZXIgcjE2MDExOS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyNTQ2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29u dGV4dDNET3BlbkdMQ29tbW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4 dDNEOjp0ZXhTdWJJbWFnZTJEKToKKyAgICAgICAgUHJvdGVjdCBHTF9IQUxGX0ZMT0FUX0FSQiB3 aXRoIFBMQVRGT1JNKE1BQykgbWFjcm8uCisKIDIwMTMtMTItMDkgIFBldGVyIE1vbG5hciAgPHBt b2xuYXIudS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNvbT4KIAogICAgICAgICBGaXggaGFuZGxp bmcgb2YgJ2luaGVyaXQnIGFuZCAnaW5pdGlhbCcgZm9yIGdyaWQgbGluZXMuCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVu R0xDb21tb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHAJKHJldmlzaW9uIDE2 MDI1OCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGlj c0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzNjUsOCArMTM2 NSwxMCBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjp0ZXhTdWJJbWFnZTJEKEdDCiB7CiAgICAg bWFrZUNvbnRleHRDdXJyZW50KCk7CiAKKyNpZiBQTEFURk9STShNQUMpCiAgICAgaWYgKHR5cGUg PT0gSEFMRl9GTE9BVF9PRVMpCiAgICAgICAgIHR5cGUgPSBHTF9IQUxGX0ZMT0FUX0FSQjsKKyNl bmRpZgogCiAgICAgLy8gRklYTUU6IHdlIHdpbGwgbmVlZCB0byBkZWFsIHdpdGggUGl4ZWxTdG9y ZSBwYXJhbXMgd2hlbiBkZWFsaW5nIHdpdGggaW1hZ2UgYnVmZmVycyB0aGF0IGRpZmZlciBmcm9t IHRoZSBzdWJpbWFnZSBzaXplLgogICAgIDo6Z2xUZXhTdWJJbWFnZTJEKHRhcmdldCwgbGV2ZWws IHhvZmYsIHlvZmYsIHdpZHRoLCBoZWlnaHQsIGZvcm1hdCwgdHlwZSwgcGl4ZWxzKTsK 218787 2013-12-09 12:12:36 -0800 2013-12-09 12:22:55 -0800 Patch bug-125464-20131209131254.patch text/plain 1551 alex.christensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MDMyMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEyLTA5ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1dpbkNhaXJv XSBCdWlsZCBmaXggYWZ0ZXIgcjE2MDExOS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyNTQ2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29u dGV4dDNET3BlbkdMQ29tbW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4 dDNEOjp0ZXhTdWJJbWFnZTJEKToKKyAgICAgICAgUHJvdGVjdCBHTF9IQUxGX0ZMT0FUX0FSQiB3 aXRoICFVU0UoT1BFTkdMX0VTXzIpIG1hY3JvIGJlY2F1c2UgaXQgaXMgZGVmaW5lZCBpbgorICAg ICAgICBHTC9nbGV4dC5oIGJ1dCBub3QgR0xFUy9nbDJleHQuaC4KKwogMjAxMy0xMi0wOSAgUGV0 ZXIgTW9sbmFyICA8cG1vbG5hci51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgogCiAgICAg ICAgIEZpeCBoYW5kbGluZyBvZiAnaW5oZXJpdCcgYW5kICdpbml0aWFsJyBmb3IgZ3JpZCBsaW5l cy4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGlj c0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29tbW9uLmNw cAkocmV2aXNpb24gMTYwMjU4KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv b3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29tbW9uLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTM2NSw4ICsxMzY1LDEwIEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OnRleFN1YkltYWdl MkQoR0MKIHsKICAgICBtYWtlQ29udGV4dEN1cnJlbnQoKTsKIAorI2lmICFVU0UoT1BFTkdMX0VT XzIpCiAgICAgaWYgKHR5cGUgPT0gSEFMRl9GTE9BVF9PRVMpCiAgICAgICAgIHR5cGUgPSBHTF9I QUxGX0ZMT0FUX0FSQjsKKyNlbmRpZgogCiAgICAgLy8gRklYTUU6IHdlIHdpbGwgbmVlZCB0byBk ZWFsIHdpdGggUGl4ZWxTdG9yZSBwYXJhbXMgd2hlbiBkZWFsaW5nIHdpdGggaW1hZ2UgYnVmZmVy cyB0aGF0IGRpZmZlciBmcm9tIHRoZSBzdWJpbWFnZSBzaXplLgogICAgIDo6Z2xUZXhTdWJJbWFn ZTJEKHRhcmdldCwgbGV2ZWwsIHhvZmYsIHlvZmYsIHdpZHRoLCBoZWlnaHQsIGZvcm1hdCwgdHlw ZSwgcGl4ZWxzKTsK