125452 2013-12-09 07:32:19 -0800 [GStreamer] Memory leak due to incorrect use of gst_tag_list_merge in TextCombinerGStreamer 2013-12-09 08:15:49 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 b.long b.long commit-queue gustavo menard mrobinson pnormand oldest_to_newest 957880 0 b.long 2013-12-09 07:32:19 -0800 [GStreamer] Memory leak due to incorrect use of gst_tag_list_merge in TextCombinerGStreamer 957882 1 218760 b.long 2013-12-09 07:34:07 -0800 Created attachment 218760 Patch 957885 2 b.long 2013-12-09 07:37:44 -0800 The problem with this is that gst_tag_list_merge creates a new list, so calling: combinerPad->tags = gst_tag_list_merge(combinerPad->tags, tags); ... Creates a new list and then leaks the old one. gst_tag_list_insert is what I should have used in the first place (and it's what gst_tag_list_merge uses internally). 957897 3 218760 commit-queue 2013-12-09 08:15:46 -0800 Comment on attachment 218760 Patch Clearing flags on attachment: 218760 Committed r160312: <http://trac.webkit.org/changeset/160312> 957898 4 commit-queue 2013-12-09 08:15:49 -0800 All reviewed patches have been landed. Closing bug. 218760 2013-12-09 07:34:07 -0800 2013-12-09 08:15:46 -0800 Patch bug-125452-20131209163401.patch text/plain 1833 b.long U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDBhOTc4NjU3Y2NkMmVk ODEyNGNhOWZhNDE3MjdkNmIwNjY2ODg4OC4uNzg3Y2YyYTM4MzEwOGMyMWU5NDIzMjk3ZTQ1MGQ4 ODVjMDMxM2NhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEyLTA5ICBCcmVu ZGFuIExvbmcgIDxiLmxvbmdAY2FibGVsYWJzLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBN ZW1vcnkgbGVhayBkdWUgdG8gaW5jb3JyZWN0IHVzZSBvZiBnc3RfdGFnX2xpc3RfbWVyZ2UgaW4g VGV4dENvbWJpbmVyR1N0cmVhbWVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMjU0NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSB0aGlzIGZpeGVzIGEgbWVtb3J5IGxl YWsuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvVGV4dENvbWJpbmVy R1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKHdlYmtpdFRleHRDb21iaW5lclBhZEV2ZW50KTogVXNl IGdzdF90YWdfbGlzdF9pbnNlcnQgaW5zdGVhZCBvZiBnc3RfdGFnX2xpc3RfbWVyZ2UsIHNpbmNl IHdlIGRvbid0IHdhbnQgdG8gY3JlYXRlIGEgbmV3IGxpc3QuCisKIDIwMTMtMTItMDkgIENhcmxv cyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQuIEZpeCB0aGUgR1RLKyBidWlsZCB3aXRoIE5ldHdvcmtQcm9jZXNzIGVuYWJsZWQuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvVGV4dENv bWJpbmVyR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9UZXh0Q29tYmluZXJHU3RyZWFtZXIuY3BwCmluZGV4IGMwZWJlN2MwMWRiMDA2MGE2 NThjNWRiNDUyYzhhNzA2NjRkN2M1MzMuLmQ5NjMyNjhmZTQyYjNhNjY0MmJlNTM4YjM5YTI5OTBk ZTA4NWY5MGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9UZXh0Q29tYmluZXJHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9UZXh0Q29tYmluZXJHU3RyZWFtZXIuY3BwCkBAIC0y MDIsNyArMjAyLDEwIEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRUZXh0Q29tYmluZXJQYWRFdmVu dChHc3RQYWQqIHBhZCwgR3N0T2JqZWN0KiBwYXJlbnQsIEdzdEV2CiAgICAgICAgIGdzdF9ldmVu dF9wYXJzZV90YWcoZXZlbnQsICZ0YWdzKTsKICAgICAgICAgQVNTRVJUKHRhZ3MpOwogCi0gICAg ICAgIGNvbWJpbmVyUGFkLT50YWdzID0gZ3N0X3RhZ19saXN0X21lcmdlKGNvbWJpbmVyUGFkLT50 YWdzLCB0YWdzLCBHU1RfVEFHX01FUkdFX1JFUExBQ0UpOworICAgICAgICBpZiAoIWNvbWJpbmVy UGFkLT50YWdzKQorICAgICAgICAgICAgY29tYmluZXJQYWQtPnRhZ3MgPSBnc3RfdGFnX2xpc3Rf Y29weSh0YWdzKTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgZ3N0X3RhZ19saXN0X2luc2Vy dChjb21iaW5lclBhZC0+dGFncywgdGFncywgR1NUX1RBR19NRVJHRV9SRVBMQUNFKTsKICAgICAg ICAgZ19vYmplY3Rfbm90aWZ5KEdfT0JKRUNUKHBhZCksICJ0YWdzIik7CiAgICAgICAgIGJyZWFr OwogICAgIH0K