125447 2013-12-09 05:44:55 -0800 [EFL][WK2] LayoutTests are broken after r160301 2013-12-09 11:27:47 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 125438 1 ryuan.choi ryuan.choi cdumez cmarcelo commit-queue gyuyoung.kim lucas.de.marchi luiz noam rakuco zeno oldest_to_newest 957862 0 ryuan.choi 2013-12-09 05:44:55 -0800 I moved FullScreenManagerProxyClient logic to WebViewEfl, child class of CoordinatedGraphics::WebView) because implementations are EFL specific. However, CoordinatedGraphics::WebView creates WebPageProxy in constructor and WebPageProxy requires FullScreenManagerProxyClient in constructor. So, All WK2/Efl based applications got crashed with below message. pure virtual method called terminate called without an active exception I will add virtual methods for Full Screen to CoordinatedGraphics so that WebPageProxy can get FullScreenManagerProxyClient instance without pure viertual methods. 957865 1 218753 ryuan.choi 2013-12-09 05:54:18 -0800 Created attachment 218753 Patch 958011 2 218753 commit-queue 2013-12-09 11:27:44 -0800 Comment on attachment 218753 Patch Clearing flags on attachment: 218753 Committed r160321: <http://trac.webkit.org/changeset/160321> 958012 3 commit-queue 2013-12-09 11:27:47 -0800 All reviewed patches have been landed. Closing bug. 218753 2013-12-09 05:54:18 -0800 2013-12-09 11:27:44 -0800 Patch bug-125447-20131209225415.patch text/plain 6907 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMzA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTJhMDZlMmQwZDY4OWZk YTRmMzg4NTJmZTcxZTAxZmRlYzE3MDZkMC4uZjIxMTJkOTUyZmNjMDhmNTA0ZTY4MWI5NDgxYTE2 YWY2ODQyMGRiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDEzLTEyLTA5ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIExh eW91dFRlc3RzIGFyZSBicm9rZW4gYWZ0ZXIgcjE2MDMwMQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1NDQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcjE2MDMwMSBtb3ZlZCBGdWxsU2NyZWVuTWFuYWdl clByb3h5Q2xpZW50IGxvZ2ljIHRvIFdlYlZpZXdFZmwsIGNoaWxkIGNsYXNzCisgICAgICAgIG9m IENvb3JkaW5hdGVkR3JhcGhpY3M6OldlYlZpZXcsIGJlY2F1c2UgaW1wbGVtZW50YXRpb25zIGFy ZSBFRkwgc3BlY2lmaWMuCisgICAgICAgIEhvd2V2ZXIsIENvb3JkaW5hdGVkR3JhcGhpY3M6Oldl YlZpZXcgY3JlYXRlcyBXZWJQYWdlUHJveHkgaW4gY29uc3RydWN0b3IgYW5kCisgICAgICAgIFdl YlBhZ2VQcm94eSByZXF1aXJlcyBGdWxsU2NyZWVuTWFuYWdlclByb3h5Q2xpZW50IGluIGNvbnN0 cnVjdG9yLgorICAgICAgICBTbywgQWxsIFdLMi9FZmwgYmFzZWQgYXBwbGljYXRpb25zIGdvdCBj cmFzaGVkCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIHZpcnR1YWwgbWV0aG9kcyBmb3IgRnVs bFNjcmVlbk1hbmFnZXJQcm94eUNsaWVudCB0byBDb29yZGluYXRlZEdyYXBoaWNzOjpXZWJWaWV3 CisgICAgICAgIHNvIHRoYXQgV2ViUGFnZVByb3h5IGNhbiBnZXQgRnVsbFNjcmVlbk1hbmFnZXJQ cm94eUNsaWVudCBpbnN0YW5jZSB3aXRob3V0CisgICAgICAgIHB1cmUgdmllcnR1YWwgbWV0aG9k cy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9Db29yZGluYXRlZEdyYXBoaWNzL1dLVmll dy5jcHA6CisgICAgICAgIChXS1ZpZXdFeGl0RnVsbFNjcmVlbik6CisgICAgICAgICogVUlQcm9j ZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl YlZpZXc6OmZ1bGxTY3JlZW5NYW5hZ2VyUHJveHlDbGllbnQpOgorICAgICAgICAoV2ViS2l0OjpX ZWJWaWV3OjpyZXF1ZXN0RXhpdEZ1bGxTY3JlZW4pOgorICAgICAgICByZW5hbWVkIGZyb20gZXhp dEZ1bGxTY3JlZW4gbm90IHRvIGNvbmZsaWN0IHdpdGggbWV0aG9kcyBvZiBGdWxsU2NyZWVuTWFu YWdlclByb3h5Q2xpZW50LgorICAgICAgICAqIFVJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNz L1dlYlZpZXcuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvZWZsL1dlYlZpZXdFZmwuY3BwOgorICAg ICAgICAqIFVJUHJvY2Vzcy9lZmwvV2ViVmlld0VmbC5oOgorCiAyMDEzLTEyLTA5ICBHdXN0YXZv IE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgogCiAgICAgICAgIFtHVEtdIHJ1bi13ZWJr aXQtdGVzdHMgbWF5IERPUyB0aGUgc3lzdGVtLCBzcGVjaWFsbHkgaW4gZGVidWcgYnVpbGRzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvQ29vcmRpbmF0ZWRHcmFw aGljcy9XS1ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL0Nvb3JkaW5h dGVkR3JhcGhpY3MvV0tWaWV3LmNwcAppbmRleCBhNmVkOTZjMzFjNTkwM2I5OGM5OGRmNWRmNzJh ZjZkZTk3ZThhYWNiLi5kZDEyODM4NTdiZjRmYTZmNTYwODcyZWNhOTRmOWYwOWM2YWFhYzZhIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvQ29vcmRpbmF0ZWRHcmFw aGljcy9XS1ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9Db29y ZGluYXRlZEdyYXBoaWNzL1dLVmlldy5jcHAKQEAgLTE4Miw3ICsxODIsNyBAQCBib29sIFdLVmll d0dldFNob3dzQXNTb3VyY2UoV0tWaWV3UmVmIHZpZXdSZWYpCiBib29sIFdLVmlld0V4aXRGdWxs U2NyZWVuKFdLVmlld1JlZiB2aWV3UmVmKQogewogI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkK LSAgICByZXR1cm4gdG9JbXBsKHZpZXdSZWYpLT5leGl0RnVsbFNjcmVlbigpOworICAgIHJldHVy biB0b0ltcGwodmlld1JlZiktPnJlcXVlc3RFeGl0RnVsbFNjcmVlbigpOwogI2Vsc2UKICAgICBV TlVTRURfUEFSQU0odmlld1JlZik7CiAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2ViVmlldy5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmNwcApp bmRleCA4MjY2NGRlMTQyMWZkMzJlYTZiMDgxNWU0MGQ5MTNjNWEzNjNhNTJmLi4zODZmNzZmOGI5 ODQ3MzAzNjM0ZDc3ZmM0MWU2MDc2ZjdmYTJlMThiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9XZWJWaWV3LmNwcApAQCAtMTk0 LDEzICsxOTQsMTYgQEAgYm9vbCBXZWJWaWV3OjpzaG93c0FzU291cmNlKCkgY29uc3QKIH0KIAog I2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKLWJvb2wgV2ViVmlldzo6ZXhpdEZ1bGxTY3JlZW4o KQorV2ViRnVsbFNjcmVlbk1hbmFnZXJQcm94eUNsaWVudCYgV2ViVmlldzo6ZnVsbFNjcmVlbk1h bmFnZXJQcm94eUNsaWVudCgpCiB7Ci0jaWYgUExBVEZPUk0oRUZMKQotICAgIC8vIEZJWE1FOiBJ bXBsZW1lbnQgdGhpcyBmb3Igb3RoZXIgcGxhdGZvcm1zLgotICAgIGlmICghbV9wYWdlLT5mdWxs U2NyZWVuTWFuYWdlcigpLT5pc0Z1bGxTY3JlZW4oKSkKKyAgICByZXR1cm4gKnRoaXM7Cit9CisK K2Jvb2wgV2ViVmlldzo6cmVxdWVzdEV4aXRGdWxsU2NyZWVuKCkKK3sKKyAgICBpZiAoIWlzRnVs bFNjcmVlbigpKQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0jZW5kaWYKKwogICAgIG1fcGFnZS0+ ZnVsbFNjcmVlbk1hbmFnZXIoKS0+cmVxdWVzdEV4aXRGdWxsU2NyZWVuKCk7CiAgICAgcmV0dXJu IHRydWU7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0 ZWRHcmFwaGljcy9XZWJWaWV3LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0 ZWRHcmFwaGljcy9XZWJWaWV3LmgKaW5kZXggOTZlMzk3YzY2MDE1OWQ3ZmE3MTc1NDE3MTc5N2Jj YmE0NjI1MmIyNC4uNzViYzM4NjE5MDhkMzJkYWVhMGU0NjNlNjc2MWMxYjFjNWMxMzBjZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvV2Vi Vmlldy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNz L1dlYlZpZXcuaApAQCAtMzMsNiArMzMsNyBAQAogI2luY2x1ZGUgIkRlZmF1bHRVbmRvQ29udHJv bGxlci5oIgogI2luY2x1ZGUgIlBhZ2VDbGllbnQuaCIKICNpbmNsdWRlICJXZWJDb250ZXh0Lmgi CisjaW5jbHVkZSAiV2ViRnVsbFNjcmVlbk1hbmFnZXJQcm94eS5oIgogI2luY2x1ZGUgIldlYkdl b21ldHJ5LmgiCiAjaW5jbHVkZSAiV2ViUGFnZUdyb3VwLmgiCiAjaW5jbHVkZSAiV2ViUGFnZVBy b3h5LmgiCkBAIC00Niw3ICs0NywxMSBAQCBjbGFzcyBDb29yZGluYXRlZEdyYXBoaWNzU2NlbmU7 CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCi1jbGFzcyBXZWJWaWV3IDogcHVibGljIEFQSTo6VHlw ZWRPYmplY3Q8QVBJOjpPYmplY3Q6OlR5cGU6OlZpZXc+LCBwdWJsaWMgUGFnZUNsaWVudCB7Citj bGFzcyBXZWJWaWV3IDogcHVibGljIEFQSTo6VHlwZWRPYmplY3Q8QVBJOjpPYmplY3Q6OlR5cGU6 OlZpZXc+LCBwdWJsaWMgUGFnZUNsaWVudAorI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKKyAg ICAsIHB1YmxpYyBXZWJGdWxsU2NyZWVuTWFuYWdlclByb3h5Q2xpZW50CisjZW5kaWYKKyAgICB7 CiBwdWJsaWM6CiAgICAgdmlydHVhbCB+V2ViVmlldygpOwogCkBAIC05Myw3ICs5OCw3IEBAIHB1 YmxpYzoKICAgICBib29sIHNob3dzQXNTb3VyY2UoKSBjb25zdDsKIAogI2lmIEVOQUJMRShGVUxM U0NSRUVOX0FQSSkKLSAgICBib29sIGV4aXRGdWxsU2NyZWVuKCk7CisgICAgYm9vbCByZXF1ZXN0 RXhpdEZ1bGxTY3JlZW4oKTsKICNlbmRpZgogCiAgICAgdm9pZCBmaW5kWm9vbWFibGVBcmVhRm9y UG9pbnQoY29uc3QgV2ViQ29yZTo6SW50UG9pbnQmLCBjb25zdCBXZWJDb3JlOjpJbnRTaXplJik7 CkBAIC0xODksNiArMTk0LDE4IEBAIHByb3RlY3RlZDoKICAgICB2aXJ0dWFsIHZvaWQgZXhpdEFj Y2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlKCkgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2b2lkIHVw ZGF0ZUFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlKGNvbnN0IExheWVyVHJlZUNvbnRleHQmKSBP VkVSUklERTsKIAorI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKKyAgICBXZWJGdWxsU2NyZWVu TWFuYWdlclByb3h5Q2xpZW50JiBmdWxsU2NyZWVuTWFuYWdlclByb3h5Q2xpZW50KCkgT1ZFUlJJ REU7CisKKyAgICAvLyBXZWJGdWxsU2NyZWVuTWFuYWdlclByb3h5Q2xpZW50CisgICAgdmlydHVh bCB2b2lkIGNsb3NlRnVsbFNjcmVlbk1hbmFnZXIoKSBPVkVSUklERSB7IH0KKyAgICB2aXJ0dWFs IGJvb2wgaXNGdWxsU2NyZWVuKCkgT1ZFUlJJREUgeyByZXR1cm4gZmFsc2U7IH0KKyAgICB2aXJ0 dWFsIHZvaWQgZW50ZXJGdWxsU2NyZWVuKCkgT1ZFUlJJREUgeyB9CisgICAgdmlydHVhbCB2b2lk IGV4aXRGdWxsU2NyZWVuKCkgT1ZFUlJJREUgeyB9CisgICAgdmlydHVhbCB2b2lkIGJlZ2FuRW50 ZXJGdWxsU2NyZWVuKGNvbnN0IFdlYkNvcmU6OkludFJlY3QmLCBjb25zdCBXZWJDb3JlOjpJbnRS ZWN0JikgT1ZFUlJJREUgeyB9CisgICAgdmlydHVhbCB2b2lkIGJlZ2FuRXhpdEZ1bGxTY3JlZW4o Y29uc3QgV2ViQ29yZTo6SW50UmVjdCYsIGNvbnN0IFdlYkNvcmU6OkludFJlY3QmKSBPVkVSUklE RSB7IH0KKyNlbmRpZgorCiBwcm90ZWN0ZWQ6CiAgICAgV2ViVmlld0NsaWVudCBtX2NsaWVudDsK ICAgICBSZWZQdHI8V2ViUGFnZVByb3h5PiBtX3BhZ2U7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvZWZsL1dlYlZpZXdFZmwuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL2VmbC9XZWJWaWV3RWZsLmNwcAppbmRleCA1ZjA4MTgxM2QwYmFiNzM3ZDg1ZDhmYTVmNmVk NzQzYzA3ODExNmI2Li40MjMzNTQ4MTZjNjAxMWZmYWU1OWUwOWQzNzIwMzg0NzljZDNlMzg0IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1dlYlZpZXdFZmwuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvV2ViVmlld0VmbC5jcHAKQEAgLTE0Miwx MSArMTQyLDYgQEAgdm9pZCBXZWJWaWV3RWZsOjpzZW5kTW91c2VFdmVudChjb25zdCBFdmFzX0V2 ZW50X01vdXNlX01vdmUqIGV2ZW50KQogCiAjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQogCi1X ZWJGdWxsU2NyZWVuTWFuYWdlclByb3h5Q2xpZW50JiBXZWJWaWV3RWZsOjpmdWxsU2NyZWVuTWFu YWdlclByb3h5Q2xpZW50KCkKLXsKLSAgICByZXR1cm4gKnRoaXM7Ci19Ci0KIC8vIFdlYkZ1bGxT Y3JlZW5NYW5hZ2VyUHJveHlDbGllbnQKIGJvb2wgV2ViVmlld0VmbDo6aXNGdWxsU2NyZWVuKCkK IHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvV2ViVmlld0VmbC5o IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9XZWJWaWV3RWZsLmgKaW5kZXggYmExZTg3 MDM2ZjM4ZjI5MGJhZjM1Yjk0YTcyYWUwOGEyNDk1NTYwYS4uNTkwNzVhMjk3YjVhYTgzODMyNDBm NDY0NDFkYjc3NmRkY2M1YTY0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L2VmbC9XZWJWaWV3RWZsLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9XZWJW aWV3RWZsLmgKQEAgLTI2LDcgKzI2LDYgQEAKICNpZm5kZWYgV2ViVmlld0VmbF9oCiAjZGVmaW5l IFdlYlZpZXdFZmxfaAogCi0jaW5jbHVkZSAiV2ViRnVsbFNjcmVlbk1hbmFnZXJQcm94eS5oIgog I2luY2x1ZGUgIldlYlZpZXcuaCIKIAogY2xhc3MgRXdrVmlldzsKQEAgLTM4LDkgKzM3LDYgQEAg Y2xhc3MgRXdrVG91Y2hFdmVudDsKICNlbmRpZgogCiBjbGFzcyBXZWJWaWV3RWZsIDogcHVibGlj IFdlYlZpZXcKLSNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpCi0gICAgLCBwdWJsaWMgV2ViRnVs bFNjcmVlbk1hbmFnZXJQcm94eUNsaWVudAotI2VuZGlmCiAgICAgewogcHVibGljOgogICAgIHZv aWQgc2V0RXdrVmlldyhFd2tWaWV3Kik7CkBAIC02NiwxMCArNjIsNiBAQCBwcml2YXRlOgogICAg IHZvaWQgaGFuZGxlRG93bmxvYWRSZXF1ZXN0KERvd25sb2FkUHJveHkqKSBPVkVSUklERTsKIAog I2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKLSAgICBXZWJGdWxsU2NyZWVuTWFuYWdlclByb3h5 Q2xpZW50JiBmdWxsU2NyZWVuTWFuYWdlclByb3h5Q2xpZW50KCkgT1ZFUlJJREU7Ci0jZW5kaWYK LQotI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKICAgICAvLyBXZWJGdWxsU2NyZWVuTWFuYWdl clByb3h5Q2xpZW50CiAgICAgdmlydHVhbCB2b2lkIGNsb3NlRnVsbFNjcmVlbk1hbmFnZXIoKSBP VkVSUklERSBGSU5BTCB7IH0KICAgICB2aXJ0dWFsIGJvb2wgaXNGdWxsU2NyZWVuKCkgT1ZFUlJJ REUgRklOQUw7Cg==