125444 2013-12-09 03:10:24 -0800 [GTK] REGRESSION: www.yahoo.com redirects to the mobile version after UA change 2016-01-17 12:12:25 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://www.yahoo.com P2 Normal --- 1 svillar gustavo berto bunk gustavo mcatanzaro mrobinson rishi.is vjaquez oldest_to_newest 957826 0 svillar 2013-12-09 03:10:24 -0800 The recent UA change from bug 124229 triggered this because if I revert to the old UA then I get the desktop version. 957933 1 berto 2013-12-09 09:38:05 -0800 Related: bug 125432 957946 2 218773 gustavo 2013-12-09 10:11:49 -0800 Created attachment 218773 Patch 957953 3 berto 2013-12-09 10:22:23 -0800 I cannot reproduce this with Epiphany btw :? 957960 4 berto 2013-12-09 10:28:29 -0800 Ah yeah, if I replace X11; Linux x86_64 with X11; Intel Mac OS X then it redirects. 957966 5 vjaquez 2013-12-09 10:32:46 -0800 (In reply to comment #2) > Created an attachment (id=218773) [details] > Patch This patch is very similar with my first one https://bug-124229-attachments.webkit.org/attachment.cgi?id=216802 But @mrobinson commented this https://bugs.webkit.org/show_bug.cgi?id=124229#c8 So I think we're in a kind of a dilemma: some site will redirect us if change it; some other will do too if we doesn't. 957983 6 gustavo 2013-12-09 10:50:55 -0800 I don't get your point Victor, what this patch does is claim to be Mac OS X properly (by not keeping the X11), it doesn't contradict Martin's comment you linked to. Do you know of a site that breaks with this patch? 958001 7 vjaquez 2013-12-09 11:12:40 -0800 (In reply to comment #6) > I don't get your point Victor, what this patch does is claim to be Mac OS X properly (by not keeping the X11), it doesn't contradict Martin's comment you linked to. Do you know of a site that breaks with this patch? oops! Sorry, I misread your patch. Now I got it. Thanks! 958002 8 gustavo 2013-12-09 11:18:09 -0800 (In reply to comment #7) > oops! Sorry, I misread your patch. Now I got it. Thanks! o/\o 958176 9 bunk 2013-12-09 20:00:26 -0800 (In reply to comment #2) > Created an attachment (id=218773) [details] > Patch I'm curious how the Windows build managed to succeed - just by looking at the patch I would have expected it to fail on an undefined cpuDescriptionForUAString() since the #if guard for that version is not removed. 958185 10 bunk 2013-12-09 21:04:13 -0800 (In reply to comment #9) > (In reply to comment #2) > > Created an attachment (id=218773) [details] [details] > > Patch > > I'm curious how the Windows build managed to succeed - just by looking at the patch I would have expected it to fail on an undefined cpuDescriptionForUAString() since the #if guard for that version is not removed. Oh right, the Windows build is not a WebKitGTK+ build. 958231 11 218773 svillar 2013-12-10 00:32:57 -0800 Comment on attachment 218773 Patch I'm all for the patch 958255 12 gustavo 2013-12-10 02:17:43 -0800 Committed r160354: <http://trac.webkit.org/changeset/160354> 1156303 13 mcatanzaro 2016-01-17 12:12:25 -0800 This quirk seems to no longer be needed, at least in my testing. I remove it in a patch in bug #142074. 218773 2013-12-09 10:11:49 -0800 2013-12-10 00:57:00 -0800 Patch bug-125444-20131209191148.patch text/plain 3096 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMzEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzFkZTc4MWQ4ZTcyNTFh MjdmODYwZTJmMTcwNjdkN2VjZWY1MTUxOC4uYjc4MDg3OTJhYjE3YjAwZWJlMmU1ODI4YTA4OTZj ZDdlNTk4ZWQ2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTEyLTA5ICBHdXN0 YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgorCisgICAgICAgIFtHVEtdIFJFR1JF U1NJT046IHd3dy55YWhvby5jb20gcmVkaXJlY3RzIHRvIHRoZSBtb2JpbGUgdmVyc2lvbiBhZnRl ciBVQSBjaGFuZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyNTQ0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3RrL1VzZXJBZ2VudEd0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpw bGF0Zm9ybVZlcnNpb25Gb3JVQVN0cmluZyk6IG1vcmUgY29ycmVjdGx5IHByZXRlbmQgd2UncmUg TWFjIE9TIFguCisgICAgICAgIChXZWJDb3JlOjpzdGFuZGFyZFVzZXJBZ2VudCk6IGRpdHRvLgor CiAyMDEzLTEyLTA5ICBCcmVuZGFuIExvbmcgIDxiLmxvbmdAY2FibGVsYWJzLmNvbT4KIAogICAg ICAgICBbR1N0cmVhbWVyXSBNZW1vcnkgbGVhayBkdWUgdG8gaW5jb3JyZWN0IHVzZSBvZiBnc3Rf dGFnX2xpc3RfbWVyZ2UgaW4gVGV4dENvbWJpbmVyR1N0cmVhbWVyCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvVXNlckFnZW50R3RrLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3BwCmluZGV4IDQ2ODZmM2M4NmNhYjliYTc4YWY4 ZmE0NDIwNjgxYTJkMTc4YjkyNjUuLmQyYjg4NmFhODQzNTE4ZGRlM2EzMWFkYjczM2IxYjc2NDVi NmE1MjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Vc2VyQWdlbnRH dGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Vc2VyQWdlbnRHdGsuY3Bw CkBAIC01MSwzNiArNTEsMTUgQEAgc3RhdGljIGNvbnN0IGNoYXIqIGNwdURlc2NyaXB0aW9uRm9y VUFTdHJpbmcoKQogfQogI2VuZGlmCiAKLXN0YXRpYyBjb25zdCBjaGFyKiBwbGF0Zm9ybUZvclVB U3RyaW5nKCkKLXsKLSNpZiBQTEFURk9STShYMTEpCi0gICAgcmV0dXJuICJYMTEiOwotI2VsaWYg T1MoV0lORE9XUykKLSAgICByZXR1cm4gIiI7Ci0jZWxpZiBQTEFURk9STShNQUMpCi0gICAgcmV0 dXJuICJNYWNpbnRvc2giOwotI2VsaWYgZGVmaW5lZChHREtfV0lORE9XSU5HX0RJUkVDVEZCKQot ICAgIHJldHVybiAiRGlyZWN0RkIiOwotI2Vsc2UKLSAgICByZXR1cm4gIlVua25vd24iOwotI2Vu ZGlmCi19Ci0KIHN0YXRpYyBTdHJpbmcgcGxhdGZvcm1WZXJzaW9uRm9yVUFTdHJpbmcoKQogewog ICAgIERFRklORV9TVEFUSUNfTE9DQUwoU3RyaW5nLCB1YU9TVmVyc2lvbiwgKFN0cmluZygpKSk7 CiAgICAgaWYgKCF1YU9TVmVyc2lvbi5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybiB1YU9TVmVy c2lvbjsKIAotI2lmIE9TKFdJTkRPV1MpCi0gICAgdWFPU1ZlcnNpb24gPSB3aW5kb3dzVmVyc2lv bkZvclVBU3RyaW5nKCk7Ci0jZWxpZiBPUyhEQVJXSU4pIHx8IE9TKFVOSVgpCiAgICAgLy8gV2Ug d2lsbCBhbHdheXMgY2xhaW0gdG8gYmUgU2FmYXJpIGluIE1hYyBPUyBYLCBzaW5jZSBTYWZhcmkg aW4gTGludXggdHJpZ2dlcnMgdGhlIGlPUyBwYXRoIG9uCiAgICAgLy8gc29tZSB3ZWJzaXRlcy4K ICAgICB1YU9TVmVyc2lvbiA9IFN0cmluZzo6Zm9ybWF0KCIlcyBNYWMgT1MgWCIsIGNwdURlc2Ny aXB0aW9uRm9yVUFTdHJpbmcoKSk7Ci0jZWxzZQotICAgIHVhT1NWZXJzaW9uID0gU3RyaW5nKCJV bmtub3duIik7Ci0jZW5kaWYKICAgICByZXR1cm4gdWFPU1ZlcnNpb247CiB9CiAKQEAgLTk1LDkg Kzc0LDkgQEAgU3RyaW5nIHN0YW5kYXJkVXNlckFnZW50KGNvbnN0IFN0cmluZyYgYXBwbGljYXRp b25OYW1lLCBjb25zdCBTdHJpbmcmIGFwcGxpY2F0aW8KICAgICAvLyB3cm9uZyBjYW4gY2F1c2Ug c2l0ZXMgdG8gbG9hZCB0aGUgd3JvbmcgSmF2YVNjcmlwdCwgQ1NTLCBvciBjdXN0b20gZm9udHMu IEluIHNvbWUgY2FzZXMKICAgICAvLyBzaXRlcyB3b24ndCBsb2FkIHJlc291cmNlcyBhdCBhbGwu CiAgICAgREVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBDU3RyaW5nLCB1YVZlcnNpb24sIChTdHJp bmc6OmZvcm1hdCgiJWkuJWkiLCBVU0VSX0FHRU5UX0dUS19NQUpPUl9WRVJTSU9OLCBVU0VSX0FH RU5UX0dUS19NSU5PUl9WRVJTSU9OKS51dGY4KCkpKTsKLSAgICBERUZJTkVfU1RBVElDX0xPQ0FM KGNvbnN0IFN0cmluZywgc3RhdGljVUEsIChTdHJpbmc6OmZvcm1hdCgiTW96aWxsYS81LjAgKCVz OyAlcykgQXBwbGVXZWJLaXQvJXMgKEtIVE1MLCBsaWtlIEdlY2tvKSBTYWZhcmkvJXMiLAotICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHBsYXRmb3JtRm9yVUFTdHJpbmcoKSwgcGxhdGZvcm1WZXJzaW9uRm9yVUFTdHJpbmcoKS51 dGY4KCkuZGF0YSgpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHVhVmVyc2lvbi5kYXRhKCksIHVhVmVyc2lvbi5kYXRhKCkp KSk7CisgICAgREVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBTdHJpbmcsIHN0YXRpY1VBLCAoU3Ry aW5nOjpmb3JtYXQoIk1vemlsbGEvNS4wIChNYWNpbnRvc2g7ICVzKSBBcHBsZVdlYktpdC8lcyAo S0hUTUwsIGxpa2UgR2Vja28pIFNhZmFyaS8lcyIsCisgICAgICAgIHBsYXRmb3JtVmVyc2lvbkZv clVBU3RyaW5nKCkudXRmOCgpLmRhdGEoKSwgdWFWZXJzaW9uLmRhdGEoKSwgdWFWZXJzaW9uLmRh dGEoKSkpKTsKKwogICAgIGlmIChhcHBsaWNhdGlvbk5hbWUuaXNFbXB0eSgpKQogICAgICAgICBy ZXR1cm4gc3RhdGljVUE7CiAK