125443 2013-12-09 02:40:08 -0800 check-webkit-style: ternary operator in macro call identified as initialization list 2013-12-09 10:54:55 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 lvidacs.u-szeged webkit-unassigned commit-queue dino glenn lvidacs.u-szeged ossy rniwa oldest_to_newest 957816 0 lvidacs.u-szeged 2013-12-09 02:40:08 -0800 checkstyle issued error for the following patch: https://bugs.webkit.org/show_bug.cgi?id=125298 /WebKitWebSourceGStreamer.cpp:943: GST_LOG_OBJECT(src, "Have %lld bytes of data", priv->buffer ? static_cast<long long>(gst_buffer_get_size(priv->buffer.get())) : length); ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] 957824 1 218744 lvidacs.u-szeged 2013-12-09 03:08:23 -0800 Created attachment 218744 Patch 957832 2 ossy 2013-12-09 03:24:44 -0800 It would be great if you could add a unit test for this fix. 957843 3 218747 lvidacs.u-szeged 2013-12-09 03:44:45 -0800 Created attachment 218747 Patch 957986 4 218747 commit-queue 2013-12-09 10:54:53 -0800 Comment on attachment 218747 Patch Clearing flags on attachment: 218747 Committed r160318: <http://trac.webkit.org/changeset/160318> 957987 5 commit-queue 2013-12-09 10:54:55 -0800 All reviewed patches have been landed. Closing bug. 218744 2013-12-09 03:08:23 -0800 2013-12-09 03:44:38 -0800 Patch bug-125443-20131209120822.patch text/plain 1620 lvidacs.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMzA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODc0ZTk5MjU4ZDBmYTNmYTQxNGI1MTNmNGIyMzdhMzM1 YWE3ZTUwYi4uM2E4YmQyZTEyNWUyOTY4M2FhZjE3NWZhNTNhNGZhMTYyYzFhMmM2MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTEyLTA5ICBMYXN6bG8gVmlkYWNzICA8bGFjQGluZi51LXN6ZWdlZC5odT4KKwor ICAgICAgICBjaGVjay13ZWJraXQtc3R5bGU6IHRlcm5hcnkgb3BlcmF0b3IgaW4gbWFjcm8gY2Fs bCBpZGVudGlmaWVkIGFzIGluaXRpYWxpemF0aW9uIGxpc3QKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTQ0MworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvIG5vdCBtYXRjaCBpbml0aWFsaXphdGlvbiBs aXN0IHdoZW4gcXVlc3Rpb25tYXJrIGlzIHBsYWNlZCBiZWZvcmUgOgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIChjaGVja19tZW1i ZXJfaW5pdGlhbGl6YXRpb25fbGlzdCk6CisKIDIwMTMtMTItMDggIFNhbSBXZWluaWcgIDxzYW1A d2Via2l0Lm9yZz4KIAogICAgICAgICAzMi1iaXQgTWluaUJyb3dzZXIgZG9lc24ndCBidWlsZApk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCA1NzA1 MjgyMDdkNTc4YzVhNmFhYzIwNDZjM2Q4NjYzOWFjZjI3NGIzLi5iNTBlMGQxYmI2MzkwYTExMTA1 MWFiY2FkYTJlZjRjMzllZjI2NmQ5IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcC5weQpAQCAtMTk4Nyw3ICsxOTg3LDcgQEAgZGVmIGNoZWNrX21lbWJlcl9p bml0aWFsaXphdGlvbl9saXN0KGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZXJyb3IpOgogICAg ICMgd2l0aCB0aGUgY29sb24gb3IgY29tbWEgcHJlY2VkaW5nIHRoZSBtZW1iZXIgb24gdGhhdCBs aW5lLgogICAgIGJlZ2luX2xpbmUgPSBsaW5lCiAgICAgIyBtYXRjaCB0aGUgc3RhcnQgb2YgaW5p dGlhbGl6YXRpb24gbGlzdAotICAgIGlmIHNlYXJjaChyJ14oP1A8aW5kZW50YXRpb24+XHMqKSgo ZXhwbGljaXRccyspP1teXHNdK1woLipcKVxzP1w6fF5ccypcOikuKlteO10qJCcsIGxpbmUpOgor ICAgIGlmIHNlYXJjaChyJ14oP1A8aW5kZW50YXRpb24+XHMqKSgoZXhwbGljaXRccyspP1teKFxz fFw/KV0rXChbXlw/XSpcKVxzP1w6fF4oXHN8XD8pKlw6KS4qW147XSokJywgbGluZSk6CiAgICAg ICAgIGlmIHNlYXJjaChyJ1teOl1cOlteXDpcc10rJywgbGluZSk6CiAgICAgICAgICAgICBlcnJv cihsaW5lX251bWJlciwgJ3doaXRlc3BhY2UvaW5pdCcsIDQsCiAgICAgICAgICAgICAgICAgJ01p c3Npbmcgc3BhY2VzIGFyb3VuZCA6JykK 218747 2013-12-09 03:44:45 -0800 2013-12-09 10:54:53 -0800 Patch bug-125443-20131209124443.patch text/plain 2230 lvidacs.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMzA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODc0ZTk5MjU4ZDBmYTNmYTQxNGI1MTNmNGIyMzdhMzM1 YWE3ZTUwYi4uM2E4YmQyZTEyNWUyOTY4M2FhZjE3NWZhNTNhNGZhMTYyYzFhMmM2MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTEyLTA5ICBMYXN6bG8gVmlkYWNzICA8bGFjQGluZi51LXN6ZWdlZC5odT4KKwor ICAgICAgICBjaGVjay13ZWJraXQtc3R5bGU6IHRlcm5hcnkgb3BlcmF0b3IgaW4gbWFjcm8gY2Fs bCBpZGVudGlmaWVkIGFzIGluaXRpYWxpemF0aW9uIGxpc3QKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTQ0MworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvIG5vdCBtYXRjaCBpbml0aWFsaXphdGlvbiBs aXN0IHdoZW4gcXVlc3Rpb25tYXJrIGlzIHBsYWNlZCBiZWZvcmUgOgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIChjaGVja19tZW1i ZXJfaW5pdGlhbGl6YXRpb25fbGlzdCk6CisKIDIwMTMtMTItMDggIFNhbSBXZWluaWcgIDxzYW1A d2Via2l0Lm9yZz4KIAogICAgICAgICAzMi1iaXQgTWluaUJyb3dzZXIgZG9lc24ndCBidWlsZApk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCA1NzA1 MjgyMDdkNTc4YzVhNmFhYzIwNDZjM2Q4NjYzOWFjZjI3NGIzLi5iNTBlMGQxYmI2MzkwYTExMTA1 MWFiY2FkYTJlZjRjMzllZjI2NmQ5IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcC5weQpAQCAtMTk4Nyw3ICsxOTg3LDcgQEAgZGVmIGNoZWNrX21lbWJlcl9p bml0aWFsaXphdGlvbl9saXN0KGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZXJyb3IpOgogICAg ICMgd2l0aCB0aGUgY29sb24gb3IgY29tbWEgcHJlY2VkaW5nIHRoZSBtZW1iZXIgb24gdGhhdCBs aW5lLgogICAgIGJlZ2luX2xpbmUgPSBsaW5lCiAgICAgIyBtYXRjaCB0aGUgc3RhcnQgb2YgaW5p dGlhbGl6YXRpb24gbGlzdAotICAgIGlmIHNlYXJjaChyJ14oP1A8aW5kZW50YXRpb24+XHMqKSgo ZXhwbGljaXRccyspP1teXHNdK1woLipcKVxzP1w6fF5ccypcOikuKlteO10qJCcsIGxpbmUpOgor ICAgIGlmIHNlYXJjaChyJ14oP1A8aW5kZW50YXRpb24+XHMqKSgoZXhwbGljaXRccyspP1teKFxz fFw/KV0rXChbXlw/XSpcKVxzP1w6fF4oXHN8XD8pKlw6KS4qW147XSokJywgbGluZSk6CiAgICAg ICAgIGlmIHNlYXJjaChyJ1teOl1cOlteXDpcc10rJywgbGluZSk6CiAgICAgICAgICAgICBlcnJv cihsaW5lX251bWJlciwgJ3doaXRlc3BhY2UvaW5pdCcsIDQsCiAgICAgICAgICAgICAgICAgJ01p c3Npbmcgc3BhY2VzIGFyb3VuZCA6JykKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggODJjNmFjMjZjNThhYjFiZGJl ZTM2OGYzYzViMjY0NzMyODJmYTA4Ni4uYjgxOTk4M2U3YjYxMDA3NDg0NzdkMjJmOThmODg3MGEy MDQ5YTgwOSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy cy9jcHBfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVj a2Vycy9jcHBfdW5pdHRlc3QucHkKQEAgLTQ5NzMsNiArNDk3Myw3IEBAIGNsYXNzIFdlYktpdFN0 eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgfTsnJycsCiAgICAgICAgICcnKQog ICAgICAgICBzZWxmLmFzc2VydF9saW50KCdvID0gZm9vKGIgPyBiYXIoKSA6IGJheigpKTsnLCAn JykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnTVlNQUNSTyhhID8gYigpIDogYyk7JywgJycp CiAKICAgICBkZWYgdGVzdF9vdGhlcihzZWxmKToKICAgICAgICAgIyBGSVhNRTogSW1wbGVtZW50 IHRoaXMuCg==