125441 2013-12-09 01:27:24 -0800 [GTK] Avoid double quotations when passing parameters to valgrind in gtk.py 2013-12-11 11:00:28 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 116317 1 alex alex commit-queue glenn mrobinson oldest_to_newest 957793 0 alex 2013-12-09 01:27:24 -0800 It is causing issues in the my environment when building the xml file output. 957798 1 218738 alex 2013-12-09 01:34:02 -0800 Created attachment 218738 Patch 957803 2 218738 mrobinson 2013-12-09 01:50:07 -0800 Comment on attachment 218738 Patch Hrm...what is the issue with escaping? 957809 3 alex 2013-12-09 02:01:07 -0800 (In reply to comment #2) > (From update of attachment 218738 [details]) > Hrm...what is the issue with escaping? It is building the pathname incorrectly, replacing using some pathname, and as the next line shows it is not required. I'm also interested on knowing what python is actually doing :). 958751 4 alex 2013-12-11 09:02:50 -0800 So, apparently it is a bug in some versions of valgrind, just checked if you run this it fails: VALGRIND_OPTS='--xml-file="/tmp/errors.xml"' valgrind /bin/ps valgrind: can't create XML file '/tmp/"/tmp/errors.xml"': No such file or directory My version is 3.8.1 in fedora 18. Considering we do not need the double quotes because we define the file name, it is safe to remove them and we can forget about this bug. I'll modify the information about the problem and upload the patch. 958753 5 218971 alex 2013-12-11 09:12:04 -0800 Created attachment 218971 Patch 958798 6 218971 commit-queue 2013-12-11 11:00:25 -0800 Comment on attachment 218971 Patch Clearing flags on attachment: 218971 Committed r160448: <http://trac.webkit.org/changeset/160448> 958799 7 commit-queue 2013-12-11 11:00:28 -0800 All reviewed patches have been landed. Closing bug. 218738 2013-12-09 01:34:02 -0800 2013-12-11 09:11:57 -0800 Patch bug-125441-20131209103400.patch text/plain 1353 alex U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMjgzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWUwNjk1Y2ZkZDMxMGExNjhlMTcxYTdkOGFlYjJiMDlm MTgxZDIyMC4uYmUxMTdkNTZjNTc0ZmQ5MWExNWE0NWU4ZDIwOWIxN2NjNWQwNGVjNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTEyLTA5ICBBbGVqYW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgor CisgICAgICAgIFtHVEtdIEF2b2lkIGVzY2FwZWQgc3RyaW5nIHdoZW4gcGFzc2luZyBwYXJhbWV0 ZXJzIHRvIHZhbGdyaW5kIGluIGd0ay5weQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTI1NDQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgSnVzdCBhdm9pZCBlc2NhcGluZyB0aGUgc3RyaW5nIHdoZW4gYnVp bGRpbmcgdGhlIHBhcmFtZXRlci4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9n dGsucHk6CisgICAgICAgIChHdGtQb3J0LnNldHVwX2Vudmlyb25fZm9yX3NlcnZlcik6CisKIDIw MTMtMTItMDcgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbQ29jb2Fd IENvbnZlcnQgYSBmZXcgbW9yZSBwYXJ0cyBvZiBNaW5pQnJvd3NlciBvdmVyIHRvIHRoZSBPYmpl Y3RpdmUtQyBBUEkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9ndGsu cHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZ3RrLnB5CmluZGV4IGZlZmUzYjQxNzQw MjdmODY2NTU3ZGI0MjRkYmIxZGVjM2NjMWYxNzkuLjJiOGUyNzgwZGZlYjgyMzE3OWQzYjZkMmRl OWQ2OTAwMjkxYzU2OWMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9n dGsucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2d0ay5weQpAQCAtMTE0LDcg KzExNCw3IEBAIGNsYXNzIEd0a1BvcnQoUG9ydCk6CiAgICAgICAgICAgICAgICAgIi0tdW5kZWYt dmFsdWUtZXJyb3JzPW5vICIgXAogICAgICAgICAgICAgICAgICItLWdlbi1zdXBwcmVzc2lvbnM9 YWxsICIgXAogICAgICAgICAgICAgICAgICItLXhtbD15ZXMgIiBcCi0gICAgICAgICAgICAgICAg Ii0teG1sLWZpbGU9XCIlc1wiICIgXAorICAgICAgICAgICAgICAgICItLXhtbC1maWxlPSVzICIg XAogICAgICAgICAgICAgICAgICItLXN1cHByZXNzaW9ucz0lcyIgJSAoeG1sZmlsZSwgc3VwcHJl c3Npb25zZmlsZSkKICAgICAgICAgcmV0dXJuIGVudmlyb25tZW50CiAK 218971 2013-12-11 09:12:04 -0800 2013-12-11 11:00:25 -0800 Patch bug-125441-20131211181202.patch text/plain 1425 alex U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwNDM3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTAzMzRlMjVjMGEyNGNlNGQ3NDYyYjVhMjE5OTQ4MDE2 MDA0NGE1YS4uYTljNDZiNjI0NDk0OGM1ODVjYWQ2NmM0NTAxOGRkNDlmYWE3NDE4YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEzLTEyLTExICBBbGVqYW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgor CisgICAgICAgIFtHVEtdIEF2b2lkIGRvdWJsZSBxdW90YXRpb25zIHdoZW4gcGFzc2luZyBwYXJh bWV0ZXJzIHRvIHZhbGdyaW5kIGluIGd0ay5weQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1NDQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGlu IFJvYmluc29uLgorCisgICAgICAgIEp1c3QgYXZvaWQgdGhlIGRvdWJsZSBxdW90YXRpb25zIHdo ZW4gYnVpbGRpbmcgdGhlIHBhcmFtZXRlcgorICAgICAgICBiZWNhdXNlIHNvbWUgdmVyc2lvbnMg b2YgdmFsZ3JpbmQgYXJlIG5vdCBoYW5kbGluZyBpdCBjb3JyZWN0bHkuCisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L3BvcnQvZ3RrLnB5OgorICAgICAgICAoR3RrUG9ydC5zZXR1cF9lbnZp cm9uX2Zvcl9zZXJ2ZXIpOgorCiAyMDEzLTEyLTExICBCcmVuZGFuIExvbmcgIDxiLmxvbmdAY2Fi bGVsYWJzLmNvbT4KIAogICAgICAgICBbR1RLXSBBZGQgImVuYWJsZS1tZWRpYXNvdXJjZSIgcHJv cGVydHkgdG8gV2ViS2l0V2ViU2V0dGluZ3MKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvcG9ydC9ndGsucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZ3RrLnB5Cmlu ZGV4IGZlZmUzYjQxNzQwMjdmODY2NTU3ZGI0MjRkYmIxZGVjM2NjMWYxNzkuLjJiOGUyNzgwZGZl YjgyMzE3OWQzYjZkMmRlOWQ2OTAwMjkxYzU2OWMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvcG9ydC9ndGsucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2d0 ay5weQpAQCAtMTE0LDcgKzExNCw3IEBAIGNsYXNzIEd0a1BvcnQoUG9ydCk6CiAgICAgICAgICAg ICAgICAgIi0tdW5kZWYtdmFsdWUtZXJyb3JzPW5vICIgXAogICAgICAgICAgICAgICAgICItLWdl bi1zdXBwcmVzc2lvbnM9YWxsICIgXAogICAgICAgICAgICAgICAgICItLXhtbD15ZXMgIiBcCi0g ICAgICAgICAgICAgICAgIi0teG1sLWZpbGU9XCIlc1wiICIgXAorICAgICAgICAgICAgICAgICIt LXhtbC1maWxlPSVzICIgXAogICAgICAgICAgICAgICAgICItLXN1cHByZXNzaW9ucz0lcyIgJSAo eG1sZmlsZSwgc3VwcHJlc3Npb25zZmlsZSkKICAgICAgICAgcmV0dXJuIGVudmlyb25tZW50CiAK