125436 2013-12-08 20:38:59 -0800 [GTK] run-webkit-tests may DOS the system, specially in debug builds 2014-01-02 05:32:04 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gustavo gustavo cgarcia commit-queue zan oldest_to_newest 957751 0 gustavo 2013-12-08 20:38:59 -0800 [GTK] run-webkit-tests may DOS the system, specially in debug builds 957790 1 218735 gustavo 2013-12-09 01:18:22 -0800 Created attachment 218735 Patch for landing 957806 2 218735 commit-queue 2013-12-09 01:52:50 -0800 Comment on attachment 218735 Patch for landing Clearing flags on attachment: 218735 Committed r160304: <http://trac.webkit.org/changeset/160304> 957807 3 commit-queue 2013-12-09 01:52:52 -0800 All reviewed patches have been landed. Closing bug. 963203 4 cgarcia 2013-12-29 06:52:06 -0800 This has caused other problems unfortunately. The other day I noticed that my ephy was using the webkit library in my source tree and I hadn't run make install. I've been investigating the problem and I've noticed that my source tree is hardcoded in the rpath of the web process and plugin process executables installed in my jhbuild: $ objdump -p /home/cgarcia/gnome/libexec/WebKitWebProcess | grep RPATH RPATH /home/cgarcia/src/git/gnome/WebKit/WebKitBuild/Release/.libs:/home/cgarcia/gnome/lib64 That explains why the non installed build sources are used by my ephy instead of the installed ones. The problem is that when using --no-fast-install, the binaries are not relinked when installed. I've tried using --disable-fast-install configure option, but then it fails when trying to relink binaries not using the --no-fast-install option. For now I've reverted this patch locally, but maybe we can use --no-fast-install for all binaries that are going to be installed and use --disable-fast-install configure option unconditionally. Or maybe there's a way to tell libtool to not do fast-install for binaries linked with --no-fast-install ld flag. I've tried manually adding fast_install=no to the WebKitWebProcess librool wrapper script and it worked, correctly relinking the command before installing it, but I don't know if that can be done automatically somehow. Btw, the no-fast-install ld flag was already removed by Gustavo in r116205. 963214 5 gustavo 2013-12-29 09:25:18 -0800 Maybe we can remove the rpath instead? It's what Debian does for all binaries. 963286 6 cgarcia 2013-12-29 23:28:36 -0800 (In reply to comment #5) > Maybe we can remove the rpath instead? It's what Debian does for all binaries. If that's enough and you don't need to relink. How can we do that while installing? 963713 7 cgarcia 2014-01-02 02:36:24 -0800 I've tried by disabling fast install globally and the build is a lot slower :-( 963730 8 cgarcia 2014-01-02 04:35:02 -0800 (In reply to comment #7) > I've tried by disabling fast install globally and the build is a lot slower :-( Was doing it wrongly, using LT_INIT, added AC_DISABLE_FAST_INSTALL to Source/autotools/SetupLibtool.m4 and it doesn't affect to the build times, as expected. 963737 9 cgarcia 2014-01-02 05:32:04 -0800 See https://bugs.webkit.org/show_bug.cgi?id=126381 218735 2013-12-09 01:18:22 -0800 2013-12-09 01:52:50 -0800 Patch for landing bug-125436-20131209101820.patch text/plain 1513 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjFmNGJmOGE1YmUzOGEw ZmEyYTBlOGIyMDE0NmVmMmFjYzkyYmYzOC4uNTJhODQzYjNiZDAxNDlhMjQ4MjE2MTEzYzFkN2U5 Y2Y1MDRiNGYxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTEyLTA4ICBHdXN0 YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgorCisgICAgICAgIFtHVEtdIHJ1bi13 ZWJraXQtdGVzdHMgbWF5IERPUyB0aGUgc3lzdGVtLCBzcGVjaWFsbHkgaW4gZGVidWcgYnVpbGRz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjU0MzYK KworICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCisKKyAgICAgICAgKiBHTlVt YWtlZmlsZS5hbTogdXNlIC1uby1mYXN0LWluc3RhbGwgZm9yIFdlYktpdFdlYlByb2Nlc3MgYW5k IFdlYktpdFBsdWdpblByb2Nlc3Mgc28KKyAgICAgICAgdGhleSBkbyBub3QgbmVlZCB0byBiZSBy ZWxpbmtlZCB0aGUgZmlyc3QgdGltZSB0aGV5IGFyZSBleGVjdXRlZCBpbi10cmVlLgorCiAyMDEz LTEyLTA4ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBb RUZMXVtXSzJdIE1vdmUgRnVsbFNjcmVlbk1hbmFnZXIgbG9naWMgdG8gV2ViVmlld0VmbApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvR05VbWFrZWZpbGUuYW0gYi9Tb3VyY2UvV2ViS2l0Mi9H TlVtYWtlZmlsZS5hbQppbmRleCA5MzFjODg3YWQ4YzY1YzE3ZDUxYzkyNjI2N2QzOGU2YWFmMjg1 NjVhLi5jMzdkZTg4NmRkNTJkYjIwZTk2MDQ1OTE4MjdiOTJmZDVmMTMzOTI2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9HTlVtYWtlZmlsZS5hbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9HTlVt YWtlZmlsZS5hbQpAQCAtNDk5LDYgKzQ5OSw5IEBAIFByb2dyYW1zX1dlYktpdFdlYlByb2Nlc3Nf TERBREQgPSBcCiAJJChHVEtfVU5JWF9QUklOVElOR19MSUJTKSBcCiAJJChMSUJTT1VQX0xJQlMp CiAKK1Byb2dyYW1zX1dlYktpdFdlYlByb2Nlc3NfTERGTEFHUyA9IFwKKwktbm8tZmFzdC1pbnN0 YWxsCisKIGxpYldlYkNvcmVHdGsyX2xhX1NPVVJDRVMgPSBcCiAJJCh3ZWJjb3JlZ3RrX3NvdXJj ZXMpCiAKQEAgLTcxNiw2ICs3MTksOSBAQCBQcm9ncmFtc19XZWJLaXRQbHVnaW5Qcm9jZXNzX0xE QUREID0gXAogCSQoV0lOTU1fTElCUykgXAogCSQoWkxJQl9MSUJTKQogCitQcm9ncmFtc19XZWJL aXRQbHVnaW5Qcm9jZXNzX0xERkxBR1MgPSBcCisJLW5vLWZhc3QtaW5zdGFsbAorCiBQcm9ncmFt c19XZWJLaXRQbHVnaW5Qcm9jZXNzX0NYWEZMQUdTID0gXAogCS1mdmlzaWJpbGl0eS1pbmxpbmVz LWhpZGRlbiBcCiAJJChnbG9iYWxfY3h4ZmxhZ3MpCg==