125422 2013-12-08 11:16:38 -0800 [WK2] Implement platform specific Resource Response for SOUP 2014-12-03 07:58:15 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108832 126128 1 brian.holt brian.holt ap beidson cgarcia commit-queue darin gustavo mrobinson ossy svillar oldest_to_newest 957670 0 brian.holt 2013-12-08 11:16:38 -0800 When building the Network Process for non-Mac ports there are a few places where mac specific code is used without a guard causing compile failures. 957673 1 218700 brian.holt 2013-12-08 11:24:30 -0800 Created attachment 218700 Patch 957682 2 218700 mrobinson 2013-12-08 11:44:10 -0800 Comment on attachment 218700 Patch This looks good to me, but I'll let a Mac reviewer chip in before we land this. It's possible that we will need GTK+ specific implementations of these sections eventually, but we are working on getting the NetworkProcess building so that we can proceed with that. 957835 3 218700 ossy 2013-12-09 03:36:04 -0800 Comment on attachment 218700 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218700&action=review > Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:249 > +#if PLATFORM(MAC) > m_suggestedRequestForWillSendRequest.updateFromDelegatePreservingOldHTTPBody(newRequest.nsURLRequest(DoNotUpdateHTTPBody)); > +#endif There is a bug report for it: https://bugs.webkit.org/show_bug.cgi?id=121430 But Darin mentioned we should explain why Mac needs is and why we don't. > Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp:111 > +#if PLATFORM(MAC) > responseCopy.setCertificateChain(certificateInfo.certificateChain()); > +#endif We won't need this once https://bugs.webkit.org/show_bug.cgi?id=124724 is fixed. 957855 4 brian.holt 2013-12-09 04:42:43 -0800 (In reply to comment #3) > (From update of attachment 218700 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=218700&action=review > There is a bug report for it: https://bugs.webkit.org/show_bug.cgi?id=121430 > But Darin mentioned we should explain why Mac needs is and why we don't. > I found that bug after I proposed this patch and I've commented on it. We should definitely find out why we don't need it, but this is blocking us using the netwok process while we try to find out. > > Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp:111 > > +#if PLATFORM(MAC) > > responseCopy.setCertificateChain(certificateInfo.certificateChain()); > > +#endif > > We won't need this once https://bugs.webkit.org/show_bug.cgi?id=124724 is fixed. Yes, it will become obsolete when that patch lands, but we need it now so that the network process compiles. 957872 5 svillar 2013-12-09 06:32:27 -0800 Reverting the cq+. Haven't read Martin's comment #2 957940 6 218700 beidson 2013-12-09 09:50:13 -0800 Comment on attachment 218700 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218700&action=review >> Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:249 >> +#endif > > There is a bug report for it: https://bugs.webkit.org/show_bug.cgi?id=121430 > But Darin mentioned we should explain why Mac needs is and why we don't. Please explain why here. >>> Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp:111 >>> +#endif >> >> We won't need this once https://bugs.webkit.org/show_bug.cgi?id=124724 is fixed. > > Yes, it will become obsolete when that patch lands, but we need it now so that the network process compiles. Please include a FIXME here referencing the bug that makes it obsolete. 958260 7 218700 brian.holt 2013-12-10 03:04:46 -0800 Comment on attachment 218700 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218700&action=review >>> Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:249 >>> +#endif >> >> There is a bug report for it: https://bugs.webkit.org/show_bug.cgi?id=121430 >> But Darin mentioned we should explain why Mac needs is and why we don't. > > Please explain why here. As Martin expected, we do need a SOUP specific implementation here. The candidate line of code will be m_suggestedRequestForWillSendRequest.updateFromDelegatePreservingOldHTTPBody(newRequest); which differs from the Mac implementation because the Mac version of updateFromDelegatePreservingOldHTTPBody() accepts a NSURLRequest* which is a CF class and doesn't exist in the SOUP world. The policy DoNotUpdateHTTPBody is therefore specific to the NSURLRequest, and is implied for SOUP in the name of the function called: updateFromDelegatePreservingOldHTTPBody(). I will submit a new patch shortly. >>>> Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp:111 >>>> +#endif >>> >>> We won't need this once https://bugs.webkit.org/show_bug.cgi?id=124724 is fixed. >> >> Yes, it will become obsolete when that patch lands, but we need it now so that the network process compiles. > > Please include a FIXME here referencing the bug that makes it obsolete. I will submit the SOUP specific implementation shortly. 958261 8 218848 brian.holt 2013-12-10 03:12:41 -0800 Created attachment 218848 Patch 958290 9 brian.holt 2013-12-10 04:40:42 -0800 Alexey made a good point in https://bugs.webkit.org/show_bug.cgi?id=121430#c7 that no ports should send the httpBody over IPC. So all we need to do is to demonstrate that for soup we don't update the http body. The only place that the http body is set for soup is in ResourceRequest::updateFromSoupMessage(). updateFromDelegatePreservingOldHTTPBody() simply sets *this for the RequestRequest to the delegatedResourceRequest which doesn't call updateFromSoupMessage(). So if the http body was empty it stays empty and will remain out of sync. Martin will test the code to confirm that this is indeed the case. 961539 10 mrobinson 2013-12-19 14:13:34 -0800 (In reply to comment #9) > Martin will test the code to confirm that this is indeed the case. I have not been able to confirm this directly, since the NetworkProcess isn't working correctly me for me at the moment. From looking at the code though, it seems that the Soup version of ResourceHandle does not use the typical updatePlatformRequest and updateResourceRequest path. This is a design problem for sure, but it also means it's unlikely that we're copying the body into the other request. 961788 11 cgarcia 2013-12-20 01:37:04 -0800 (In reply to comment #10) > (In reply to comment #9) > > > Martin will test the code to confirm that this is indeed the case. > > I have not been able to confirm this directly, since the NetworkProcess isn't working correctly me for me at the moment. From looking at the code though, it seems that the Soup version of ResourceHandle does not use the typical updatePlatformRequest and updateResourceRequest path. This is a design problem for sure, but it also means it's unlikely that we're copying the body into the other request. I've checked we are never sending the http body over IPC, at least in the tests I've done. I think we can land this patch in any case, to allow at least build with the network process, to make it easier for everybody to continue working on this and all other network process related issues. 962299 12 219866 cgarcia 2013-12-22 01:44:41 -0800 Created attachment 219866 Patch for landing Updated patch to include FIXMES and bug urls. This is blocking our work in the network process, because it doesn't build without it. 962417 13 219866 commit-queue 2013-12-23 00:37:43 -0800 Comment on attachment 219866 Patch for landing Clearing flags on attachment: 219866 Committed r160988: <http://trac.webkit.org/changeset/160988> 962418 14 commit-queue 2013-12-23 00:37:47 -0800 All reviewed patches have been landed. Closing bug. 1052159 15 ossy 2014-12-03 07:58:15 -0800 *** Bug 121430 has been marked as a duplicate of this bug. *** 218700 2013-12-08 11:24:30 -0800 2013-12-10 03:12:34 -0800 Patch bug-125422-20131208202428.patch text/plain 2684 brian.holt U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMjkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTYxNzU3NjYxNmUzMzlh NTA0NGU1ZjRjNjUzZjAwODgzZTJhNTVmOC4uMWQzYTBhYTRkZWIxZWQ0ZTljNzIwYTNmODliMDZi YmY0MDExZThlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTEyLTA4ICBCcmlh biBIb2x0ICA8YnJpYW4uaG9sdEBzYW1zdW5nLmNvbT4KKworICAgICAgICBbV0syXSBHdWFyZCBN YWMgc3BlY2lmaWMgbmV0d29yayBwcm9jZXNzIGNvZGUgd2l0aCBQTEFURk9STShNQUMpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjU0MjIKKworICAg ICAgICBNYWMgc3BlY2lmaWMgY29kZSBzaG91bGQgYmUgZ3VhcmRlZCB0byBwcmV2ZW50IGNvbXBp bGUgZmFpbHVyZXMgb24gb3RoZXIgcGxhdGZvcm1zLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNl TG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya1Jlc291cmNlTG9hZGVyOjpjb250 aW51ZVdpbGxTZW5kUmVxdWVzdCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJl c291cmNlTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUmVzb3VyY2VMb2FkZXI6OmRp ZFJlY2VpdmVSZXNwb25zZVdpdGhDZXJ0aWZpY2F0ZUluZm8pOgorCiAyMDEzLTEyLTA3ICBTYW0g V2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0NvY29hXSBSZW1vdmUgd2ViUHJv Y2Vzc1BsdWdJbkluaXRpYWxpemU6IGZyb20gdGhlIFdLV2ViUHJvY2Vzc1BsdWdJbiBwcm90b2Nv bApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291 cmNlTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNv dXJjZUxvYWRlci5jcHAKaW5kZXggNDMyZWM3NmNmM2FlZjljZjNmN2I4ODM2MTA5ZjQ2NmZmYmQx YzJkNy4uNjdiYzAwMDcyYWE1ZjlhOTJiZDFlZmY5MjI5NGI5ZTAxMDlmZGEwMiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2Fk ZXIuY3BwCkBAIC0yNDQsNyArMjQ0LDkgQEAgdm9pZCBOZXR3b3JrUmVzb3VyY2VMb2FkZXI6Ondp bGxTZW5kUmVxdWVzdEFzeW5jKFJlc291cmNlSGFuZGxlKiBoYW5kbGUsIGNvbnN0IFIKIAogdm9p ZCBOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OmNvbnRpbnVlV2lsbFNlbmRSZXF1ZXN0KGNvbnN0IFJl c291cmNlUmVxdWVzdCYgbmV3UmVxdWVzdCkKIHsKKyNpZiBQTEFURk9STShNQUMpCiAgICAgbV9z dWdnZXN0ZWRSZXF1ZXN0Rm9yV2lsbFNlbmRSZXF1ZXN0LnVwZGF0ZUZyb21EZWxlZ2F0ZVByZXNl cnZpbmdPbGRIVFRQQm9keShuZXdSZXF1ZXN0Lm5zVVJMUmVxdWVzdChEb05vdFVwZGF0ZUhUVFBC b2R5KSk7CisjZW5kaWYKIAogICAgIFJ1bkxvb3A6Om1haW4oKS0+ZGlzcGF0Y2goYmluZCgmTmV0 d29ya1Jlc291cmNlTG9hZFNjaGVkdWxlcjo6cmVjZWl2ZWRSZWRpcmVjdCwgJk5ldHdvcmtQcm9j ZXNzOjpzaGFyZWQoKS5uZXR3b3JrUmVzb3VyY2VMb2FkU2NoZWR1bGVyKCksIHRoaXMsIG1fc3Vn Z2VzdGVkUmVxdWVzdEZvcldpbGxTZW5kUmVxdWVzdC51cmwoKSkpOwogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkZXIuY3BwIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJlc291cmNlTG9hZGVyLmNwcApp bmRleCBhNWI4NDQ5YzQ3NzA2ZGNkNTU4NjQyNWQ1MDNjZDE3YjBmNGUzZGQ5Li4yNTA3ZDYzNDFk NGZiZWMwMDFiYmNjYjcyOTVjZmZjNjkwYmJjN2ViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvTmV0d29yay9XZWJSZXNvdXJjZUxvYWRlci5jcHAKQEAgLTEwNiw3 ICsxMDYsOSBAQCB2b2lkIFdlYlJlc291cmNlTG9hZGVyOjpkaWRSZWNlaXZlUmVzcG9uc2VXaXRo Q2VydGlmaWNhdGVJbmZvKGNvbnN0IFJlc291cmNlUmVzcAogICAgIFJlZjxXZWJSZXNvdXJjZUxv YWRlcj4gcHJvdGVjdCgqdGhpcyk7CiAKICAgICBSZXNvdXJjZVJlc3BvbnNlIHJlc3BvbnNlQ29w eShyZXNwb25zZSk7CisjaWYgUExBVEZPUk0oTUFDKQogICAgIHJlc3BvbnNlQ29weS5zZXRDZXJ0 aWZpY2F0ZUNoYWluKGNlcnRpZmljYXRlSW5mby5jZXJ0aWZpY2F0ZUNoYWluKCkpOworI2VuZGlm CiAgICAgbV9jb3JlTG9hZGVyLT5kaWRSZWNlaXZlUmVzcG9uc2UocmVzcG9uc2VDb3B5KTsKIAog ICAgIC8vIElmIG1fY29yZUxvYWRlciBiZWNvbWVzIG51bGwgYXMgYSByZXN1bHQgb2YgdGhlIGRp ZFJlY2VpdmVSZXNwb25zZSBjYWxsYmFjaywgd2UgY2FuJ3QgdXNlIHRoZSBzZW5kIGZ1bmN0aW9u KCkuIAo= 218848 2013-12-10 03:12:41 -0800 2013-12-22 01:44:41 -0800 Patch bug-125422-20131210121239.patch text/plain 2939 brian.holt U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMzQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjQ4MWViNDdjZjFiOWE5 YzdlMjc2OWE3YjQ1ZTRiMmM2OWEwZmFjOC4uZDk2ZjJlYWQyNDFiN2RiMGM2MzhjNTY4NTBmMjQ5 NWIwMTUwNDkyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTEyLTEwICBCcmlh biBIb2x0ICA8YnJpYW4uaG9sdEBzYW1zdW5nLmNvbT4KKworICAgICAgICBbV0syXSBJbXBsZW1l bnQgcGxhdGZvcm0gc3BlY2lmaWMgUmVzb3VyY2UgUmVzcG9uc2UgZm9yIFNPVVAKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTQyMgorCisgICAgICAg IFNPVVAgc3BlY2lmaWMgUmVzb3VyY2UgUmVzcG9uc2UgaW1wbGVtZW50YXRpb24gZm9yIHRoZSBO ZXR3b3JrIFByb2Nlc3MuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgor CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6TmV0d29ya1Jlc291cmNlTG9hZGVyOjpjb250aW51ZVdpbGxTZW5kUmVx dWVzdCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJlc291cmNlTG9hZGVyLmNw cDoKKyAgICAgICAgKFdlYktpdDo6V2ViUmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVSZXNwb25z ZVdpdGhDZXJ0aWZpY2F0ZUluZm8pOgorCiAyMDEzLTEyLTA5ICBBbmRlcnMgQ2FybHNzb24gIDxh bmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgQmVnaW4gd29ya2luZyBvbiBhIFVzZXJEYXRh IGNsYXNzIGludGVuZGVkIHRvIHJlcGxhY2UgVXNlck1lc3NhZ2VDb2RlcnMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3Bw CmluZGV4IDQzMmVjNzZjZjNhZWY5Y2YzZjdiODgzNjEwOWY0NjZmZmJkMWMyZDcuLmI0OWMyMDZi MWYxZTk3MDdlMjIwMjIxOTQxYzZhMGY0NTI0Y2M1YWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcApAQCAtMjQ0 LDcgKzI0NCwxMSBAQCB2b2lkIE5ldHdvcmtSZXNvdXJjZUxvYWRlcjo6d2lsbFNlbmRSZXF1ZXN0 QXN5bmMoUmVzb3VyY2VIYW5kbGUqIGhhbmRsZSwgY29uc3QgUgogCiB2b2lkIE5ldHdvcmtSZXNv dXJjZUxvYWRlcjo6Y29udGludWVXaWxsU2VuZFJlcXVlc3QoY29uc3QgUmVzb3VyY2VSZXF1ZXN0 JiBuZXdSZXF1ZXN0KQogeworI2lmIFBMQVRGT1JNKE1BQykKICAgICBtX3N1Z2dlc3RlZFJlcXVl c3RGb3JXaWxsU2VuZFJlcXVlc3QudXBkYXRlRnJvbURlbGVnYXRlUHJlc2VydmluZ09sZEhUVFBC b2R5KG5ld1JlcXVlc3QubnNVUkxSZXF1ZXN0KERvTm90VXBkYXRlSFRUUEJvZHkpKTsKKyNlbHNl CisgICAgbV9zdWdnZXN0ZWRSZXF1ZXN0Rm9yV2lsbFNlbmRSZXF1ZXN0LnVwZGF0ZUZyb21EZWxl Z2F0ZVByZXNlcnZpbmdPbGRIVFRQQm9keShuZXdSZXF1ZXN0KTsKKyNlbmRpZgogCiAgICAgUnVu TG9vcDo6bWFpbigpLT5kaXNwYXRjaChiaW5kKCZOZXR3b3JrUmVzb3VyY2VMb2FkU2NoZWR1bGVy OjpyZWNlaXZlZFJlZGlyZWN0LCAmTmV0d29ya1Byb2Nlc3M6OnNoYXJlZCgpLm5ldHdvcmtSZXNv dXJjZUxvYWRTY2hlZHVsZXIoKSwgdGhpcywgbV9zdWdnZXN0ZWRSZXF1ZXN0Rm9yV2lsbFNlbmRS ZXF1ZXN0LnVybCgpKSk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv TmV0d29yay9XZWJSZXNvdXJjZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkZXIuY3BwCmluZGV4IGE1Yjg0NDljNDc3MDZkY2Q1NTg2 NDI1ZDUwM2NkMTdiMGY0ZTNkZDkuLmVkN2JiNTllZTMxYzVjM2U1NjBhYWEzNWVhYjliNjYxM2Y1 Nzc2MTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTmV0d29yay9XZWJS ZXNvdXJjZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9OZXR3b3Jr L1dlYlJlc291cmNlTG9hZGVyLmNwcApAQCAtMTA2LDcgKzEwNiwxMiBAQCB2b2lkIFdlYlJlc291 cmNlTG9hZGVyOjpkaWRSZWNlaXZlUmVzcG9uc2VXaXRoQ2VydGlmaWNhdGVJbmZvKGNvbnN0IFJl c291cmNlUmVzcAogICAgIFJlZjxXZWJSZXNvdXJjZUxvYWRlcj4gcHJvdGVjdCgqdGhpcyk7CiAK ICAgICBSZXNvdXJjZVJlc3BvbnNlIHJlc3BvbnNlQ29weShyZXNwb25zZSk7CisjaWYgUExBVEZP Uk0oTUFDKQogICAgIHJlc3BvbnNlQ29weS5zZXRDZXJ0aWZpY2F0ZUNoYWluKGNlcnRpZmljYXRl SW5mby5jZXJ0aWZpY2F0ZUNoYWluKCkpOworI2VsaWYgVVNFKFNPVVApCisgICAgcmVzcG9uc2VD b3B5LnNldFNvdXBNZXNzYWdlQ2VydGlmaWNhdGUoY2VydGlmaWNhdGVJbmZvLmNlcnRpZmljYXRl KCkpOworICAgIHJlc3BvbnNlQ29weS5zZXRTb3VwTWVzc2FnZVRMU0Vycm9ycyhjZXJ0aWZpY2F0 ZUluZm8udGxzRXJyb3JzKCkpOworI2VuZGlmCiAgICAgbV9jb3JlTG9hZGVyLT5kaWRSZWNlaXZl UmVzcG9uc2UocmVzcG9uc2VDb3B5KTsKIAogICAgIC8vIElmIG1fY29yZUxvYWRlciBiZWNvbWVz IG51bGwgYXMgYSByZXN1bHQgb2YgdGhlIGRpZFJlY2VpdmVSZXNwb25zZSBjYWxsYmFjaywgd2Ug Y2FuJ3QgdXNlIHRoZSBzZW5kIGZ1bmN0aW9uKCkuIAo= 219866 2013-12-22 01:44:41 -0800 2013-12-23 00:37:43 -0800 Patch for landing wk2-soup-network-process.diff text/plain 2983 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxMmVjZDllLi4xNzE5NzU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMTItMTAgIEJyaWFuIEhvbHQgIDxicmlhbi5ob2x0QHNhbXN1bmcuY29tPgorCisg ICAgICAgIFtXSzJdIEltcGxlbWVudCBwbGF0Zm9ybSBzcGVjaWZpYyBSZXNvdXJjZSBSZXNwb25z ZSBmb3IgU09VUAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTI1NDIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgorCisgICAg ICAgIFNPVVAgc3BlY2lmaWMgUmVzb3VyY2UgUmVzcG9uc2UgaW1wbGVtZW50YXRpb24gZm9yIHRo ZSBOZXR3b3JrCisgICAgICAgIFByb2Nlc3MuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9O ZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUmVzb3Vy Y2VMb2FkZXI6OmNvbnRpbnVlV2lsbFNlbmRSZXF1ZXN0KToKKyAgICAgICAgKiBXZWJQcm9jZXNz L05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJSZXNv dXJjZUxvYWRlcjo6ZGlkUmVjZWl2ZVJlc3BvbnNlV2l0aENlcnRpZmljYXRlSW5mbyk6CisKIDIw MTMtMTItMjIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQuIEZpeCBHVEsrIGJ1aWxkIGFmdGVyIHIxNjA5NzEgYW5kIHIxNjA5 NjkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVz b3VyY2VMb2FkZXIuY3BwIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jl c291cmNlTG9hZGVyLmNwcAppbmRleCAyZjhhNDlmLi45NjM3OWI5IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5jcHAK QEAgLTI0Myw3ICsyNDMsMTIgQEAgdm9pZCBOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OndpbGxTZW5k UmVxdWVzdEFzeW5jKFJlc291cmNlSGFuZGxlKiBoYW5kbGUsIGNvbnN0IFIKIAogdm9pZCBOZXR3 b3JrUmVzb3VyY2VMb2FkZXI6OmNvbnRpbnVlV2lsbFNlbmRSZXF1ZXN0KGNvbnN0IFJlc291cmNl UmVxdWVzdCYgbmV3UmVxdWVzdCkKIHsKKyNpZiBQTEFURk9STShNQUMpCiAgICAgbV9zdWdnZXN0 ZWRSZXF1ZXN0Rm9yV2lsbFNlbmRSZXF1ZXN0LnVwZGF0ZUZyb21EZWxlZ2F0ZVByZXNlcnZpbmdP bGRIVFRQQm9keShuZXdSZXF1ZXN0Lm5zVVJMUmVxdWVzdChEb05vdFVwZGF0ZUhUVFBCb2R5KSk7 CisjZWxpZiBVU0UoU09VUCkKKyAgICAvLyBGSVhNRTogSW1wbGVtZW50IFJlc291cmNlUmVxdWVz dDo6dXBkYXRlRnJvbURlbGVnYXRlUHJlc2VydmluZ09sZEhUVFBCb2R5LiBTZWUgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjEyNy4KKyAgICBtX3N1Z2dlc3RlZFJl cXVlc3RGb3JXaWxsU2VuZFJlcXVlc3QudXBkYXRlRnJvbURlbGVnYXRlUHJlc2VydmluZ09sZEhU VFBCb2R5KG5ld1JlcXVlc3QpOworI2VuZGlmCiAKICAgICBSdW5Mb29wOjptYWluKCktPmRpc3Bh dGNoKGJpbmQoJk5ldHdvcmtSZXNvdXJjZUxvYWRTY2hlZHVsZXI6OnJlY2VpdmVkUmVkaXJlY3Qs ICZOZXR3b3JrUHJvY2Vzczo6c2hhcmVkKCkubmV0d29ya1Jlc291cmNlTG9hZFNjaGVkdWxlcigp LCB0aGlzLCBtX3N1Z2dlc3RlZFJlcXVlc3RGb3JXaWxsU2VuZFJlcXVlc3QudXJsKCkpKTsKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJlc291cmNl TG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTmV0d29yay9XZWJSZXNvdXJj ZUxvYWRlci5jcHAKaW5kZXggYzdmYjRkNy4uODQ1OTkzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJlc291cmNlTG9hZGVyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkZXIuY3BwCkBAIC0x MDYsNyArMTA2LDEzIEBAIHZvaWQgV2ViUmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVSZXNwb25z ZVdpdGhDZXJ0aWZpY2F0ZUluZm8oY29uc3QgUmVzb3VyY2VSZXNwCiAgICAgUmVmPFdlYlJlc291 cmNlTG9hZGVyPiBwcm90ZWN0KCp0aGlzKTsKIAogICAgIFJlc291cmNlUmVzcG9uc2UgcmVzcG9u c2VDb3B5KHJlc3BvbnNlKTsKKyAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgdXNlIENlcnRpZmlj YXRlSW5mbyB0byBhdm9pZCB0aGUgcGxhdGZvcm0gaWZkZWZzLiBTZWUgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDcyNC4KKyNpZiBQTEFURk9STShNQUMpCiAgICAg cmVzcG9uc2VDb3B5LnNldENlcnRpZmljYXRlQ2hhaW4oY2VydGlmaWNhdGVJbmZvLmNlcnRpZmlj YXRlQ2hhaW4oKSk7CisjZWxpZiBVU0UoU09VUCkKKyAgICByZXNwb25zZUNvcHkuc2V0U291cE1l c3NhZ2VDZXJ0aWZpY2F0ZShjZXJ0aWZpY2F0ZUluZm8uY2VydGlmaWNhdGUoKSk7CisgICAgcmVz cG9uc2VDb3B5LnNldFNvdXBNZXNzYWdlVExTRXJyb3JzKGNlcnRpZmljYXRlSW5mby50bHNFcnJv cnMoKSk7CisjZW5kaWYKICAgICBtX2NvcmVMb2FkZXItPmRpZFJlY2VpdmVSZXNwb25zZShyZXNw b25zZUNvcHkpOwogCiAgICAgLy8gSWYgbV9jb3JlTG9hZGVyIGJlY29tZXMgbnVsbCBhcyBhIHJl c3VsdCBvZiB0aGUgZGlkUmVjZWl2ZVJlc3BvbnNlIGNhbGxiYWNrLCB3ZSBjYW4ndCB1c2UgdGhl IHNlbmQgZnVuY3Rpb24oKS4gCg==