125420 2013-12-08 11:02:07 -0800 32-bit MiniBrowser doesn't build 2013-12-08 20:51:20 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser sam andersca mitz simon.fraser oldest_to_newest 957666 0 simon.fraser 2013-12-08 11:02:07 -0800 WK_API_ENABLED isn't defined for 32-bit, so the API-using MiniBrowser doesn't build. I guess we should just not build MiniBrowser for 32-bit? What if WTR wants to use WebKit2 API? 957667 1 simon.fraser 2013-12-08 11:02:27 -0800 Also, this is breaking the build: http://build.webkit.org/builders/Apple%20MountainLion%20Release%20%2832-bit%20Build%29 957752 2 218723 sam 2013-12-08 20:46:07 -0800 Created attachment 218723 Patch 957753 3 sam 2013-12-08 20:48:13 -0800 (In reply to comment #0) > WK_API_ENABLED isn't defined for 32-bit, so the API-using MiniBrowser doesn't build. > > I guess we should just not build MiniBrowser for 32-bit? I'm just going to fix the issue I introduced. But I am not sure there is value in building 32-bit. > What if WTR wants to use WebKit2 API? I don't think this is likely, at least anytime soon, since WTR is cross-platform. 957754 4 sam 2013-12-08 20:48:30 -0800 Committed r160298: <http://trac.webkit.org/changeset/160298> 957755 5 mitz 2013-12-08 20:51:20 -0800 (In reply to comment #0) > WK_API_ENABLED isn't defined for 32-bit, so the API-using MiniBrowser doesn't build. > > I guess we should just not build MiniBrowser for 32-bit? What if WTR wants to use WebKit2 API? WebKitTestRunner is cross-platform so it’s not expected to need the Cocoa API. In the future, if we retire the cross-platform C SPI, we might want to transition WebKitTestRunner to some C++ SPI. 218723 2013-12-08 20:46:07 -0800 2013-12-08 20:46:49 -0800 Patch bug-125420-20131208204607.patch text/plain 2085 sam SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2MDI5NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEzLTEyLTA4ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgMzItYml0IE1pbmlCcm93c2VyIGRvZXNuJ3QgYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTQyMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTWluaUJyb3dzZXIvbWFjL0FwcERlbGVn YXRlLmg6CisgICAgICAgICogTWluaUJyb3dzZXIvbWFjL0FwcERlbGVnYXRlLm06CisgICAgICAg ICgtW0Jyb3dzZXJBcHBEZWxlZ2F0ZSBpbml0XSk6CisgICAgICAgICgtW0Jyb3dzZXJBcHBEZWxl Z2F0ZSBhcHBsaWNhdGlvbldpbGxUZXJtaW5hdGU6XSk6CisKIDIwMTMtMTItMDggIEJyaWFuIEhv bHQgIDxicmlhbi5ob2x0QHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtXSzJdIEFkZCBFTkFCTEVf TkVUV09SS19QUk9DRVNTIGZsYWcKSW5kZXg6IFRvb2xzL01pbmlCcm93c2VyL21hYy9BcHBEZWxl Z2F0ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL01pbmlCcm93c2VyL21hYy9BcHBEZWxlZ2F0ZS5o CShyZXZpc2lvbiAxNjAyNzUpCisrKyBUb29scy9NaW5pQnJvd3Nlci9tYWMvQXBwRGVsZWdhdGUu aAkod29ya2luZyBjb3B5KQpAQCAtMjMsMTAgKzIzLDEzIEBACiAgKiBUSEUgUE9TU0lCSUxJVFkg T0YgU1VDSCBEQU1BR0UuCiAgKi8KIAorI2ltcG9ydCA8V2ViS2l0Mi9XZWJLaXQyLmg+CisKIEBp bnRlcmZhY2UgQnJvd3NlckFwcERlbGVnYXRlIDogTlNPYmplY3QgPE5TQXBwbGljYXRpb25EZWxl Z2F0ZT4geworI2lmIFdLX0FQSV9FTkFCTEVECiAgICAgV0tQcm9jZXNzR3JvdXAgKl9wcm9jZXNz R3JvdXA7CiAgICAgV0tCcm93c2luZ0NvbnRleHRHcm91cCAqX2Jyb3dzaW5nQ29udGV4dEdyb3Vw OwotCisjZW5kaWYKICAgICBOU011dGFibGVTZXQgKl9icm93c2VyV2luZG93czsKIH0KIApJbmRl eDogVG9vbHMvTWluaUJyb3dzZXIvbWFjL0FwcERlbGVnYXRlLm0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvTWluaUJyb3dzZXIvbWFjL0FwcERlbGVnYXRlLm0JKHJldmlzaW9uIDE2MDI3NSkKKysrIFRv b2xzL01pbmlCcm93c2VyL21hYy9BcHBEZWxlZ2F0ZS5tCSh3b3JraW5nIGNvcHkpCkBAIC00NSw4 ICs0NSwxMCBAQCAtIChpZClpbml0CiB7CiAgICAgc2VsZiA9IFtzdXBlciBpbml0XTsKICAgICBp ZiAoc2VsZikgeworI2lmIFdLX0FQSV9FTkFCTEVECiAgICAgICAgIF9wcm9jZXNzR3JvdXAgPSBb W1dLUHJvY2Vzc0dyb3VwIGFsbG9jXSBpbml0XTsKICAgICAgICAgX2Jyb3dzaW5nQ29udGV4dEdy b3VwID0gW1tXS0Jyb3dzaW5nQ29udGV4dEdyb3VwIGFsbG9jXSBpbml0V2l0aElkZW50aWZpZXI6 QCJNaW5pQnJvd3NlciJdOworI2VuZGlmCiAgICAgICAgIF9icm93c2VyV2luZG93cyA9IFtbTlNN dXRhYmxlU2V0IGFsbG9jXSBpbml0XTsKICAgICB9CiAKQEAgLTkyLDExICs5NCwxMyBAQCAtICh2 b2lkKWFwcGxpY2F0aW9uV2lsbFRlcm1pbmF0ZTooTlNOb3RpCiAgICAgICAgIFtjb250cm9sbGVy IGFwcGxpY2F0aW9uVGVybWluYXRpbmddOwogICAgIH0KIAorI2lmIFdLX0FQSV9FTkFCTEVECiAg ICAgW19wcm9jZXNzR3JvdXAgcmVsZWFzZV07CiAgICAgX3Byb2Nlc3NHcm91cCA9IG5pbDsKIAog ICAgIFtfYnJvd3NpbmdDb250ZXh0R3JvdXAgcmVsZWFzZV07CiAgICAgX2Jyb3dzaW5nQ29udGV4 dEdyb3VwID0gbmlsOworI2VuZGlmCiB9CiAKIC0gKEJyb3dzZXJXaW5kb3dDb250cm9sbGVyICop ZnJvbnRtb3N0QnJvd3NlcldpbmRvd0NvbnRyb2xsZXIK