125416 2013-12-08 09:37:39 -0800 [GTK] Do not generate new dispatch_event methods marked as deprecated 2013-12-08 10:13:18 -0800 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 125417 1 cgarcia webkit-unassigned cdumez commit-queue gustavo oldest_to_newest 957641 0 cgarcia 2013-12-08 09:37:39 -0800 We are currently marking all dispatch_events (except the one in the interface) as deprecated, but also for new objects implementing the EventTarget interface. We should simply skip the method in such case. 957642 1 218694 cgarcia 2013-12-08 09:40:36 -0800 Created attachment 218694 Patch 957649 2 218694 gustavo 2013-12-08 09:56:18 -0800 Comment on attachment 218694 Patch Yes! 957654 3 cgarcia 2013-12-08 10:13:18 -0800 Committed r160288: <http://trac.webkit.org/changeset/160288> 218694 2013-12-08 09:40:36 -0800 2013-12-08 09:56:18 -0800 Patch wkdom-dispatch-event.diff text/plain 2741 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5MGIzZjYwLi45NmIzNDQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMTItMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIERvIG5vdCBnZW5lcmF0ZWQgbmV3IGRpc3BhdGNoX2V2ZW50cyBt YXJrZWQgYXMgZ2VuZXJhdGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjU0MTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG06Cisg ICAgICAgIChTa2lwRnVuY3Rpb24pOiBTa2lwIGRpc3BhdGNoX2V2ZW50IG1ldGhvZHMgZm9yIG9i amVjdHMKKyAgICAgICAgaW1wbGVtZW50aW5nIEV2ZW50VGFyZ2V0IGludGVyZmFjZSB1bmxlc3Mg dGhleSBhcmUgYWxyZWFkeQorICAgICAgICBkZXByZWNhdGVkLgorICAgICAgICAoR2VuZXJhdGVG dW5jdGlvbik6IFBhc3MgYWxzbyB0aGUgcGFyZW50Tm9kZSB0byBTa2lwRnVuY3Rpb24oKS4KKwog MjAxMy0xMi0wNSAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBb TVNFXSBCcmluZyBlbmQtb2Ytc3RyZWFtIGFsZ29yaXRobSBzZWN0aW9uIHVwIHRvIGN1cnJlbnQg c3BlYy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdl bmVyYXRvckdPYmplY3QucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVH ZW5lcmF0b3JHT2JqZWN0LnBtCmluZGV4IGQ1MDJmMGYuLmQzYWE0ODYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0KKysr IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5w bQpAQCAtMjQ0LDYgKzI0NCw3IEBAIHN1YiBTa2lwQXR0cmlidXRlIHsKIHN1YiBTa2lwRnVuY3Rp b24gewogICAgIG15ICRvYmplY3QgPSBzaGlmdDsKICAgICBteSAkZnVuY3Rpb24gPSBzaGlmdDsK KyAgICBteSAkcGFyZW50Tm9kZSA9IHNoaWZ0OwogICAgIG15ICRkZWNhbWVsaXplID0gc2hpZnQ7 CiAgICAgbXkgJHByZWZpeCA9IHNoaWZ0OwogCkBAIC0yODcsNiArMjg4LDIxIEBAIHN1YiBTa2lw RnVuY3Rpb24gewogICAgICAgICByZXR1cm4gMTsKICAgICB9CiAKKyAgICAjIFNraXAgZGlzcGF0 Y2hfZXZlbnQgbWV0aG9kcywgZXhjZXB0IHRoZSBvbmUgYWxyZWFkeSBkZXByZWNhdGVkLgorICAg IGlmICgkcGFyZW50Tm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkV2ZW50VGFyZ2V0In0gJiYg JGZ1bmN0aW9uLT5zaWduYXR1cmUtPm5hbWUgZXEgImRpc3BhdGNoRXZlbnQiCisgICAgICAgICYm ICRmdW5jdGlvbk5hbWUgbmUgIndlYmtpdF9kb21fYXVkaW9fdHJhY2tfbGlzdF9kaXNwYXRjaF9l dmVudCIKKyAgICAgICAgJiYgJGZ1bmN0aW9uTmFtZSBuZSAid2Via2l0X2RvbV9iYXR0ZXJ5X21h bmFnZXJfZGlzcGF0Y2hfZXZlbnQiCisgICAgICAgICYmICRmdW5jdGlvbk5hbWUgbmUgIndlYmtp dF9kb21fZG9tX2FwcGxpY2F0aW9uX2NhY2hlX2Rpc3BhdGNoX2V2ZW50IgorICAgICAgICAmJiAk ZnVuY3Rpb25OYW1lIG5lICJ3ZWJraXRfZG9tX2RvbV93aW5kb3dfZGlzcGF0Y2hfZXZlbnQiCisg ICAgICAgICYmICRmdW5jdGlvbk5hbWUgbmUgIndlYmtpdF9kb21fbm9kZV9kaXNwYXRjaF9ldmVu dCIKKyAgICAgICAgJiYgJGZ1bmN0aW9uTmFtZSBuZSAid2Via2l0X2RvbV90ZXh0X3RyYWNrX2N1 ZV9kaXNwYXRjaF9ldmVudCIKKyAgICAgICAgJiYgJGZ1bmN0aW9uTmFtZSBuZSAid2Via2l0X2Rv bV90ZXh0X3RyYWNrX2Rpc3BhdGNoX2V2ZW50IgorICAgICAgICAmJiAkZnVuY3Rpb25OYW1lIG5l ICJ3ZWJraXRfZG9tX3RleHRfdHJhY2tfbGlzdF9kaXNwYXRjaF9ldmVudCIKKyAgICAgICAgJiYg JGZ1bmN0aW9uTmFtZSBuZSAid2Via2l0X2RvbV92aWRlb190cmFja19saXN0X2Rpc3BhdGNoX2V2 ZW50IgorICAgICAgICAmJiAkZnVuY3Rpb25OYW1lIG5lICJ3ZWJraXRfZG9tX3dlYmtpdF9uYW1l ZF9mbG93X2Rpc3BhdGNoX2V2ZW50IgorICAgICAgICAmJiAkZnVuY3Rpb25OYW1lIG5lICJ3ZWJr aXRfZG9tX3Rlc3RfZXZlbnRfdGFyZ2V0X2Rpc3BhdGNoX2V2ZW50IikgeworICAgICAgICByZXR1 cm4gMTsKKyAgICB9CiAKICAgICBpZiAoJGZ1bmN0aW9uLT5zaWduYXR1cmUtPm5hbWUgZXEgInNl dCIgYW5kICRwYXJlbnROb2RlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiVHlwZWRBcnJheSJ9KSB7 CiAgICAgICAgIHJldHVybiAxOwpAQCAtOTExLDcgKzkyNyw3IEBAIHN1YiBHZW5lcmF0ZUZ1bmN0 aW9uIHsKIAogICAgIG15ICRkZWNhbWVsaXplID0gZGVjYW1lbGl6ZSgkaW50ZXJmYWNlTmFtZSk7 CiAKLSAgICBpZiAoU2tpcEZ1bmN0aW9uKCRvYmplY3QsICRmdW5jdGlvbiwgJGRlY2FtZWxpemUs ICRwcmVmaXgpKSB7CisgICAgaWYgKFNraXBGdW5jdGlvbigkb2JqZWN0LCAkZnVuY3Rpb24sICRw YXJlbnROb2RlLCAkZGVjYW1lbGl6ZSwgJHByZWZpeCkpIHsKICAgICAgICAgcmV0dXJuOwogICAg IH0KIAo=