125415 2013-12-08 08:01:33 -0800 [WK2] Guard include of SecItemShim.h with ENABLE(SEC_ITEM_SHIM) 2013-12-08 10:23:19 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 118231 1 brian.holt brian.holt ap beidson buildbot commit-queue mrobinson rniwa oldest_to_newest 957622 0 brian.holt 2013-12-08 08:01:33 -0800 NetworkProcess.cpp and NetworkProcessProxy.cpp both include SecItemShim.h unguarded. 957625 1 218690 brian.holt 2013-12-08 08:13:54 -0800 Created attachment 218690 Patch 957630 2 218690 gustavo 2013-12-08 08:34:24 -0800 Comment on attachment 218690 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218690&action=review > Source/WebKit2/UIProcess/Network/NetworkProcessProxy.cpp:41 > -#include "SecItemShimProxy.h" > #include "WebContext.h" > #include "WebProcessMessages.h" > #include <wtf/RunLoop.h> > > +#if ENABLE(SEC_ITEM_SHIM) > +#include "SecItemShim.h" SecItemShim.h != SecItemShimProxy.h, intended? 957635 3 218690 buildbot 2013-12-08 08:49:48 -0800 Comment on attachment 218690 Patch Attachment 218690 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/46658037 957637 4 218690 buildbot 2013-12-08 09:05:08 -0800 Comment on attachment 218690 Patch Attachment 218690 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/46658040 957640 5 218693 brian.holt 2013-12-08 09:20:11 -0800 Created attachment 218693 Patch 957645 6 218693 brian.holt 2013-12-08 09:45:53 -0800 Comment on attachment 218693 Patch Thanks for the review - could you set CQ+? 957657 7 218693 commit-queue 2013-12-08 10:23:17 -0800 Comment on attachment 218693 Patch Clearing flags on attachment: 218693 Committed r160290: <http://trac.webkit.org/changeset/160290> 957658 8 commit-queue 2013-12-08 10:23:19 -0800 All reviewed patches have been landed. Closing bug. 218690 2013-12-08 08:13:54 -0800 2013-12-08 09:20:05 -0800 Patch bug-125415-20131208171352.patch text/plain 2253 brian.holt U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmI2MmE4NjYwYWU1NWJk ZGFmOTNkZGM4ZWJjM2QxZGIyM2ZlYjMwOS4uN2ZmZTNjMGZjNjY3NGQ4MmFlZjg1M2VjZmUxOGY4 YmFlZDlhNTNkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTEyLTA4ICBCcmlh biBIb2x0ICA8YnJpYW4uaG9sdEBzYW1zdW5nLmNvbT4KKworICAgICAgICBbV0syXSBHdWFyZCBp bmNsdWRlIG9mIFNlY0l0ZW1TaGltLmggd2l0aCBFTkFCTEUoU0VDX0lURU1fU0hJTSkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTQxNQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTmV0d29ya1Byb2Nl c3MvTmV0d29ya1Byb2Nlc3MuY3BwOgorICAgICAgICAqIFVJUHJvY2Vzcy9OZXR3b3JrL05ldHdv cmtQcm9jZXNzUHJveHkuY3BwOgorCiAyMDEzLTEyLTA3ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtp dC5vcmc+CiAKICAgICAgICAgW0NvY29hXSBNYWtlIFdLV2ViUHJvY2Vzc1BsdWdJbkNvbnRyb2xs ZXIgd29yayB3aXRoIFdLT2JqZWN0IHdyYXBwaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3 b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAKaW5kZXggOTA4ZDE5ODE5Y2M1YjEzODdiYmU5 YTE4MmQxNGVlOTRmMGU1ODg4My4uOTBhZTkyMzhhZjJkNTYyYjkxY2M4MGE0MTVmM2U3MDhiMDAy MDBlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1By b2Nlc3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9j ZXNzLmNwcApAQCAtMzksNyArMzksNiBAQAogI2luY2x1ZGUgIk5ldHdvcmtQcm9jZXNzUHJveHlN ZXNzYWdlcy5oIgogI2luY2x1ZGUgIk5ldHdvcmtSZXNvdXJjZUxvYWRlci5oIgogI2luY2x1ZGUg IlJlbW90ZU5ldHdvcmtpbmdDb250ZXh0LmgiCi0jaW5jbHVkZSAiU2VjSXRlbVNoaW0uaCIKICNp bmNsdWRlICJTdGF0aXN0aWNzRGF0YS5oIgogI2luY2x1ZGUgIldlYkNvbnRleHRNZXNzYWdlcy5o IgogI2luY2x1ZGUgIldlYkNvb2tpZU1hbmFnZXIuaCIKQEAgLTQ4LDYgKzQ3LDEwIEBACiAjaW5j bHVkZSA8d3RmL1J1bkxvb3AuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKKyNp ZiBFTkFCTEUoU0VDX0lURU1fU0hJTSkKKyNpbmNsdWRlICJTZWNJdGVtU2hpbS5oIgorI2VuZGlm CisKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCiBuYW1lc3BhY2UgV2ViS2l0IHsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNzUHJv eHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NQ cm94eS5jcHAKaW5kZXggZGRlMGEyMTNiNzQ0MmM4NDJlMzE5MWJiNTBiZDRhZDliNDM1ZGQ3Mi4u NWE2MWQwN2U5MDI0NWJlMDU2MWM5YTRjMzJlNTMyNjU0MjcyOTI3MyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NQcm94eS5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NQcm94eS5j cHAKQEAgLTMzLDExICszMywxNCBAQAogI2luY2x1ZGUgIkRvd25sb2FkUHJveHlNZXNzYWdlcy5o IgogI2luY2x1ZGUgIk5ldHdvcmtQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzLmgiCiAjaW5jbHVk ZSAiTmV0d29ya1Byb2Nlc3NNZXNzYWdlcy5oIgotI2luY2x1ZGUgIlNlY0l0ZW1TaGltUHJveHku aCIKICNpbmNsdWRlICJXZWJDb250ZXh0LmgiCiAjaW5jbHVkZSAiV2ViUHJvY2Vzc01lc3NhZ2Vz LmgiCiAjaW5jbHVkZSA8d3RmL1J1bkxvb3AuaD4KIAorI2lmIEVOQUJMRShTRUNfSVRFTV9TSElN KQorI2luY2x1ZGUgIlNlY0l0ZW1TaGltLmgiCisjZW5kaWYKKwogI2RlZmluZSBNRVNTQUdFX0NI RUNLKGFzc2VydGlvbikgTUVTU0FHRV9DSEVDS19CQVNFKGFzc2VydGlvbiwgY29ubmVjdGlvbigp KQogCiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsK 218693 2013-12-08 09:20:11 -0800 2013-12-08 10:23:17 -0800 Patch bug-125415-20131208182009.patch text/plain 2258 brian.holt U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmI2MmE4NjYwYWU1NWJk ZGFmOTNkZGM4ZWJjM2QxZGIyM2ZlYjMwOS4uN2ZmZTNjMGZjNjY3NGQ4MmFlZjg1M2VjZmUxOGY4 YmFlZDlhNTNkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTEyLTA4ICBCcmlh biBIb2x0ICA8YnJpYW4uaG9sdEBzYW1zdW5nLmNvbT4KKworICAgICAgICBbV0syXSBHdWFyZCBp bmNsdWRlIG9mIFNlY0l0ZW1TaGltLmggd2l0aCBFTkFCTEUoU0VDX0lURU1fU0hJTSkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTQxNQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTmV0d29ya1Byb2Nl c3MvTmV0d29ya1Byb2Nlc3MuY3BwOgorICAgICAgICAqIFVJUHJvY2Vzcy9OZXR3b3JrL05ldHdv cmtQcm9jZXNzUHJveHkuY3BwOgorCiAyMDEzLTEyLTA3ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtp dC5vcmc+CiAKICAgICAgICAgW0NvY29hXSBNYWtlIFdLV2ViUHJvY2Vzc1BsdWdJbkNvbnRyb2xs ZXIgd29yayB3aXRoIFdLT2JqZWN0IHdyYXBwaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3 b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAKaW5kZXggOTA4ZDE5ODE5Y2M1YjEzODdiYmU5 YTE4MmQxNGVlOTRmMGU1ODg4My4uOTBhZTkyMzhhZjJkNTYyYjkxY2M4MGE0MTVmM2U3MDhiMDAy MDBlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1By b2Nlc3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9j ZXNzLmNwcApAQCAtMzksNyArMzksNiBAQAogI2luY2x1ZGUgIk5ldHdvcmtQcm9jZXNzUHJveHlN ZXNzYWdlcy5oIgogI2luY2x1ZGUgIk5ldHdvcmtSZXNvdXJjZUxvYWRlci5oIgogI2luY2x1ZGUg IlJlbW90ZU5ldHdvcmtpbmdDb250ZXh0LmgiCi0jaW5jbHVkZSAiU2VjSXRlbVNoaW0uaCIKICNp bmNsdWRlICJTdGF0aXN0aWNzRGF0YS5oIgogI2luY2x1ZGUgIldlYkNvbnRleHRNZXNzYWdlcy5o IgogI2luY2x1ZGUgIldlYkNvb2tpZU1hbmFnZXIuaCIKQEAgLTQ4LDYgKzQ3LDEwIEBACiAjaW5j bHVkZSA8d3RmL1J1bkxvb3AuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKKyNp ZiBFTkFCTEUoU0VDX0lURU1fU0hJTSkKKyNpbmNsdWRlICJTZWNJdGVtU2hpbS5oIgorI2VuZGlm CisKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCiBuYW1lc3BhY2UgV2ViS2l0IHsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNzUHJv eHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NQ cm94eS5jcHAKaW5kZXggZGRlMGEyMTNiNzQ0MmM4NDJlMzE5MWJiNTBiZDRhZDliNDM1ZGQ3Mi4u YzgxYzc0MTE5ZjZhNmE5NjAxYjAxMTU4YzAwOGI5YWU0NGFiYzYxZiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NQcm94eS5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NQcm94eS5j cHAKQEAgLTMzLDExICszMywxNCBAQAogI2luY2x1ZGUgIkRvd25sb2FkUHJveHlNZXNzYWdlcy5o IgogI2luY2x1ZGUgIk5ldHdvcmtQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzLmgiCiAjaW5jbHVk ZSAiTmV0d29ya1Byb2Nlc3NNZXNzYWdlcy5oIgotI2luY2x1ZGUgIlNlY0l0ZW1TaGltUHJveHku aCIKICNpbmNsdWRlICJXZWJDb250ZXh0LmgiCiAjaW5jbHVkZSAiV2ViUHJvY2Vzc01lc3NhZ2Vz LmgiCiAjaW5jbHVkZSA8d3RmL1J1bkxvb3AuaD4KIAorI2lmIEVOQUJMRShTRUNfSVRFTV9TSElN KQorI2luY2x1ZGUgIlNlY0l0ZW1TaGltUHJveHkuaCIKKyNlbmRpZgorCiAjZGVmaW5lIE1FU1NB R0VfQ0hFQ0soYXNzZXJ0aW9uKSBNRVNTQUdFX0NIRUNLX0JBU0UoYXNzZXJ0aW9uLCBjb25uZWN0 aW9uKCkpCiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwo=