125408 2013-12-08 04:24:33 -0800 [webkitpy] Add a WestonDriver unit test 2013-12-08 08:47:04 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan brian.holt commit-queue glenn mrobinson oldest_to_newest 957598 0 zan 2013-12-08 04:24:33 -0800 [webkitpy] Add a WestonDriver unit test 957599 1 218682 zan 2013-12-08 04:45:13 -0800 Created attachment 218682 Patch 957620 2 218682 gustavo 2013-12-08 07:48:09 -0800 Comment on attachment 218682 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218682&action=review > Tools/Scripts/webkitpy/port/westondriver_unittest.py:67 > + driver._weston_process = None I don't really get this one, why do you do this here? Looks good otherwise. 957631 3 zan 2013-12-08 08:38:23 -0800 (In reply to comment #2) > (From update of attachment 218682 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=218682&action=review > > > Tools/Scripts/webkitpy/port/westondriver_unittest.py:67 > > + driver._weston_process = None > > I don't really get this one, why do you do this here? Looks good otherwise. This prevents calling terminate() on the subprocess.Popen mock representation, on which there's no method of such name. This (proper cleanup in WestonDriver.stop()) is rather tested in test_stop() instead. I'll put a comment above this assignment line, explaining why it is done. 957632 4 zan 2013-12-08 08:47:04 -0800 Committed r160286: <http://trac.webkit.org/changeset/160286> 218682 2013-12-08 04:45:13 -0800 2013-12-08 07:48:09 -0800 Patch bug-125408-20131208134512.patch text/plain 5530 zan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2MDI4MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIyIEBACisyMDEzLTEyLTA4ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNv bT4KKworICAgICAgICBbd2Via2l0cHldIEFkZCBhIFdlc3RvbkRyaXZlciB1bml0IHRlc3QKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTQwOAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIHdlYmtp dHB5IHVuaXQgdGVzdCBmb3IgdGhlIFdlc3RvbiBkcml2ZXIuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L3BvcnQvd2VzdG9uZHJpdmVyX3VuaXR0ZXN0LnB5OiBBZGRlZC4KKyAgICAgICAg KFdlc3RvbkRyaXZlclRlc3QpOgorICAgICAgICAoV2VzdG9uRHJpdmVyVGVzdC5tYWtlX2RyaXZl cik6IFNldHMgdXAgYSBuZXcgV2VzdG9uRHJpdmVyIGluc3RhbmNlIGZvciB0ZXN0aW5nIHB1cnBv c2VzLgorICAgICAgICAoV2VzdG9uRHJpdmVyVGVzdC50ZXN0X3N0YXJ0KTogQ2hlY2sgdGhhdCB0 aGUgV2VzdG9uIGNvbXBvc2l0b3IgaXMgbGF1bmNoZWQgcHJvcGVybHkgYW5kIHRoYXQKKyAgICAg ICAgdGhlIHNlcnZlciBlbnZpcm9ubWVudCBjb250YWlucyBwcm9wZXIgV0FZTEFORCBhbmQgR0RL X0JBQ0tFTkQgZW50cmllcy4KKyAgICAgICAgKFdlc3RvbkRyaXZlclRlc3QudGVzdF9zdG9wKTog Q2hlY2sgdGhhdCB0aGUgV2VzdG9uIGNvbXBvc2l0b3IgaXMgdGVybWluYXRlZCBwcm9wZXJseSBh bmQgdGhhdAorICAgICAgICB0aGUgZHJpdmVyIGNsZWFucyB1cCB0aGUgdGVtcG9yYXJ5IGRpcmVj dG9yeS4KKyAgICAgICAgKFdlc3RvbkRyaXZlclRlc3QudGVzdF9zdG9wLkZha2VXZXN0b25Qcm9j ZXNzKTogQSBoZWxwZXIgY2xhc3MgdGhhdCBsb2dzIHRoZSBleHBlY3RlZCB0ZXJtaW5hdGlvbi4K KyAgICAgICAgKFdlc3RvbkRyaXZlclRlc3QudGVzdF9zdG9wLkZha2VXZXN0b25Qcm9jZXNzLnRl cm1pbmF0ZSk6CisKIDIwMTMtMTItMDcgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAog ICAgICAgICBbQ29jb2FdIENvbnZlcnQgYSBmZXcgbW9yZSBwYXJ0cyBvZiBNaW5pQnJvd3NlciBv dmVyIHRvIHRoZSBPYmplY3RpdmUtQyBBUEkKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv cG9ydC93ZXN0b25kcml2ZXJfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9wb3J0L3dlc3RvbmRyaXZlcl91bml0dGVzdC5weQkocmV2aXNpb24gMCkKKysr IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC93ZXN0b25kcml2ZXJfdW5pdHRlc3QucHkJKHdv cmtpbmcgY29weSkKQEAgLTAsMCArMSw4MyBAQAorIyBDb3B5cmlnaHQgKEMpIDIwMTMgSWdhbGlh IFMuTC4KKyMKKyMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBm b3Jtcywgd2l0aCBvciB3aXRob3V0CisjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92 aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKKyMgbWV0OgorIworIyAgICAq IFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29w eXJpZ2h0CisjIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dp bmcgZGlzY2xhaW1lci4KKyMgICAgKiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVz dCByZXByb2R1Y2UgdGhlIGFib3ZlCisjIGNvcHlyaWdodCBub3RpY2UsIHRoaXMgbGlzdCBvZiBj b25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIKKyMgaW4gdGhlIGRvY3VtZW50 YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZQorIyBkaXN0cmli dXRpb24uCisjICAgICogTmVpdGhlciB0aGUgbmFtZSBvZiBJZ2FsaWEgUy5MLiBub3IgdGhlIG5h bWVzIG9mIGl0cworIyBjb250cmlidXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5kb3JzZSBvciBwcm9t b3RlIHByb2R1Y3RzIGRlcml2ZWQgZnJvbQorIyB0aGlzIHNvZnR3YXJlIHdpdGhvdXQgc3BlY2lm aWMgcHJpb3Igd3JpdHRlbiBwZXJtaXNzaW9uLgorIworIyBUSElTIFNPRlRXQVJFIElTIFBST1ZJ REVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVSUyBBTkQgQ09OVFJJQlVUT1JTCisjICJBUyBJUyIg QU5EIEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9U CisjIExJTUlURUQgVE8sIFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZ IEFORCBGSVRORVNTIEZPUgorIyBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4g SU4gTk8gRVZFTlQgU0hBTEwgVEhFIENPUFlSSUdIVAorIyBPV05FUiBPUiBDT05UUklCVVRPUlMg QkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwKKyMgU1BFQ0lB TCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5P VAorIyBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJ Q0VTOyBMT1NTIE9GIFVTRSwKKyMgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJS VVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZCisjIFRIRU9SWSBPRiBMSUFCSUxJVFks IFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyMgKElOQ0xV RElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBU SEUgVVNFCisjIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lC SUxJVFkgT0YgU1VDSCBEQU1BR0UuCisKK2ltcG9ydCBsb2dnaW5nCitpbXBvcnQgcmUKK2ltcG9y dCB1bml0dGVzdDIgYXMgdW5pdHRlc3QKKworZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtLmZp bGVzeXN0ZW1fbW9jayBpbXBvcnQgTW9ja0ZpbGVTeXN0ZW0KK2Zyb20gd2Via2l0cHkuY29tbW9u LnN5c3RlbS5vdXRwdXRjYXB0dXJlIGltcG9ydCBPdXRwdXRDYXB0dXJlCitmcm9tIHdlYmtpdHB5 LmNvbW1vbi5zeXN0ZW0uc3lzdGVtaG9zdF9tb2NrIGltcG9ydCBNb2NrU3lzdGVtSG9zdAorZnJv bSB3ZWJraXRweS5wb3J0IGltcG9ydCBQb3J0Citmcm9tIHdlYmtpdHB5LnBvcnQuc2VydmVyX3By b2Nlc3NfbW9jayBpbXBvcnQgTW9ja1NlcnZlclByb2Nlc3MKK2Zyb20gd2Via2l0cHkucG9ydC53 ZXN0b25kcml2ZXIgaW1wb3J0IFdlc3RvbkRyaXZlcgorZnJvbSB3ZWJraXRweS50b29sLm1vY2t0 b29sIGltcG9ydCBNb2NrT3B0aW9ucworCitfbG9nID0gbG9nZ2luZy5nZXRMb2dnZXIoX19uYW1l X18pCisKKworY2xhc3MgV2VzdG9uRHJpdmVyVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CisgICAg ZGVmIG1ha2VfZHJpdmVyKHNlbGYsIGZpbGVzeXN0ZW09Tm9uZSk6CisgICAgICAgIHBvcnQgPSBQ b3J0KE1vY2tTeXN0ZW1Ib3N0KGxvZ19leGVjdXRpdmU9VHJ1ZSwgZmlsZXN5c3RlbT1maWxlc3lz dGVtKSwgJ3dlc3RvbmRyaXZlcnRlc3Rwb3J0Jywgb3B0aW9ucz1Nb2NrT3B0aW9ucyhjb25maWd1 cmF0aW9uPSdSZWxlYXNlJykpCisgICAgICAgIHBvcnQuX2NvbmZpZy5idWlsZF9kaXJlY3Rvcnkg PSBsYW1iZGEgY29uZmlndXJhdGlvbjogIi9tb2NrX2J1aWxkIgorICAgICAgICBwb3J0Ll9zZXJ2 ZXJfcHJvY2Vzc19jb25zdHJ1Y3RvciA9IE1vY2tTZXJ2ZXJQcm9jZXNzCisKKyAgICAgICAgZHJp dmVyID0gV2VzdG9uRHJpdmVyKHBvcnQsIHdvcmtlcl9udW1iZXI9MCwgcGl4ZWxfdGVzdHM9VHJ1 ZSkKKyAgICAgICAgZHJpdmVyLl9zdGFydHVwX2RlbGF5X3NlY3MgPSAwCisgICAgICAgIHJldHVy biBkcml2ZXIKKworICAgIGRlZiB0ZXN0X3N0YXJ0KHNlbGYpOgorICAgICAgICBkcml2ZXIgPSBz ZWxmLm1ha2VfZHJpdmVyKCkKKyAgICAgICAgb3V0cHV0X2NhcHR1cmUgPSBPdXRwdXRDYXB0dXJl KCkKKworICAgICAgICBvdXRwdXRfY2FwdHVyZS5jYXB0dXJlX291dHB1dCgpCisgICAgICAgIGRy aXZlci5zdGFydChwaXhlbF90ZXN0cz1UcnVlLCBwZXJfdGVzdF9hcmdzPVtdKQorICAgICAgICBf LCBfLCBsb2dzID0gb3V0cHV0X2NhcHR1cmUucmVzdG9yZV9vdXRwdXQoKQorCisgICAgICAgIHNl bGYuYXNzZXJ0VHJ1ZShyZS5tYXRjaChyIk1PQ0sgcG9wZW46IFxbJ3dlc3RvbicsICctLXNvY2tl dD1XS1Rlc3Rpbmctd2VzdG9uLVswLTlhLWZdezMyfScsICctLXdpZHRoPTgwMCcsICctLWhlaWdo dD02MDAnXF1cbiIsIGxvZ3MpLCBOb25lKQorICAgICAgICBzZWxmLmFzc2VydFRydWUocmUubWF0 Y2gociJXS1Rlc3Rpbmctd2VzdG9uLVswLTlhLWZdezMyfSIsIGRyaXZlci5fc2VydmVyX3Byb2Nl c3MuZW52WydXQVlMQU5EX0RJU1BMQVknXSkpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoZHJp dmVyLl9zZXJ2ZXJfcHJvY2Vzcy5lbnZbJ0dES19CQUNLRU5EJ10sICd3YXlsYW5kJykKKyAgICAg ICAgc2VsZi5hc3NlcnRUcnVlKGRyaXZlci5fc2VydmVyX3Byb2Nlc3Muc3RhcnRlZCkKKworICAg ICAgICBkcml2ZXIuX3dlc3Rvbl9wcm9jZXNzID0gTm9uZQorCisgICAgZGVmIHRlc3Rfc3RvcChz ZWxmKToKKyAgICAgICAgY2xhc3MgRmFrZVdlc3RvblByb2Nlc3Mob2JqZWN0KToKKyAgICAgICAg ICAgIGRlZiB0ZXJtaW5hdGUoc2VsZik6CisgICAgICAgICAgICAgICAgX2xvZy5pbmZvKCJNT0NL IEZha2VXZXN0b25Qcm9jZXNzLnRlcm1pbmF0ZSIpCisKKyAgICAgICAgZmlsZXN5c3RlbSA9IE1v Y2tGaWxlU3lzdGVtKGRpcnM9WycvdG1wL3dlc3Rvbi1kcml2ZXItZGlyZWN0b3J5J10pCisgICAg ICAgIGRyaXZlciA9IHNlbGYubWFrZV9kcml2ZXIoZmlsZXN5c3RlbSkKKyAgICAgICAgZHJpdmVy Ll93ZXN0b25fcHJvY2VzcyA9IEZha2VXZXN0b25Qcm9jZXNzKCkKKyAgICAgICAgZHJpdmVyLl9k cml2ZXJfZGlyZWN0b3J5ID0gJy90bXAvd2VzdG9uLWRyaXZlci1kaXJlY3RvcnknCisKKyAgICAg ICAgZXhwZWN0ZWRfbG9ncyA9ICJNT0NLIEZha2VXZXN0b25Qcm9jZXNzLnRlcm1pbmF0ZVxuIgor ICAgICAgICBPdXRwdXRDYXB0dXJlKCkuYXNzZXJ0X291dHB1dHMoc2VsZiwgZHJpdmVyLnN0b3As IFtdLCBleHBlY3RlZF9sb2dzPWV4cGVjdGVkX2xvZ3MpCisKKyAgICAgICAgc2VsZi5hc3NlcnRJ c05vbmUoZHJpdmVyLl93ZXN0b25fcHJvY2VzcykKKyAgICAgICAgc2VsZi5hc3NlcnRGYWxzZShk cml2ZXIuX3BvcnQuX2ZpbGVzeXN0ZW0uZXhpc3RzKGRyaXZlci5fZHJpdmVyX2RpcmVjdG9yeSkp Cg==