125383 2013-12-07 02:21:56 -0800 [WinCairo] OpenGL compile error. 2013-12-11 12:04:59 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned alex.christensen bfulgham commit-queue dino kondapallykalyan noam ralpht+bugs roger_fong oldest_to_newest 957500 0 peavo 2013-12-07 02:21:56 -0800 Compiling GraphicsContext3DOpenGLCommon.cpp on WinCairo fails, because GL_HALF_FLOAT_ARB is undefined. It's defined in <GL/glext.h>, but when I include that, I get other compile errors. 957501 1 218655 peavo 2013-12-07 02:26:46 -0800 Created attachment 218655 Patch 957587 2 218655 bfulgham 2013-12-08 00:00:54 -0800 Comment on attachment 218655 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218655&action=review > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1368 > +#if !PLATFORM(WIN) || defined(GL_HALF_FLOAT_ARB) Can you file a bug for the break in a Windows with GLext.h included, and add a FIXME here? Then I'll r+ this as a build fix. 958017 3 218782 peavo 2013-12-09 11:34:48 -0800 Created attachment 218782 Patch 958018 4 peavo 2013-12-09 11:37:22 -0800 On second thought, I think it's better to define GL_HALF_FLOAT_ARB when OPENGL_ES_2 is used. It doesn't seem we're meant to include <GL/glext.h> when OPENGL_ES_2 is used, rather <GLES2/gl2ext.h>. 958040 5 218782 commit-queue 2013-12-09 12:14:53 -0800 Comment on attachment 218782 Patch Clearing flags on attachment: 218782 Committed r160324: <http://trac.webkit.org/changeset/160324> 958041 6 commit-queue 2013-12-09 12:14:55 -0800 All reviewed patches have been landed. Closing bug. 958044 7 alex.christensen 2013-12-09 12:16:44 -0800 *** Bug 125464 has been marked as a duplicate of this bug. *** 958829 8 ralpht+bugs 2013-12-11 11:38:33 -0800 Oops, I filed this patch for the same issue. I think it affects all GL ES 2.0 targets, not just Windows. https://bugs.webkit.org/show_bug.cgi?id=125541 I'll update my patch to weaken the #if guard to just #if USE(OPENGL_ES_2). 958847 9 ralpht+bugs 2013-12-11 11:57:32 -0800 (In reply to comment #8) > Oops, I filed this patch for the same issue. I think it affects all GL ES 2.0 targets, not just Windows. > > https://bugs.webkit.org/show_bug.cgi?id=125541 > > I'll update my patch to weaken the #if guard to just #if USE(OPENGL_ES_2). Oops, actually that would be wrong; I didn't realize that HALF_FLOAT_OES and HALF_FLOAT_ARB are different values -- an actual GLES 2 implementation wants HALF_FLOAT_OES (0x8D61). I think my other patch is still OK, though it's weird to have guards around the same thing in two places. Does the Windows GL ES 2 implementation really want HALF_FLOAT_ARB? 958852 10 ralpht+bugs 2013-12-11 12:04:59 -0800 If you're using the ANGLE in the WebKit tree then it will bail in glTexImage2D if you use the GL_HALF_FLOAT_ARB constant (look in src/libGLESv2/libGLESv2.cpp for HALF_FLOAT_OES). It doesn't seem to support half float vertices at all. Maybe you're using some vendor OpenGL ICD, in which case it'd be fine. I'm not sure how the Windows build is set up. Sorry for so many comments. 218655 2013-12-07 02:26:46 -0800 2013-12-09 11:34:41 -0800 Patch bug-125383-20131207112606.patch text/plain 1501 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MDI2OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTEyLTA3ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gT3Bl bkdMIGNvbXBpbGUgZXJyb3IuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjUzODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9w ZW5HTENvbW1vbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6dGV4 U3ViSW1hZ2UyRCk6IE9uIFdpbmRvd3MsIGNoZWNrIHRoYXQgR0xfSEFMRl9GTE9BVF9BUkIgaXMg ZGVmaW5lZCBiZWZvcmUgdXNpbmcgaXQuCisKIDIwMTMtMTItMDYgIFRpbSBIb3J0b24gIDx0aW1v dGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgW21hY10gS2VlcCBhcm91bmQgbW9yZSBk ZWNvZGVkIGltYWdlIGRhdGEsIHNpbmNlIGl0J3MgcHVyZ2VhYmxlCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0xDb21t b24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29w ZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHAJKHJldmlzaW9uIDE2MDI2OCkK KysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRl eHQzRE9wZW5HTENvbW1vbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzNjUsOCArMTM2NSwxMCBA QCB2b2lkIEdyYXBoaWNzQ29udGV4dDNEOjp0ZXhTdWJJbWFnZTJEKEdDCiB7CiAgICAgbWFrZUNv bnRleHRDdXJyZW50KCk7CiAKKyNpZiAhUExBVEZPUk0oV0lOKSB8fCBkZWZpbmVkKEdMX0hBTEZf RkxPQVRfQVJCKQogICAgIGlmICh0eXBlID09IEhBTEZfRkxPQVRfT0VTKQogICAgICAgICB0eXBl ID0gR0xfSEFMRl9GTE9BVF9BUkI7CisjZW5kaWYKIAogICAgIC8vIEZJWE1FOiB3ZSB3aWxsIG5l ZWQgdG8gZGVhbCB3aXRoIFBpeGVsU3RvcmUgcGFyYW1zIHdoZW4gZGVhbGluZyB3aXRoIGltYWdl IGJ1ZmZlcnMgdGhhdCBkaWZmZXIgZnJvbSB0aGUgc3ViaW1hZ2Ugc2l6ZS4KICAgICA6OmdsVGV4 U3ViSW1hZ2UyRCh0YXJnZXQsIGxldmVsLCB4b2ZmLCB5b2ZmLCB3aWR0aCwgaGVpZ2h0LCBmb3Jt YXQsIHR5cGUsIHBpeGVscyk7Cg== 218782 2013-12-09 11:34:48 -0800 2013-12-09 12:14:53 -0800 Patch bug-125383-20131209203442.patch text/plain 1303 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MDMyMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEzLTEyLTA5ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gT3Bl bkdMIGNvbXBpbGUgZXJyb3IuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjUzODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNpb25zM0RPcGVuR0xF Uy5oOiBEZWZpbmUgR0xfSEFMRl9GTE9BVF9BUkIgb24gV2luZG93cyB3aGVuIE9QRU5HTF9FU18y IGlzIHVzZWQuCisKIDIwMTMtMTItMDkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxl LmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbnNwZWN0b3IuanNvbiBhbmQgQ29kZUdl bmVyYXRvciB0d2Vha3MKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29w ZW5nbC9FeHRlbnNpb25zM0RPcGVuR0xFUy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNpb25zM0RPcGVuR0xFUy5oCShyZXZpc2lv biAxNjAyNjgpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0 ZW5zaW9uczNET3BlbkdMRVMuaAkod29ya2luZyBjb3B5KQpAQCAtMzksNiArMzksMTIgQEAKICNk ZWZpbmUgUEZOR0xSRU5ERVJCVUZGRVJTVE9SQUdFTVVMVElTQU1QTEVJTUcgUEZOR0xSRU5ERVJC VUZGRVJTVE9SQUdFTVVMVElTQU1QTEVJTUdQUk9DCiAjZW5kaWYKIAorI2lmIFBMQVRGT1JNKFdJ TikgJiYgVVNFKE9QRU5HTF9FU18yKQorI2lmbmRlZiBHTF9BUkJfaGFsZl9mbG9hdF9waXhlbAor I2RlZmluZSBHTF9IQUxGX0ZMT0FUX0FSQiAgICAgICAgICAgICAgICAgMHgxNDBCCisjZW5kaWYK KyNlbmRpZgorCiAjaWZuZGVmIEdMX0VYVF9yb2J1c3RuZXNzCiAvKiByZXVzZSBHTF9OT19FUlJP UiAqLwogI2RlZmluZSBHTF9HVUlMVFlfQ09OVEVYVF9SRVNFVF9FWFQgMHg4MjUzCg==