125381 2013-12-06 22:26:30 -0800 CStack Branch: Fix Specialized Thunks to use function prologues and epilogues 2014-01-13 18:46:20 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff buildbot eflews.bot ggaren gtk-ews gyuyoung.kim mark.lam philn rniwa xan.lopez oldest_to_newest 957482 0 msaboff 2013-12-06 22:26:30 -0800 The SpecializedThunkJIT generator isn't using the function prologue / epilogue for the native convention. 957483 1 218651 msaboff 2013-12-06 22:29:53 -0800 Created attachment 218651 Patch With this change, the LLInt can run v8-crypto.js to completion. 957484 2 218651 eflews.bot 2013-12-06 22:33:17 -0800 Comment on attachment 218651 Patch Attachment 218651 did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/46408019 957485 3 218651 eflews.bot 2013-12-06 22:34:34 -0800 Comment on attachment 218651 Patch Attachment 218651 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/46428014 957487 4 218651 gtk-ews 2013-12-06 22:37:51 -0800 Comment on attachment 218651 Patch Attachment 218651 did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/46468014 957488 5 msaboff 2013-12-06 22:39:31 -0800 Patch landed in change set r160268 <http://trac.webkit.org/changeset/160268>. 957490 6 218651 buildbot 2013-12-06 23:00:45 -0800 Comment on attachment 218651 Patch Attachment 218651 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/46468015 957493 7 218651 buildbot 2013-12-06 23:09:58 -0800 Comment on attachment 218651 Patch Attachment 218651 did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/46418014 957494 8 218651 buildbot 2013-12-06 23:28:05 -0800 Comment on attachment 218651 Patch Attachment 218651 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/46468016 957524 9 218651 ggaren 2013-12-07 10:51:27 -0800 Comment on attachment 218651 Patch r=me 957525 10 ggaren 2013-12-07 10:51:41 -0800 > With this change, the LLInt can run v8-crypto.js to completion. Nice! 967612 11 mark.lam 2014-01-13 18:46:20 -0800 Review status updated in r161938: <http://trac.webkit.org/r161938>. 218651 2013-12-06 22:29:53 -0800 2013-12-07 10:51:27 -0800 Patch 125381.patch text/plain 3425 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwMjY3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDEzLTEyLTA2ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENTdGFjayBCcmFuY2g6IEZpeCBTcGVjaWFsaXplZCBUaHVua3MgdG8gdXNlIGZ1bmN0aW9u IHByb2xvZ3VlcyBhbmQgZXBpbG9ndWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjUzODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBDaGFuZ2VkIHRoZSBlbnRyeSAvIGV4aXQgc2VxdWVuY2VzIHRvIHVz ZSBlbWl0RnVuY3Rpb25Qcm9sb2d1ZSgpIGFuZAorICAgICAgICBmdW5jdGlvbkVwaWxvZ3VlKCku CisKKyAgICAgICAgKiBqaXQvU3BlY2lhbGl6ZWRUaHVua0pJVC5oOgorICAgICAgICAoSlNDOjpT cGVjaWFsaXplZFRodW5rSklUOjpTcGVjaWFsaXplZFRodW5rSklUKToKKyAgICAgICAgKEpTQzo6 U3BlY2lhbGl6ZWRUaHVua0pJVDo6cmV0dXJuSlNWYWx1ZSk6CisgICAgICAgIChKU0M6OlNwZWNp YWxpemVkVGh1bmtKSVQ6OnJldHVybkRvdWJsZSk6CisgICAgICAgIChKU0M6OlNwZWNpYWxpemVk VGh1bmtKSVQ6OnJldHVybkludDMyKToKKyAgICAgICAgKEpTQzo6U3BlY2lhbGl6ZWRUaHVua0pJ VDo6cmV0dXJuSlNDZWxsKToKKwogMjAxMy0xMi0wNiAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2Zm QGFwcGxlLmNvbT4KIAogICAgICAgICBDU3RhY2sgQnJhbmNoOiBFbmFibGUgYmFzaWMgSmF2YVNj cmlwdCBmdW5jdGlvbmFsaXR5IGluIExMSW50CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv aml0L1NwZWNpYWxpemVkVGh1bmtKSVQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvaml0L1NwZWNpYWxpemVkVGh1bmtKSVQuaAkocmV2aXNpb24gMTYwMjUxKQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9TcGVjaWFsaXplZFRodW5rSklULmgJKHdvcmtpbmcgY29w eSkKQEAgLTQxLDYgKzQxLDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIFNwZWNpYWxpemVk VGh1bmtKSVQoVk0qIHZtLCBpbnQgZXhwZWN0ZWRBcmdDb3VudCkKICAgICAgICAgICAgIDogSlNJ bnRlcmZhY2VKSVQodm0pCiAgICAgICAgIHsKKyAgICAgICAgICAgIGVtaXRGdW5jdGlvblByb2xv Z3VlKCk7CiAgICAgICAgICAgICAvLyBDaGVjayB0aGF0IHdlIGhhdmUgdGhlIGV4cGVjdGVkIG51 bWJlciBvZiBhcmd1bWVudHMKICAgICAgICAgICAgIG1fZmFpbHVyZXMuYXBwZW5kKGJyYW5jaDMy KE5vdEVxdWFsLCBwYXlsb2FkRm9yKEpTU3RhY2s6OkFyZ3VtZW50Q291bnQpLCBUcnVzdGVkSW1t MzIoZXhwZWN0ZWRBcmdDb3VudCArIDEpKSk7CiAgICAgICAgIH0KQEAgLTQ4LDYgKzQ5LDcgQEAg bmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIGV4cGxpY2l0IFNwZWNpYWxpemVkVGh1bmtKSVQoVk0q IHZtKQogICAgICAgICAgICAgOiBKU0ludGVyZmFjZUpJVCh2bSkKICAgICAgICAgeworICAgICAg ICAgICAgZW1pdEZ1bmN0aW9uUHJvbG9ndWUoKTsKICAgICAgICAgfQogICAgICAgICAKICAgICAg ICAgdm9pZCBsb2FkRG91YmxlQXJndW1lbnQoaW50IGFyZ3VtZW50LCBGUFJlZ2lzdGVySUQgZHN0 LCBSZWdpc3RlcklEIHNjcmF0Y2gpCkBAIC05Nyw3ICs5OSw3IEBAIG5hbWVzcGFjZSBKU0Mgewog ICAgICAgICB7CiAgICAgICAgICAgICBpZiAoc3JjICE9IHJlZ1QwKQogICAgICAgICAgICAgICAg IG1vdmUoc3JjLCByZWdUMCk7Ci0gICAgICAgICAgICBsb2FkUHRyKEFkZHJlc3MoY2FsbEZyYW1l UmVnaXN0ZXIsIENhbGxGcmFtZTo6Y2FsbGVyRnJhbWVPZmZzZXQoKSksIGNhbGxGcmFtZVJlZ2lz dGVyKTsKKyAgICAgICAgICAgIGVtaXRGdW5jdGlvbkVwaWxvZ3VlKCk7CiAgICAgICAgICAgICBy ZXQoKTsKICAgICAgICAgfQogI2Vsc2UKQEAgLTEwNSw3ICsxMDcsNyBAQCBuYW1lc3BhY2UgSlND IHsKICAgICAgICAgewogICAgICAgICAgICAgQVNTRVJUX1VOVVNFRChwYXlsb2FkLCBwYXlsb2Fk ID09IHJlZ1QwKTsKICAgICAgICAgICAgIEFTU0VSVF9VTlVTRUQodGFnLCB0YWcgPT0gcmVnVDEp OwotICAgICAgICAgICAgbG9hZFB0cihBZGRyZXNzKGNhbGxGcmFtZVJlZ2lzdGVyLCBDYWxsRnJh bWU6OmNhbGxlckZyYW1lT2Zmc2V0KCkpLCBjYWxsRnJhbWVSZWdpc3Rlcik7CisgICAgICAgICAg ICBlbWl0RnVuY3Rpb25FcGlsb2d1ZSgpOwogICAgICAgICAgICAgcmV0KCk7CiAgICAgICAgIH0K ICNlbmRpZgpAQCAtMTM2LDcgKzEzOCw3IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICAgICAg bG93Tm9uWmVyby5saW5rKHRoaXMpOwogICAgICAgICAgICAgaGlnaE5vblplcm8ubGluayh0aGlz KTsKICNlbmRpZgotICAgICAgICAgICAgbG9hZFB0cihBZGRyZXNzKGNhbGxGcmFtZVJlZ2lzdGVy LCBDYWxsRnJhbWU6OmNhbGxlckZyYW1lT2Zmc2V0KCkpLCBjYWxsRnJhbWVSZWdpc3Rlcik7Cisg ICAgICAgICAgICBlbWl0RnVuY3Rpb25FcGlsb2d1ZSgpOwogICAgICAgICAgICAgcmV0KCk7CiAg ICAgICAgIH0KIApAQCAtMTQ1LDcgKzE0Nyw3IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICAg ICAgaWYgKHNyYyAhPSByZWdUMCkKICAgICAgICAgICAgICAgICBtb3ZlKHNyYywgcmVnVDApOwog ICAgICAgICAgICAgdGFnUmV0dXJuQXNJbnQzMigpOwotICAgICAgICAgICAgbG9hZFB0cihBZGRy ZXNzKGNhbGxGcmFtZVJlZ2lzdGVyLCBDYWxsRnJhbWU6OmNhbGxlckZyYW1lT2Zmc2V0KCkpLCBj YWxsRnJhbWVSZWdpc3Rlcik7CisgICAgICAgICAgICBlbWl0RnVuY3Rpb25FcGlsb2d1ZSgpOwog ICAgICAgICAgICAgcmV0KCk7CiAgICAgICAgIH0KIApAQCAtMTU0LDcgKzE1Niw3IEBAIG5hbWVz cGFjZSBKU0MgewogICAgICAgICAgICAgaWYgKHNyYyAhPSByZWdUMCkKICAgICAgICAgICAgICAg ICBtb3ZlKHNyYywgcmVnVDApOwogICAgICAgICAgICAgdGFnUmV0dXJuQXNKU0NlbGwoKTsKLSAg ICAgICAgICAgIGxvYWRQdHIoQWRkcmVzcyhjYWxsRnJhbWVSZWdpc3RlciwgQ2FsbEZyYW1lOjpj YWxsZXJGcmFtZU9mZnNldCgpKSwgY2FsbEZyYW1lUmVnaXN0ZXIpOworICAgICAgICAgICAgZW1p dEZ1bmN0aW9uRXBpbG9ndWUoKTsKICAgICAgICAgICAgIHJldCgpOwogICAgICAgICB9CiAgICAg ICAgIAo=