125372 2013-12-06 16:16:39 -0800 Remove statusWithDirection static function from RenderBlockLineLayout 2013-12-07 21:50:38 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zoltan zoltan commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 957424 0 zoltan 2013-12-06 16:16:39 -0800 I run into a FIXME about using BidiStatus constructor rather than statusWithDirection, once it's implemented. BidiStatus has got the appropriate constructor now, so I removed statusWithDirection and updated the code to use the constructor of BidiStatus. 957425 1 218631 zoltan 2013-12-06 16:19:12 -0800 Created attachment 218631 Patch 957572 2 218631 commit-queue 2013-12-07 21:50:37 -0800 Comment on attachment 218631 Patch Clearing flags on attachment: 218631 Committed r160279: <http://trac.webkit.org/changeset/160279> 957573 3 commit-queue 2013-12-07 21:50:38 -0800 All reviewed patches have been landed. Closing bug. 218631 2013-12-06 16:19:12 -0800 2013-12-07 21:50:37 -0800 Patch statuswith.patch text/plain 2762 zoltan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5M2RmNDc3Li5kNjgyNjlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMTItMDYgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgUmVtb3ZlIHN0YXR1c1dpdGhEaXJlY3Rpb24gc3RhdGljIGZ1bmN0aW9uIGZyb20gUmVu ZGVyQmxvY2tMaW5lTGF5b3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjUzNzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJIHJ1biBpbnRvIGEgRklYTUUgYWJvdXQgdXNpbmcgQmlkaVN0YXR1cyBjb25z dHJ1Y3RvciByYXRoZXIgdGhhbiBzdGF0dXNXaXRoRGlyZWN0aW9uLAorICAgICAgICBvbmNlIGl0 J3MgaW1wbGVtZW50ZWQuIEJpZGlTdGF0dXMgaGFzIGdvdCB0aGUgYXBwcm9wcmlhdGUgY29uc3Ry dWN0b3Igbm93LCBzbyBJIHJlbW92ZWQKKyAgICAgICAgc3RhdHVzV2l0aERpcmVjdGlvbiBhbmQg dXBkYXRlZCB0aGUgY29kZSB0byB1c2UgdGhlIGNvbnN0cnVjdG9yIG9mIEJpZGlTdGF0dXMuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNv bnN0cnVjdEJpZGlSdW5zRm9yU2VnbWVudCk6CisKIDIwMTMtMTItMDYgIEFsZXhleSBQcm9za3Vy eWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHNvbWUgZHVwbGljYXRlIGNo ZWNrcyBmcm9tIFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcAppbmRleCA0YmZkNGY5Li5kYjUwODll IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5 b3V0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5 b3V0LmNwcApAQCAtODY1LDE2ICs4NjUsNiBAQCB2b2lkIFJlbmRlckJsb2NrRmxvdzo6YXBwZW5k RmxvYXRpbmdPYmplY3RUb0xhc3RMaW5lKEZsb2F0aW5nT2JqZWN0KiBmbG9hdGluZ09iagogICAg IGxhc3RSb290Qm94KCktPmFwcGVuZEZsb2F0KGZsb2F0aW5nT2JqZWN0LT5yZW5kZXJlcigpKTsK IH0KIAotLy8gRklYTUU6IFRoaXMgc2hvdWxkIGJlIGEgQmlkaVN0YXR1cyBjb25zdHJ1Y3RvciBv ciBjcmVhdGUgbWV0aG9kLgotc3RhdGljIGlubGluZSBCaWRpU3RhdHVzIHN0YXR1c1dpdGhEaXJl Y3Rpb24oVGV4dERpcmVjdGlvbiB0ZXh0RGlyZWN0aW9uLCBib29sIGlzT3ZlcnJpZGUpCi17Ci0g ICAgVUNoYXJEaXJlY3Rpb24gZGlyZWN0aW9uID0gdGV4dERpcmVjdGlvbiA9PSBMVFIgPyBVX0xF RlRfVE9fUklHSFQgOiBVX1JJR0hUX1RPX0xFRlQ7Ci0gICAgUmVmUHRyPEJpZGlDb250ZXh0PiBj b250ZXh0ID0gQmlkaUNvbnRleHQ6OmNyZWF0ZSh0ZXh0RGlyZWN0aW9uID09IExUUiA/IDAgOiAx LCBkaXJlY3Rpb24sIGlzT3ZlcnJpZGUsIEZyb21TdHlsZU9yRE9NKTsKLQotICAgIC8vIFRoaXMg Y29waWVzIEJpZGlTdGF0dXMgYW5kIG1heSBjaHVybiB0aGUgcmVmIG9uIEJpZGlDb250ZXh0LiBJ IGRvdWJ0IGl0IG1hdHRlcnMuCi0gICAgcmV0dXJuIEJpZGlTdGF0dXMoZGlyZWN0aW9uLCBkaXJl Y3Rpb24sIGRpcmVjdGlvbiwgY29udGV4dC5yZWxlYXNlKCkpOwotfQotCiAvLyBGSVhNRTogQmlk aVJlc29sdmVyIHNob3VsZCBoYXZlIHRoaXMgbG9naWMuCiBzdGF0aWMgaW5saW5lIHZvaWQgY29u c3RydWN0QmlkaVJ1bnNGb3JTZWdtZW50KElubGluZUJpZGlSZXNvbHZlciYgdG9wUmVzb2x2ZXIs IEJpZGlSdW5MaXN0PEJpZGlSdW4+JiBiaWRpUnVucywgY29uc3QgSW5saW5lSXRlcmF0b3ImIGVu ZE9mUnVucywgVmlzdWFsRGlyZWN0aW9uT3ZlcnJpZGUgb3ZlcnJpZGUsIGJvb2wgcHJldmlvdXNM aW5lQnJva2VDbGVhbmx5KQogewpAQCAtOTA3LDcgKzg5Nyw3IEBAIHN0YXRpYyBpbmxpbmUgdm9p ZCBjb25zdHJ1Y3RCaWRpUnVuc0ZvclNlZ21lbnQoSW5saW5lQmlkaVJlc29sdmVyJiB0b3BSZXNv bHZlciwKICAgICAgICAgICAgIEFTU0VSVCh1bmljb2RlQmlkaSA9PSBJc29sYXRlIHx8IHVuaWNv ZGVCaWRpID09IElzb2xhdGVPdmVycmlkZSk7CiAgICAgICAgICAgICBkaXJlY3Rpb24gPSBpc29s YXRlZElubGluZS0+c3R5bGUoKS5kaXJlY3Rpb24oKTsKICAgICAgICAgfQotICAgICAgICBpc29s YXRlZFJlc29sdmVyLnNldFN0YXR1cyhzdGF0dXNXaXRoRGlyZWN0aW9uKGRpcmVjdGlvbiwgaXNP dmVycmlkZSh1bmljb2RlQmlkaSkpKTsKKyAgICAgICAgaXNvbGF0ZWRSZXNvbHZlci5zZXRTdGF0 dXMoQmlkaVN0YXR1cyhkaXJlY3Rpb24sIGlzT3ZlcnJpZGUodW5pY29kZUJpZGkpKSk7CiAKICAg ICAgICAgLy8gRklYTUU6IFRoZSBmYWN0IHRoYXQgd2UgaGF2ZSB0byBjb25zdHJ1Y3QgYW4gSXRl cmF0b3IgaGVyZQogICAgICAgICAvLyBjdXJyZW50bHkgcHJldmVudHMgdGhpcyBjb2RlIGZyb20g bW92aW5nIGludG8gQmlkaVJlc29sdmVyLgo=