125358 2013-12-06 11:54:00 -0800 Remove some duplicate checks from SerializedScriptValue 2013-12-06 14:31:36 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap alecflett commit-queue ggaren jsbell oliver oldest_to_newest 957330 0 ap 2013-12-06 11:54:00 -0800 WebCore toXXX() functions incorporate inherits(). 957332 1 218609 ap 2013-12-06 12:00:21 -0800 Created attachment 218609 proposed patch 957347 2 218609 ggaren 2013-12-06 12:34:35 -0800 Comment on attachment 218609 proposed patch r=me 957400 3 ap 2013-12-06 14:31:36 -0800 Committed <http://trac.webkit.org/changeset/160250>. 218609 2013-12-06 12:00:21 -0800 2013-12-06 12:34:35 -0800 proposed patch NoInherits.txt text/plain 3792 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MDIzNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTEyLTA2ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBzb21lIGR1cGxp Y2F0ZSBjaGVja3MgZnJvbSBTZXJpYWxpemVkU2NyaXB0VmFsdWUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTM1OAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGlzIG5vIG5lZWQgdG8gY2FsbCBp bmhlcml0cygpIGJlZm9yZSBXZWJDb3JlJ3MgdG9YWFgoSlNWYWx1ZSkgZnVuY3Rpb25zLgorCisg ICAgICAgIEFsc28sIHRoZSByZXN1bHQgb2YgdG9BcnJheUJ1ZmZlcigpIGlzIGEgcmF3IHBvaW50 ZXIsIG5vdCBhIFJlZlB0ciAoaXQncyBjb25mdXNpbmcKKyAgICAgICAgYmVjYXVzZSB0b0FycmF5 QnVmZmVyVmlldyByZXR1cm5zIGEgUmVmUHRyKS4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL1Nl cmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHA6IChXZWJDb3JlOjpDbG9uZVNlcmlhbGl6ZXI6OmR1bXBJ ZlRlcm1pbmFsKToKKwogMjAxMy0xMi0wNiAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5Ad2Via2l0 Lm9yZz4KIAogICAgICAgICBDbGVhbiB1cCB0aGUgaW5jbHVkZXMgb2YgUmVuZGVyQmxvY2suaCAK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2VyaWFsaXplZFNj cmlwdFZhbHVlLmNwcAkocmV2aXNpb24gMTYwMDExKQorKysgU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU2LDcg KzE1Niw3IEBAIHN0YXRpYyB1bnNpZ25lZCB0eXBlZEFycmF5RWxlbWVudFNpemUoQXIKIAogfQog Ci0vKiBDdXJyZW50VmVyc2lvbiB0cmFja3MgdGhlIHNlcmlhbGl6YXRpb24gdmVyc2lvbiBzbyB0 aGF0IHBlcnNpc3RhbnQgc3RvcmVzCisvKiBDdXJyZW50VmVyc2lvbiB0cmFja3MgdGhlIHNlcmlh bGl6YXRpb24gdmVyc2lvbiBzbyB0aGF0IHBlcnNpc3RlbnQgc3RvcmVzCiAgKiBhcmUgYWJsZSB0 byBjb3JyZWN0bHkgYmFpbCBvdXQgaW4gdGhlIGNhc2Ugb2YgZW5jb3VudGVyaW5nIG5ld2VyIGZv cm1hdHMuCiAgKgogICogSW5pdGlhbCB2ZXJzaW9uIHdhcyAxLgpAQCAtNjQ0LDEzICs2NDQsMTIg QEAgcHJpdmF0ZToKICAgICAgICAgICAgICAgICB3cml0ZShvYmotPmludGVybmFsVmFsdWUoKS5h c051bWJlcigpKTsKICAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgICAgIH0K LSAgICAgICAgICAgIGlmIChvYmotPmluaGVyaXRzKEpTRmlsZTo6aW5mbygpKSkgeworICAgICAg ICAgICAgaWYgKEZpbGUqIGZpbGUgPSB0b0ZpbGUob2JqKSkgewogICAgICAgICAgICAgICAgIHdy aXRlKEZpbGVUYWcpOwotICAgICAgICAgICAgICAgIHdyaXRlKHRvRmlsZShvYmopKTsKKyAgICAg ICAgICAgICAgICB3cml0ZShmaWxlKTsKICAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAg ICAgICAgICAgIH0KLSAgICAgICAgICAgIGlmIChvYmotPmluaGVyaXRzKEpTRmlsZUxpc3Q6Omlu Zm8oKSkpIHsKLSAgICAgICAgICAgICAgICBGaWxlTGlzdCogbGlzdCA9IHRvRmlsZUxpc3Qob2Jq KTsKKyAgICAgICAgICAgIGlmIChGaWxlTGlzdCogbGlzdCA9IHRvRmlsZUxpc3Qob2JqKSkgewog ICAgICAgICAgICAgICAgIHdyaXRlKEZpbGVMaXN0VGFnKTsKICAgICAgICAgICAgICAgICB1bnNp Z25lZCBsZW5ndGggPSBsaXN0LT5sZW5ndGgoKTsKICAgICAgICAgICAgICAgICB3cml0ZShsZW5n dGgpOwpAQCAtNjU4LDE3ICs2NTcsMTUgQEAgcHJpdmF0ZToKICAgICAgICAgICAgICAgICAgICAg d3JpdGUobGlzdC0+aXRlbShpKSk7CiAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAg ICAgICAgICB9Ci0gICAgICAgICAgICBpZiAob2JqLT5pbmhlcml0cyhKU0Jsb2I6OmluZm8oKSkp IHsKKyAgICAgICAgICAgIGlmIChCbG9iKiBibG9iID0gdG9CbG9iKG9iaikpIHsKICAgICAgICAg ICAgICAgICB3cml0ZShCbG9iVGFnKTsKLSAgICAgICAgICAgICAgICBCbG9iKiBibG9iID0gdG9C bG9iKG9iaik7CiAgICAgICAgICAgICAgICAgbV9ibG9iVVJMcy5hcHBlbmQoYmxvYi0+dXJsKCkp OwogICAgICAgICAgICAgICAgIHdyaXRlKGJsb2ItPnVybCgpKTsKICAgICAgICAgICAgICAgICB3 cml0ZShibG9iLT50eXBlKCkpOwogICAgICAgICAgICAgICAgIHdyaXRlKGJsb2ItPnNpemUoKSk7 CiAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgICAgICB9Ci0gICAgICAgICAg ICBpZiAob2JqLT5pbmhlcml0cyhKU0ltYWdlRGF0YTo6aW5mbygpKSkgewotICAgICAgICAgICAg ICAgIEltYWdlRGF0YSogZGF0YSA9IHRvSW1hZ2VEYXRhKG9iaik7CisgICAgICAgICAgICBpZiAo SW1hZ2VEYXRhKiBkYXRhID0gdG9JbWFnZURhdGEob2JqKSkgewogICAgICAgICAgICAgICAgIHdy aXRlKEltYWdlRGF0YVRhZyk7CiAgICAgICAgICAgICAgICAgd3JpdGUoZGF0YS0+d2lkdGgoKSk7 CiAgICAgICAgICAgICAgICAgd3JpdGUoZGF0YS0+aGVpZ2h0KCkpOwpAQCAtNzAyLDggKzY5OSw3 IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAgICAgY29kZSA9IFZhbGlkYXRpb25FcnJvcjsKICAg ICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgICAgIH0KLSAgICAgICAgICAgIGlm IChvYmotPmluaGVyaXRzKEpTQXJyYXlCdWZmZXI6OmluZm8oKSkpIHsKLSAgICAgICAgICAgICAg ICBSZWZQdHI8QXJyYXlCdWZmZXI+IGFycmF5QnVmZmVyID0gdG9BcnJheUJ1ZmZlcihvYmopOwor ICAgICAgICAgICAgaWYgKEFycmF5QnVmZmVyKiBhcnJheUJ1ZmZlciA9IHRvQXJyYXlCdWZmZXIo b2JqKSkgewogICAgICAgICAgICAgICAgIGlmIChhcnJheUJ1ZmZlci0+aXNOZXV0ZXJlZCgpKSB7 CiAgICAgICAgICAgICAgICAgICAgIGNvZGUgPSBWYWxpZGF0aW9uRXJyb3I7CiAgICAgICAgICAg ICAgICAgICAgIHJldHVybiB0cnVlOwpAQCAtNzE4LDcgKzcxNCw3IEBAIHByaXZhdGU6CiAgICAg ICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICAgICAgICAgIHdyaXRlKEFycmF5 QnVmZmVyVGFnKTsKICAgICAgICAgICAgICAgICB3cml0ZShhcnJheUJ1ZmZlci0+Ynl0ZUxlbmd0 aCgpKTsKLSAgICAgICAgICAgICAgICB3cml0ZShzdGF0aWNfY2FzdDxjb25zdCB1aW50OF90ICo+ KGFycmF5QnVmZmVyLT5kYXRhKCkpLCBhcnJheUJ1ZmZlci0+Ynl0ZUxlbmd0aCgpKTsKKyAgICAg ICAgICAgICAgICB3cml0ZShzdGF0aWNfY2FzdDxjb25zdCB1aW50OF90Kj4oYXJyYXlCdWZmZXIt PmRhdGEoKSksIGFycmF5QnVmZmVyLT5ieXRlTGVuZ3RoKCkpOwogICAgICAgICAgICAgICAgIHJl dHVybiB0cnVlOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgaWYgKG9iai0+aW5oZXJpdHMo SlNBcnJheUJ1ZmZlclZpZXc6OmluZm8oKSkpIHsK