125345 2013-12-06 06:32:05 -0800 Define SHA1 hash size in SHA1.h and use it at various places. 2013-12-06 10:56:36 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 lvidacs.u-szeged webkit-unassigned commit-queue fpizlo ggaren lvidacs.u-szeged pnormand oldest_to_newest 957225 0 lvidacs.u-szeged 2013-12-06 06:32:05 -0800 SHA1 size is used at various places but usually defined as a local variable. A common constant in SHA1.h used by all parties would be a better solution. 957226 1 218593 lvidacs.u-szeged 2013-12-06 06:45:34 -0800 Created attachment 218593 Patch 957246 2 218593 andersca 2013-12-06 08:49:21 -0800 Comment on attachment 218593 Patch I like this change, but could you also make computeHash take an std::array<uint8_t, hashSize>. There's no need for it to take a Vector. 957300 3 218593 commit-queue 2013-12-06 10:51:40 -0800 Comment on attachment 218593 Patch Clearing flags on attachment: 218593 Committed r160228: <http://trac.webkit.org/changeset/160228> 957306 4 commit-queue 2013-12-06 10:56:36 -0800 All reviewed patches have been landed. Closing bug. 218593 2013-12-06 06:45:34 -0800 2013-12-06 10:51:25 -0800 Patch bug-125345-20131206154529.patch text/plain 5830 lvidacs.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMjIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 YzQzNjdkZDY0ZTBmYmNjY2FjYmViMzgxZjVkNjQ2NzU3Y2MzNThiLi4wMmQxZGM1ZWI1NjI0NDRk NmEwNTlkYTlmNGEyY2QzMjk1YjE1NjU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMy0xMi0wNiAgTGFzemxvIFZpZGFjcyAgPGxhY0BpbmYudS1zemVnZWQu aHU+CisKKyAgICAgICAgRGVmaW5lIFNIQTEgaGFzaCBzaXplIGluIFNIQTEuaCBhbmQgdXNlIGl0 IGF0IHZhcmlvdXMgcGxhY2VzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTI1MzQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVXNlIFNIQTE6Omhhc2hTaXplIGluc3RlYWQgb2YgbG9jYWwgdmFyaWFibGVz LgorCisgICAgICAgICogYnl0ZWNvZGUvQ29kZUJsb2NrSGFzaC5jcHA6CisgICAgICAgIChKU0M6 OkNvZGVCbG9ja0hhc2g6OkNvZGVCbG9ja0hhc2gpOiB1c2UgU0hBMTo6aGFzaFNpemUKKwogMjAx My0xMi0wNSAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBK U0M6IFNpbXBsaWZ5IGludGVyZmFjZSBiZXR3ZWVuIHRocm93IGFuZCBjYXRjaCBoYW5kbGVyCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmlu ZGV4IDVjZTk0YWEwMTRkNTA0NGViMjdkYWEyNmQ0YzUzZWVlOTI3ZWI2NWYuLjNjNzU0YThkNzc4 ZDIyZTM2ZDZkNjBmYTBjMmZmNWYyNWM1NDRlMzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMt MTItMDYgIExhc3psbyBWaWRhY3MgIDxsYWNAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIERl ZmluZSBTSEExIGhhc2ggc2l6ZSBpbiBTSEExLmggYW5kIHVzZSBpdCBhdCB2YXJpb3VzIHBsYWNl cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTM0 NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBT SEExOjpoYXNoU2l6ZSBpbnN0ZWFkIG9mIGxvY2FsIHZhcmlhYmxlcy4KKworICAgICAgICAqIHd0 Zi9TSEExLmg6IGRlZmluZSBTSEExIGhhc2ggc2l6ZQorCiAyMDEzLTEyLTA1ICBJYWluIExhbmUg IDxpYWluLmxhbmVAY2Fub25pY2FsLmNvbT4KIAogICAgICAgICBSZW1vdmUgVVNFKExPQ0tGUkVF X1RIUkVBRFNBRkVSRUZDT1VOVEVEKSBmcm9tIEF0b21pY3MuY3BwIHNpbmNlIGl0IGlzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKaW5kZXggY2Y2NDUzYzY2MjJhZmRhYmRjY2QyZDk0Y2E0OTY5ZWQ3YzQ4YTA3NC4uNmM1ODg1 MjU5YjcyMDljMzgwNjAzYWZmOGI5MDJjMzdkNzYyYjg2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE3IEBACisyMDEzLTEyLTA2ICBMYXN6bG8gVmlkYWNzICA8bGFjQGluZi51LXN6ZWdlZC5odT4K KworICAgICAgICBEZWZpbmUgU0hBMSBoYXNoIHNpemUgaW4gU0hBMS5oIGFuZCB1c2UgaXQgYXQg dmFyaW91cyBwbGFjZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjUzNDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBVc2UgU0hBMTo6aGFzaFNpemUgaW5zdGVhZCBvZiBsb2NhbCB2YXJpYWJsZXMuCisK KyAgICAgICAgKiBNb2R1bGVzL3dlYnNvY2tldHMvV2ViU29ja2V0SGFuZHNoYWtlLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OldlYlNvY2tldEhhbmRzaGFrZTo6Z2V0RXhwZWN0ZWRXZWJTb2NrZXRB Y2NlcHQpOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNv dXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SG9zdFRMU0NlcnRpZmljYXRlU2V0Ojpjb21wdXRl Q2VydGlmaWNhdGVIYXNoKToKKwogMjAxMy0xMi0wNiAgTHVrYXN6IEdham93eSAgPGwuZ2Fqb3d5 QHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtBVEtdIE1pc3NpbmcgYXJpYSByb2xlcyBtYXBwaW5n cwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9ja0hh c2guY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9ja0hhc2guY3Bw CmluZGV4IGYzMDE0ZmI0NjNmOTcwNGU1OWQ1YWRjOGU0OWY2MWJhYmY4ZjIwYjcuLjRkNTlmYWIx MDZjOGFkOGFkZGIxYzEyMTQyZDFjOTIwZGYwNzMxOTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2tIYXNoLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrSGFzaC5jcHAKQEAgLTQyLDcgKzQyLDcgQEAgQ29k ZUJsb2NrSGFzaDo6Q29kZUJsb2NrSGFzaChjb25zdCBTb3VyY2VDb2RlJiBzb3VyY2VDb2RlLCBD b2RlU3BlY2lhbGl6YXRpb25LaW4KIHsKICAgICBTSEExIHNoYTE7CiAgICAgc2hhMS5hZGRCeXRl cyhzb3VyY2VDb2RlLnRvVVRGOCgpKTsKLSAgICBWZWN0b3I8dWludDhfdCwgMjA+IGRpZ2VzdDsK KyAgICBWZWN0b3I8dWludDhfdCwgU0hBMTo6aGFzaFNpemU+IGRpZ2VzdDsKICAgICBzaGExLmNv bXB1dGVIYXNoKGRpZ2VzdCk7CiAgICAgbV9oYXNoICs9IGRpZ2VzdFswXSB8IChkaWdlc3RbMV0g PDwgOCkgfCAoZGlnZXN0WzJdIDw8IDE2KSB8IChkaWdlc3RbM10gPDwgMjQpOwogICAgIG1faGFz aCBePSBzdGF0aWNfY2FzdDx1bnNpZ25lZD4oa2luZCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RG L3d0Zi9TSEExLmggYi9Tb3VyY2UvV1RGL3d0Zi9TSEExLmgKaW5kZXggMTg2YTIwYThiMGMyODQ4 OGNhZWU3MjM0MmEzZTBkZWZhZDEwMWE5OS4uYjBkNGZiZmIwNzhjY2E4ZDQ3NTkwY2IxOWEzMGVm NjJhZGZlM2RlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvU0hBMS5oCisrKyBiL1NvdXJj ZS9XVEYvd3RmL1NIQTEuaApAQCAtNjQsNyArNjQsMTAgQEAgcHVibGljOgogICAgIAogICAgIC8v IENvbXB1dGUgdGhlIGhleCBkaWdlc3QgZGlyZWN0bHkuIFBhc3MgYSBsaW1pdCBsZXNzIHRoYW4g NDAgaWYgeW91IHdhbnQgYSBzaG9ydGVyIGRpZ2VzdC4KICAgICBXVEZfRVhQT1JUX1BSSVZBVEUg Q1N0cmluZyBjb21wdXRlSGV4RGlnZXN0KCk7Ci0gICAgCisKKyAgICAvLyBTaXplIG9mIHRoZSBT SEExIGhhc2gKKyAgICBXVEZfRVhQT1JUX1BSSVZBVEUgc3RhdGljIGNvbnN0IHNpemVfdCBoYXNo U2l6ZSA9IDIwOworCiBwcml2YXRlOgogICAgIHZvaWQgZmluYWxpemUoKTsKICAgICB2b2lkIHBy b2Nlc3NCbG9jaygpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJzb2Nr ZXRzL1dlYlNvY2tldEhhbmRzaGFrZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnNv Y2tldHMvV2ViU29ja2V0SGFuZHNoYWtlLmNwcAppbmRleCAxZGVmNDVlZTc3MWQ3MmNjZGMzMGE3 ZDQxNzllZGIxNzU3NmQzZGJjLi4xYzVkOWMyMTBjY2ZiYjFjNmYzNzMwNjM4NWUzNjVkMzhjZTcy YmI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnNvY2tldHMvV2ViU29j a2V0SGFuZHNoYWtlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnNvY2tldHMv V2ViU29ja2V0SGFuZHNoYWtlLmNwcApAQCAtMTA5LDE0ICsxMDksMTMgQEAgc3RhdGljIFN0cmlu ZyBnZW5lcmF0ZVNlY1dlYlNvY2tldEtleSgpCiBTdHJpbmcgV2ViU29ja2V0SGFuZHNoYWtlOjpn ZXRFeHBlY3RlZFdlYlNvY2tldEFjY2VwdChjb25zdCBTdHJpbmcmIHNlY1dlYlNvY2tldEtleSkK IHsKICAgICBzdGF0aWMgY29uc3QgY2hhciogY29uc3Qgd2ViU29ja2V0S2V5R1VJRCA9ICIyNThF QUZBNS1FOTE0LTQ3REEtOTVDQS1DNUFCMERDODVCMTEiOwotICAgIHN0YXRpYyBjb25zdCBzaXpl X3Qgc2hhMUhhc2hTaXplID0gMjA7IC8vIEZJWE1FOiBUaGlzIHNob3VsZCBiZSBkZWZpbmVkIGlu IFNIQTEuaC4KICAgICBTSEExIHNoYTE7CiAgICAgQ1N0cmluZyBrZXlEYXRhID0gc2VjV2ViU29j a2V0S2V5LmFzY2lpKCk7CiAgICAgc2hhMS5hZGRCeXRlcyhyZWludGVycHJldF9jYXN0PGNvbnN0 IHVpbnQ4X3QqPihrZXlEYXRhLmRhdGEoKSksIGtleURhdGEubGVuZ3RoKCkpOwogICAgIHNoYTEu YWRkQnl0ZXMocmVpbnRlcnByZXRfY2FzdDxjb25zdCB1aW50OF90Kj4od2ViU29ja2V0S2V5R1VJ RCksIHN0cmxlbih3ZWJTb2NrZXRLZXlHVUlEKSk7Ci0gICAgVmVjdG9yPHVpbnQ4X3QsIHNoYTFI YXNoU2l6ZT4gaGFzaDsKKyAgICBWZWN0b3I8dWludDhfdCwgU0hBMTo6aGFzaFNpemU+IGhhc2g7 CiAgICAgc2hhMS5jb21wdXRlSGFzaChoYXNoKTsKLSAgICByZXR1cm4gYmFzZTY0RW5jb2RlKGhh c2guZGF0YSgpLCBzaGExSGFzaFNpemUpOworICAgIHJldHVybiBiYXNlNjRFbmNvZGUoaGFzaC5k YXRhKCksIFNIQTE6Omhhc2hTaXplKTsKIH0KIAogV2ViU29ja2V0SGFuZHNoYWtlOjpXZWJTb2Nr ZXRIYW5kc2hha2UoY29uc3QgVVJMJiB1cmwsIGNvbnN0IFN0cmluZyYgcHJvdG9jb2wsIFNjcmlw dEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCmluZGV4IDRj ODgyMTY5OWFiNDFjZmExOTgzNjY0OTYxODMzODFhZTg3ZDYyNzMuLmMzMmIwMWNjYWJhM2RlMjIx NjhjZjcxYjhhZTUwYThmZGQ1Y2MyYjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCkBAIC0yMDUs MTQgKzIwNSwxMyBAQCBwcml2YXRlOgogICAgICAgICBpZiAoIWNlcnRpZmljYXRlRGF0YSkKICAg ICAgICAgICAgIHJldHVybiBTdHJpbmcoKTsKIAotICAgICAgICBzdGF0aWMgY29uc3Qgc2l6ZV90 IHNoYTFIYXNoU2l6ZSA9IDIwOwogICAgICAgICBTSEExIHNoYTE7CiAgICAgICAgIHNoYTEuYWRk Qnl0ZXMoY2VydGlmaWNhdGVEYXRhLT5kYXRhLCBjZXJ0aWZpY2F0ZURhdGEtPmxlbik7CiAKLSAg ICAgICAgVmVjdG9yPHVpbnQ4X3QsIHNoYTFIYXNoU2l6ZT4gZGlnZXN0OworICAgICAgICBWZWN0 b3I8dWludDhfdCwgU0hBMTo6aGFzaFNpemU+IGRpZ2VzdDsKICAgICAgICAgc2hhMS5jb21wdXRl SGFzaChkaWdlc3QpOwogCi0gICAgICAgIHJldHVybiBiYXNlNjRFbmNvZGUocmVpbnRlcnByZXRf Y2FzdDxjb25zdCBjaGFyKj4oZGlnZXN0LmRhdGEoKSksIHNoYTFIYXNoU2l6ZSk7CisgICAgICAg IHJldHVybiBiYXNlNjRFbmNvZGUocmVpbnRlcnByZXRfY2FzdDxjb25zdCBjaGFyKj4oZGlnZXN0 LmRhdGEoKSksIFNIQTE6Omhhc2hTaXplKTsKICAgICB9CiAKICAgICBIYXNoU2V0PFN0cmluZz4g bV9jZXJ0aWZpY2F0ZXM7Cg==