125341 2013-12-06 01:26:31 -0800 Remove function from style/checkers/cpp.py 2013-12-06 10:57:50 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tgergely.u-szeged webkit-unassigned cjerdonek commit-queue eric galpeter glenn oldest_to_newest 957181 0 tgergely.u-szeged 2013-12-06 01:26:31 -0800 There is a FIXME: to remove process_file_data from style/checkers/cpp.py. 957183 1 218579 tgergely.u-szeged 2013-12-06 01:55:10 -0800 Created attachment 218579 patch removes a function I have simply split the functionality of process_file_data into two parts: the checker is now created directly in the CppStyleTestBase unit test, while setting the module's global _unit_test_config is done from the constructor of CppChecker. Although currently it causes no problem, I think that setting the global from the constructor is not a nice nor safe solution. What could be done are: - move the global into the CppChecker class and propagate its value (through 3 functions) to the only place it is used (the 3 functions are used nowhere else), or - move all the functions (or almost all) into the CppChecker class, or - leave it as it is now. By the way, to set up some specific environments, the cpp_unittest uses both globals and parameter propagation. Is one of them preferred? 957304 2 218579 commit-queue 2013-12-06 10:54:45 -0800 Comment on attachment 218579 patch removes a function Clearing flags on attachment: 218579 Committed r160230: <http://trac.webkit.org/changeset/160230> 957308 3 commit-queue 2013-12-06 10:57:50 -0800 All reviewed patches have been landed. Closing bug. 218579 2013-12-06 01:55:10 -0800 2013-12-06 10:54:02 -0800 patch removes a function remove_function_from_cpp_style_checker.patch text/plain 3458 tgergely.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiOWQw NzJhLi40ZmYyNzZjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTMtMTItMDYgIFRhbWFzIEdlcmdlbHkgIDx0Z2Vy Z2VseS51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgorCisgICAgICAgIFJlbW92ZSBmdW5j dGlvbiBmcm9tIHN0eWxlL2NoZWNrZXJzL2NwcC5weS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTM0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIENvcnJlY3RzIGEgRklYTUU6IGJ5IHJlbW92aW5nIGEg ZnVuY3Rpb24gZnJvbSBjcHAucHkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcC5weToKKyAgICAgICAgKENwcENoZWNrZXIuX19pbml0X18pOgorICAgICAg ICAoQ3BwQ2hlY2tlci5jaGVjayk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jcHBfdW5pdHRlc3QucHk6CisgICAgICAgIChDcHBTdHlsZVRlc3RCYXNlLnByb2Nl c3NfZmlsZV9kYXRhKToKKwogMjAxMy0xMi0wNSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3 ZWJraXQub3JnPgogCiAgICAgICAgIERpc2FibGUgV2ViS2l0MiB3ZWJraXRweSB1bml0dGVzdHMg b24gV2luZG93cwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVj a2Vycy9jcHAucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5w eQppbmRleCBkNWMyNzg2Li5kOTJiNzVkIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAtMzcyMiw3ICszNzIyLDcgQEAgY2xhc3MgQ3BwQ2hlY2tl cihvYmplY3QpOgogICAgICAgICBdKQogCiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIGZpbGVfcGF0 aCwgZmlsZV9leHRlbnNpb24sIGhhbmRsZV9zdHlsZV9lcnJvciwKLSAgICAgICAgICAgICAgICAg bWluX2NvbmZpZGVuY2UpOgorICAgICAgICAgICAgICAgICBtaW5fY29uZmlkZW5jZSwgdW5pdF90 ZXN0X2NvbmZpZz17fSk6CiAgICAgICAgICIiIkNyZWF0ZSBhIENwcENoZWNrZXIgaW5zdGFuY2Uu CiAKICAgICAgICAgQXJnczoKQEAgLTM3MzAsMTAgKzM3MzAsMTIgQEAgY2xhc3MgQ3BwQ2hlY2tl cihvYmplY3QpOgogICAgICAgICAgICAgICAgICAgICAgICAgICB0aGUgbGVhZGluZyBkb3QuCiAK ICAgICAgICAgIiIiCisgICAgICAgIGdsb2JhbCBfdW5pdF90ZXN0X2NvbmZpZwogICAgICAgICBz ZWxmLmZpbGVfZXh0ZW5zaW9uID0gZmlsZV9leHRlbnNpb24KICAgICAgICAgc2VsZi5maWxlX3Bh dGggPSBmaWxlX3BhdGgKICAgICAgICAgc2VsZi5oYW5kbGVfc3R5bGVfZXJyb3IgPSBoYW5kbGVf c3R5bGVfZXJyb3IKICAgICAgICAgc2VsZi5taW5fY29uZmlkZW5jZSA9IG1pbl9jb25maWRlbmNl CisgICAgICAgIF91bml0X3Rlc3RfY29uZmlnID0gdW5pdF90ZXN0X2NvbmZpZwogCiAgICAgIyBV c2VmdWwgZm9yIHVuaXQgdGVzdGluZy4KICAgICBkZWYgX19lcV9fKHNlbGYsIG90aGVyKToKQEAg LTM3NTcsMTIgKzM3NTksMyBAQCBjbGFzcyBDcHBDaGVja2VyKG9iamVjdCk6CiAgICAgZGVmIGNo ZWNrKHNlbGYsIGxpbmVzKToKICAgICAgICAgX3Byb2Nlc3NfbGluZXMoc2VsZi5maWxlX3BhdGgs IHNlbGYuZmlsZV9leHRlbnNpb24sIGxpbmVzLAogICAgICAgICAgICAgICAgICAgICAgICBzZWxm LmhhbmRsZV9zdHlsZV9lcnJvciwgc2VsZi5taW5fY29uZmlkZW5jZSkKLQotCi0jIEZJWE1FOiBS ZW1vdmUgdGhpcyBmdW5jdGlvbiAocmVxdWlyZXMgcmVmYWN0b3JpbmcgdW5pdCB0ZXN0cykuCi1k ZWYgcHJvY2Vzc19maWxlX2RhdGEoZmlsZW5hbWUsIGZpbGVfZXh0ZW5zaW9uLCBsaW5lcywgZXJy b3IsIG1pbl9jb25maWRlbmNlLCB1bml0X3Rlc3RfY29uZmlnKToKLSAgICBnbG9iYWwgX3VuaXRf dGVzdF9jb25maWcKLSAgICBfdW5pdF90ZXN0X2NvbmZpZyA9IHVuaXRfdGVzdF9jb25maWcKLSAg ICBjaGVja2VyID0gQ3BwQ2hlY2tlcihmaWxlbmFtZSwgZmlsZV9leHRlbnNpb24sIGVycm9yLCBt aW5fY29uZmlkZW5jZSkKLSAgICBjaGVja2VyLmNoZWNrKGxpbmVzKQotICAgIF91bml0X3Rlc3Rf Y29uZmlnID0ge30KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVj a2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggMGEwODY2MS4uZjYzZjVjZCAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkK QEAgLTI0Nyw5ICsyNDcsOCBAQCBjbGFzcyBDcHBTdHlsZVRlc3RCYXNlKHVuaXR0ZXN0LlRlc3RD YXNlKToKICAgICAjIEhlbHBlciBmdW5jdGlvbiB0byBhdm9pZCBuZWVkaW5nIHRvIGV4cGxpY2l0 bHkgcGFzcyBjb25maWRlbmNlCiAgICAgIyBpbiBhbGwgdGhlIHVuaXQgdGVzdCBjYWxscyB0byBj cHBfc3R5bGUucHJvY2Vzc19maWxlX2RhdGEoKS4KICAgICBkZWYgcHJvY2Vzc19maWxlX2RhdGEo c2VsZiwgZmlsZW5hbWUsIGZpbGVfZXh0ZW5zaW9uLCBsaW5lcywgZXJyb3IsIHVuaXRfdGVzdF9j b25maWc9e30pOgotICAgICAgICAiIiJDYWxsIGNwcF9zdHlsZS5wcm9jZXNzX2ZpbGVfZGF0YSgp IHdpdGggdGhlIG1pbl9jb25maWRlbmNlLiIiIgotICAgICAgICByZXR1cm4gY3BwX3N0eWxlLnBy b2Nlc3NfZmlsZV9kYXRhKGZpbGVuYW1lLCBmaWxlX2V4dGVuc2lvbiwgbGluZXMsCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZXJyb3IsIHNlbGYubWluX2NvbmZp ZGVuY2UsIHVuaXRfdGVzdF9jb25maWcpCisgICAgICAgIGNoZWNrZXIgPSBDcHBDaGVja2VyKGZp bGVuYW1lLCBmaWxlX2V4dGVuc2lvbiwgZXJyb3IsIHNlbGYubWluX2NvbmZpZGVuY2UsIHVuaXRf dGVzdF9jb25maWcpCisgICAgICAgIGNoZWNrZXIuY2hlY2sobGluZXMpCiAKICAgICBkZWYgcGVy Zm9ybV9saW50KHNlbGYsIGNvZGUsIGZpbGVuYW1lLCBiYXNpY19lcnJvcl9ydWxlcywgdW5pdF90 ZXN0X2NvbmZpZz17fSwgbGluZXNfdG9fY2hlY2s9Tm9uZSk6CiAgICAgICAgIGVycm9yX2NvbGxl Y3RvciA9IEVycm9yQ29sbGVjdG9yKHNlbGYuYXNzZXJ0VHJ1ZSwgRmlsdGVyQ29uZmlndXJhdGlv bihiYXNpY19lcnJvcl9ydWxlcyksIGxpbmVzX3RvX2NoZWNrKQo=