125320 2013-12-05 15:08:12 -0800 [Gtk] install-dependencies doesn't install libgtk-3-dev 2013-12-08 07:27:35 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Minor --- 1 b.long b.long commit-queue gustavo mrobinson zan oldest_to_newest 957063 0 b.long 2013-12-05 15:08:12 -0800 I'm using Ubuntu 13.10 and Tools/gtk/install-dependencies misses libgtk-3-dev. I'm not sure if adding this will break earlier Ubuntus though. 957068 1 b.long 2013-12-05 15:15:11 -0800 Apparently it's also missing libsoup2.4-dev and libgtk2.0-dev. 957231 2 gustavo 2013-12-06 07:38:57 -0800 I think the reason why we don't install those is two fold: 1) we don't need very new versions of them 2) we build them in our jhbuild. That said, I wouldn't oppose - it looks like we have soup for Fedora, for isntance. As for the APT version, I see libgtk2.0-dev there, so we're missing libgtk-3-dev and libsoup2.4-dev only. 957233 3 mrobinson 2013-12-06 07:51:02 -0800 (In reply to comment #2) > I think the reason why we don't install those is two fold: 1) we don't need very new versions of them 2) we build them in our jhbuild. That said, I wouldn't oppose - it looks like we have soup for Fedora, for isntance. > > As for the APT version, I see libgtk2.0-dev there, so we're missing libgtk-3-dev and libsoup2.4-dev only. Yeah, presumably if you are using install-dependencies you are also using build-webkit. 957595 4 218680 b.long 2013-12-08 03:54:34 -0800 Created attachment 218680 Patch I also added a section for webkit-patch dependencies, since it needs subversion apparently. 957616 5 218680 commit-queue 2013-12-08 07:27:33 -0800 Comment on attachment 218680 Patch Clearing flags on attachment: 218680 Committed r160285: <http://trac.webkit.org/changeset/160285> 957617 6 commit-queue 2013-12-08 07:27:35 -0800 All reviewed patches have been landed. Closing bug. 218680 2013-12-08 03:54:34 -0800 2013-12-08 07:27:33 -0800 Patch bug-125320-20131208125431.patch text/plain 1640 b.long U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMjgzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWUwNjk1Y2ZkZDMxMGExNjhlMTcxYTdkOGFlYjJiMDlm MTgxZDIyMC4uZjY4ZTkxOTIxNmI3YTA1YmJlMDU3ZTVkZjZkMTlmMzBmOTBhMzVlYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDEzLTEyLTA4ICBCcmVuZGFuIExvbmcgIDxiLmxvbmdAY2FibGVsYWJzLmNvbT4KKwor ICAgICAgICBbR3RrXSBpbnN0YWxsLWRlcGVuZGVuY2llcyBkb2Vzbid0IGluc3RhbGwgbGliZ3Rr LTMtZGV2CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MjUzMjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGd0ay9pbnN0YWxsLWRlcGVuZGVuY2llczogQWRkIGxpYmd0ay0zLWRldiwgbGlic291cDIuNCBh bmQgc3VidmVyc2lvbgorCiAyMDEzLTEyLTA3ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgW0NvY29hXSBDb252ZXJ0IGEgZmV3IG1vcmUgcGFydHMgb2YgTWluaUJyb3dz ZXIgb3ZlciB0byB0aGUgT2JqZWN0aXZlLUMgQVBJCmRpZmYgLS1naXQgYS9Ub29scy9ndGsvaW5z dGFsbC1kZXBlbmRlbmNpZXMgYi9Ub29scy9ndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXMKaW5kZXgg ZjkwYmJiY2RkZjYyMmZmN2NmNzc3NDk4MWM2ZjdhMzc0NjE5ZWQzMC4uM2Y4NTlhODk1OTVkOWVh NDAyN2RlYTkzZjI0MWQ1ZDk2NDRkMWU4MSAxMDA3NTUKLS0tIGEvVG9vbHMvZ3RrL2luc3RhbGwt ZGVwZW5kZW5jaWVzCisrKyBiL1Rvb2xzL2d0ay9pbnN0YWxsLWRlcGVuZGVuY2llcwpAQCAtNTUs NiArNTUsNyBAQCBmdW5jdGlvbiBpbnN0YWxsRGVwZW5kZW5jaWVzV2l0aEFwdCB7CiAgICAgICAg IGxpYmdsMS1tZXNhLWdseCBcCiAgICAgICAgIGxpYmdudXRscy1kZXYgXAogICAgICAgICBsaWJn dGsyLjAtZGV2IFwKKyAgICAgICAgbGliZ3RrLTMtZGV2IFwKICAgICAgICAgbGliZ3VkZXYtMS4w LWRldiBcCiAgICAgICAgIGxpYmljdS1kZXYgXAogICAgICAgICBsaWJqcGVnOC1kZXYgXApAQCAt NjUsNiArNjYsNyBAQCBmdW5jdGlvbiBpbnN0YWxsRGVwZW5kZW5jaWVzV2l0aEFwdCB7CiAgICAg ICAgIGxpYnB1bHNlLWRldiBcCiAgICAgICAgIGxpYnJzdmcyLWRldiBcCiAgICAgICAgIGxpYnNl Y3JldC0xLWRldiBcCisgICAgICAgIGxpYnNvdXAyLjQtZGV2IFwKICAgICAgICAgbGlic3FsaXRl My1kZXYgXAogICAgICAgICBsaWJ0aGVvcmEtZGV2IFwKICAgICAgICAgbGlidG9vbCBcCkBAIC0x MTYsNiArMTE4LDEwIEBAIGZ1bmN0aW9uIGluc3RhbGxEZXBlbmRlbmNpZXNXaXRoQXB0IHsKICAg ICAgICAgeGZvbnRzLXV0aWxzIFwKICAgICAgICAgeHRyYW5zLWRldiBcCiAgICAgICAgIHh1dGls cy1kZXYKKworICAgICMgVGhlc2UgYXJlIGRlcGVuZGVuY2llcyBuZWNlc3NhcnkgZm9yIHVzaW5n IHdlYmtpdC1wYXRjaAorICAgIGFwdC1nZXQgaW5zdGFsbCBcCisgICAgICAgIHN1YnZlcnNpb24K IH0KIAogZnVuY3Rpb24gaW5zdGFsbERlcGVuZGVuY2llc1dpdGhZdW0gewo=