125319 2013-12-05 14:22:46 -0800 "Use Selection for Find" doesn't work in PDF viewed in Safari 2013-12-05 14:27:51 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 957046 0 andersca 2013-12-05 14:22:46 -0800 "Use Selection for Find" doesn't work in PDF viewed in Safari 957047 1 218544 andersca 2013-12-05 14:25:03 -0800 Created attachment 218544 Patch 957048 2 andersca 2013-12-05 14:27:51 -0800 Committed r160193: <http://trac.webkit.org/changeset/160193> 218544 2013-12-05 14:25:03 -0800 2013-12-05 14:26:15 -0800 Patch bug-125319-20131205142503.patch text/plain 6630 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDkzOTQ1MTE0ZmNmYWFl MzRiNjQxYjI2NmZmOTNkZmY3M2U4MWMxMy4uZjZkMGNiODBiZTAzYTY5MDhhN2VkNGMyODE3MDcz OTY4MDVmNzY0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDEzLTEyLTA1ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgIlVzZSBTZWxlY3Rp b24gZm9yIEZpbmQiIGRvZXNuJ3Qgd29yayBpbiBQREYgdmlld2VkIGluIFNhZmFyaQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1MzE5CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8xNTQ4Njk4Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9QREYvUERGUGx1Z2luLmg6 CisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4ubW06CisgICAgICAg ICgtW1dLUERGTGF5ZXJDb250cm9sbGVyRGVsZWdhdGUgd3JpdGVJdGVtc1RvUGFzdGVib2FyZDp3 aXRoVHlwZXM6XSk6CisgICAgICAgIFBhc3MgTlNHZW5lcmFsUGJvYXJkIHRvIHdyaXRlSXRlbXNU b1Bhc3RlYm9hcmQuCisKKyAgICAgICAgKFdlYktpdDo6UERGUGx1Z2luOjpoYW5kbGVFZGl0aW5n Q29tbWFuZCk6CisgICAgICAgIEhhbmRsZSB0YWtlRmluZFN0cmluZ0Zyb21TZWxlY3Rpb24gYnkg Z2V0dGluZyB0aGUgY3VycmVudCBzZWxlY3Rpb24gc3RyaW5nIGFuZCB3cml0aW5nIGl0IHRvIHRo ZSBmaW5kIHBhc3RlYm9hcmQuCisKKyAgICAgICAgKFdlYktpdDo6UERGUGx1Z2luOjppc0VkaXRp bmdDb21tYW5kRW5hYmxlZCk6CisgICAgICAgIEhhbmRsZSB0YWtlRmluZFN0cmluZ0Zyb21TZWxl Y3Rpb24uCisKKyAgICAgICAgKFdlYktpdDo6UERGUGx1Z2luOjp3cml0ZUl0ZW1zVG9QYXN0ZWJv YXJkKToKKyAgICAgICAgVXBkYXRlIHRoaXMgdG8gdGFrZSBhIHBhc3RlYm9hcmQgbmFtZS4KKwor MjAxMy0xMi0wNSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAg ICAgIFdlYktpdDIgQVBJIHNob3VsZCB1c2Ugd2VhayBvd25lcnNoaXAgZm9yIGRlbGVnYXRlIHBy b3BlcnRpZXMgcmF0aGVyIHRoYW4gYXNzaWduCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjUzMTYKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE1NTYw NjE0PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9Q REZQbHVnaW4uaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvUERGUGx1 Z2luLmgKaW5kZXggNzI0YTIxMzIxNDQyZTRlYjQ1MjM3NTM2OGMyYWJiMDA3ZjY3YzNiNC4uM2Qy OTJjNTJkOGU4ZmU5OTcxZTQ0M2ZkYzY4NTNkODFkMWExN2JlYSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4uaAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5oCkBAIC04OCw3ICs4OCw3 IEBAIHB1YmxpYzoKICAgICB2b2lkIGNsaWNrZWRMaW5rKE5TVVJMICopOwogICAgIHZvaWQgc2F2 ZVRvUERGKCk7CiAgICAgdm9pZCBvcGVuV2l0aE5hdGl2ZUFwcGxpY2F0aW9uKCk7Ci0gICAgdm9p ZCB3cml0ZUl0ZW1zVG9QYXN0ZWJvYXJkKE5TQXJyYXkgKml0ZW1zLCBOU0FycmF5ICp0eXBlcyk7 CisgICAgdm9pZCB3cml0ZUl0ZW1zVG9QYXN0ZWJvYXJkKE5TU3RyaW5nICpwYXN0ZWJvYXJkTmFt ZSwgTlNBcnJheSAqaXRlbXMsIE5TQXJyYXkgKnR5cGVzKTsKICAgICB2b2lkIHNob3dEZWZpbml0 aW9uRm9yQXR0cmlidXRlZFN0cmluZyhOU0F0dHJpYnV0ZWRTdHJpbmcgKiwgQ0dQb2ludCk7CiAg ICAgdm9pZCBwZXJmb3JtV2ViU2VhcmNoKE5TU3RyaW5nICopOwogICAgIHZvaWQgcGVyZm9ybVNw b3RsaWdodFNlYXJjaChOU1N0cmluZyAqKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvUGx1Z2lucy9QREYvUERGUGx1Z2luLm1tIGIvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4ubW0KaW5kZXggMmIwYjIzNGM0ZDI0YTI5NzcwMWM0 OTBiZmRkZTI0YzQ4NDBiY2E1MC4uODllZTg5ZjEwODllZDMxYTcwOGEyMjVhM2JmMjQ1Y2Q4ZmVl MmQ1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9Q REZQbHVnaW4ubW0KKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9Q REZQbHVnaW4ubW0KQEAgLTMzNSw3ICszMzUsNyBAQCBzdGF0aWMgY29uc3QgaW50IGRlZmF1bHRT Y3JvbGxNYWduaXR1ZGVUaHJlc2hvbGRGb3JQYWdlRmxpcCA9IDIwOwogCiAtICh2b2lkKXdyaXRl SXRlbXNUb1Bhc3RlYm9hcmQ6KE5TQXJyYXkgKilpdGVtcyB3aXRoVHlwZXM6KE5TQXJyYXkgKil0 eXBlcwogewotICAgIF9wZGZQbHVnaW4tPndyaXRlSXRlbXNUb1Bhc3RlYm9hcmQoaXRlbXMsIHR5 cGVzKTsKKyAgICBfcGRmUGx1Z2luLT53cml0ZUl0ZW1zVG9QYXN0ZWJvYXJkKE5TR2VuZXJhbFBi b2FyZCwgaXRlbXMsIHR5cGVzKTsKIH0KIAogLSAodm9pZClzaG93RGVmaW5pdGlvbkZvckF0dHJp YnV0ZWRTdHJpbmc6KE5TQXR0cmlidXRlZFN0cmluZyAqKXN0cmluZyBhdFBvaW50OihDR1BvaW50 KXBvaW50CkBAIC0xNDgwLDE3ICsxNDgwLDIyIEBAIGJvb2wgUERGUGx1Z2luOjpoYW5kbGVLZXli b2FyZEV2ZW50KGNvbnN0IFdlYktleWJvYXJkRXZlbnQmIGV2ZW50KQogYm9vbCBQREZQbHVnaW46 OmhhbmRsZUVkaXRpbmdDb21tYW5kKGNvbnN0IFN0cmluZyYgY29tbWFuZE5hbWUsIGNvbnN0IFN0 cmluZyYgYXJndW1lbnQpCiB7CiAgICAgaWYgKGNvbW1hbmROYW1lID09ICJjb3B5IikKLSAgICAg ICAgW21fcGRmTGF5ZXJDb250cm9sbGVyLmdldCgpIGNvcHlTZWxlY3Rpb25dOworICAgICAgICBb bV9wZGZMYXllckNvbnRyb2xsZXIgY29weVNlbGVjdGlvbl07CiAgICAgZWxzZSBpZiAoY29tbWFu ZE5hbWUgPT0gInNlbGVjdEFsbCIpCi0gICAgICAgIFttX3BkZkxheWVyQ29udHJvbGxlci5nZXQo KSBzZWxlY3RBbGxdOwotICAgIAorICAgICAgICBbbV9wZGZMYXllckNvbnRyb2xsZXIgc2VsZWN0 QWxsXTsKKyAgICBlbHNlIGlmIChjb21tYW5kTmFtZSA9PSAidGFrZUZpbmRTdHJpbmdGcm9tU2Vs ZWN0aW9uIikgeworICAgICAgICBOU1N0cmluZyAqc3RyaW5nID0gW21fcGRmTGF5ZXJDb250cm9s bGVyIGN1cnJlbnRTZWxlY3Rpb25dLnN0cmluZzsKKyAgICAgICAgaWYgKHN0cmluZy5sZW5ndGgp CisgICAgICAgICAgICB3cml0ZUl0ZW1zVG9QYXN0ZWJvYXJkKE5TRmluZFBib2FyZCwgQFsgW3N0 cmluZyBkYXRhVXNpbmdFbmNvZGluZzpOU1VURjhTdHJpbmdFbmNvZGluZ10gXSwgQFsgTlNQYXN0 ZWJvYXJkVHlwZVN0cmluZyBdKTsKKyAgICB9CisKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAogYm9v bCBQREZQbHVnaW46OmlzRWRpdGluZ0NvbW1hbmRFbmFibGVkKGNvbnN0IFN0cmluZyYgY29tbWFu ZE5hbWUpCiB7Ci0gICAgaWYgKGNvbW1hbmROYW1lID09ICJjb3B5IikKLSAgICAgICAgcmV0dXJu IFttX3BkZkxheWVyQ29udHJvbGxlci5nZXQoKSBjdXJyZW50U2VsZWN0aW9uXTsKKyAgICBpZiAo Y29tbWFuZE5hbWUgPT0gImNvcHkiIHx8IGNvbW1hbmROYW1lID09ICJ0YWtlRmluZFN0cmluZ0Zy b21TZWxlY3Rpb24iKQorICAgICAgICByZXR1cm4gW21fcGRmTGF5ZXJDb250cm9sbGVyIGN1cnJl bnRTZWxlY3Rpb25dOwogICAgICAgICAKICAgICBpZiAoY29tbWFuZE5hbWUgPT0gInNlbGVjdEFs bCIpCiAgICAgICAgIHJldHVybiB0cnVlOwpAQCAtMTYzMCw3ICsxNjM1LDcgQEAgdm9pZCBQREZQ bHVnaW46Om9wZW5XaXRoTmF0aXZlQXBwbGljYXRpb24oKQogICAgIHdlYkZyYW1lKCktPnBhZ2Uo KS0+c2VuZChNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpPcGVuUERGRnJvbVRlbXBvcmFyeUZvbGRl cldpdGhOYXRpdmVBcHBsaWNhdGlvbihtX3RlbXBvcmFyeVBERlVVSUQpKTsKIH0KIAotdm9pZCBQ REZQbHVnaW46OndyaXRlSXRlbXNUb1Bhc3RlYm9hcmQoTlNBcnJheSAqaXRlbXMsIE5TQXJyYXkg KnR5cGVzKQordm9pZCBQREZQbHVnaW46OndyaXRlSXRlbXNUb1Bhc3RlYm9hcmQoTlNTdHJpbmcg KnBhc3RlYm9hcmROYW1lLCBOU0FycmF5ICppdGVtcywgTlNBcnJheSAqdHlwZXMpCiB7CiAgICAg VmVjdG9yPFN0cmluZz4gcGFzdGVib2FyZFR5cGVzOwogCkBAIC0xNjM4LDcgKzE2NDMsNyBAQCB2 b2lkIFBERlBsdWdpbjo6d3JpdGVJdGVtc1RvUGFzdGVib2FyZChOU0FycmF5ICppdGVtcywgTlNB cnJheSAqdHlwZXMpCiAgICAgICAgIHBhc3RlYm9hcmRUeXBlcy5hcHBlbmQodHlwZSk7CiAKICAg ICB1aW50NjRfdCBuZXdDaGFuZ2VDb3VudDsKLSAgICBXZWJQcm9jZXNzOjpzaGFyZWQoKS5wYXJl bnRQcm9jZXNzQ29ubmVjdGlvbigpLT5zZW5kU3luYyhNZXNzYWdlczo6V2ViQ29udGV4dDo6U2V0 UGFzdGVib2FyZFR5cGVzKE5TR2VuZXJhbFBib2FyZCwgcGFzdGVib2FyZFR5cGVzKSwKKyAgICBX ZWJQcm9jZXNzOjpzaGFyZWQoKS5wYXJlbnRQcm9jZXNzQ29ubmVjdGlvbigpLT5zZW5kU3luYyhN ZXNzYWdlczo6V2ViQ29udGV4dDo6U2V0UGFzdGVib2FyZFR5cGVzKHBhc3RlYm9hcmROYW1lLCBw YXN0ZWJvYXJkVHlwZXMpLAogICAgICAgICBNZXNzYWdlczo6V2ViQ29udGV4dDo6U2V0UGFzdGVi b2FyZFR5cGVzOjpSZXBseShuZXdDaGFuZ2VDb3VudCksIDApOwogCiAgICAgZm9yIChOU1VJbnRl Z2VyIGkgPSAwLCBjb3VudCA9IGl0ZW1zLmNvdW50OyBpIDwgY291bnQ7ICsraSkgewpAQCAtMTY1 Myw3ICsxNjU4LDcgQEAgdm9pZCBQREZQbHVnaW46OndyaXRlSXRlbXNUb1Bhc3RlYm9hcmQoTlNB cnJheSAqaXRlbXMsIE5TQXJyYXkgKnR5cGVzKQogCiAgICAgICAgIGlmIChbdHlwZSBpc0VxdWFs VG9TdHJpbmc6TlNTdHJpbmdQYm9hcmRUeXBlXSB8fCBbdHlwZSBpc0VxdWFsVG9TdHJpbmc6TlNQ YXN0ZWJvYXJkVHlwZVN0cmluZ10pIHsKICAgICAgICAgICAgIFJldGFpblB0cjxOU1N0cmluZz4g cGxhaW5UZXh0U3RyaW5nID0gYWRvcHROUyhbW05TU3RyaW5nIGFsbG9jXSBpbml0V2l0aERhdGE6 ZGF0YSBlbmNvZGluZzpOU1VURjhTdHJpbmdFbmNvZGluZ10pOwotICAgICAgICAgICAgV2ViUHJv Y2Vzczo6c2hhcmVkKCkucGFyZW50UHJvY2Vzc0Nvbm5lY3Rpb24oKS0+c2VuZFN5bmMoTWVzc2Fn ZXM6OldlYkNvbnRleHQ6OlNldFBhc3RlYm9hcmRTdHJpbmdGb3JUeXBlKE5TR2VuZXJhbFBib2Fy ZCwgdHlwZSwgcGxhaW5UZXh0U3RyaW5nLmdldCgpKSwKKyAgICAgICAgICAgIFdlYlByb2Nlc3M6 OnNoYXJlZCgpLnBhcmVudFByb2Nlc3NDb25uZWN0aW9uKCktPnNlbmRTeW5jKE1lc3NhZ2VzOjpX ZWJDb250ZXh0OjpTZXRQYXN0ZWJvYXJkU3RyaW5nRm9yVHlwZShwYXN0ZWJvYXJkTmFtZSwgdHlw ZSwgcGxhaW5UZXh0U3RyaW5nLmdldCgpKSwKICAgICAgICAgICAgICAgICBNZXNzYWdlczo6V2Vi Q29udGV4dDo6U2V0UGFzdGVib2FyZFN0cmluZ0ZvclR5cGU6OlJlcGx5KG5ld0NoYW5nZUNvdW50 KSwgMCk7CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBSZWZQdHI8U2hhcmVkQnVmZmVy PiBidWZmZXIgPSBTaGFyZWRCdWZmZXI6OndyYXBOU0RhdGEoZGF0YSk7CkBAIC0xNjY1LDcgKzE2 NzAsNyBAQCB2b2lkIFBERlBsdWdpbjo6d3JpdGVJdGVtc1RvUGFzdGVib2FyZChOU0FycmF5ICpp dGVtcywgTlNBcnJheSAqdHlwZXMpCiAgICAgICAgICAgICBSZWZQdHI8U2hhcmVkTWVtb3J5PiBz aGFyZWRNZW1vcnkgPSBTaGFyZWRNZW1vcnk6OmNyZWF0ZShidWZmZXItPnNpemUoKSk7CiAgICAg ICAgICAgICBtZW1jcHkoc2hhcmVkTWVtb3J5LT5kYXRhKCksIGJ1ZmZlci0+ZGF0YSgpLCBidWZm ZXItPnNpemUoKSk7CiAgICAgICAgICAgICBzaGFyZWRNZW1vcnktPmNyZWF0ZUhhbmRsZShoYW5k bGUsIFNoYXJlZE1lbW9yeTo6UmVhZE9ubHkpOwotICAgICAgICAgICAgV2ViUHJvY2Vzczo6c2hh cmVkKCkucGFyZW50UHJvY2Vzc0Nvbm5lY3Rpb24oKS0+c2VuZFN5bmMoTWVzc2FnZXM6OldlYkNv bnRleHQ6OlNldFBhc3RlYm9hcmRCdWZmZXJGb3JUeXBlKE5TR2VuZXJhbFBib2FyZCwgdHlwZSwg aGFuZGxlLCBidWZmZXItPnNpemUoKSksCisgICAgICAgICAgICBXZWJQcm9jZXNzOjpzaGFyZWQo KS5wYXJlbnRQcm9jZXNzQ29ubmVjdGlvbigpLT5zZW5kU3luYyhNZXNzYWdlczo6V2ViQ29udGV4 dDo6U2V0UGFzdGVib2FyZEJ1ZmZlckZvclR5cGUocGFzdGVib2FyZE5hbWUsIHR5cGUsIGhhbmRs ZSwgYnVmZmVyLT5zaXplKCkpLAogICAgICAgICAgICAgICAgIE1lc3NhZ2VzOjpXZWJDb250ZXh0 OjpTZXRQYXN0ZWJvYXJkQnVmZmVyRm9yVHlwZTo6UmVwbHkobmV3Q2hhbmdlQ291bnQpLCAwKTsK ICAgICAgICAgfQogICAgIH0K