<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>125309</bug_id>
          
          <creation_ts>2013-12-05 10:57:18 -0800</creation_ts>
          <short_desc>[Win] Avoid copying compiled-in resources to DSTROOT</short_desc>
          <delta_ts>2013-12-05 12:39:25 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Minor</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>125249</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Brent Fulgham">bfulgham</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>jer.noble</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>956963</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-12-05 10:57:18 -0800</bug_when>
    <thetext>We don&apos;t need to include the WebKit.rc file, or the various PNG&apos;s that are compiled into the DLL when we build the installer.

It turns out that ONLY the Info.plist needs to be copied from the source WebKit.resource directory to the DSTROOT&apos;s resource directory.  All the other contents are compiled into the WebKit.dll.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>957004</commentid>
    <comment_count>1</comment_count>
      <attachid>218531</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-12-05 12:24:43 -0800</bug_when>
    <thetext>Created attachment 218531
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>957013</commentid>
    <comment_count>2</comment_count>
      <attachid>218531</attachid>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2013-12-05 12:38:25 -0800</bug_when>
    <thetext>Comment on attachment 218531
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>957014</commentid>
    <comment_count>3</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-12-05 12:39:25 -0800</bug_when>
    <thetext>Committed r160188: &lt;http://trac.webkit.org/changeset/160188&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>218531</attachid>
            <date>2013-12-05 12:24:43 -0800</date>
            <delta_ts>2013-12-05 12:38:25 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-125309-20131205122441.patch</filename>
            <type>text/plain</type>
            <size>1487</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNjAxODQpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTEyLTA1ICBCcmVudCBGdWxn
aGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIEF2b2lkIGNvcHlpbmcg
Y29tcGlsZWQtaW4gcmVzb3VyY2VzIHRvIERTVFJPT1QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTMwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViS2l0LnZjeHByb2ovV2ViS2l0L1dlYktpdFBv
c3RCdWlsZC5jbWQ6IE9ubHkgY29weSBJbmZvLnBsaXN0IHRvIHRoZSBmaW5hbCBXZWJLaXQucmVz
b3VyY2UgYnVuZGxlLgorICAgICAgICBUaGUgUE5HIGFuZCBSQyBmaWxlcyBhcmUgY29tcGlsZWQg
aW50byB0aGUgV2ViS2l0LmRsbCBsaWJyYXJ5LgorCiAyMDEzLTEyLTA0ICBCcmVudCBGdWxnaGFt
ICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5dIENvcnJlY3QgV2ViS2l0Lm1h
a2UgY29weSBjb21tYW5kIHRvIGxhbmQgcmVzb3VyY2VzIGluIHByb3BlciBkaXJlY3RvcnkuCklu
ZGV4OiBTb3VyY2UvV2ViS2l0L1dlYktpdC52Y3hwcm9qL1dlYktpdC9XZWJLaXRQb3N0QnVpbGQu
Y21kCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViS2l0LnZjeHByb2ovV2ViS2l0L1dl
YktpdFBvc3RCdWlsZC5jbWQJKHJldmlzaW9uIDE2MDE4MCkKKysrIFNvdXJjZS9XZWJLaXQvV2Vi
S2l0LnZjeHByb2ovV2ViS2l0L1dlYktpdFBvc3RCdWlsZC5jbWQJKHdvcmtpbmcgY29weSkKQEAg
LTE1LDcgKzE1LDcgQEAgeGNvcHkgL3kgL2QgIiVDT05GSUdVUkFUSU9OQlVJTERESVIlXGluYwog
CiBlY2hvIENvcHlpbmcgcmVzb3VyY2VzLi4uCiBta2RpciAiJVJlc291cmNlc0RpcmVjdG9yeSUi
IDI+TlVMCi14Y29weSAveSAvZCAiJVBST0pFQ1RESVIlXC4uXC4uXHdpblxXZWJLaXQucmVzb3Vy
Y2VzXCoiICIlUmVzb3VyY2VzRGlyZWN0b3J5JSIgPk5VTAoreGNvcHkgL3kgL2QgIiVQUk9KRUNU
RElSJVwuLlwuLlx3aW5cV2ViS2l0LnJlc291cmNlc1xJbmZvLnBsaXN0IiAiJVJlc291cmNlc0Rp
cmVjdG9yeSUiID5OVUwKIAogaWYgZXhpc3QgIiVXRUJLSVRfTElCUkFSSUVTJVx0b29sc1xWZXJz
aW9uU3RhbXBlclxWZXJzaW9uU3RhbXBlci5leGUiICIlV0VCS0lUX0xJQlJBUklFUyVcdG9vbHNc
VmVyc2lvblN0YW1wZXJcVmVyc2lvblN0YW1wZXIuZXhlIiAtLXZlcmJvc2UgIiVUQVJHRVRQQVRI
JSIKIAo=
</data>
<flag name="review"
          id="241988"
          type_id="1"
          status="+"
          setter="jer.noble"
    />
          </attachment>
      

    </bug>

</bugzilla>