125303 2013-12-05 06:24:36 -0800 [GTK] Do not use deprecated gtk-doc 'Rename to' tag 2013-12-05 06:48:17 -0800 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo pnormand oldest_to_newest 956882 0 cgarcia 2013-12-05 06:24:36 -0800 DerivedSources/webkitdom/WebKitDOMEventTarget.h:110: Warning: WebKit: GObject-Introspection specific GTK-Doc tag "Rename to" has been deprecated, please use annotations on the identifier instead: * Rename to: webkit_dom_event_target_add_event_listener ^ DerivedSources/webkitdom/WebKitDOMEventTarget.h:129: Warning: WebKit: GObject-Introspection specific GTK-Doc tag "Rename to" has been deprecated, please use annotations on the identifier instead: * Rename to: webkit_dom_event_target_remove_event_listener ^ rename-to annotation is available in gobject-introspection since 0.6.3 so we should use that instead. 956883 1 218509 cgarcia 2013-12-05 06:27:49 -0800 Created attachment 218509 Patch This now produces a different warning when generating gtk-doc documentation, but it's actually a gtk-doc bug see https://bugzilla.gnome.org/show_bug.cgi?id=710478 Running gtkdoc-mkdb DerivedSources/webkitdom/WebKitDOMEventTarget.h:109: warning: Symbol name not found at the start of the comment block. DerivedSources/webkitdom/WebKitDOMEventTarget.h:126: warning: Symbol name not found at the start of the comment block. 956890 2 cgarcia 2013-12-05 06:48:17 -0800 Committed r160174: <http://trac.webkit.org/changeset/160174> 218509 2013-12-05 06:27:49 -0800 2013-12-05 06:42:58 -0800 Patch wkdom-rename-to.diff text/plain 2976 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlZDYzYmE4Li4yMTAyNmQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTMtMTItMDUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIERvIG5vdCB1c2UgZGVwcmVjYXRlZCBndGstZG9jICdSZW5hbWUg dG8nIHRhZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTI1MzAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg R09iamVjdCBpbnRyb3NwZWN0aW9uIHJlbmFtZS10byBhbm5vdGF0aW9uIGlzIGF2YWlsYWJsZSBp bgorICAgICAgICBzaW5jZSB2ZXJzaW9uIDAuNi4zIHNvIHdlIHNob3VsZCB1c2UgdGhhdCBpbnN0 ZWFkLgorCisgICAgICAgICogYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01FdmVudFRhcmdldC5o OgorCisyMDEzLTEyLTA1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv bT4KKwogICAgICAgICBbR1RLXSBBZGQgbWlzc2luZyBzeW1ib2xzIHRvIFdlYktpdERPTURlcHJl Y2F0ZWQuc3ltYm9scwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTI1MzAwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmpl Y3QvV2ViS2l0RE9NRXZlbnRUYXJnZXQuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmpl Y3QvV2ViS2l0RE9NRXZlbnRUYXJnZXQuaAppbmRleCBkYTNmNzI2Li4zZDNkNjYwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUV2ZW50VGFyZ2V0 LmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01FdmVudFRh cmdldC5oCkBAIC05Niw3ICs5Niw3IEBAIFdFQktJVF9BUEkgZ2Jvb2xlYW4gIHdlYmtpdF9kb21f ZXZlbnRfdGFyZ2V0X3JlbW92ZV9ldmVudF9saXN0ZW5lcihXZWJLaXRET01FdmVuCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgZ2Jvb2xlYW4gICAgICAgICAgICAgIHVzZV9jYXB0dXJlKTsKIAogLyoqCi0gKiB3ZWJraXRf ZG9tX2V2ZW50X3RhcmdldF9hZGRfZXZlbnRfbGlzdGVuZXJfd2l0aF9jbG9zdXJlOgorICogd2Vi a2l0X2RvbV9ldmVudF90YXJnZXRfYWRkX2V2ZW50X2xpc3RlbmVyX3dpdGhfY2xvc3VyZTogKHJl bmFtZS10byB3ZWJraXRfZG9tX2V2ZW50X3RhcmdldF9hZGRfZXZlbnRfbGlzdGVuZXIpCiAgKiBA dGFyZ2V0OiBBICNXZWJLaXRET01FdmVudFRhcmdldAogICogQGV2ZW50X25hbWU6IEEgI2djaGFy CiAgKiBAaGFuZGxlcjogQSAjR0Nsb3N1cmUKQEAgLTEwNiw4ICsxMDYsNiBAQCBXRUJLSVRfQVBJ IGdib29sZWFuICB3ZWJraXRfZG9tX2V2ZW50X3RhcmdldF9yZW1vdmVfZXZlbnRfbGlzdGVuZXIo V2ViS2l0RE9NRXZlbgogICogaW5zdGVhZCBvZiBhIGNhbGxiYWNrcyBmb3IgZWFzaWVyIGJpbmRp bmcgaW4gb3RoZXIgbGFuZ3VhZ2VzLgogICoKICAqIFJldHVybnM6IGEgI2dib29sZWFuCi0gKgot ICogUmVuYW1lIHRvOiB3ZWJraXRfZG9tX2V2ZW50X3RhcmdldF9hZGRfZXZlbnRfbGlzdGVuZXIK ICAqLwogV0VCS0lUX0FQSSBnYm9vbGVhbiB3ZWJraXRfZG9tX2V2ZW50X3RhcmdldF9hZGRfZXZl bnRfbGlzdGVuZXJfd2l0aF9jbG9zdXJlKFdlYktpdERPTUV2ZW50VGFyZ2V0ICp0YXJnZXQsCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgY29uc3QgY2hhciAgICAgICAgICAgKmV2ZW50X25hbWUsCkBAIC0x MTUsNyArMTEzLDcgQEAgV0VCS0lUX0FQSSBnYm9vbGVhbiB3ZWJraXRfZG9tX2V2ZW50X3Rhcmdl dF9hZGRfZXZlbnRfbGlzdGVuZXJfd2l0aF9jbG9zdXJlKFdlYksKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBnYm9vbGVhbiAgICAgICAgICAgICAgdXNlX2NhcHR1cmUpOwogCiAvKioKLSAqIHdlYmtpdF9k b21fZXZlbnRfdGFyZ2V0X3JlbW92ZV9ldmVudF9saXN0ZW5lcl93aXRoX2Nsb3N1cmU6CisgKiB3 ZWJraXRfZG9tX2V2ZW50X3RhcmdldF9yZW1vdmVfZXZlbnRfbGlzdGVuZXJfd2l0aF9jbG9zdXJl OiAocmVuYW1lLXRvIHdlYmtpdF9kb21fZXZlbnRfdGFyZ2V0X3JlbW92ZV9ldmVudF9saXN0ZW5l cikKICAqIEB0YXJnZXQ6IEEgI1dlYktpdERPTUV2ZW50VGFyZ2V0CiAgKiBAZXZlbnRfbmFtZTog QSAjZ2NoYXIKICAqIEBoYW5kbGVyOiBBICNHQ2xvc3VyZQpAQCAtMTI1LDggKzEyMyw2IEBAIFdF QktJVF9BUEkgZ2Jvb2xlYW4gd2Via2l0X2RvbV9ldmVudF90YXJnZXRfYWRkX2V2ZW50X2xpc3Rl bmVyX3dpdGhfY2xvc3VyZShXZWJLCiAgKiBpbnN0ZWFkIG9mIGEgY2FsbGJhY2tzIGZvciBlYXNp ZXIgYmluZGluZyBpbiBvdGhlciBsYW5ndWFnZXMuCiAgKgogICogUmV0dXJuczogYSAjZ2Jvb2xl YW4KLSAqCi0gKiBSZW5hbWUgdG86IHdlYmtpdF9kb21fZXZlbnRfdGFyZ2V0X3JlbW92ZV9ldmVu dF9saXN0ZW5lcgogICovCiBXRUJLSVRfQVBJIGdib29sZWFuIHdlYmtpdF9kb21fZXZlbnRfdGFy Z2V0X3JlbW92ZV9ldmVudF9saXN0ZW5lcl93aXRoX2Nsb3N1cmUoV2ViS2l0RE9NRXZlbnRUYXJn ZXQgKnRhcmdldCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBjaGFyICAgICAgICAgICAq ZXZlbnRfbmFtZSwK