125302 2013-12-05 05:21:09 -0800 [GTK] Fix gtk-doc warnings when generating DOM bindings API docs 2013-12-05 06:30:05 -0800 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo pnormand oldest_to_newest 956868 0 cgarcia 2013-12-05 05:21:09 -0800 The following API are missing documentation: WEBKIT_API WEBKIT_DEPRECATED WEBKIT_DEPRECATED_FOR Those are macros that shouldn't be documented, but they should be added to the -sections.txt as private API file to avoid the gtk-doc warnings. 956872 1 218506 cgarcia 2013-12-05 05:23:17 -0800 Created attachment 218506 Patch 956874 2 218506 pnormand 2013-12-05 05:27:22 -0800 Comment on attachment 218506 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218506&action=review > Tools/gtk/generate-webkitdom-doc-files:193 > + sys.stdout.write('<FILE>webkitdeomdefines</FILE>\n<TITLE>WebKitDOMDefines</TITLE>\n') deom ? :) 956876 3 cgarcia 2013-12-05 05:29:46 -0800 (In reply to comment #2) > (From update of attachment 218506 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=218506&action=review > > > Tools/gtk/generate-webkitdom-doc-files:193 > > + sys.stdout.write('<FILE>webkitdeomdefines</FILE>\n<TITLE>WebKitDOMDefines</TITLE>\n') > > deom ? :) Oops, it doesn't really matter actually, but good catch, will update the patch :-) 956877 4 218507 cgarcia 2013-12-05 05:31:58 -0800 Created attachment 218507 Updated patch Fixed typo 956884 5 cgarcia 2013-12-05 06:30:05 -0800 Committed r160173: <http://trac.webkit.org/changeset/160173> 218506 2013-12-05 05:23:17 -0800 2013-12-05 05:31:58 -0800 Patch wkdom-gtk-doc-warnings.diff text/plain 1631 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAyYmY3 Mjc1Li5hOThhN2MzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMTItMDUgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEZpeCBndGstZG9jIHdhcm5p bmdzIHdoZW4gZ2VuZXJhdGluZyBET00gYmluZGluZ3MgQVBJIGRvY3MKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTMwMgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZ3RrL2dlbmVyYXRlLXdlYmtpdGRv bS1kb2MtZmlsZXM6CisgICAgICAgIChXZWJLaXRET01Eb2NHZW5lcmF0b3JTZWN0aW9ucy53cml0 ZV9mb290ZXIpOiBBZGQgYSBuZXcgc2VjdGlvbgorICAgICAgICBjb250YWluaW5nIGEgcHJpdmF0 ZSBzdWJzZWN0aW9uIGZvciBXRUJLSVRfQVBJLCBXRUJLSVRfREVQUkVDQVRFRAorICAgICAgICBh bmQgV0VCS0lUX0RFUFJFQ0FURURfRk9SIG1hY3Jvcy4KKwogMjAxMy0xMi0wNSAgVGFtYXMgR2Vy Z2VseSAgPHRnZXJnZWx5LnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CiAKICAgICAgICAg UmVtb3ZlIGR1cGxpY2F0ZWQvZGVhZCBjb2RlIGZyb20gY3BwIHN0eWxlIGNoZWNrZXIgdW5pdCB0 ZXN0cy4KZGlmZiAtLWdpdCBhL1Rvb2xzL2d0ay9nZW5lcmF0ZS13ZWJraXRkb20tZG9jLWZpbGVz IGIvVG9vbHMvZ3RrL2dlbmVyYXRlLXdlYmtpdGRvbS1kb2MtZmlsZXMKaW5kZXggYjQ3ZTI5YS4u Mjc3Mzk0NCAxMDA3NTUKLS0tIGEvVG9vbHMvZ3RrL2dlbmVyYXRlLXdlYmtpdGRvbS1kb2MtZmls ZXMKKysrIGIvVG9vbHMvZ3RrL2dlbmVyYXRlLXdlYmtpdGRvbS1kb2MtZmlsZXMKQEAgLTE4OCw2 ICsxODgsMTMgQEAgY2xhc3MgV2ViS2l0RE9NRG9jR2VuZXJhdG9yU2VjdGlvbnMoV2ViS2l0RE9N RG9jR2VuZXJhdG9yKToKICAgICAgICAgICAgIHN5cy5zdGRvdXQud3JpdGUoJ3dlYmtpdF9kb21f JXNfZ2V0X3R5cGVcbicgJSBzZWxmLl9kb21fY2xhc3NfZGVjYW1lbGl6ZShjbGFzc19uYW1lKS5s b3dlcigpKQogICAgICAgICAgICAgc3lzLnN0ZG91dC53cml0ZSgnPC9TRUNUSU9OPlxuXG4nKQog CisgICAgZGVmIHdyaXRlX2Zvb3RlcihzZWxmKToKKyAgICAgICAgc3lzLnN0ZG91dC53cml0ZSgn PFNFQ1RJT04+XG4nKQorICAgICAgICBzeXMuc3Rkb3V0LndyaXRlKCc8RklMRT53ZWJraXRkZW9t ZGVmaW5lczwvRklMRT5cbjxUSVRMRT5XZWJLaXRET01EZWZpbmVzPC9USVRMRT5cbicpCisgICAg ICAgIHN5cy5zdGRvdXQud3JpdGUoJzxTVUJTRUNUSU9OIFByaXZhdGU+XG4nKQorICAgICAgICBz eXMuc3Rkb3V0LndyaXRlKCdXRUJLSVRfQVBJXG5XRUJLSVRfREVQUkVDQVRFRFxuV0VCS0lUX0RF UFJFQ0FURURfRk9SXG4nKQorICAgICAgICBzeXMuc3Rkb3V0LndyaXRlKCc8L1NFQ1RJT04+XG5c bicpCisKIAogc3ltYm9sX2ZpbGVzID0gc3lzLnN0ZGluLnJlYWQoKS5zdHJpcCgnXG4nKS5zcGxp dCgnICcpCiBpZiAnZG9jcycgaW4gc3lzLmFyZ3ZbMTpdOgo= 218507 2013-12-05 05:31:58 -0800 2013-12-05 05:34:10 -0800 Updated patch wkdom-gtk-doc-warnings.diff text/plain 1581 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0N2Ez ZWY1Li5iODNhOTViNTYzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMTItMDUgIENhcmxvcyBHYXJjaWEgQ2Ft cG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEZpeCBndGstZG9jIHdh cm5pbmdzIHdoZW4gZ2VuZXJhdGluZyBET00gYmluZGluZ3MgQVBJIGRvY3MKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTMwMgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZ3RrL2dlbmVyYXRlLXdlYmtp dGRvbS1kb2MtZmlsZXM6CisgICAgICAgIChXZWJLaXRET01Eb2NHZW5lcmF0b3JTZWN0aW9ucy53 cml0ZV9mb290ZXIpOiBBZGQgYSBuZXcgc2VjdGlvbgorICAgICAgICBjb250YWluaW5nIGEgcHJp dmF0ZSBzdWJzZWN0aW9uIGZvciBXRUJLSVRfQVBJLCBXRUJLSVRfREVQUkVDQVRFRAorICAgICAg ICBhbmQgV0VCS0lUX0RFUFJFQ0FURURfRk9SIG1hY3Jvcy4KKwogMjAxMy0xMi0wNSAgTGFzemxv IFZpZGFjcyAgPGxhY0BpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgRml4IGNyb3NzIGNvbXBp bGF0aW9uIG9uIHg4NgpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2dlbmVyYXRlLXdlYmtpdGRvbS1k b2MtZmlsZXMgYi9Ub29scy9ndGsvZ2VuZXJhdGUtd2Via2l0ZG9tLWRvYy1maWxlcwppbmRleCBi NDdlMjlhLi4wMjE0ZTFlIDEwMDc1NQotLS0gYS9Ub29scy9ndGsvZ2VuZXJhdGUtd2Via2l0ZG9t LWRvYy1maWxlcworKysgYi9Ub29scy9ndGsvZ2VuZXJhdGUtd2Via2l0ZG9tLWRvYy1maWxlcwpA QCAtMTg4LDYgKzE4OCwxMyBAQCBjbGFzcyBXZWJLaXRET01Eb2NHZW5lcmF0b3JTZWN0aW9ucyhX ZWJLaXRET01Eb2NHZW5lcmF0b3IpOgogICAgICAgICAgICAgc3lzLnN0ZG91dC53cml0ZSgnd2Vi a2l0X2RvbV8lc19nZXRfdHlwZVxuJyAlIHNlbGYuX2RvbV9jbGFzc19kZWNhbWVsaXplKGNsYXNz X25hbWUpLmxvd2VyKCkpCiAgICAgICAgICAgICBzeXMuc3Rkb3V0LndyaXRlKCc8L1NFQ1RJT04+ XG5cbicpCiAKKyAgICBkZWYgd3JpdGVfZm9vdGVyKHNlbGYpOgorICAgICAgICBzeXMuc3Rkb3V0 LndyaXRlKCc8U0VDVElPTj5cbicpCisgICAgICAgIHN5cy5zdGRvdXQud3JpdGUoJzxGSUxFPndl YmtpdGRvbWRlZmluZXM8L0ZJTEU+XG48VElUTEU+V2ViS2l0RE9NRGVmaW5lczwvVElUTEU+XG4n KQorICAgICAgICBzeXMuc3Rkb3V0LndyaXRlKCc8U1VCU0VDVElPTiBQcml2YXRlPlxuJykKKyAg ICAgICAgc3lzLnN0ZG91dC53cml0ZSgnV0VCS0lUX0FQSVxuV0VCS0lUX0RFUFJFQ0FURURcbldF QktJVF9ERVBSRUNBVEVEX0ZPUlxuJykKKyAgICAgICAgc3lzLnN0ZG91dC53cml0ZSgnPC9TRUNU SU9OPlxuXG4nKQorCiAKIHN5bWJvbF9maWxlcyA9IHN5cy5zdGRpbi5yZWFkKCkuc3RyaXAoJ1xu Jykuc3BsaXQoJyAnKQogaWYgJ2RvY3MnIGluIHN5cy5hcmd2WzE6XToK