125298 2013-12-05 04:12:39 -0800 32bit buildfix after r160151 2013-12-05 15:09:59 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 lvidacs.u-szeged webkit-unassigned commit-queue gustavo k.czech menard mrobinson ossy pnormand oldest_to_newest 956846 0 lvidacs.u-szeged 2013-12-05 04:12:39 -0800 32bit build fails with the following message: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: In member function 'void StreamingClient::handleDataReceived(const char*, int)': Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:517: error: format '%ld' expects argument of type 'long int', but argument 8 has type 'unsigned int' [-Werror=format] Buildbot: EFL Linux 32-bit Release (Build) 956858 1 218503 lvidacs.u-szeged 2013-12-05 04:57:47 -0800 Created attachment 218503 Patch 956861 2 commit-queue 2013-12-05 04:59:14 -0800 Attachment 218503 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 956864 3 lvidacs.u-szeged 2013-12-05 05:04:18 -0800 This seems to be a false positive - no initialization list in this line. 956869 4 218503 pnormand 2013-12-05 05:21:21 -0800 Comment on attachment 218503 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218503&action=review > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943 > + GST_LOG_OBJECT(src, "Have %lld bytes of data", priv->buffer ? static_cast<long long>(gst_buffer_get_size(priv->buffer.get())) : length); Perhaps use %zd ? 956870 5 pnormand 2013-12-05 05:23:15 -0800 *** This bug has been marked as a duplicate of bug 125296 *** 957053 6 218503 ossy 2013-12-05 14:39:59 -0800 Comment on attachment 218503 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218503&action=review >> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943 >> + GST_LOG_OBJECT(src, "Have %lld bytes of data", priv->buffer ? static_cast<long long>(gst_buffer_get_size(priv->buffer.get())) : length); > > Perhaps use %zd ? gst_buffer_get_size returns unsigned int (32bit), length is int (32bit). An unsigned int can be extended properly to long long int (64bit) on x86. So it is the proper fix, r=me to fix the build as soon as possible. 957054 7 ossy 2013-12-05 14:40:20 -0800 Reopen to let CQ land the fix. 957056 8 ossy 2013-12-05 14:42:02 -0800 *** Bug 125296 has been marked as a duplicate of this bug. *** 957064 9 218503 commit-queue 2013-12-05 15:09:55 -0800 Comment on attachment 218503 Patch Clearing flags on attachment: 218503 Committed r160196: <http://trac.webkit.org/changeset/160196> 957065 10 commit-queue 2013-12-05 15:09:59 -0800 All reviewed patches have been landed. Closing bug. 218503 2013-12-05 04:57:47 -0800 2013-12-05 15:09:55 -0800 Patch bug-125298-20131205135743.patch text/plain 1613 lvidacs.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzMxZTk3ZmU4ZTFkMmY0 M2ZlYjVlMzA1MzVkNzFhZTcxODg3NmRmZC4uYjI0NWRhOWJiMzk3ZjkzNjMwZGJkY2RiZDljMGY1 NDBmNGQ1NmRiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTEyLTA1ICBMYXN6 bG8gVmlkYWNzICA8bGFjQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICAzMmJpdCBidWlsZGZp eCBhZnRlciByMTYwMTUxCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjUyOTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3Ry ZWFtZXIuY3BwOgorICAgICAgICAoU3RyZWFtaW5nQ2xpZW50OjpoYW5kbGVEYXRhUmVjZWl2ZWQp OgorCiAyMDEzLTEyLTA1ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbR1RLXSBNb3ZlIHBsYXRmb3JtIHNvdXJjZXMgZnJlZSBvZiBsYXllcmluZyB2aW9s YXRpb25zIHVuZGVyIGxpYlBsYXRmb3JtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VH U3RyZWFtZXIuY3BwCmluZGV4IGFmNzhhZTAwZGM5ZmI5MzJkNTNjZGQ4OWM0MzkzYTQyYzU3MDg3 ZTAuLmQ5OGEzNWVmYjgwYTNhNzlmN2Q5NzRhNjYxZDc1YjBjOTE2MGM2ZTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3Vy Y2VHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwCkBAIC05NDAsNyArOTQwLDcgQEAg dm9pZCBTdHJlYW1pbmdDbGllbnQ6OmhhbmRsZURhdGFSZWNlaXZlZChjb25zdCBjaGFyKiBkYXRh LCBpbnQgbGVuZ3RoKQogCiAgICAgR011dGV4TG9ja2VyIGxvY2tlcihHU1RfT0JKRUNUX0dFVF9M T0NLKHNyYykpOwogCi0gICAgR1NUX0xPR19PQkpFQ1Qoc3JjLCAiSGF2ZSAlbGQgYnl0ZXMgb2Yg ZGF0YSIsIHByaXYtPmJ1ZmZlciA/IGdzdF9idWZmZXJfZ2V0X3NpemUocHJpdi0+YnVmZmVyLmdl dCgpKSA6IGxlbmd0aCk7CisgICAgR1NUX0xPR19PQkpFQ1Qoc3JjLCAiSGF2ZSAlbGxkIGJ5dGVz IG9mIGRhdGEiLCBwcml2LT5idWZmZXIgPyBzdGF0aWNfY2FzdDxsb25nIGxvbmc+KGdzdF9idWZm ZXJfZ2V0X3NpemUocHJpdi0+YnVmZmVyLmdldCgpKSkgOiBsZW5ndGgpOwogCiAgICAgQVNTRVJU KCFwcml2LT5idWZmZXIgfHwgZGF0YSA9PSBnZXRHc3RCdWZmZXJEYXRhUG9pbnRlcihwcml2LT5i dWZmZXIuZ2V0KCkpKTsKIAo=