125296 2013-12-05 02:52:32 -0800 [EFL] Buildfix after r160151 2022-03-01 02:56:07 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 125298 P2 Normal --- 1 k.czech webkit-unassigned commit-queue eflews.bot gustavo gyuyoung.kim lucas.de.marchi lvidacs.u-szeged menard mrobinson nick.diego ossy pnormand ryuan.choi oldest_to_newest 956828 0 k.czech 2013-12-05 02:52:32 -0800 /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:517: error: format '%ld' expects argument of type 'long int', but argument 8 has type 'unsigned int' [-Werror=format] 956829 1 218496 k.czech 2013-12-05 02:55:59 -0800 Created attachment 218496 patch 956831 2 commit-queue 2013-12-05 02:58:10 -0800 Attachment 218496 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 956833 3 k.czech 2013-12-05 03:03:59 -0800 Changing format specifier from %ld to %d 956837 4 218496 eflews.bot 2013-12-05 03:11:24 -0800 Comment on attachment 218496 patch Attachment 218496 did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/39298350 956840 5 218496 eflews.bot 2013-12-05 03:48:23 -0800 Comment on attachment 218496 patch Attachment 218496 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/43618008 956849 6 nick.diego 2013-12-05 04:25:03 -0800 /mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: In member function 'void StreamingClient::handleDataReceived(const char*, int)': /mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:483: error: format '%d' expects argument of type 'int', but argument 8 has type 'long unsigned int' [-Werror=format] Looks like it should be %lu :) 956850 7 ryuan.choi 2013-12-05 04:34:36 -0800 (In reply to comment #6) > /mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: In member function 'void StreamingClient::handleDataReceived(const char*, int)': > /mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:483: error: format '%d' expects argument of type 'int', but argument 8 has type 'long unsigned int' [-Werror=format] > > Looks like it should be %lu :) So, is static_cast<unsigned long>(length) only the solution ? 956856 8 k.czech 2013-12-05 04:53:46 -0800 (In reply to comment #7) > (In reply to comment #6) > > /mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: In member function 'void StreamingClient::handleDataReceived(const char*, int)': > > /mnt/eflews/webkit/WebKit/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943:483: error: format '%d' expects argument of type 'int', but argument 8 has type 'long unsigned int' [-Werror=format] > > > > Looks like it should be %lu :) > > So, is static_cast<unsigned long>(length) only the solution ? What about signed values ?, maybe static_cast<long>(length) 956857 9 218502 k.czech 2013-12-05 04:57:34 -0800 Created attachment 218502 patch 956860 10 commit-queue 2013-12-05 04:58:45 -0800 Attachment 218502 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943: Comma should be at the beggining of the line in a member initialization list. [whitespace/init] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 956871 11 pnormand 2013-12-05 05:23:15 -0800 *** Bug 125298 has been marked as a duplicate of this bug. *** 956879 12 lvidacs.u-szeged 2013-12-05 05:40:45 -0800 A possible solution is submitted to https://bugs.webkit.org/show_bug.cgi?id=125298 Unsigned int does not fit in long int, so the common type for both values could be long long int. Could you take a look at that patch? 957055 13 ossy 2013-12-05 14:42:02 -0800 Mark this one as duplicate, because the other bug contains the proper fix. *** This bug has been marked as a duplicate of bug 125298 *** 218496 2013-12-05 02:55:59 -0800 2013-12-05 04:57:34 -0800 patch patch.patch text/plain 1413 k.czech ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3MzFlOTdmLi4wNTM2NmRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTMtMTItMDUgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CisK KyAgICAgICAgW0VGTF0gQnVpbGRmaXggYWZ0ZXIgcjE2MDE1MQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1Mjk2CisKKyAgICAgICAgVW5yZXZpZXdl ZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3Vy Y2VHU3RyZWFtZXIuY3BwOgorICAgICAgICAoU3RyZWFtaW5nQ2xpZW50OjpoYW5kbGVEYXRhUmVj ZWl2ZWQpOgorCiAyMDEzLTEyLTA1ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNv bT4KIAogICAgICAgICBbR1RLXSBNb3ZlIHBsYXRmb3JtIHNvdXJjZXMgZnJlZSBvZiBsYXllcmlu ZyB2aW9sYXRpb25zIHVuZGVyIGxpYlBsYXRmb3JtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJT b3VyY2VHU3RyZWFtZXIuY3BwCmluZGV4IGFmNzhhZTAuLmZhMTE4OWIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VH U3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwCkBAIC05NDAsNyArOTQwLDcgQEAgdm9p ZCBTdHJlYW1pbmdDbGllbnQ6OmhhbmRsZURhdGFSZWNlaXZlZChjb25zdCBjaGFyKiBkYXRhLCBp bnQgbGVuZ3RoKQogCiAgICAgR011dGV4TG9ja2VyIGxvY2tlcihHU1RfT0JKRUNUX0dFVF9MT0NL KHNyYykpOwogCi0gICAgR1NUX0xPR19PQkpFQ1Qoc3JjLCAiSGF2ZSAlbGQgYnl0ZXMgb2YgZGF0 YSIsIHByaXYtPmJ1ZmZlciA/IGdzdF9idWZmZXJfZ2V0X3NpemUocHJpdi0+YnVmZmVyLmdldCgp KSA6IGxlbmd0aCk7CisgICAgR1NUX0xPR19PQkpFQ1Qoc3JjLCAiSGF2ZSAlZCBieXRlcyBvZiBk YXRhIiwgcHJpdi0+YnVmZmVyID8gZ3N0X2J1ZmZlcl9nZXRfc2l6ZShwcml2LT5idWZmZXIuZ2V0 KCkpIDogbGVuZ3RoKTsKIAogICAgIEFTU0VSVCghcHJpdi0+YnVmZmVyIHx8IGRhdGEgPT0gZ2V0 R3N0QnVmZmVyRGF0YVBvaW50ZXIocHJpdi0+YnVmZmVyLmdldCgpKSk7CiAK 218502 2013-12-05 04:57:34 -0800 2022-03-01 02:56:07 -0800 patch patch.patch text/plain 1433 k.czech ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3MzFlOTdmLi4wNTM2NmRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTMtMTItMDUgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CisK KyAgICAgICAgW0VGTF0gQnVpbGRmaXggYWZ0ZXIgcjE2MDE1MQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1Mjk2CisKKyAgICAgICAgVW5yZXZpZXdl ZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3Vy Y2VHU3RyZWFtZXIuY3BwOgorICAgICAgICAoU3RyZWFtaW5nQ2xpZW50OjpoYW5kbGVEYXRhUmVj ZWl2ZWQpOgorCiAyMDEzLTEyLTA1ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNv bT4KIAogICAgICAgICBbR1RLXSBNb3ZlIHBsYXRmb3JtIHNvdXJjZXMgZnJlZSBvZiBsYXllcmlu ZyB2aW9sYXRpb25zIHVuZGVyIGxpYlBsYXRmb3JtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJT b3VyY2VHU3RyZWFtZXIuY3BwCmluZGV4IGFmNzhhZTAuLjY2YTI0ZWQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VH U3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwCkBAIC05NDAsNyArOTQwLDcgQEAgdm9p ZCBTdHJlYW1pbmdDbGllbnQ6OmhhbmRsZURhdGFSZWNlaXZlZChjb25zdCBjaGFyKiBkYXRhLCBp bnQgbGVuZ3RoKQogCiAgICAgR011dGV4TG9ja2VyIGxvY2tlcihHU1RfT0JKRUNUX0dFVF9MT0NL KHNyYykpOwogCi0gICAgR1NUX0xPR19PQkpFQ1Qoc3JjLCAiSGF2ZSAlbGQgYnl0ZXMgb2YgZGF0 YSIsIHByaXYtPmJ1ZmZlciA/IGdzdF9idWZmZXJfZ2V0X3NpemUocHJpdi0+YnVmZmVyLmdldCgp KSA6IGxlbmd0aCk7CisgICAgR1NUX0xPR19PQkpFQ1Qoc3JjLCAiSGF2ZSAlbGQgYnl0ZXMgb2Yg ZGF0YSIsIHByaXYtPmJ1ZmZlciA/IGdzdF9idWZmZXJfZ2V0X3NpemUocHJpdi0+YnVmZmVyLmdl dCgpKSA6IHN0YXRpY19jYXN0PGxvbmc+KGxlbmd0aCkpOwogCiAgICAgQVNTRVJUKCFwcml2LT5i dWZmZXIgfHwgZGF0YSA9PSBnZXRHc3RCdWZmZXJEYXRhUG9pbnRlcihwcml2LT5idWZmZXIuZ2V0 KCkpKTsKIAo=