125287 2013-12-04 23:51:35 -0800 Remove bridge/testqtbindings.cpp. 2013-12-05 00:45:08 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 llango.u-szeged webkit-unassigned ap commit-queue gyuyoung.kim zherczeg oldest_to_newest 956790 0 llango.u-szeged 2013-12-04 23:51:35 -0800 There is no QT anymore. We don't need this file. 956791 1 218491 llango.u-szeged 2013-12-04 23:55:05 -0800 Created attachment 218491 Patch 956797 2 218491 ap 2013-12-05 00:16:12 -0800 Comment on attachment 218491 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218491&action=review r=me > Source/WebCore/ChangeLog:8 > + * bridge/testqtbindings.cpp: Removed. There is no QT anymore. Officially, it's "Qt", not "QT". The latter is more commonly used as an abbreviation for QuickTime. 956801 3 218491 commit-queue 2013-12-05 00:45:05 -0800 Comment on attachment 218491 Patch Clearing flags on attachment: 218491 Committed r160163: <http://trac.webkit.org/changeset/160163> 956802 4 commit-queue 2013-12-05 00:45:08 -0800 All reviewed patches have been landed. Closing bug. 218491 2013-12-04 23:55:05 -0800 2013-12-05 00:45:05 -0800 Patch bug-125287-20131204235504.patch text/plain 5777 llango.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGRiMTY4MzEwYTYyZmU4 YWRiYWRlYjUyZjI3NmU5YzE4NmY4MjNmZS4uMjFiYzE1ZmQwMDNjY2M5NWVkNjdiZGUwOTFkNjFh N2RmOTBiNDhiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTEyLTA1ICBMw6Fz emzDsyBMYW5nw7MgIDxsYW5nb0BpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmVtb3ZlIGJy aWRnZS90ZXN0cXRiaW5kaW5ncy5jcHAuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjUyODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGJyaWRnZS90ZXN0cXRiaW5kaW5ncy5jcHA6IFJlbW92ZWQuIFRo ZXJlIGlzIG5vIFFUIGFueW1vcmUuCisgICAgICAgIFdlIGRvbid0IG5lZWQgdGhpcyBmaWxlLgor CiAyMDEzLTEyLTA0ICBMw6FzemzDsyBMYW5nw7MgIDxsYW5nb0BpbmYudS1zemVnZWQuaHU+CiAK ICAgICAgICAgVHlwbyBmaXggYWZ0ZXIgcjE2MDA3NCB0byBmaXggZGVidWcgYnVpbGRzLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYnJpZGdlL3Rlc3RxdGJpbmRpbmdzLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2JyaWRnZS90ZXN0cXRiaW5kaW5ncy5jcHAKZGVsZXRlZCBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IGMyNTBjOTliN2NhM2M4NmQ5YjAxNjMxMjMzMmYwOWY4MWEwMGVkYWYuLjAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAKLS0tIGEvU291cmNlL1dlYkNvcmUv YnJpZGdlL3Rlc3RxdGJpbmRpbmdzLmNwcAorKysgL2Rldi9udWxsCkBAIC0xLDE0MSArMCwwIEBA Ci0vKgotICogQ29weXJpZ2h0IChDKSAyMDA4IE5va2lhIENvcnBvcmF0aW9uIGFuZC9vciBpdHMg c3Vic2lkaWFyeSgtaWVzKQotICoKLSAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNl IGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAotICogbW9kaWZpY2F0aW9uLCBhcmUg cGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCi0gKiBhcmUg bWV0OgotICogMS4gUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRo ZSBhYm92ZSBjb3B5cmlnaHQKLSAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMg YW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KLSAqIDIuIFJlZGlzdHJpYnV0aW9ucyBpbiBi aW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0Ci0gKiAgICBub3Rp Y2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIg aW4gdGhlCi0gKiAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlk ZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgotICoKLSAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklE RUQgQlkgQVBQTEUgQ09NUFVURVIsIElOQy4gYGBBUyBJUycnIEFORCBBTlkKLSAqIEVYUFJFU1Mg T1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhF Ci0gKiBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZP UiBBIFBBUlRJQ1VMQVIKLSAqIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuICBJTiBOTyBFVkVOVCBT SEFMTCBBUFBMRSBDT01QVVRFUiwgSU5DLiBPUgotICogQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBG T1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsCi0gKiBFWEVNUExB UlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQg VE8sCi0gKiBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NT IE9GIFVTRSwgREFUQSwgT1IKLSAqIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikg SE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkKLSAqIE9GIExJQUJJTElUWSwgV0hFVEhF UiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAotICogKElOQ0xVRElORyBO RUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNF Ci0gKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZ IE9GIFNVQ0ggREFNQUdFLiAKLSAqLwotI2luY2x1ZGUgImNvbmZpZy5oIgotCi0jaW5jbHVkZSAi QnJpZGdlSlNDLmgiCi0jaW5jbHVkZSAiSlNDSlNWYWx1ZS5oIgotI2luY2x1ZGUgIkpTT2JqZWN0 LmgiCi0jaW5jbHVkZSAiaW50ZXJwcmV0ZXIuaCIKLSNpbmNsdWRlICJxZGVidWcuaCIKLSNpbmNs dWRlICJxb2JqZWN0LmgiCi0jaW5jbHVkZSAicnVudGltZV9vYmplY3QuaCIKLSNpbmNsdWRlICJ0 eXBlcy5oIgotI2luY2x1ZGUgPGFzc2VydC5oPgotI2luY2x1ZGUgPHN0ZGlvLmg+Ci0jaW5jbHVk ZSA8c3RyaW5nLmg+Ci0KLQotY2xhc3MgTXlPYmplY3QgOiBwdWJsaWMgUU9iamVjdAotewotICAg IFFfT0JKRUNUCi0gICAgUV9QUk9QRVJUWShRU3RyaW5nIHRlc3RTdHJpbmcgUkVBRCB0ZXN0U3Ry aW5nIFdSSVRFIHNldFRlc3RTdHJpbmcpCi0gICAgUV9QUk9QRVJUWShpbnQgdGVzdEludCBSRUFE IHRlc3RJbnQgV1JJVEUgc2V0VGVzdEludCkKLQotcHVibGljOgotICAgIE15T2JqZWN0KCkgOiBR T2JqZWN0KDApLCBpbnRlZ2VyKDApe30KLQotICAgIHZvaWQgc2V0VGVzdFN0cmluZyhjb25zdCBR U3RyaW5nICZzdHIpIHsKLSAgICAgICAgcURlYnVnKCkgPDwgImNhbGxlZCBzZXRUZXN0U3RyaW5n IiA8PCBzdHI7Ci0gICAgICAgIHN0cmluZyA9IHN0cjsKLSAgICB9Ci0gICAgdm9pZCBzZXRUZXN0 SW50KGludCBpKSB7Ci0gICAgICAgIHFEZWJ1ZygpIDw8ICJjYWxsZWQgc2V0VGVzdEludCIgPDwg aTsKLSAgICAgICAgaW50ZWdlciA9IGk7Ci0gICAgfQotICAgIFFTdHJpbmcgdGVzdFN0cmluZygp IGNvbnN0IHsKLSAgICAgICAgcURlYnVnKCkgPDwgImNhbGxlZCB0ZXN0U3RyaW5nIiA8PCBzdHJp bmc7Ci0gICAgICAgIHJldHVybiBzdHJpbmc7Ci0gICAgfQotICAgIGludCB0ZXN0SW50KCkgY29u c3QgewotICAgICAgICBxRGVidWcoKSA8PCAiY2FsbGVkIHRlc3RJbnQiIDw8IGludGVnZXI7Ci0g ICAgICAgIHJldHVybiBpbnRlZ2VyOwotICAgIH0KLSAgICBRU3RyaW5nIHN0cmluZzsKLSAgICBp bnQgaW50ZWdlcjsKLQotcHVibGljIFFfU0xPVFM6Ci0gICAgdm9pZCBmb28oKSB7IHFEZWJ1Zygp IDw8ICJmb28gaW52b2tlZCI7IH0KLX07Ci0KLS8vIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCi0KLXVzaW5nIG5hbWVzcGFjZSBKU0M7Ci11 c2luZyBuYW1lc3BhY2UgSlNDOjpCaW5kaW5nczsKLQotY2xhc3MgR2xvYmFsIDogcHVibGljIEpT Tm9uRmluYWxPYmplY3QgewotcHVibGljOgotICAgIHR5cGVkZWYgSlNOb25GaW5hbE9iamVjdCBC YXNlOwotCi0gICAgc3RhdGljIFN0cmluZyBjbGFzc05hbWUoY29uc3QgSlNPYmplY3QqKSB7IHJl dHVybiAiZ2xvYmFsIjsgfQotfTsKLQotc3RhdGljIGNoYXIgY29kZVtdID0KLSAgICAibXlJbnRl cmZhY2UuZm9vKCk7XG4iCi0gICAgIm15SW50ZXJmYWNlLnRlc3RTdHJpbmcgPSBcIkhlbGxvXCI7 XG4iCi0gICAgInN0ciA9IG15SW50ZXJmYWNlLnRlc3RTdHJpbmc7XG4iCi0gICAgIm15SW50ZXJm YWNlLnRlc3RJbnQgPSAxMDtcbiIKLSAgICAiaSA9IG15SW50ZXJmYWNlLnRlc3RJbnQ7XG4iOwot Ci1pbnQgbWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCi17Ci0gICAgLy8gZXhwZWN0aW5nIGEg ZmlsZW5hbWUKLSAgICBib29sIHJldCA9IHRydWU7Ci0gICAgewotICAgICAgICBKU0xvY2sgbG9j azsKLSAgICAgICAgCi0gICAgICAgIC8vIGNyZWF0ZSBpbnRlcnByZXRlciB3LyBnbG9iYWwgb2Jq ZWN0Ci0gICAgICAgIEdsb2JhbCogZ2xvYmFsID0gbmV3IEdsb2JhbCgpOwotCi0gICAgICAgIC8v IGNyZWF0ZSBpbnRlcnByZXRlcgotICAgICAgICBSZWZQdHI8SW50ZXJwcmV0ZXI+IGludGVycCA9 IG5ldyBJbnRlcnByZXRlcihnbG9iYWwpOwotICAgICAgICBFeGVjU3RhdGUqIGV4ZWMgPSBpbnRl cnAtPmdsb2JhbEV4ZWMoKTsKLSAgICAgICAgCi0gICAgICAgIE15T2JqZWN0KiBteU9iamVjdCA9 IG5ldyBNeU9iamVjdDsKLSAgICAgICAgCi0gICAgICAgIGdsb2JhbC0+bWV0aG9kVGFibGUoKS0+ cHV0KGdsb2JhbCwgZXhlYywgSWRlbnRpZmllcigibXlJbnRlcmZhY2UiKSwgSW5zdGFuY2U6OmNy ZWF0ZVJ1bnRpbWVPYmplY3QoSW5zdGFuY2U6OlF0TGFuZ3VhZ2UsICh2b2lkKilteU9iamVjdCkp OwotICAgICAgICAKLSAgICAgICAgCi0gICAgICAgIGlmIChjb2RlKSB7Ci0gICAgICAgICAgICAv LyBydW4KLSAgICAgICAgICAgIENvbXBsZXRpb24gY29tcChpbnRlcnAtPmV2YWx1YXRlKCIiLCAw LCBjb2RlKSk7Ci0gICAgICAgICAgICAKLSAgICAgICAgICAgIGlmIChjb21wLmNvbXBsVHlwZSgp ID09IFRocm93KSB7Ci0gICAgICAgICAgICAgICAgcURlYnVnKCkgPDwgImV4Y2VwdGlvbiB0aHJv d24iOwotICAgICAgICAgICAgICAgIEpTVmFsdWUqIGV4VmFsID0gY29tcC52YWx1ZSgpOwotICAg ICAgICAgICAgICAgIGNoYXIqIG1zZyA9IGV4VmFsLT50b1N0cmluZyhleGVjKS0+dmFsdWUoZXhl YykuYXNjaWkoKTsKLSAgICAgICAgICAgICAgICBpbnQgbGluZW5vID0gLTE7Ci0gICAgICAgICAg ICAgICAgaWYgKGV4VmFsLT50eXBlKCkgPT0gT2JqZWN0VHlwZSkgewotICAgICAgICAgICAgICAg ICAgICBKU1ZhbHVlKiBsaW5lVmFsID0gZXhWYWwtPmdldE9iamVjdCgpLT5nZXQoZXhlYywgSWRl bnRpZmllcigibGluZSIpKTsKLSAgICAgICAgICAgICAgICAgICAgaWYgKGxpbmVWYWwtPnR5cGUo KSA9PSBOdW1iZXJUeXBlKQotICAgICAgICAgICAgICAgICAgICAgICAgbGluZW5vID0gaW50KGxp bmVWYWwtPnRvTnVtYmVyKGV4ZWMpKTsKLSAgICAgICAgICAgICAgICB9Ci0gICAgICAgICAgICAg ICAgaWYgKGxpbmVubyAhPSAtMSkKLSAgICAgICAgICAgICAgICAgICAgZnByaW50ZihzdGRlcnIs IkV4Y2VwdGlvbiwgbGluZSAlZDogJXNcbiIsbGluZW5vLG1zZyk7Ci0gICAgICAgICAgICAgICAg ZWxzZQotICAgICAgICAgICAgICAgICAgICBmcHJpbnRmKHN0ZGVyciwiRXhjZXB0aW9uOiAlc1xu Iixtc2cpOwotICAgICAgICAgICAgICAgIHJldCA9IGZhbHNlOwotICAgICAgICAgICAgfQotICAg ICAgICAgICAgZWxzZSBpZiAoY29tcC5jb21wbFR5cGUoKSA9PSBSZXR1cm5WYWx1ZSkgewotICAg ICAgICAgICAgICAgIGNoYXIqIG1zZyA9IGNvbXAudmFsdWUoKS0+dG9TdHJpbmcoaW50ZXJwLT5n bG9iYWxFeGVjKCkpLmFzY2lpKCk7Ci0gICAgICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsIlJl dHVybiB2YWx1ZTogJXNcbiIsbXNnKTsKLSAgICAgICAgICAgIH0KLSAgICAgICAgfQotICAgICAg ICAKLSAgICB9IC8vIGVuZCBibG9jaywgc28gdGhhdCBJbnRlcnByZXRlciBhbmQgZ2xvYmFsIGdl dCBkZWxldGVkCi0gICAgCi0gICAgcmV0dXJuIHJldCA/IDAgOiAxOwotfQotCi0jaW5jbHVkZSAi dGVzdHF0YmluZGluZ3MubW9jIgo=