125283 2013-12-04 23:31:46 -0800 FTL should support all of ValueToInt32 2013-12-06 12:56:43 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 125275 112840 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 956783 0 fpizlo 2013-12-04 23:31:46 -0800 Not just the boolean bits. 957346 1 218615 fpizlo 2013-12-06 12:34:01 -0800 Created attachment 218615 the patch 957353 2 218615 mhahnenberg 2013-12-06 12:46:25 -0800 Comment on attachment 218615 the patch r=me with test 957360 3 fpizlo 2013-12-06 12:56:43 -0800 Landed in http://trac.webkit.org/changeset/160242 218615 2013-12-06 12:34:01 -0800 2013-12-06 12:46:25 -0800 the patch blah.patch text/plain 7336 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwMjM4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEzLTEyLTA2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RlRMIHNob3VsZCBzdXBwb3J0IGFsbCBvZiBWYWx1ZVRvSW50MzIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTI4MworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZnRsL0ZUTENhcGFiaWxpdGllcy5jcHA6 CisgICAgICAgIChKU0M6OkZUTDo6Y2FuQ29tcGlsZSk6CisgICAgICAgICogZnRsL0ZUTExvd2Vy REZHVG9MTFZNLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpMb3dlckRGR1RvTExWTTo6Y29tcGls ZVZhbHVlVG9JbnQzMik6CisgICAgICAgIChKU0M6OkZUTDo6TG93ZXJERkdUb0xMVk06OmNvbXBp bGVQdXRCeVZhbCk6CisgICAgICAgIChKU0M6OkZUTDo6TG93ZXJERkdUb0xMVk06Omxvd0NlbGwp OgorICAgICAgICAoSlNDOjpGVEw6Okxvd2VyREZHVG9MTFZNOjppc0NlbGwpOgorCiAyMDEzLTEy LTA2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgRlRMIHNob3Vs ZG4ndCBoYXZlIGEgZG91YmxlVG9VSW50MzIgcGF0aApJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL2Z0bC9GVExDYXBhYmlsaXRpZXMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9mdGwvRlRMQ2FwYWJpbGl0aWVzLmNwcAkocmV2aXNpb24gMTYwMjM1KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExDYXBhYmlsaXRpZXMuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xMDUsNiArMTA1LDcgQEAgaW5saW5lIENhcGFiaWxpdHlMZXZlbCBjYW5Db21waWxlKE5v ZGUqIAogICAgIGNhc2UgRnVuY3Rpb25SZWVudHJ5V2F0Y2hwb2ludDoKICAgICBjYXNlIFZhcmlh YmxlV2F0Y2hwb2ludDoKICAgICBjYXNlIE5vdGlmeVdyaXRlOgorICAgIGNhc2UgVmFsdWVUb0lu dDMyOgogICAgICAgICAvLyBUaGVzZSBhcmUgT0suCiAgICAgICAgIGJyZWFrOwogICAgIGNhc2Ug R2V0QnlJZDoKQEAgLTIyNCwxMCArMjI1LDYgQEAgaW5saW5lIENhcGFiaWxpdHlMZXZlbCBjYW5D b21waWxlKE5vZGUqIAogICAgICAgICAgICAgcmV0dXJuIENhbm5vdENvbXBpbGU7CiAgICAgICAg IH0KICAgICAgICAgYnJlYWs7Ci0gICAgY2FzZSBWYWx1ZVRvSW50MzI6Ci0gICAgICAgIGlmIChu b2RlLT5jaGlsZDEoKS51c2VLaW5kKCkgIT0gQm9vbGVhblVzZSkKLSAgICAgICAgICAgIHJldHVy biBDYW5ub3RDb21waWxlOwotICAgICAgICBicmVhazsKICAgICBkZWZhdWx0OgogICAgICAgICAv LyBEb24ndCBrbm93IGhvdyB0byBoYW5kbGUgYW55dGhpbmcgZWxzZS4KICAgICAgICAgcmV0dXJu IENhbm5vdENvbXBpbGU7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2Vy REZHVG9MTFZNLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZU TExvd2VyREZHVG9MTFZNLmNwcAkocmV2aXNpb24gMTYwMjM1KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ4NCw4 ICs0ODQsOTYgQEAgcHJpdmF0ZToKIAogICAgIHZvaWQgY29tcGlsZVZhbHVlVG9JbnQzMigpCiAg ICAgewotICAgICAgICBBU1NFUlQobV9ub2RlLT5jaGlsZDEoKS51c2VLaW5kKCkgPT0gQm9vbGVh blVzZSk7Ci0gICAgICAgIHNldEludDMyKG1fb3V0Lnplcm9FeHQobG93Qm9vbGVhbihtX25vZGUt PmNoaWxkMSgpKSwgbV9vdXQuaW50MzIpKTsKKyAgICAgICAgc3dpdGNoIChtX25vZGUtPmNoaWxk MSgpLnVzZUtpbmQoKSkgeworICAgICAgICBjYXNlIEludDMyVXNlOgorICAgICAgICAgICAgc2V0 SW50MzIobG93SW50MzIobV9ub2RlLT5jaGlsZDEoKSkpOworICAgICAgICAgICAgYnJlYWs7Cisg ICAgICAgICAgICAKKyAgICAgICAgY2FzZSBNYWNoaW5lSW50VXNlOgorICAgICAgICAgICAgc2V0 SW50MzIobV9vdXQuY2FzdFRvSW50MzIobG93U3RyaWN0SW50NTIobV9ub2RlLT5jaGlsZDEoKSkp KTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgCisgICAgICAgIGNhc2UgTnVtYmVy VXNlOgorICAgICAgICBjYXNlIE5vdENlbGxVc2U6IHsKKyAgICAgICAgICAgIExvd2VyZWROb2Rl VmFsdWUgdmFsdWUgPSBtX2ludDMyVmFsdWVzLmdldChtX25vZGUtPmNoaWxkMSgpLm5vZGUoKSk7 CisgICAgICAgICAgICBpZiAoaXNWYWxpZCh2YWx1ZSkpIHsKKyAgICAgICAgICAgICAgICBzZXRJ bnQzMih2YWx1ZS52YWx1ZSgpKTsKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAg IH0KKyAgICAgICAgICAgIAorICAgICAgICAgICAgdmFsdWUgPSBtX2pzVmFsdWVWYWx1ZXMuZ2V0 KG1fbm9kZS0+Y2hpbGQxKCkubm9kZSgpKTsKKyAgICAgICAgICAgIGlmIChpc1ZhbGlkKHZhbHVl KSkgeworICAgICAgICAgICAgICAgIExCYXNpY0Jsb2NrIGludENhc2UgPSBGVExfTkVXX0JMT0NL KG1fb3V0LCAoIlZhbHVlVG9JbnQzMiBpbnQgY2FzZSIpKTsKKyAgICAgICAgICAgICAgICBMQmFz aWNCbG9jayBub3RJbnRDYXNlID0gRlRMX05FV19CTE9DSyhtX291dCwgKCJWYWx1ZVRvSW50MzIg bm90IGludCBjYXNlIikpOworICAgICAgICAgICAgICAgIExCYXNpY0Jsb2NrIGRvdWJsZUNhc2Ug PSAwOworICAgICAgICAgICAgICAgIExCYXNpY0Jsb2NrIG5vdE51bWJlckNhc2UgPSAwOworICAg ICAgICAgICAgICAgIGlmIChtX25vZGUtPmNoaWxkMSgpLnVzZUtpbmQoKSA9PSBOb3RDZWxsVXNl KSB7CisgICAgICAgICAgICAgICAgICAgIGRvdWJsZUNhc2UgPSBGVExfTkVXX0JMT0NLKG1fb3V0 LCAoIlZhbHVlVG9JbnQzMiBkb3VibGUgY2FzZSIpKTsKKyAgICAgICAgICAgICAgICAgICAgbm90 TnVtYmVyQ2FzZSA9IEZUTF9ORVdfQkxPQ0sobV9vdXQsICgiVmFsdWVUb0ludDMyIG5vdCBudW1i ZXIgY2FzZSIpKTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgTEJhc2ljQmxv Y2sgY29udGludWF0aW9uID0gRlRMX05FV19CTE9DSyhtX291dCwgKCJWYWx1ZVRvSW50MzIgY29u dGludWF0aW9uIikpOworICAgICAgICAgICAgICAgIAorICAgICAgICAgICAgICAgIFZlY3RvcjxW YWx1ZUZyb21CbG9jaz4gcmVzdWx0czsKKyAgICAgICAgICAgICAgICAKKyAgICAgICAgICAgICAg ICBtX291dC5icmFuY2goaXNOb3RJbnQzMih2YWx1ZS52YWx1ZSgpKSwgbm90SW50Q2FzZSwgaW50 Q2FzZSk7CisgICAgICAgICAgICAgICAgCisgICAgICAgICAgICAgICAgTEJhc2ljQmxvY2sgbGFz dE5leHQgPSBtX291dC5hcHBlbmRUbyhpbnRDYXNlLCBub3RJbnRDYXNlKTsKKyAgICAgICAgICAg ICAgICByZXN1bHRzLmFwcGVuZChtX291dC5hbmNob3IodW5ib3hJbnQzMih2YWx1ZS52YWx1ZSgp KSkpOworICAgICAgICAgICAgICAgIG1fb3V0Lmp1bXAoY29udGludWF0aW9uKTsKKyAgICAgICAg ICAgICAgICAKKyAgICAgICAgICAgICAgICBpZiAobV9ub2RlLT5jaGlsZDEoKS51c2VLaW5kKCkg PT0gTnVtYmVyVXNlKSB7CisgICAgICAgICAgICAgICAgICAgIG1fb3V0LmFwcGVuZFRvKG5vdElu dENhc2UsIGNvbnRpbnVhdGlvbik7CisgICAgICAgICAgICAgICAgICAgIEZUTF9UWVBFX0NIRUNL KAorICAgICAgICAgICAgICAgICAgICAgICAganNWYWx1ZVZhbHVlKHZhbHVlLnZhbHVlKCkpLCBt X25vZGUtPmNoaWxkMSgpLCBTcGVjRnVsbE51bWJlciwKKyAgICAgICAgICAgICAgICAgICAgICAg IGlzQ2VsbE9yTWlzYyh2YWx1ZS52YWx1ZSgpKSk7CisgICAgICAgICAgICAgICAgICAgIHJlc3Vs dHMuYXBwZW5kKG1fb3V0LmFuY2hvcihkb3VibGVUb0ludDMyKHVuYm94RG91YmxlKHZhbHVlLnZh bHVlKCkpKSkpOworICAgICAgICAgICAgICAgICAgICBtX291dC5qdW1wKGNvbnRpbnVhdGlvbik7 CisgICAgICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICAgICAgbV9vdXQuYXBw ZW5kVG8obm90SW50Q2FzZSwgZG91YmxlQ2FzZSk7CisgICAgICAgICAgICAgICAgICAgIG1fb3V0 LmJyYW5jaChpc0NlbGxPck1pc2ModmFsdWUudmFsdWUoKSksIG5vdE51bWJlckNhc2UsIGRvdWJs ZUNhc2UpOworICAgICAgICAgICAgICAgICAgICAKKyAgICAgICAgICAgICAgICAgICAgbV9vdXQu YXBwZW5kVG8oZG91YmxlQ2FzZSwgbm90TnVtYmVyQ2FzZSk7CisgICAgICAgICAgICAgICAgICAg IHJlc3VsdHMuYXBwZW5kKG1fb3V0LmFuY2hvcihkb3VibGVUb0ludDMyKHVuYm94RG91YmxlKHZh bHVlLnZhbHVlKCkpKSkpOworICAgICAgICAgICAgICAgICAgICBtX291dC5qdW1wKGNvbnRpbnVh dGlvbik7CisgICAgICAgICAgICAgICAgICAgIAorICAgICAgICAgICAgICAgICAgICBtX291dC5h cHBlbmRUbyhub3ROdW1iZXJDYXNlLCBjb250aW51YXRpb24pOworICAgICAgICAgICAgICAgICAg ICAKKyAgICAgICAgICAgICAgICAgICAgRlRMX1RZUEVfQ0hFQ0soCisgICAgICAgICAgICAgICAg ICAgICAgICBqc1ZhbHVlVmFsdWUodmFsdWUudmFsdWUoKSksIG1fbm9kZS0+Y2hpbGQxKCksIH5T cGVjQ2VsbCwKKyAgICAgICAgICAgICAgICAgICAgICAgIGlzQ2VsbCh2YWx1ZS52YWx1ZSgpKSk7 CisgICAgICAgICAgICAgICAgICAgIAorICAgICAgICAgICAgICAgICAgICBMVmFsdWUgc3BlY2lh bFJlc3VsdCA9IG1fb3V0LnNlbGVjdCgKKyAgICAgICAgICAgICAgICAgICAgICAgIG1fb3V0LmVx dWFsKAorICAgICAgICAgICAgICAgICAgICAgICAgICAgIHZhbHVlLnZhbHVlKCksCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgbV9vdXQuY29uc3RJbnQ2NChKU1ZhbHVlOjplbmNvZGUoanNC b29sZWFuKHRydWUpKSkpLAorICAgICAgICAgICAgICAgICAgICAgICAgbV9vdXQuaW50MzJPbmUs IG1fb3V0LmludDMyWmVybyk7CisgICAgICAgICAgICAgICAgICAgIHJlc3VsdHMuYXBwZW5kKG1f b3V0LmFuY2hvcihzcGVjaWFsUmVzdWx0KSk7CisgICAgICAgICAgICAgICAgICAgIG1fb3V0Lmp1 bXAoY29udGludWF0aW9uKTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgCisg ICAgICAgICAgICAgICAgbV9vdXQuYXBwZW5kVG8oY29udGludWF0aW9uLCBsYXN0TmV4dCk7Cisg ICAgICAgICAgICAgICAgc2V0SW50MzIobV9vdXQucGhpKG1fb3V0LmludDMyLCByZXN1bHRzKSk7 CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICB9CisgICAgICAgICAgICAKKyAg ICAgICAgICAgIHZhbHVlID0gbV9kb3VibGVWYWx1ZXMuZ2V0KG1fbm9kZS0+Y2hpbGQxKCkubm9k ZSgpKTsKKyAgICAgICAgICAgIGlmIChpc1ZhbGlkKHZhbHVlKSkgeworICAgICAgICAgICAgICAg IHNldEludDMyKGRvdWJsZVRvSW50MzIodmFsdWUudmFsdWUoKSkpOworICAgICAgICAgICAgICAg IGJyZWFrOworICAgICAgICAgICAgfQorICAgICAgICAgICAgCisgICAgICAgICAgICB0ZXJtaW5h dGUoVW5jb3VudGFibGUpOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KKyAgICAgICAg ICAgIAorICAgICAgICBjYXNlIEJvb2xlYW5Vc2U6CisgICAgICAgICAgICBzZXRJbnQzMihtX291 dC56ZXJvRXh0KGxvd0Jvb2xlYW4obV9ub2RlLT5jaGlsZDEoKSksIG1fb3V0LmludDMyKSk7Cisg ICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIAorICAgICAgICBkZWZhdWx0OgorICAgICAg ICAgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgICAgIGJyZWFrOwor ICAgICAgICB9CiAgICAgfQogCiAgICAgdm9pZCBjb21waWxlSW50NTJUb1ZhbHVlKCkKQEAgLTE2 NDksNyArMTczNyw3IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoY2hp bGQzLnVzZUtpbmQoKSA9PSBJbnQzMlVzZSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBp bnRWYWx1ZSA9IGxvd0ludDMyKGNoaWxkMyk7CiAgICAgICAgICAgICAgICAgICAgICAgICBlbHNl Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgaW50VmFsdWUgPSBtX291dC5jYXN0VG9JbnQz Mihsb3dJbnQ1MihjaGlsZDMpKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnRWYWx1 ZSA9IG1fb3V0LmNhc3RUb0ludDMyKGxvd1N0cmljdEludDUyKGNoaWxkMykpOwogCiAgICAgICAg ICAgICAgICAgICAgICAgICBpZiAoaXNDbGFtcGVkKHR5cGUpKSB7CiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgQVNTRVJUKGVsZW1lbnRTaXplKHR5cGUpID09IDEpOwpAQCAtMzI1Niw3ICsz MzQ0LDcgQEAgcHJpdmF0ZToKICAgICAKICAgICBMVmFsdWUgbG93Q2VsbChFZGdlIGVkZ2UsIE9w ZXJhbmRTcGVjdWxhdGlvbk1vZGUgbW9kZSA9IEF1dG9tYXRpY09wZXJhbmRTcGVjdWxhdGlvbikK ICAgICB7Ci0gICAgICAgIEFTU0VSVF9VTlVTRUQobW9kZSwgbW9kZSA9PSBNYW51YWxPcGVyYW5k U3BlY3VsYXRpb24gfHwgaXNDZWxsKGVkZ2UudXNlS2luZCgpKSk7CisgICAgICAgIEFTU0VSVF9V TlVTRUQobW9kZSwgbW9kZSA9PSBNYW51YWxPcGVyYW5kU3BlY3VsYXRpb24gfHwgREZHOjppc0Nl bGwoZWRnZS51c2VLaW5kKCkpKTsKICAgICAgICAgCiAgICAgICAgIGlmIChlZGdlLT5vcCgpID09 IEpTQ29uc3RhbnQpIHsKICAgICAgICAgICAgIEpTVmFsdWUgdmFsdWUgPSBtX2dyYXBoLnZhbHVl T2ZKU0NvbnN0YW50KGVkZ2Uubm9kZSgpKTsKQEAgLTM1NjUsNiArMzY1MywxMSBAQCBwcml2YXRl OgogICAgICAgICByZXR1cm4gbV9vdXQudGVzdE5vblplcm82NChqc1ZhbHVlLCBtX3RhZ01hc2sp OwogICAgIH0KICAgICAKKyAgICBMVmFsdWUgaXNDZWxsKExWYWx1ZSBqc1ZhbHVlKQorICAgIHsK KyAgICAgICAgcmV0dXJuIG1fb3V0LnRlc3RJc1plcm82NChqc1ZhbHVlLCBtX3RhZ01hc2spOwor ICAgIH0KKyAgICAKICAgICBMVmFsdWUgaXNOb3RCb29sZWFuKExWYWx1ZSBqc1ZhbHVlKQogICAg IHsKICAgICAgICAgcmV0dXJuIG1fb3V0LnRlc3ROb25aZXJvNjQoCg==