125280 2013-12-04 23:09:49 -0800 Import the layout test style-sharing-type-and-readonly.html from blink 2015-01-27 12:50:36 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate, InRadar P2 Normal --- 1 rniwa benjamin benjamin kling koivisto simon.fraser webkit-bug-importer oldest_to_newest 956777 0 rniwa 2013-12-04 23:09:49 -0800 Merge https://chromium.googlesource.com/chromium/blink/+/b857a7d6c5813dc5d9f10c7eece0ac3d58afeafe or come up with a better fix RuleSet has a special case in isCommonAttributeSelectorAttribute for allowing style sharing on elements that match "type" or "readonly" attribute selectors as long as they have the same value. This was added long ago in r96393 and worked based on the assumption that there was logic in canShareStyleWithElement that actually checked the value of the type and readonly attributes on the style sharing candidates. Later in r123730 the type attribute handling was regressed when it was moved to only check the value for <input>. The readonly attribute was later regressed in the same way in r134984. This patch restores the checks those two patches moved but retains the switch from getAttribute to fastGetAttribute for HTML which was likely most of the performance improvement and fixes the bug where elements would incorrectly share style even if one of them matched an attribute selector. Unfortunately this does mean that we need to call the slow geAttribute in SVG documents which may be a minor regression. We can work to improve the performance of SVG in the future once we get the correctness back. 1064452 1 webkit-bug-importer 2015-01-27 00:49:34 -0800 <rdar://problem/19611922> 1064453 2 245427 benjamin 2015-01-27 00:53:14 -0800 Created attachment 245427 Patch 1064454 3 245427 svillar 2015-01-27 01:00:47 -0800 Comment on attachment 245427 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245427&action=review > LayoutTests/fast/css/style-sharing-type-and-readonly-expected.txt:1 > +Make sure special case style sharing for readonly and type attributes works Nit: a full stop after "works" > LayoutTests/fast/css/style-sharing-type-and-readonly.html:19 > +description("Make sure special case style sharing for readonly and type attributes works"); Ditto. 1064622 4 benjamin 2015-01-27 12:50:36 -0800 Committed r179205: <http://trac.webkit.org/changeset/179205> 245427 2015-01-27 00:53:14 -0800 2015-01-27 01:00:47 -0800 Patch bug-125280-20150127005317.patch text/plain 2769 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5MTc0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzNhZDFlN2E3NGYzNDE4YTg5MmFj YTE2YmM4YmE0NDIyNzE4MDI0Yy4uOWRhYmQwNDFjZTYzODViMWNmMDAxMmExNTNhMzYyM2E1Mjk0 MzFjNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAxLTI3ICBCZW5qYW1pbiBQb3VsYWlu ICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBJbXBvcnQgdGhlIGxheW91dCB0ZXN0 IHN0eWxlLXNoYXJpbmctdHlwZS1hbmQtcmVhZG9ubHkuaHRtbCBmcm9tIGJsaW5rCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjUyODAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJIGZpeGVkIHRoZSBidWcg YSB3aGlsZSBhZ28gYnV0IGhhdmluZyBvbmUgbW9yZSB0ZXN0IHNlZW1zIHZhbHVhYmxlLgorICAg ICAgICBUaGlzIHRlc3QgaXMgZnJvbSBibGluazogaHR0cHM6Ly9jb2RlcmV2aWV3LmNocm9taXVt Lm9yZy8yNzAzMzAxMQorICAgICAgICBieSBFbGxpb3R0IFNwcmVobi4KKworICAgICAgICAqIGZh c3QvY3NzL3N0eWxlLXNoYXJpbmctdHlwZS1hbmQtcmVhZG9ubHktZXhwZWN0ZWQudHh0OiBBZGRl ZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9zdHlsZS1zaGFyaW5nLXR5cGUtYW5kLXJlYWRvbmx5Lmh0 bWw6IEFkZGVkLgorCiAyMDE1LTAxLTI2ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+ CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcmViYXNlbGluZSBzZXZlcmFsIENTUyB0ZXN0cyBhZnRl ciByMTc5MTY4LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3Mvc3R5bGUtc2hhcmlu Zy10eXBlLWFuZC1yZWFkb25seS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9z dHlsZS1zaGFyaW5nLXR5cGUtYW5kLXJlYWRvbmx5LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5i MDQzNzBhN2NkNDJiZjU4Yzk5YTcxZjNiZmQ3ZWQwNmU5OWIyYzU1Ci0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3Mvc3R5bGUtc2hhcmluZy10eXBlLWFuZC1yZWFkb25seS1l eHBlY3RlZC50eHQKQEAgLTAsMCArMSwxNCBAQAorTWFrZSBzdXJlIHNwZWNpYWwgY2FzZSBzdHls ZSBzaGFyaW5nIGZvciByZWFkb25seSBhbmQgdHlwZSBhdHRyaWJ1dGVzIHdvcmtzCisKK09uIHN1 Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2Vk IGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGdldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQu cXVlcnlTZWxlY3RvcigiW2JsYWNrXSIpKS5jb2xvciBpcyAicmdiKDAsIDAsIDApIgorUEFTUyBn ZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoIltyZWFkb25seV0iKSkuY29s b3IgaXMgInJnYigyNTUsIDAsIDApIgorUEFTUyBnZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LnF1 ZXJ5U2VsZWN0b3IoIlt0eXBlXSIpKS5jb2xvciBpcyAicmdiKDAsIDAsIDI1NSkiCitQQVNTIHN1 Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKK0JsYWNrCitSZWQKK0Js dWUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL3N0eWxlLXNoYXJpbmctdHlwZS1h bmQtcmVhZG9ubHkuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL3N0eWxlLXNoYXJpbmctdHlw ZS1hbmQtcmVhZG9ubHkuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43MjUxMmI5NGI4ZmZhY2MzZmFhMWFhYmUz MTc5MjRhOGNmY2UwZGNjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3Mv c3R5bGUtc2hhcmluZy10eXBlLWFuZC1yZWFkb25seS5odG1sCkBAIC0wLDAgKzEsMjUgQEAKKzwh RE9DVFlQRSBodG1sPgorCis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QuanMi Pjwvc2NyaXB0PgorCis8c3R5bGU+CisgIGRpdltyZWFkb25seT0icmVkIl0geworICAgIGNvbG9y OiByZWQ7CisgIH0KKyAgZGl2W3R5cGU9ImJsdWUiXSB7CisgICAgY29sb3I6IGJsdWU7CisgIH0K Kzwvc3R5bGU+CisKKzxkaXYgYmxhY2s+QmxhY2s8L2Rpdj4KKzxkaXYgcmVhZG9ubHk9InJlZCI+ UmVkPC9kaXY+Cis8ZGl2IHR5cGU9ImJsdWUiPkJsdWU8L2Rpdj4KKworPHNjcmlwdD4KK2Rlc2Ny aXB0aW9uKCJNYWtlIHN1cmUgc3BlY2lhbCBjYXNlIHN0eWxlIHNoYXJpbmcgZm9yIHJlYWRvbmx5 IGFuZCB0eXBlIGF0dHJpYnV0ZXMgd29ya3MiKTsKKworc2hvdWxkQmUoJ2dldENvbXB1dGVkU3R5 bGUoZG9jdW1lbnQucXVlcnlTZWxlY3RvcigiW2JsYWNrXSIpKS5jb2xvcicsJyJyZ2IoMCwgMCwg MCkiJyk7CitzaG91bGRCZSgnZ2V0Q29tcHV0ZWRTdHlsZShkb2N1bWVudC5xdWVyeVNlbGVjdG9y KCJbcmVhZG9ubHldIikpLmNvbG9yJywnInJnYigyNTUsIDAsIDApIicpOworc2hvdWxkQmUoJ2dl dENvbXB1dGVkU3R5bGUoZG9jdW1lbnQucXVlcnlTZWxlY3RvcigiW3R5cGVdIikpLmNvbG9yJywn InJnYigwLCAwLCAyNTUpIicpOworPC9zY3JpcHQ+CisK