125274 2013-12-04 18:43:52 -0800 Simplify ScriptFunctionCall by removing dead code 2013-12-06 12:53:01 -0800 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned commit-queue joepeck timothy oldest_to_newest 956744 0 joepeck 2013-12-04 18:43:52 -0800 Simplify ScriptFunctionCall by removing dead code. (ScriptCallback, reportExceptions parameter requiring DOM Bindings). 956745 1 joepeck 2013-12-04 18:45:10 -0800 Arg, my patch is not going to apply... Let me make a clean patch. 956746 2 218482 joepeck 2013-12-04 18:47:26 -0800 Created attachment 218482 [PATCH] Proposed Fix 957356 3 218482 commit-queue 2013-12-06 12:52:59 -0800 Comment on attachment 218482 [PATCH] Proposed Fix Clearing flags on attachment: 218482 Committed r160240: <http://trac.webkit.org/changeset/160240> 957357 4 commit-queue 2013-12-06 12:53:01 -0800 All reviewed patches have been landed. Closing bug. 218482 2013-12-04 18:47:26 -0800 2013-12-06 12:52:59 -0800 [PATCH] Proposed Fix simplify.patch text/plain 5339 joepeck Y29tbWl0IDE1YzRiNTU3YTk0NmFhYmNiZjk0YWI1OTE5MmMyZDE5YjE0YjI0MjQKQXV0aG9yOiBK b3NlcGggUGVjb3Jhcm8gPHBlY29yYXJvQGFwcGxlLmNvbT4KRGF0ZTogICBXZWQgRGVjIDQgMTg6 MjE6MjggMjAxMyAtMDgwMAoKICAgIFBBUlQgNDogUmVtb3ZlIHN0YWxlIFNjcmlwdENhbGxiYWNr IGNsYXNzCiAgICAKICAgIENvbmZsaWN0czoKICAgIAlTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9q cy9TY3JpcHRGdW5jdGlvbkNhbGwuaAoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3MTEzYWFlLi43YzJhZDgxIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMTItMDQgIEpvc2VwaCBQZWNvcmFybyAg PHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBTaW1wbGlmeSBTY3JpcHRGdW5jdGlvbkNh bGwgYnkgcmVtb3ZpbmcgZGVhZCBjb2RlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTI1Mjc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9TY3JpcHRGdW5jdGlvbkNhbGwuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6U2NyaXB0RnVuY3Rpb25DYWxsOjpjYWxsKToKKyAgICAgICAgKiBi aW5kaW5ncy9qcy9TY3JpcHRGdW5jdGlvbkNhbGwuaDoKKwogMjAxMy0xMi0wNCAgQW5keSBFc3Rl cyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gQnVpbGQgcHJvamVjdHMgd2l0 aCAkKEFSQ0hTX1NUQU5EQVJEXzMyXzY0X0JJVCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL2pzL1NjcmlwdEZ1bmN0aW9uQ2FsbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9TY3JpcHRGdW5jdGlvbkNhbGwuY3BwCmluZGV4IDAxNDZiMmUuLjJlYTJiNGIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdEZ1bmN0aW9uQ2FsbC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0RnVuY3Rpb25DYWxsLmNw cApAQCAtMzEsNyArMzEsNiBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIlNjcmlw dEZ1bmN0aW9uQ2FsbC5oIgogCi0jaW5jbHVkZSAiSlNET01CaW5kaW5nLmgiCiAjaW5jbHVkZSAi SlNNYWluVGhyZWFkRXhlY1N0YXRlLmgiCiAjaW5jbHVkZSAiU2NyaXB0VmFsdWUuaCIKIApAQCAt MTE1LDcgKzExNCw3IEBAIFNjcmlwdEZ1bmN0aW9uQ2FsbDo6U2NyaXB0RnVuY3Rpb25DYWxsKGNv bnN0IFNjcmlwdE9iamVjdCYgdGhpc09iamVjdCwgY29uc3QgU3RyCiB7CiB9CiAKLVNjcmlwdFZh bHVlIFNjcmlwdEZ1bmN0aW9uQ2FsbDo6Y2FsbChib29sJiBoYWRFeGNlcHRpb24sIGJvb2wgcmVw b3J0RXhjZXB0aW9ucykKK1NjcmlwdFZhbHVlIFNjcmlwdEZ1bmN0aW9uQ2FsbDo6Y2FsbChib29s JiBoYWRFeGNlcHRpb24pCiB7CiAgICAgSlNPYmplY3QqIHRoaXNPYmplY3QgPSBtX3RoaXNPYmpl Y3QuanNPYmplY3QoKTsKIApAQCAtMTIzLDkgKzEyMiw2IEBAIFNjcmlwdFZhbHVlIFNjcmlwdEZ1 bmN0aW9uQ2FsbDo6Y2FsbChib29sJiBoYWRFeGNlcHRpb24sIGJvb2wgcmVwb3J0RXhjZXB0aW9u cykKIAogICAgIEpTVmFsdWUgZnVuY3Rpb24gPSB0aGlzT2JqZWN0LT5nZXQobV9leGVjLCBJZGVu dGlmaWVyKG1fZXhlYywgbV9uYW1lKSk7CiAgICAgaWYgKG1fZXhlYy0+aGFkRXhjZXB0aW9uKCkp IHsKLSAgICAgICAgaWYgKHJlcG9ydEV4Y2VwdGlvbnMpCi0gICAgICAgICAgICByZXBvcnRFeGNl cHRpb24obV9leGVjLCBtX2V4ZWMtPmV4Y2VwdGlvbigpKTsKLQogICAgICAgICBoYWRFeGNlcHRp b24gPSB0cnVlOwogICAgICAgICByZXR1cm4gU2NyaXB0VmFsdWUoKTsKICAgICB9CkBAIC0xNDIs OSArMTM4LDYgQEAgU2NyaXB0VmFsdWUgU2NyaXB0RnVuY3Rpb25DYWxsOjpjYWxsKGJvb2wmIGhh ZEV4Y2VwdGlvbiwgYm9vbCByZXBvcnRFeGNlcHRpb25zKQogICAgICAgICByZXN1bHQgPSBKU0M6 OmNhbGwobV9leGVjLCBmdW5jdGlvbiwgY2FsbFR5cGUsIGNhbGxEYXRhLCB0aGlzT2JqZWN0LCBt X2FyZ3VtZW50cyk7CiAKICAgICBpZiAobV9leGVjLT5oYWRFeGNlcHRpb24oKSkgewotICAgICAg ICBpZiAocmVwb3J0RXhjZXB0aW9ucykKLSAgICAgICAgICAgIHJlcG9ydEV4Y2VwdGlvbihtX2V4 ZWMsIG1fZXhlYy0+ZXhjZXB0aW9uKCkpOwotCiAgICAgICAgIGhhZEV4Y2VwdGlvbiA9IHRydWU7 CiAgICAgICAgIHJldHVybiBTY3JpcHRWYWx1ZSgpOwogICAgIH0KQEAgLTE1OCw2MiArMTUxLDQg QEAgU2NyaXB0VmFsdWUgU2NyaXB0RnVuY3Rpb25DYWxsOjpjYWxsKCkKICAgICByZXR1cm4gY2Fs bChoYWRFeGNlcHRpb24pOwogfQogCi1TY3JpcHRPYmplY3QgU2NyaXB0RnVuY3Rpb25DYWxsOjpj b25zdHJ1Y3QoYm9vbCYgaGFkRXhjZXB0aW9uLCBib29sIHJlcG9ydEV4Y2VwdGlvbnMpCi17Ci0g ICAgSlNPYmplY3QqIHRoaXNPYmplY3QgPSBtX3RoaXNPYmplY3QuanNPYmplY3QoKTsKLQotICAg IEpTTG9ja0hvbGRlciBsb2NrKG1fZXhlYyk7Ci0KLSAgICBKU09iamVjdCogY29uc3RydWN0b3Ig PSBhc09iamVjdCh0aGlzT2JqZWN0LT5nZXQobV9leGVjLCBJZGVudGlmaWVyKG1fZXhlYywgbV9u YW1lKSkpOwotICAgIGlmIChtX2V4ZWMtPmhhZEV4Y2VwdGlvbigpKSB7Ci0gICAgICAgIGlmIChy ZXBvcnRFeGNlcHRpb25zKQotICAgICAgICAgICAgcmVwb3J0RXhjZXB0aW9uKG1fZXhlYywgbV9l eGVjLT5leGNlcHRpb24oKSk7Ci0KLSAgICAgICAgaGFkRXhjZXB0aW9uID0gdHJ1ZTsKLSAgICAg ICAgcmV0dXJuIFNjcmlwdE9iamVjdCgpOwotICAgIH0KLQotICAgIENvbnN0cnVjdERhdGEgY29u c3RydWN0RGF0YTsKLSAgICBDb25zdHJ1Y3RUeXBlIGNvbnN0cnVjdFR5cGUgPSBjb25zdHJ1Y3Rv ci0+bWV0aG9kVGFibGUoKS0+Z2V0Q29uc3RydWN0RGF0YShjb25zdHJ1Y3RvciwgY29uc3RydWN0 RGF0YSk7Ci0gICAgaWYgKGNvbnN0cnVjdFR5cGUgPT0gQ29uc3RydWN0VHlwZU5vbmUpCi0gICAg ICAgIHJldHVybiBTY3JpcHRPYmplY3QoKTsKLQotICAgIEpTVmFsdWUgcmVzdWx0ID0gSlNDOjpj b25zdHJ1Y3QobV9leGVjLCBjb25zdHJ1Y3RvciwgY29uc3RydWN0VHlwZSwgY29uc3RydWN0RGF0 YSwgbV9hcmd1bWVudHMpOwotICAgIGlmIChtX2V4ZWMtPmhhZEV4Y2VwdGlvbigpKSB7Ci0gICAg ICAgIGlmIChyZXBvcnRFeGNlcHRpb25zKQotICAgICAgICAgICAgcmVwb3J0RXhjZXB0aW9uKG1f ZXhlYywgbV9leGVjLT5leGNlcHRpb24oKSk7Ci0KLSAgICAgICAgaGFkRXhjZXB0aW9uID0gdHJ1 ZTsKLSAgICAgICAgcmV0dXJuIFNjcmlwdE9iamVjdCgpOwotICAgIH0KLQotICAgIHJldHVybiBT Y3JpcHRPYmplY3QobV9leGVjLCBhc09iamVjdChyZXN1bHQpKTsKLX0KLQotU2NyaXB0Q2FsbGJh Y2s6OlNjcmlwdENhbGxiYWNrKEpTQzo6RXhlY1N0YXRlKiBzdGF0ZSwgY29uc3QgU2NyaXB0VmFs dWUmIGZ1bmN0aW9uKQotICAgIDogU2NyaXB0Q2FsbEFyZ3VtZW50SGFuZGxlcihzdGF0ZSkKLSAg ICAsIG1fZnVuY3Rpb24oZnVuY3Rpb24pCi17Ci19Ci0KLVNjcmlwdFZhbHVlIFNjcmlwdENhbGxi YWNrOjpjYWxsKCkKLXsKLSAgICBKU0xvY2tIb2xkZXIgbG9jayhtX2V4ZWMpOwotCi0gICAgQ2Fs bERhdGEgY2FsbERhdGE7Ci0gICAgQ2FsbFR5cGUgY2FsbFR5cGUgPSBnZXRDYWxsRGF0YShtX2Z1 bmN0aW9uLmpzVmFsdWUoKSwgY2FsbERhdGEpOwotICAgIGlmIChjYWxsVHlwZSA9PSBDYWxsVHlw ZU5vbmUpCi0gICAgICAgIHJldHVybiBTY3JpcHRWYWx1ZSgpOwotCi0gICAgSlNWYWx1ZSByZXN1 bHQgPSBKU0M6OmNhbGwobV9leGVjLCBtX2Z1bmN0aW9uLmpzVmFsdWUoKSwgY2FsbFR5cGUsIGNh bGxEYXRhLCBtX2Z1bmN0aW9uLmpzVmFsdWUoKSwgbV9hcmd1bWVudHMpOwotICAgIGJvb2wgaGFk RXhjZXB0aW9uID0gbV9leGVjLT5oYWRFeGNlcHRpb24oKTsKLQotICAgIGlmIChoYWRFeGNlcHRp b24pIHsKLSAgICAgICAgcmVwb3J0RXhjZXB0aW9uKG1fZXhlYywgbV9leGVjLT5leGNlcHRpb24o KSk7Ci0gICAgICAgIHJldHVybiBTY3JpcHRWYWx1ZSgpOwotICAgIH0KLQotICAgIHJldHVybiBT Y3JpcHRWYWx1ZShtX2V4ZWMtPnZtKCksIHJlc3VsdCk7Ci19Ci0KIH0gLy8gbmFtZXNwYWNlIFdl YkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdEZ1bmN0 aW9uQ2FsbC5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0RnVuY3Rpb25DYWxs LmgKaW5kZXggYWFlY2I5ZC4uNTZmYTQ3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvanMvU2NyaXB0RnVuY3Rpb25DYWxsLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvU2NyaXB0RnVuY3Rpb25DYWxsLmgKQEAgLTc0LDI1ICs3NCwxNCBAQCBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAgICAgY2xhc3MgU2NyaXB0RnVuY3Rpb25DYWxsIDogcHVibGljIFNjcmlwdENh bGxBcmd1bWVudEhhbmRsZXIgewogICAgIHB1YmxpYzoKICAgICAgICAgU2NyaXB0RnVuY3Rpb25D YWxsKGNvbnN0IFNjcmlwdE9iamVjdCYgdGhpc09iamVjdCwgY29uc3QgU3RyaW5nJiBuYW1lKTsK LSAgICAgICAgU2NyaXB0VmFsdWUgY2FsbChib29sJiBoYWRFeGNlcHRpb24sIGJvb2wgcmVwb3J0 RXhjZXB0aW9ucyA9IHRydWUpOworICAgICAgICBTY3JpcHRWYWx1ZSBjYWxsKGJvb2wmIGhhZEV4 Y2VwdGlvbik7CiAgICAgICAgIFNjcmlwdFZhbHVlIGNhbGwoKTsKLSAgICAgICAgU2NyaXB0T2Jq ZWN0IGNvbnN0cnVjdChib29sJiBoYWRFeGNlcHRpb24sIGJvb2wgcmVwb3J0RXhjZXB0aW9ucyA9 IHRydWUpOwogCiAgICAgcHJvdGVjdGVkOgogICAgICAgICBTY3JpcHRPYmplY3QgbV90aGlzT2Jq ZWN0OwogICAgICAgICBTdHJpbmcgbV9uYW1lOwogICAgIH07CiAKLSAgICBjbGFzcyBTY3JpcHRD YWxsYmFjayA6IHB1YmxpYyBTY3JpcHRDYWxsQXJndW1lbnRIYW5kbGVyIHsKLSAgICBwdWJsaWM6 Ci0gICAgICAgIFNjcmlwdENhbGxiYWNrKEpTQzo6RXhlY1N0YXRlKiwgY29uc3QgU2NyaXB0VmFs dWUmKTsKLQotICAgICAgICBTY3JpcHRWYWx1ZSBjYWxsKCk7Ci0KLSAgICBwcml2YXRlOgotICAg ICAgICBTY3JpcHRWYWx1ZSBtX2Z1bmN0aW9uOwotICAgIH07Ci0KIH0gLy8gbmFtZXNwYWNlIFdl YkNvcmUKIAogI2VuZGlmIC8vIFNjcmlwdEZ1bmN0aW9uQ2FsbAo=