125272 2013-12-04 17:58:16 -0800 [Win] Exiting from Media Full Screen mode via 'escape' key does not work properly 2013-12-05 12:12:06 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham bfulgham jer.noble jonlee oldest_to_newest 956722 0 bfulgham 2013-12-04 17:58:16 -0800 If you enter full screen video mode, and then exit using the "Escape" key, WebKit will not re-enter fullscreen mode. If you use the media control to enter/exit fullscreen mode, everything works properly. This bug is caused by improper cleanup of the Document::m_fullScreenElementStack member: When logic passes through the JavaScript layer, it pops the most recent full screen element off of the stack because it calls Document::webkitExitFullscreen(), which pops the element before calling the client's exitFullScreenForElement. The 'escape' key handler in Windows calls Document::webkitWillExitFullScreenForElement(Element*), which bypasses the pop operation and leaves the element on the stack. Subsequent calls to enter full screen mode fail because WebCore believes a full screen controller is already in place. The proposed solution is to modify the WebKit/win/WebView implementation to use "webkitExitFullscreen" rather than "webkitWillExitFullScreenForElement" to more closely match that logic of the media control interface. 956926 1 218520 bfulgham 2013-12-05 09:15:31 -0800 Created attachment 218520 Patch 956951 2 218520 jer.noble 2013-12-05 10:19:03 -0800 Comment on attachment 218520 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218520&action=review r=me, with nit. > Source/WebKit/win/WebView.cpp:6958 > - m_fullScreenElement->document().webkitWillExitFullScreenForElement(m_fullScreenElement.get()); > + m_fullScreenElement->document().webkitExitFullscreen(); This should probably use webkitCancelFullScreen(), which will pop the entire full screen element stack. 956997 3 bfulgham 2013-12-05 12:12:06 -0800 Committed r160184: <http://trac.webkit.org/changeset/160184> 218520 2013-12-05 09:15:31 -0800 2013-12-05 10:19:02 -0800 Patch bug-125272-20131205091530.patch text/plain 1362 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MDE1MCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTEyLTA0 ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIEV4 aXRpbmcgZnJvbSBNZWRpYSBGdWxsIFNjcmVlbiBtb2RlIHZpYSAnZXNjYXBlJyBrZXkgZG9lcyBu b3Qgd29yayBwcm9wZXJseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTI1MjcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBXZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYlZpZXc6OmZ1bGxTY3JlZW5DbGll bnRXaWxsRXhpdEZ1bGxTY3JlZW4pOiBDaGFuZ2UgdG8gd2Via2l0RXhpdEZ1bGxzY3JlZW4gbWV0 aG9kIGNhbGwKKyAgICAgICAgdG8gbW9yZSBjbG9zZWx5IG1hdGNoIE1lZGlhIENvbnRyb2wgYmVo YXZpb3IuCisKIDIwMTMtMTItMDMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBQdXNoIFJlbW90ZSBJbnNwZWN0b3IgZGVidWdn aW5nIGNvbm5lY3Rpb24gbWFuYWdlbWVudCBpbnRvIEphdmFTY3JpcHRDb3JlCkluZGV4OiBTb3Vy Y2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3dp bi9XZWJWaWV3LmNwcAkocmV2aXNpb24gMTYwMTUwKQorKysgU291cmNlL1dlYktpdC93aW4vV2Vi Vmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY5NTUsNyArNjk1NSw3IEBAIHZvaWQgV2ViVmll dzo6ZnVsbFNjcmVlbkNsaWVudERpZEVudGVyRnUKIHZvaWQgV2ViVmlldzo6ZnVsbFNjcmVlbkNs aWVudFdpbGxFeGl0RnVsbFNjcmVlbigpCiB7CiAgICAgQVNTRVJUKG1fZnVsbFNjcmVlbkVsZW1l bnQpOwotICAgIG1fZnVsbFNjcmVlbkVsZW1lbnQtPmRvY3VtZW50KCkud2Via2l0V2lsbEV4aXRG dWxsU2NyZWVuRm9yRWxlbWVudChtX2Z1bGxTY3JlZW5FbGVtZW50LmdldCgpKTsKKyAgICBtX2Z1 bGxTY3JlZW5FbGVtZW50LT5kb2N1bWVudCgpLndlYmtpdEV4aXRGdWxsc2NyZWVuKCk7CiB9CiAK IHZvaWQgV2ViVmlldzo6ZnVsbFNjcmVlbkNsaWVudERpZEV4aXRGdWxsU2NyZWVuKCkK