125260 2013-12-04 15:24:35 -0800 Web Inspector: ColorWheel uses old Color constructor 2013-12-04 16:49:47 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 graouts graouts commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 956660 0 graouts 2013-12-04 15:24:35 -0800 The Color constructor changed in http://trac.webkit.org/changeset/160132 but ColorWheel still uses the old signature. 956662 1 218463 graouts 2013-12-04 15:26:24 -0800 Created attachment 218463 Patch 956671 2 218463 joepeck 2013-12-04 15:41:36 -0800 Comment on attachment 218463 Patch Isn't 0 black? Shouldn't this be 255, 255, 255, 0? r- 956673 3 218463 joepeck 2013-12-04 15:42:51 -0800 Comment on attachment 218463 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218463&action=review > Source/WebInspectorUI/UserInterface/ColorWheel.js:103 > + return new WebInspector.Color(WebInspector.Color.Format.RGBA, [0, 0, 0, 0]); Shouldn't this be [255, 255, 255, 0]? 956679 4 graouts 2013-12-04 15:51:36 -0800 (In reply to comment #3) > (From update of attachment 218463 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=218463&action=review > > > Source/WebInspectorUI/UserInterface/ColorWheel.js:103 > > + return new WebInspector.Color(WebInspector.Color.Format.RGBA, [0, 0, 0, 0]); > > Shouldn't this be [255, 255, 255, 0]? Since the alpha bit is 0, I don't think it makes any difference, it's a clear color anyway. 956692 5 218463 joepeck 2013-12-04 16:21:46 -0800 Comment on attachment 218463 Patch Ahh, gotcha. I should have read the change log closer to see the intent. Thanks! 956697 6 218463 commit-queue 2013-12-04 16:49:45 -0800 Comment on attachment 218463 Patch Clearing flags on attachment: 218463 Committed r160145: <http://trac.webkit.org/changeset/160145> 956698 7 commit-queue 2013-12-04 16:49:47 -0800 All reviewed patches have been landed. Closing bug. 218463 2013-12-04 15:26:24 -0800 2013-12-04 16:49:45 -0800 Patch bug-125260-20131205002624.patch text/plain 2038 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA5 NWY4ZWVhNDFkMjQ4NDYzMDg2NTIyYTMwZDI2ZjdkZTBiZjllMGEyLi5jMjJjYjk5MmFjZDQ4NjRm NDQzZmNmNzcyNzFlOTQ1MTVlNTI0ZTU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxOCBAQAogMjAxMy0xMi0wNCAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29t PgogCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvbG9yV2hlZWwgdXNlcyBvbGQgQ29sb3IgY29u c3RydWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyNTI2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFVwZGF0ZSB0byBuZXcgV2ViSW5zcGVjdG9yLkNvbG9yIGNvbnN0cnVjdG9yIHNpZ25hdHVyZSBh bmQgdXNlIGEgY2xlYXIgY29sb3IuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0NvbG9yV2hl ZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29sb3JXaGVlbC5wcm90b3R5cGUuZ2V0IHRp bnRlZENvbG9yKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db2xvcldoZWVsLnByb3RvdHlwZS5n ZXQgcmF3Q29sb3IpOgorCisyMDEzLTEyLTA0ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBs ZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogImRhdGEgZGV0ZWN0b3JzIiBtZW51IG9u IGhvdmVyIGZvciBhY3Rpb25hYmxlIHRva2VucwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0MzYzCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbG9yV2hlZWwuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9Db2xvcldoZWVsLmpzCmluZGV4IDZkYTRhZTEyNDFlMWUzMDkzMzEy ZGViYjE2NmYwMmE1YWY0YjQyZjkuLjBmNDk2ZGQ3ODU2Y2RlY2FhNjkwZjQyZmQxZGQ3ZDdkNmI5 NzdlNWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Nv bG9yV2hlZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29s b3JXaGVlbC5qcwpAQCAtODUsNyArODUsNyBAQCBXZWJJbnNwZWN0b3IuQ29sb3JXaGVlbC5wcm90 b3R5cGUgPSB7CiAgICAgICAgIGlmICh0aGlzLl9jcm9zc2hhaXJQb3NpdGlvbikKICAgICAgICAg ICAgIHJldHVybiB0aGlzLl9jb2xvckF0UG9pbnRXaXRoQnJpZ2h0bmVzcyh0aGlzLl9jcm9zc2hh aXJQb3NpdGlvbi54LCB0aGlzLl9jcm9zc2hhaXJQb3NpdGlvbi55LCB0aGlzLl9icmlnaHRuZXNz KTsKIAotICAgICAgICByZXR1cm4gbmV3IFdlYkluc3BlY3Rvci5Db2xvcigid2hpdGUiKTsKKyAg ICAgICAgcmV0dXJuIG5ldyBXZWJJbnNwZWN0b3IuQ29sb3IoV2ViSW5zcGVjdG9yLkNvbG9yLkZv cm1hdC5SR0JBLCBbMCwgMCwgMCwgMF0pOwogICAgIH0sCiAKICAgICBzZXQgdGludGVkQ29sb3Io dGludGVkQ29sb3IpCkBAIC0xMDAsNyArMTAwLDcgQEAgV2ViSW5zcGVjdG9yLkNvbG9yV2hlZWwu cHJvdG90eXBlID0gewogICAgICAgICBpZiAodGhpcy5fY3Jvc3NoYWlyUG9zaXRpb24pCiAgICAg ICAgICAgICByZXR1cm4gdGhpcy5fY29sb3JBdFBvaW50V2l0aEJyaWdodG5lc3ModGhpcy5fY3Jv c3NoYWlyUG9zaXRpb24ueCwgdGhpcy5fY3Jvc3NoYWlyUG9zaXRpb24ueSwgMSk7CiAKLSAgICAg ICAgcmV0dXJuIG5ldyBXZWJJbnNwZWN0b3IuQ29sb3IoIndoaXRlIik7CisgICAgICAgIHJldHVy biBuZXcgV2ViSW5zcGVjdG9yLkNvbG9yKFdlYkluc3BlY3Rvci5Db2xvci5Gb3JtYXQuUkdCQSwg WzAsIDAsIDAsIDBdKTsKICAgICB9LAogCiAgICAgLy8gUHJvdGVjdGVkCg==