125246 2013-12-04 13:04:20 -0800 check-webkit-style detected some ternary statements as initialization lists 2013-12-05 00:37:34 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmaxfield mmaxfield bfulgham burg commit-queue darin dbates galpeter glenn llango.u-szeged rniwa zherczeg oldest_to_newest 956539 0 mmaxfield 2013-12-04 13:04:20 -0800 check-webkit-style detected some turnary statements as initialization lists 956542 1 218432 mmaxfield 2013-12-04 13:06:17 -0800 Created attachment 218432 Patch 956545 2 218432 dino 2013-12-04 13:11:59 -0800 Comment on attachment 218432 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218432&action=review > Tools/Scripts/webkitpy/style/checkers/cpp.py:1989 > + if search(r'^(?P<indentation>\s*)((explicit )?[^\s]+\(.*\)\s?\:|^\s*\:).*[^;]*$', line): Should this be explicit\s+ ? > Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:4986 > + self.assert_lint('o = foo(b ? bar() : baz());', '') Should you have a test with "explicit" too? 956558 3 218437 mmaxfield 2013-12-04 13:24:25 -0800 Created attachment 218437 Patch 956596 4 218437 commit-queue 2013-12-04 14:13:40 -0800 Comment on attachment 218437 Patch Clearing flags on attachment: 218437 Committed r160124: <http://trac.webkit.org/changeset/160124> 956597 5 commit-queue 2013-12-04 14:13:42 -0800 All reviewed patches have been landed. Closing bug. 956798 6 llango.u-szeged 2013-12-05 00:37:34 -0800 Nice, thanks for the fix. 218432 2013-12-04 13:06:17 -0800 2013-12-04 13:24:24 -0800 Patch bug-125246-20131204130616.patch text/plain 2473 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMDk3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTFjOGRmZjU4YTg4ODRlNjA4Y2M0Y2RhOTJiZTRlZWZl ODAwYzM3NC4uOWI4ZjExOWVlNzk0ZDk2MTI4M2YxYWMyYWIzZmFjMmU3MDliNDA0YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEzLTEyLTA0ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+ CisKKyAgICAgICAgY2hlY2std2Via2l0LXN0eWxlIGRldGVjdGVkIHNvbWUgdHVybmFyeSBzdGF0 ZW1lbnRzIGFzIGluaXRpYWxpemF0aW9uIGxpc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjUyNDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgcmVndWxhciBleHByZXNzaW9uIHRoYXQgY2hlY2st d2Via2l0LXRlc3RzIHVzZXMgdG8gZGV0ZWN0IGluaXRpYWxpemF0aW9uCisgICAgICAgIGxpc3Rz IHdhcyB0b28gYnJvYWQsIHJlc3VsdGluZyBpbiBmYWxzZSBwb3NpdGl2ZXMuIFRoaXMgcGF0Y2gg bWFrZXMgdGhlCisgICAgICAgIHJlZ2V4IG1vcmUgc3BlY2lmaWMKKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5OgorICAgICAgICAoY2hlY2tfbWVtYmVy X2luaXRpYWxpemF0aW9uX2xpc3QpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5OgorICAgICAgICAoV2ViS2l0U3R5bGVUZXN0LnRlc3Rf bWVtYmVyX2luaXRpYWxpemF0aW9uX2xpc3QpOgorCiAyMDEzLTEyLTA0ICBUYW1hcyBHZXJnZWx5 ICA8dGdlcmdlbHkudS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNvbT4KIAogICAgICAgICBTdHls ZSBjaGVja2VyIGZvciAubWVzc2FnZXMuaW4gZmlsZXMgKFdURjo6IHByZWZpeCkKZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggNzRlZGQ3MGExZDU2 OTdiZDRiNjRiNDU5OGVhY2IxNTRkYWYwY2I4ZS4uM2Q1ZjI5NjcwNWNmZGIzNTczYjg0NTVhZTg0 M2VlOGVjZDAwY2FhOCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jcHAucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy cy9jcHAucHkKQEAgLTE5ODYsNyArMTk4Niw3IEBAIGRlZiBjaGVja19tZW1iZXJfaW5pdGlhbGl6 YXRpb25fbGlzdChjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGVycm9yKToKICAgICAjIEVhY2gg bWVtYmVyIChhbmQgc3VwZXJjbGFzcykgc2hvdWxkIGJlIGluZGVudGVkIG9uIGEgc2VwYXJhdGUg bGluZSwKICAgICAjIHdpdGggdGhlIGNvbG9uIG9yIGNvbW1hIHByZWNlZGluZyB0aGUgbWVtYmVy IG9uIHRoYXQgbGluZS4KICAgICBiZWdpbl9saW5lID0gbGluZQotICAgIGlmIHNlYXJjaChyJyg/ UDxpbmRlbnRhdGlvbj5ccyopKFteXHNdXCguKlwpXHM/XDp8XlxzKlw6KS4qW147XSokJywgbGlu ZSk6CisgICAgaWYgc2VhcmNoKHInXig/UDxpbmRlbnRhdGlvbj5ccyopKChleHBsaWNpdCApP1te XHNdK1woLipcKVxzP1w6fF5ccypcOikuKlteO10qJCcsIGxpbmUpOgogICAgICAgICBpZiBzZWFy Y2gocidbXjpdXDpbXlw6XHNdKycsIGxpbmUpOgogICAgICAgICAgICAgZXJyb3IobGluZV9udW1i ZXIsICd3aGl0ZXNwYWNlL2luaXQnLCA0LAogICAgICAgICAgICAgICAgICdNaXNzaW5nIHNwYWNl cyBhcm91bmQgOicpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2No ZWNrZXJzL2NwcF91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlcnMvY3BwX3VuaXR0ZXN0LnB5CmluZGV4IDc3ODc0MDcyNmU5NGRiMTQxZTNjNDYzZTE1ZmIw OWY2Y2YwMzc0YzkuLmFiNWY3ODM1MmY3MmJkZWY4YWI0Y2ZhMzZiMTlhOGU4NTJmYTU4NmIgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0 ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3Vu aXR0ZXN0LnB5CkBAIC00OTgzLDYgKzQ5ODMsNyBAQCBjbGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3Bw U3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICwgcHVibGljIGZvbyB7CiAgICAgICAgIH07JycnLAog ICAgICAgICAnJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnbyA9IGZvbyhiID8gYmFyKCkg OiBiYXooKSk7JywgJycpCiAKICAgICBkZWYgdGVzdF9vdGhlcihzZWxmKToKICAgICAgICAgIyBG SVhNRTogSW1wbGVtZW50IHRoaXMuCg== 218437 2013-12-04 13:24:25 -0800 2013-12-04 14:13:40 -0800 Patch bug-125246-20131204132424.patch text/plain 3061 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMDk3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTFjOGRmZjU4YTg4ODRlNjA4Y2M0Y2RhOTJiZTRlZWZl ODAwYzM3NC4uNGJjMWRmMmUzMTU4NmQzMmIwZDk5ZGM1OTExMDA4M2I3ZTE4NWNiMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEzLTEyLTA0ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+ CisKKyAgICAgICAgY2hlY2std2Via2l0LXN0eWxlIGRldGVjdGVkIHNvbWUgdGVybmFyeSBzdGF0 ZW1lbnRzIGFzIGluaXRpYWxpemF0aW9uIGxpc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjUyNDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgcmVndWxhciBleHByZXNzaW9uIHRoYXQgY2hlY2st d2Via2l0LXRlc3RzIHVzZXMgdG8gZGV0ZWN0IGluaXRpYWxpemF0aW9uCisgICAgICAgIGxpc3Rz IHdhcyB0b28gYnJvYWQsIHJlc3VsdGluZyBpbiBmYWxzZSBwb3NpdGl2ZXMuIFRoaXMgcGF0Y2gg bWFrZXMgdGhlCisgICAgICAgIHJlZ2V4IG1vcmUgc3BlY2lmaWMKKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5OgorICAgICAgICAoY2hlY2tfbWVtYmVy X2luaXRpYWxpemF0aW9uX2xpc3QpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5OgorICAgICAgICAoV2ViS2l0U3R5bGVUZXN0LnRlc3Rf bWVtYmVyX2luaXRpYWxpemF0aW9uX2xpc3QpOgorCiAyMDEzLTEyLTA0ICBUYW1hcyBHZXJnZWx5 ICA8dGdlcmdlbHkudS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNvbT4KIAogICAgICAgICBTdHls ZSBjaGVja2VyIGZvciAubWVzc2FnZXMuaW4gZmlsZXMgKFdURjo6IHByZWZpeCkKZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggNzRlZGQ3MGExZDU2 OTdiZDRiNjRiNDU5OGVhY2IxNTRkYWYwY2I4ZS4uZDVjMjc4NmI0ZjkzNGJlNWI3MjljNjBiMzE4 YzAxMmJlZWU5ZDFkYSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jcHAucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy cy9jcHAucHkKQEAgLTE5ODYsNyArMTk4Niw3IEBAIGRlZiBjaGVja19tZW1iZXJfaW5pdGlhbGl6 YXRpb25fbGlzdChjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGVycm9yKToKICAgICAjIEVhY2gg bWVtYmVyIChhbmQgc3VwZXJjbGFzcykgc2hvdWxkIGJlIGluZGVudGVkIG9uIGEgc2VwYXJhdGUg bGluZSwKICAgICAjIHdpdGggdGhlIGNvbG9uIG9yIGNvbW1hIHByZWNlZGluZyB0aGUgbWVtYmVy IG9uIHRoYXQgbGluZS4KICAgICBiZWdpbl9saW5lID0gbGluZQotICAgIGlmIHNlYXJjaChyJyg/ UDxpbmRlbnRhdGlvbj5ccyopKFteXHNdXCguKlwpXHM/XDp8XlxzKlw6KS4qW147XSokJywgbGlu ZSk6CisgICAgaWYgc2VhcmNoKHInXig/UDxpbmRlbnRhdGlvbj5ccyopKChleHBsaWNpdFxzKyk/ W15cc10rXCguKlwpXHM/XDp8XlxzKlw6KS4qW147XSokJywgbGluZSk6CiAgICAgICAgIGlmIHNl YXJjaChyJ1teOl1cOlteXDpcc10rJywgbGluZSk6CiAgICAgICAgICAgICBlcnJvcihsaW5lX251 bWJlciwgJ3doaXRlc3BhY2UvaW5pdCcsIDQsCiAgICAgICAgICAgICAgICAgJ01pc3Npbmcgc3Bh Y2VzIGFyb3VuZCA6JykKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggNzc4NzQwNzI2ZTk0ZGIxNDFlM2M0NjNlMTVm YjA5ZjZjZjAzNzRjOS4uMTM2OTY5MTY4NGE2ZTI0ZGY2YmM1YjMxMTEzN2JkZTc0YjVmMmVmOSAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5p dHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBf dW5pdHRlc3QucHkKQEAgLTQ5MTQsNiArNDkxNCw5IEBAIGNsYXNzIFdlYktpdFN0eWxlVGVzdChD cHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgICAgICAgICB3ZWJraXRfZXhwb3J0X2Vycm9yX3J1 bGVzKSkKIAogICAgIGRlZiB0ZXN0X21lbWJlcl9pbml0aWFsaXphdGlvbl9saXN0KHNlbGYpOgor ICAgICAgICBzZWxmLmFzc2VydF9saW50KCdleHBsaWNpdCBNeUNsYXNzKERvY3VtZW50KiBkb2Mp IDogTXlTdXBlckNsYXNzKCkgeyB9JywKKyAgICAgICAgJ1Nob3VsZCBiZSBpbmRlbnRlZCBvbiBh IHNlcGFyYXRlIGxpbmUsIHdpdGggdGhlIGNvbG9uIG9yIGNvbW1hIGZpcnN0IG9uIHRoYXQgbGlu ZS4nCisgICAgICAgICcgIFt3aGl0ZXNwYWNlL2luZGVudF0gWzRdJykKICAgICAgICAgc2VsZi5h c3NlcnRfbGludCgnTXlDbGFzczo6TXlDbGFzcyhEb2N1bWVudCogZG9jKSA6IE15U3VwZXJDbGFz cygpIHsgfScsCiAgICAgICAgICdTaG91bGQgYmUgaW5kZW50ZWQgb24gYSBzZXBhcmF0ZSBsaW5l LCB3aXRoIHRoZSBjb2xvbiBvciBjb21tYSBmaXJzdCBvbiB0aGF0IGxpbmUuJwogICAgICAgICAn ICBbd2hpdGVzcGFjZS9pbmRlbnRdIFs0XScpCkBAIC00OTgzLDYgKzQ5ODYsNyBAQCBjbGFzcyBX ZWJLaXRTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICwgcHVibGljIGZvbyB7 CiAgICAgICAgIH07JycnLAogICAgICAgICAnJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgn byA9IGZvbyhiID8gYmFyKCkgOiBiYXooKSk7JywgJycpCiAKICAgICBkZWYgdGVzdF9vdGhlcihz ZWxmKToKICAgICAgICAgIyBGSVhNRTogSW1wbGVtZW50IHRoaXMuCg==