125228 2013-12-04 10:45:44 -0800 Use ThreadingOnce class to encapsulate pthread_once functionality. 2014-01-06 11:55:59 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 125264 1 peavo webkit-unassigned bfulgham commit-queue ggaren oldest_to_newest 956444 0 peavo 2013-12-04 10:45:44 -0800 In runtime/InitializeThreading.cpp, the non-pthread version is not fully equivalent to the pthread version. We can use the ThreadingOnce class here. 956450 1 218416 peavo 2013-12-04 10:53:31 -0800 Created attachment 218416 Patch 956514 2 218416 bfulgham 2013-12-04 12:13:46 -0800 Comment on attachment 218416 Patch r=me 956525 3 218416 commit-queue 2013-12-04 12:40:31 -0800 Comment on attachment 218416 Patch Clearing flags on attachment: 218416 Committed r160116: <http://trac.webkit.org/changeset/160116> 956526 4 commit-queue 2013-12-04 12:40:33 -0800 All reviewed patches have been landed. Closing bug. 956661 5 ggaren 2013-12-04 15:24:39 -0800 This is wrong. Please roll it out. It is incorrect for WTF::ThreadingOnce to be declared static. Since we build without thread-safe statics, that declaration is not thread-safe. Also, if statics were thread-safe, there would be no need for WTF::ThreadingOnce to contain any logic or data members: the constructor could just call the provided function, and you could rely on the compiler to ensure that the constructor was called only once. Therefore, this patch is either meaningless or wrong, depending on your platform. 956682 6 commit-queue 2013-12-04 15:59:00 -0800 Re-opened since this is blocked by bug 125264 956684 7 bfulgham 2013-12-04 16:00:30 -0800 We can switch to "std::call_once" when we move to VS2013. 956899 8 peavo 2013-12-05 07:45:19 -0800 (In reply to comment #5) > This is wrong. Please roll it out. > > It is incorrect for WTF::ThreadingOnce to be declared static. Since we build without thread-safe statics, that declaration is not thread-safe. > > Also, if statics were thread-safe, there would be no need for WTF::ThreadingOnce to contain any logic or data members: the constructor could just call the provided function, and you could rely on the compiler to ensure that the constructor was called only once. > > Therefore, this patch is either meaningless or wrong, depending on your platform. Thanks for catching this. A couple of other places needs to be changed as well, I've made bug 125305 for this. Sorry for the inconvienience. 964696 9 peavo 2014-01-06 11:55:59 -0800 This is now fixed by using std::call_once. 218416 2013-12-04 10:53:31 -0800 2013-12-04 12:40:31 -0800 Patch bug-125228-20131204195257.patch text/plain 1832 peavo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwMTA0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEzLTEyLTA0ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisg ICAgICAgIFVzZSBUaHJlYWRpbmdPbmNlIGNsYXNzIHRvIGVuY2Fwc3VsYXRlIHB0aHJlYWRfb25j ZSBmdW5jdGlvbmFsaXR5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTI1MjI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBydW50aW1lL0luaXRpYWxpemVUaHJlYWRpbmcuY3BwOgorICAgICAgICAoSlND Ojppbml0aWFsaXplVGhyZWFkaW5nKToKKwogMjAxMy0xMi0wNCAgSm9zZXBoIFBlY29yYXJvICA8 cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgV2luZG93cyBCdWlsZCBG aXggYXR0ZW1wdCBhZnRlciByMTYwMDk5LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvSW5pdGlhbGl6ZVRocmVhZGluZy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSW5pdGlhbGl6ZVRocmVhZGluZy5jcHAJKHJldmlzaW9uIDE2MDA3 NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0luaXRpYWxpemVUaHJlYWRpbmcu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MSwxNiArNDEsMTMgQEAKICNpbmNsdWRlICJXcml0ZUJh cnJpZXIuaCIKICNpbmNsdWRlIDx3dGYvZHRvYS5oPgogI2luY2x1ZGUgPHd0Zi9UaHJlYWRpbmcu aD4KKyNpbmNsdWRlIDx3dGYvVGhyZWFkaW5nT25jZS5oPgogI2luY2x1ZGUgPHd0Zi9kdG9hL2Nh Y2hlZC1wb3dlcnMuaD4KIAogdXNpbmcgbmFtZXNwYWNlIFdURjsKIAogbmFtZXNwYWNlIEpTQyB7 CiAKLSNpZiBPUyhEQVJXSU4pCi1zdGF0aWMgcHRocmVhZF9vbmNlX3QgaW5pdGlhbGl6ZVRocmVh ZGluZ0tleU9uY2UgPSBQVEhSRUFEX09OQ0VfSU5JVDsKLSNlbmRpZgotCiBzdGF0aWMgdm9pZCBp bml0aWFsaXplVGhyZWFkaW5nT25jZSgpCiB7CiAgICAgV1RGOjpkb3VibGVfY29udmVyc2lvbjo6 aW5pdGlhbGl6ZSgpOwpAQCAtNzYsMTUgKzczLDggQEAgc3RhdGljIHZvaWQgaW5pdGlhbGl6ZVRo cmVhZGluZ09uY2UoKQogCiB2b2lkIGluaXRpYWxpemVUaHJlYWRpbmcoKQogewotI2lmIE9TKERB UldJTikKLSAgICBwdGhyZWFkX29uY2UoJmluaXRpYWxpemVUaHJlYWRpbmdLZXlPbmNlLCBpbml0 aWFsaXplVGhyZWFkaW5nT25jZSk7Ci0jZWxzZQotICAgIHN0YXRpYyBib29sIGluaXRpYWxpemVk VGhyZWFkaW5nID0gZmFsc2U7Ci0gICAgaWYgKCFpbml0aWFsaXplZFRocmVhZGluZykgewotICAg ICAgICBpbml0aWFsaXplVGhyZWFkaW5nT25jZSgpOwotICAgICAgICBpbml0aWFsaXplZFRocmVh ZGluZyA9IHRydWU7Ci0gICAgfQotI2VuZGlmCisgICAgc3RhdGljIFdURjo6VGhyZWFkaW5nT25j ZSBpbml0aWFsaXplVGhyZWFkaW5nS2V5T25jZTsKKyAgICBpbml0aWFsaXplVGhyZWFkaW5nS2V5 T25jZS5jYWxsT25jZShpbml0aWFsaXplVGhyZWFkaW5nT25jZSk7CiB9CiAKIH0gLy8gbmFtZXNw YWNlIEpTQwo=