125226 2013-12-04 09:23:18 -0800 Remove duplicated/dead code from cpp style checker unit tests. 2013-12-05 03:58:01 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tgergely.u-szeged webkit-unassigned commit-queue galpeter glenn ossy rniwa oldest_to_newest 956409 0 tgergely.u-szeged 2013-12-04 09:23:18 -0800 There are two test classes in webkitpy/style/checkers/cpp_unittest.py with the same name. The second overrides the first which can be removed. 956410 1 218412 tgergely.u-szeged 2013-12-04 09:29:39 -0800 Created attachment 218412 Remove dead code. 956821 2 galpeter 2013-12-05 02:34:08 -0800 Good catch! LGTM :) 956843 3 218412 commit-queue 2013-12-05 03:57:59 -0800 Comment on attachment 218412 Remove dead code. Clearing flags on attachment: 218412 Committed r160167: <http://trac.webkit.org/changeset/160167> 956844 4 commit-queue 2013-12-05 03:58:01 -0800 All reviewed patches have been landed. Closing bug. 218412 2013-12-04 09:29:39 -0800 2013-12-05 03:57:59 -0800 Remove dead code. remove_dead_code_from_cpp_style_unittest.patch text/plain 2995 tgergely.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhMWM4 ZGZmLi5jNGU0ZTU4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMjEgQEAKIDIwMTMtMTItMDQgIFRhbWFzIEdlcmdlbHkgIDx0Z2Vy Z2VseS51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgogCisgICAgICAgIFJlbW92ZSBkdXBs aWNhdGVkL2RlYWQgY29kZSBmcm9tIGNwcCBzdHlsZSBjaGVja2VyIHVuaXQgdGVzdHMuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjUyMjYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdGhlIGZp cnN0IGRlZmluaXRpb24gb2YgT3JkZXJPZkluY2x1ZGVzVGVzdCBjbGFzcyBhcyBpdCBpcworICAg ICAgICBvdmVyd3JpdHRlbiBieSB0aGUgc2Vjb25kLiBSZW1vdmUgYSBkdXBsaWNhdGVkIGFzc2Vy dCBzdGF0ZW1lbnQKKyAgICAgICAgZnJvbSB0aGUgc2Vjb25kIGNsYXNzLgorCisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHk6CisgICAgICAg IChPcmRlck9mSW5jbHVkZXNUZXN0LnNldFVwKToKKyAgICAgICAgKE9yZGVyT2ZJbmNsdWRlc1Rl c3QudGVzdF90cnlfZHJvcF9jb21tb25fc3VmZml4ZXMpOgorICAgICAgICAgIFRoZSBsYXN0IGFz c2VydCB3YXMgZHVwbGljYXRlZC4KKworMjAxMy0xMi0wNCAgVGFtYXMgR2VyZ2VseSAgPHRnZXJn ZWx5LnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CisKICAgICAgICAgU3R5bGUgY2hlY2tl ciBmb3IgLm1lc3NhZ2VzLmluIGZpbGVzIChXVEY6OiBwcmVmaXgpCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjUxNDIKIApkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQppbmRleCA3 Nzg3NDA3Li42ODg5YzUwIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQpAQCAtMjUzMywzMCArMjUzMyw2IEBAIGNsYXNz IE9yZGVyT2ZJbmNsdWRlc1Rlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAKICAgICAgICAgIyBDaGVh dCBvcy5wYXRoLmFic3BhdGggY2FsbGVkIGluIEZpbGVJbmZvIGNsYXNzLgogICAgICAgICBzZWxm Lm9zX3BhdGhfYWJzcGF0aF9vcmlnID0gb3MucGF0aC5hYnNwYXRoCi0gICAgICAgIG9zLnBhdGgu YWJzcGF0aCA9IGxhbWJkYSB2YWx1ZTogdmFsdWUKLQotICAgIGRlZiB0ZWFyRG93bihzZWxmKToK LSAgICAgICAgb3MucGF0aC5hYnNwYXRoID0gc2VsZi5vc19wYXRoX2Fic3BhdGhfb3JpZwotCi0g ICAgZGVmIHRlc3RfdHJ5X2Ryb3BfY29tbW9uX3N1ZmZpeGVzKHNlbGYpOgotICAgICAgICBzZWxm LmFzc2VydEVxdWFsKCdmb28vZm9vJywgY3BwX3N0eWxlLl9kcm9wX2NvbW1vbl9zdWZmaXhlcygn Zm9vL2Zvby1pbmwuaCcpKQotICAgICAgICBzZWxmLmFzc2VydEVxdWFsKCdmb28vYmFyL2Zvbycs Ci0gICAgICAgICAgICAgICAgICAgICAgICAgY3BwX3N0eWxlLl9kcm9wX2NvbW1vbl9zdWZmaXhl cygnZm9vL2Jhci9mb29faW5sLmgnKSkKLSAgICAgICAgc2VsZi5hc3NlcnRFcXVhbCgnZm9vL2Zv bycsIGNwcF9zdHlsZS5fZHJvcF9jb21tb25fc3VmZml4ZXMoJ2Zvby9mb28uY3BwJykpCi0gICAg ICAgIHNlbGYuYXNzZXJ0RXF1YWwoJ2Zvby9mb29fdW51c3VhbGludGVybmFsJywKLSAgICAgICAg ICAgICAgICAgICAgICAgICBjcHBfc3R5bGUuX2Ryb3BfY29tbW9uX3N1ZmZpeGVzKCdmb28vZm9v X3VudXN1YWxpbnRlcm5hbC5oJykpCi0gICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoJycsCi0gICAg ICAgICAgICAgICAgICAgICAgICAgY3BwX3N0eWxlLl9kcm9wX2NvbW1vbl9zdWZmaXhlcygnX3Rl c3QuY3BwJykpCi0gICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoJ3Rlc3QnLAotICAgICAgICAgICAg ICAgICAgICAgICAgIGNwcF9zdHlsZS5fZHJvcF9jb21tb25fc3VmZml4ZXMoJ3Rlc3QuY3BwJykp Ci0KLQotY2xhc3MgT3JkZXJPZkluY2x1ZGVzVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKLSAgICBk ZWYgc2V0VXAoc2VsZik6Ci0gICAgICAgIHNlbGYuaW5jbHVkZV9zdGF0ZSA9IGNwcF9zdHlsZS5f SW5jbHVkZVN0YXRlKCkKLQotICAgICAgICAjIENoZWF0IG9zLnBhdGguYWJzcGF0aCBjYWxsZWQg aW4gRmlsZUluZm8gY2xhc3MuCi0gICAgICAgIHNlbGYub3NfcGF0aF9hYnNwYXRoX29yaWcgPSBv cy5wYXRoLmFic3BhdGgKICAgICAgICAgc2VsZi5vc19wYXRoX2lzZmlsZV9vcmlnID0gb3MucGF0 aC5pc2ZpbGUKICAgICAgICAgb3MucGF0aC5hYnNwYXRoID0gbGFtYmRhIHZhbHVlOiB2YWx1ZQog CkBAIC0yODc3LDggKzI4NTMsNyBAQCBjbGFzcyBPcmRlck9mSW5jbHVkZXNUZXN0KENwcFN0eWxl VGVzdEJhc2UpOgogICAgICAgICAgICAgICAgICAgICAgICAgIGNwcF9zdHlsZS5fZHJvcF9jb21t b25fc3VmZml4ZXMoJ190ZXN0LmNwcCcpKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKCd0ZXN0 JywKICAgICAgICAgICAgICAgICAgICAgICAgICBjcHBfc3R5bGUuX2Ryb3BfY29tbW9uX3N1ZmZp eGVzKCd0ZXN0LmNwcCcpKQotICAgICAgICBzZWxmLmFzc2VydEVxdWFsKCd0ZXN0JywKLSAgICAg ICAgICAgICAgICAgICAgICAgICBjcHBfc3R5bGUuX2Ryb3BfY29tbW9uX3N1ZmZpeGVzKCd0ZXN0 LmNwcCcpKQorCiAKIGNsYXNzIENoZWNrRm9yRnVuY3Rpb25MZW5ndGhzVGVzdChDcHBTdHlsZVRl c3RCYXNlKToKICAgICBkZWYgc2V0VXAoc2VsZik6Cg==