125215 2013-12-04 02:50:05 -0800 Avoid to add zero offset in BaseIndex. 2013-12-05 01:08:57 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 llango.u-szeged webkit-unassigned commit-queue fpizlo oldest_to_newest 956330 0 llango.u-szeged 2013-12-04 02:50:05 -0800 Avoid to add zero offset in BaseIndex class in offlineasm/cloop.rb. 956332 1 218394 llango.u-szeged 2013-12-04 02:53:00 -0800 Created attachment 218394 Patch 956378 2 218394 commit-queue 2013-12-04 06:39:23 -0800 Comment on attachment 218394 Patch Clearing flags on attachment: 218394 Committed r160091: <http://trac.webkit.org/changeset/160091> 956379 3 commit-queue 2013-12-04 06:39:25 -0800 All reviewed patches have been landed. Closing bug. 956407 4 fpizlo 2013-12-04 09:14:08 -0800 As a general rule, I would avoid making such changes. This change has no upside. The C compiler would have folded the zero, and it would have done it as part of one of many already-mandatory folding passes - even at -O0. So, you're just duplicating that functionality in offlineasm, which just means more code to maintain and more places where someone might make a mistake. 956806 5 llango.u-szeged 2013-12-05 01:08:57 -0800 (In reply to comment #4) > As a general rule, I would avoid making such changes. This change has no upside. The C compiler would have folded the zero, and it would have done it as part of one of many already-mandatory folding passes - even at -O0. So, you're just duplicating that functionality in offlineasm, which just means more code to maintain and more places where someone might make a mistake. Thanks for the reply. Yes, you are partly right. The GCC with -O0 really optimize this out, but the clang isn't. It won't do it with -O0. The other reason why I made this is that there's already a similar change in class Address in this file: http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/offlineasm/cloop.rb#L195 So we should keep or remove from both places. I'm still think this is a good change. 218394 2013-12-04 02:53:00 -0800 2013-12-04 06:39:23 -0800 Patch bug-125215-20131204025300.patch text/plain 1551 llango.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMDc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz YjljNzk4ZjA4NDAyY2UyZmQ1N2IyNGI4NDMwMmQxM2Y2OWM2ZjYzLi5jODBhNDgwOGQwNTIwODg1 ZjFkMzE0MTdlN2RkNWQ3ZTY2NGM4M2U2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxMy0xMi0wNCAgTMOhc3psw7MgTGFuZ8OzICA8bGFuZ29AaW5mLnUtc3pl Z2VkLmh1PgorCisgICAgICAgIEF2b2lkIHRvIGFkZCB6ZXJvIG9mZnNldCBpbiBCYXNlSW5kZXgu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjUyMTUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHVz aW5nIGNsb29wIGRvIG5vdCBnZW5lcmF0ZSBvZmZzZXRzIGFkZGl0aW9ucyBmb3IgQmFzZUluZGV4 IGlmIHRoZSBvZmZzZXQgaXMgemVyby4KKworICAgICAgICAqIG9mZmxpbmVhc20vY2xvb3AucmI6 CisKIDIwMTMtMTItMDMgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAg IHRlc3RhcGkgdGVzdCBjcmFzaGVzIG9uIFdpbmRvd3MgaW4gV1RGOjpWZWN0b3I8d2NoYXJfdCw2 NCxXVEY6OlVuc2FmZVZlY3Rvck92ZXJmbG93Pjo6c2l6ZSgpLgpkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vY2xvb3AucmIgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvb2ZmbGluZWFzbS9jbG9vcC5yYgppbmRleCA5N2I5ZmFjZTNiZGI5YWNmNGJmY2ZlYzBlMWU0 Y2E3YzE1M2YwMzE0Li5iNTNkNDExMmRjMzUwODljNmZmN2M1ODM0NDVkMzg4MDE4Y2JhNjRiIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9jbG9vcC5yYgorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9jbG9vcC5yYgpAQCAtMjYxLDcgKzI2 MSwxMSBAQCBjbGFzcyBCYXNlSW5kZXgKICAgICAgICAgZW5kCiAgICAgZW5kCiAgICAgZGVmIHBv aW50ZXJFeHByCi0gICAgICAgICIje2Jhc2UuY2xWYWx1ZSg6aW50OFB0cil9ICsgKCN7aW5kZXgu Y2xWYWx1ZX0gPDwgI3tzY2FsZVNoaWZ0fSkgKyAje29mZnNldC5jbFZhbHVlfSIKKyAgICAgICAg aWYgb2Zmc2V0LnZhbHVlID09IDAKKyAgICAgICAgICAgICIje2Jhc2UuY2xWYWx1ZSg6aW50OFB0 cil9ICsgKCN7aW5kZXguY2xWYWx1ZX0gPDwgI3tzY2FsZVNoaWZ0fSkiCisgICAgICAgIGVsc2UK KyAgICAgICAgICAgICIje2Jhc2UuY2xWYWx1ZSg6aW50OFB0cil9ICsgKCN7aW5kZXguY2xWYWx1 ZX0gPDwgI3tzY2FsZVNoaWZ0fSkgKyAje29mZnNldC5jbFZhbHVlfSIKKyAgICAgICAgZW5kCiAg ICAgZW5kCiAgICAgZGVmIGludDhNZW1SZWYKICAgICAgICAgIipDQVNUPGludDhfdCo+KCN7cG9p bnRlckV4cHJ9KSIK