125190 2013-12-03 15:00:47 -0800 PageBannerClientImpl should be an API::Client 2013-12-03 15:16:53 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 956144 0 andersca 2013-12-03 15:00:47 -0800 PageBannerClientImpl should be an API::Client 956146 1 218347 andersca 2013-12-03 15:03:05 -0800 Created attachment 218347 Patch 956160 2 andersca 2013-12-03 15:16:53 -0800 Committed r160047: <http://trac.webkit.org/changeset/160047> 218347 2013-12-03 15:03:05 -0800 2013-12-03 15:07:41 -0800 Patch bug-125190-20131203150304.patch text/plain 4882 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMDM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTRmMjJlMTdkNGQ4ZTky NWZkNmU1YzQzNGIzMDgwYzQ2ZDdhNjcwMS4uYWRlNGVjZTcxYjA3ZWJkZGUzMWMwMGNmMGVkZWJi ZThjMjFmMGE0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEzLTEyLTAzICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgUGFnZUJhbm5lckNs aWVudEltcGwgc2hvdWxkIGJlIGFuIEFQSTo6Q2xpZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjUxOTAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJ L2MvbWFjL1dLQnVuZGxlUGFnZUJhbm5lck1hYy5tbToKKyAgICAgICAgKFBhZ2VCYW5uZXJDbGll bnRJbXBsOjpQYWdlQmFubmVyQ2xpZW50SW1wbCk6CisgICAgICAgIChQYWdlQmFubmVyQ2xpZW50 SW1wbDo6flBhZ2VCYW5uZXJDbGllbnRJbXBsKToKKyAgICAgICAgKFdLQnVuZGxlUGFnZUJhbm5l ckNyZWF0ZUJhbm5lcldpdGhDQUxheWVyKToKKworMjAxMy0xMi0wMyAgQW5kZXJzIENhcmxzc29u ICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIERlcHJlY2F0ZSBXS05vdGlmaWNhdGlv blByb3ZpZGVyCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjUxNzgKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3Rl ZEJ1bmRsZS9BUEkvYy9tYWMvV0tCdW5kbGVQYWdlQmFubmVyTWFjLm1tIGIvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9tYWMvV0tCdW5kbGVQYWdlQmFubmVy TWFjLm1tCmluZGV4IDMwOWUzMDg0YTI1NThmYmRhZTdiZmFjY2U0YzY2MmE5NmEyNWVjNDYuLjAy MTE3NzNjNzc4MTkxYjVmMzZhMzE1ZTJjZTYyYTM3ZWNjZjA5MjQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvbWFjL1dLQnVuZGxlUGFn ZUJhbm5lck1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVu ZGxlL0FQSS9jL21hYy9XS0J1bmRsZVBhZ2VCYW5uZXJNYWMubW0KQEAgLTI2LDYgKzI2LDcgQEAK ICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJXS0J1bmRsZVBhZ2VCYW5uZXJNYWMuaCIK IAorI2luY2x1ZGUgIkFQSUNsaWVudC5oIgogI2luY2x1ZGUgIlBhZ2VCYW5uZXIuaCIKICNpbmNs dWRlICJXS0FQSUNhc3QuaCIKICNpbmNsdWRlICJXS0J1bmRsZUFQSUNhc3QuaCIKQEAgLTM0LDY2 ICszNSw3MSBAQAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiB1c2luZyBuYW1lc3BhY2UgV2Vi S2l0OwogCi1jbGFzcyBQYWdlQmFubmVyQ2xpZW50SW1wbCA6IHB1YmxpYyBQYWdlQmFubmVyOjpD bGllbnQgeworbmFtZXNwYWNlIEFQSSB7Cit0ZW1wbGF0ZTw+IHN0cnVjdCBDbGllbnRUcmFpdHM8 V0tCdW5kbGVQYWdlQmFubmVyQ2xpZW50QmFzZT4geworICAgIHR5cGVkZWYgc3RkOjp0dXBsZTxX S0J1bmRsZVBhZ2VCYW5uZXJDbGllbnRWMD4gVmVyc2lvbnM7Cit9OworfQorCitjbGFzcyBQYWdl QmFubmVyQ2xpZW50SW1wbCA6IHB1YmxpYyBBUEk6OkNsaWVudDxXS0J1bmRsZVBhZ2VCYW5uZXJD bGllbnRCYXNlPiwgcHVibGljIFBhZ2VCYW5uZXI6OkNsaWVudCB7CiBwdWJsaWM6Ci0gICAgZXhw bGljaXQgUGFnZUJhbm5lckNsaWVudEltcGwoV0tCdW5kbGVQYWdlQmFubmVyQ2xpZW50KiBjbGll bnQpCi0gICAgICAgIDogbV9jbGllbnQoKQorICAgIGV4cGxpY2l0IFBhZ2VCYW5uZXJDbGllbnRJ bXBsKFdLQnVuZGxlUGFnZUJhbm5lckNsaWVudEJhc2UqIGNsaWVudCkKKyAgICB7CisgICAgfQor CisgICAgdmlydHVhbCB+UGFnZUJhbm5lckNsaWVudEltcGwoKQogICAgIHsKLSAgICAgICAgaWYg KGNsaWVudCkKLSAgICAgICAgICAgIG1fY2xpZW50ID0gKmNsaWVudDsKICAgICB9CiAKIHByaXZh dGU6CiAgICAgLy8gUGFnZUJhbm5lcjo6Q2xpZW50LgotICAgIHZpcnR1YWwgdm9pZCBwYWdlQmFu bmVyRGVzdHJveWVkKFBhZ2VCYW5uZXIqKQorICAgIHZpcnR1YWwgdm9pZCBwYWdlQmFubmVyRGVz dHJveWVkKFBhZ2VCYW5uZXIqKSBPVkVSUklERQogICAgIHsKICAgICAgICAgZGVsZXRlIHRoaXM7 CiAgICAgfQogICAgIAotICAgIHZpcnR1YWwgYm9vbCBtb3VzZUV2ZW50KFBhZ2VCYW5uZXIqIHBh Z2VCYW5uZXIsIFdlYkV2ZW50OjpUeXBlIHR5cGUsIFdlYk1vdXNlRXZlbnQ6OkJ1dHRvbiBidXR0 b24sIGNvbnN0IFdlYkNvcmU6OkludFBvaW50JiBwb3NpdGlvbikKKyAgICB2aXJ0dWFsIGJvb2wg bW91c2VFdmVudChQYWdlQmFubmVyKiBwYWdlQmFubmVyLCBXZWJFdmVudDo6VHlwZSB0eXBlLCBX ZWJNb3VzZUV2ZW50OjpCdXR0b24gYnV0dG9uLCBjb25zdCBJbnRQb2ludCYgcG9zaXRpb24pIE9W RVJSSURFCiAgICAgewogICAgICAgICBzd2l0Y2ggKHR5cGUpIHsKICAgICAgICAgY2FzZSBXZWJF dmVudDo6TW91c2VEb3duOiB7CiAgICAgICAgICAgICBpZiAoIW1fY2xpZW50Lm1vdXNlRG93bikK ICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICAgICAgICAgIHJldHVybiBtX2Ns aWVudC5tb3VzZURvd24odG9BUEkocGFnZUJhbm5lciksIHRvQVBJKHBvc2l0aW9uKSwgdG9BUEko YnV0dG9uKSwgbV9jbGllbnQuY2xpZW50SW5mbyk7CisgICAgICAgICAgICByZXR1cm4gbV9jbGll bnQubW91c2VEb3duKHRvQVBJKHBhZ2VCYW5uZXIpLCB0b0FQSShwb3NpdGlvbiksIHRvQVBJKGJ1 dHRvbiksIG1fY2xpZW50LmJhc2UuY2xpZW50SW5mbyk7CiAgICAgICAgIH0KICAgICAgICAgY2Fz ZSBXZWJFdmVudDo6TW91c2VVcDogewogICAgICAgICAgICAgaWYgKCFtX2NsaWVudC5tb3VzZVVw KQogICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgICAgICAgICAgcmV0dXJuIG1f Y2xpZW50Lm1vdXNlVXAodG9BUEkocGFnZUJhbm5lciksIHRvQVBJKHBvc2l0aW9uKSwgdG9BUEko YnV0dG9uKSwgbV9jbGllbnQuY2xpZW50SW5mbyk7CisgICAgICAgICAgICByZXR1cm4gbV9jbGll bnQubW91c2VVcCh0b0FQSShwYWdlQmFubmVyKSwgdG9BUEkocG9zaXRpb24pLCB0b0FQSShidXR0 b24pLCBtX2NsaWVudC5iYXNlLmNsaWVudEluZm8pOwogICAgICAgICB9CiAgICAgICAgIGNhc2Ug V2ViRXZlbnQ6Ok1vdXNlTW92ZTogewogICAgICAgICAgICAgaWYgKGJ1dHRvbiA9PSBXZWJNb3Vz ZUV2ZW50OjpOb0J1dHRvbikgewogICAgICAgICAgICAgICAgIGlmICghbV9jbGllbnQubW91c2VN b3ZlZCkKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgICAgICAgICAg ICAgcmV0dXJuIG1fY2xpZW50Lm1vdXNlTW92ZWQodG9BUEkocGFnZUJhbm5lciksIHRvQVBJKHBv c2l0aW9uKSwgbV9jbGllbnQuY2xpZW50SW5mbyk7CisgICAgICAgICAgICAgICAgcmV0dXJuIG1f Y2xpZW50Lm1vdXNlTW92ZWQodG9BUEkocGFnZUJhbm5lciksIHRvQVBJKHBvc2l0aW9uKSwgbV9j bGllbnQuYmFzZS5jbGllbnRJbmZvKTsKICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgLy8g VGhpcyBpcyBhIE1vdXNlTW92ZSBldmVudCB3aXRoIGEgbW91c2UgYnV0dG9uIHByZXNzZWQuIENh bGwgbW91c2VEcmFnZ2VkLgogICAgICAgICAgICAgaWYgKCFtX2NsaWVudC5tb3VzZURyYWdnZWQp CiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgICAgICAgICByZXR1cm4gbV9j bGllbnQubW91c2VEcmFnZ2VkKHRvQVBJKHBhZ2VCYW5uZXIpLCB0b0FQSShwb3NpdGlvbiksIHRv QVBJKGJ1dHRvbiksIG1fY2xpZW50LmNsaWVudEluZm8pOworICAgICAgICAgICAgcmV0dXJuIG1f Y2xpZW50Lm1vdXNlRHJhZ2dlZCh0b0FQSShwYWdlQmFubmVyKSwgdG9BUEkocG9zaXRpb24pLCB0 b0FQSShidXR0b24pLCBtX2NsaWVudC5iYXNlLmNsaWVudEluZm8pOwogICAgICAgICB9CiAKICAg ICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgfQogICAg IH0KLSAgICAKLSAgICBXS0J1bmRsZVBhZ2VCYW5uZXJDbGllbnQgbV9jbGllbnQ7CiB9OwogCi1X S0J1bmRsZVBhZ2VCYW5uZXJSZWYgV0tCdW5kbGVQYWdlQmFubmVyQ3JlYXRlQmFubmVyV2l0aENB TGF5ZXIoQ0FMYXllciAqbGF5ZXIsIGludCBoZWlnaHQsIFdLQnVuZGxlUGFnZUJhbm5lckNsaWVu dCAqIHdrQ2xpZW50KQorV0tCdW5kbGVQYWdlQmFubmVyUmVmIFdLQnVuZGxlUGFnZUJhbm5lckNy ZWF0ZUJhbm5lcldpdGhDQUxheWVyKENBTGF5ZXIgKmxheWVyLCBpbnQgaGVpZ2h0LCBXS0J1bmRs ZVBhZ2VCYW5uZXJDbGllbnQqIHdrQ2xpZW50KQogewogICAgIGlmICh3a0NsaWVudCAmJiB3a0Ns aWVudC0+dmVyc2lvbikKICAgICAgICAgcmV0dXJuIDA7CiAKLSAgICBhdXRvIGNsaWVudEltcGwg PSBzdGQ6Om1ha2VfdW5pcXVlPFBhZ2VCYW5uZXJDbGllbnRJbXBsPih3a0NsaWVudCk7CisgICAg YXV0byBjbGllbnRJbXBsID0gc3RkOjptYWtlX3VuaXF1ZTxQYWdlQmFubmVyQ2xpZW50SW1wbD4o cmVpbnRlcnByZXRfY2FzdDxXS0J1bmRsZVBhZ2VCYW5uZXJDbGllbnRCYXNlKj4od2tDbGllbnQp KTsKICAgICByZXR1cm4gdG9BUEkoUGFnZUJhbm5lcjo6Y3JlYXRlKGxheWVyLCBoZWlnaHQsIGNs aWVudEltcGwucmVsZWFzZSgpKS5sZWFrUmVmKCkpOwogfQogCg==