125186 2013-12-03 14:31:32 -0800 [Win] Cannot build 64-bit with ENABLE_LLINT but without ENABLE_JIT 2013-12-03 17:16:20 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 bfulgham mark.lam oldest_to_newest 956113 0 bfulgham 2013-12-03 14:31:32 -0800 Attempting to create a 64-bit build on Windows with ENABLE_JIT undefined results in the following build error: 7>C:\Projects\WebKit\OpenSource\WebKitBuild\Release\obj64\JavaScriptCore\DerivedSources\LLIntAssembly.h(5): error C2065: 'callToJavaScript' : undeclared identifier 7>C:\Projects\WebKit\OpenSource\WebKitBuild\Release\obj64\JavaScriptCore\DerivedSources\LLIntAssembly.h(5): error C2051: case expression not constant 7>C:\Projects\WebKit\OpenSource\WebKitBuild\Release\obj64\JavaScriptCore\DerivedSources\LLIntAssembly.h(17): error C2065: 'returnFromJavaScript' : undeclared identifier 7>C:\Projects\WebKit\OpenSource\WebKitBuild\Release\obj64\JavaScriptCore\DerivedSources\LLIntAssembly.h(17): error C2051: case expression not constant The 64-bit build automatically activates ENABLE_LLINT, which may be the problem. "callToJavaScript" and "returnFromJavaScript" are implemented in assembly code (see JITStubsMSVC64.asm). However, I don't think the declarations are visible to LowLevelInterpreter.cpp when building without ENABLE_JIT. If I add declarations for those methods, I still encounter the "case expression not constant" error, since it is attempting to use a method declaration as a label. 956217 1 218364 mark.lam 2013-12-03 17:04:12 -0800 Created attachment 218364 the patch. 956218 2 218364 mark.lam 2013-12-03 17:05:35 -0800 Comment on attachment 218364 the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=218364&action=review > Source/JavaScriptCore/ChangeLog:12 > + - Win64 will build JITStubMSVC64.asm even when !WNABLE(JIT). This results typo: WNABLE ==> ENABLE. Will fix before landing. 956219 3 218364 msaboff 2013-12-03 17:12:42 -0800 Comment on attachment 218364 the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=218364&action=review > Source/JavaScriptCore/jit/JITOperationsMSVC64.cpp:35 > +// The following is a workaround that is only needed because JITStubsMSVC64.asm is built Please add a FIXME: 956222 4 mark.lam 2013-12-03 17:16:20 -0800 Thanks for the review. Landed in r160062: <http://trac.webkit.org/r160062>. 218364 2013-12-03 17:04:12 -0800 2013-12-03 17:12:41 -0800 the patch. bug-125186.patch text/plain 6719 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwMDYxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBA CisyMDEzLTEyLTAzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG aXggTExJTlRfQ19MT09QIGJ1aWxkIGZvciBXaW42NC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNTE4Ni4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEphdmFTY3JpcHRDb3JlLnZjeHByb2ovSmF2YVNj cmlwdENvcmUudmN4cHJvajoKKyAgICAgICAgKiBKYXZhU2NyaXB0Q29yZS52Y3hwcm9qL0phdmFT Y3JpcHRDb3JlLnZjeHByb2ouZmlsdGVyczoKKyAgICAgICAgKiBqaXQvSklUT3BlcmF0aW9uc01T VkM2NC5jcHA6IEFkZGVkLgorICAgICAgICAoSlNDOjpnZXRIb3N0Q2FsbFJldHVyblZhbHVlV2l0 aEV4ZWNTdGF0ZSk6CisgICAgICAgIC0gV2luNjQgd2lsbCBidWlsZCBKSVRTdHViTVNWQzY0LmFz bSBldmVuIHdoZW4gIVdOQUJMRShKSVQpLiBUaGlzIHJlc3VsdHMKKyAgICAgICAgICBpbiBhIGxp bmthZ2UgZXJyb3IgZHVlIHRvIGEgbWlzc2luZyBnZXRIb3N0Q2FsbFJldHVyblZhbHVlV2l0aEV4 ZWNTdGF0ZSgpLgorICAgICAgICAgIFNvLCB3ZSBhZGQgYSBzdHViIGdldEhvc3RDYWxsUmV0dXJu VmFsdWVXaXRoRXhlY1N0YXRlKCkgaGVyZSB0byBzYXRpc2Z5CisgICAgICAgICAgdGhhdCBsaW5r YWdlLiBUaGlzIGZ1bmN0aW9uIHdpbGwgbmV2ZXIgYmUgY2FsbGVkLgorICAgICAgICAgIFRoZSBh bHRlcm5hdGl2ZSB0byBwcm92aWRpbmcgc3VjaCBhIHN0dWIgaXMgdG8gbWFrZSB0aGUgTVNWQyBw cm9qZWN0CisgICAgICAgICAgcmVjb2duaXplIGlmIHRoZSBKSVQgaXMgZW5hYmxlZCBvciBub3Qs IGFuZCBleGNsdWRlIEpJVFN0dWJNU1ZDNjQuYXNtCisgICAgICAgICAgaWYgaXQncyBub3QgZW5h YmxlZC4gV2UgZG9uJ3QgY3VycmVudGx5IHNldCBFTkFCTEUoSklUKSB2aWEgdGhlIE1TVkMKKyAg ICAgICAgICBwcm9qZWN0IGFuZCB0aGUgd29yayB0byBkbyB0aGF0IGlzIHRvbyBtdWNoIHRyb3Vi bGUgZm9yIHdoYXQgd2UncmUgdHJ5aW5nCisgICAgICAgICAgdG8gYWNoaWV2ZSBoZXJlLiBTbywg d2UncmUgb3B0aW5nIGZvciB0aGlzIHNpbXBsZXIgd29ya2Fyb3VuZCBpbnN0ZWFkLgorCisgICAg ICAgICogbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc206CisgICAgICAgICogbGxpbnQvTG93 TGV2ZWxJbnRlcnByZXRlci5jcHA6CisgICAgICAgIChKU0M6OkNMb29wOjpleGVjdXRlKToKKyAg ICAgICAgLSBEb24ndCBidWlsZCBjYWxsVG9KYXZhU2NyaXB0IGlmIHdlJ3JlIGJ1aWxkaW5nIHRo ZSBDIGxvb3AuIE90aGVyd2lzZSwKKyAgICAgICAgICB0aGUgQyBsb29wIHdvbid0IGJ1aWxkIGlm ICFFTkFCTEUoQ09NUFVURV9HT1RPX09QQ09ERVMpLiAKKwogMjAxMy0xMi0wMyAgTWljaGFlbCBT YWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBBUk02NDogQ3Jhc2ggaW4gSklU IGNvZGUgZHVlIHRvIGltcHJvcGVyIHJldXNlIG9mIGNhY2hlZCBtZW1vcnkgdGVtcCByZWdpc3Rl cgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnZjeHByb2ovSmF2 YVNjcmlwdENvcmUudmN4cHJvago9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv SmF2YVNjcmlwdENvcmUudmN4cHJvai9KYXZhU2NyaXB0Q29yZS52Y3hwcm9qCShyZXZpc2lvbiAx NjAwMzQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmN4cHJvai9K YXZhU2NyaXB0Q29yZS52Y3hwcm9qCSh3b3JraW5nIGNvcHkpCkBAIC00NzgsNiArNDc4LDcgQEAK ICAgICA8Q2xDb21waWxlIEluY2x1ZGU9Ii4uXGppdFxKSVRPcGNvZGVzLmNwcCIgLz4KICAgICA8 Q2xDb21waWxlIEluY2x1ZGU9Ii4uXGppdFxKSVRPcGNvZGVzMzJfNjQuY3BwIiAvPgogICAgIDxD bENvbXBpbGUgSW5jbHVkZT0iLi5caml0XEpJVE9wZXJhdGlvbnMuY3BwIiAvPgorICAgIDxDbENv bXBpbGUgSW5jbHVkZT0iLi5caml0XEpJVE9wZXJhdGlvbnNNU1ZDNjQuY3BwIiAvPgogICAgIDxD bENvbXBpbGUgSW5jbHVkZT0iLi5caml0XEpJVFByb3BlcnR5QWNjZXNzLmNwcCIgLz4KICAgICA8 Q2xDb21waWxlIEluY2x1ZGU9Ii4uXGppdFxKSVRQcm9wZXJ0eUFjY2VzczMyXzY0LmNwcCIgLz4K ICAgICA8Q2xDb21waWxlIEluY2x1ZGU9Ii4uXGppdFxKSVRTdHViUm91dGluZS5jcHAiIC8+Cklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmN4cHJvai9KYXZhU2Ny aXB0Q29yZS52Y3hwcm9qLmZpbHRlcnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL0phdmFTY3JpcHRDb3JlLnZjeHByb2ovSmF2YVNjcmlwdENvcmUudmN4cHJvai5maWx0ZXJz CShyZXZpc2lvbiAxNjAwMzQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENv cmUudmN4cHJvai9KYXZhU2NyaXB0Q29yZS52Y3hwcm9qLmZpbHRlcnMJKHdvcmtpbmcgY29weSkK QEAgLTEyMzMsNiArMTIzMyw5IEBACiAgICAgPENsQ29tcGlsZSBJbmNsdWRlPSIuLlxqaXRcSklU T3BlcmF0aW9ucy5jcHAiPgogICAgICAgPEZpbHRlcj5qaXQ8L0ZpbHRlcj4KICAgICA8L0NsQ29t cGlsZT4KKyAgICA8Q2xDb21waWxlIEluY2x1ZGU9Ii4uXGppdFxKSVRPcGVyYXRpb25zTVNWQzY0 LmNwcCI+CisgICAgICA8RmlsdGVyPmppdDwvRmlsdGVyPgorICAgIDwvQ2xDb21waWxlPgogICAg IDxDbENvbXBpbGUgSW5jbHVkZT0iLi5ccnVudGltZVxUZXN0UnVubmVyVXRpbHMuY3BwIj4KICAg ICAgIDxGaWx0ZXI+cnVudGltZTwvRmlsdGVyPgogICAgIDwvQ2xDb21waWxlPgpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zTVNWQzY0LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnNNU1ZDNjQuY3BwCShy ZXZpc2lvbiAwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zTVNW QzY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDQ1IEBACisvKgorICogQ29weXJpZ2h0 IChDKSAyMDEzIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqCisgKiBSZWRpc3Ry aWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhv dXQKKyAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xs b3dpbmcgY29uZGl0aW9ucworICogYXJlIG1ldDoKKyAqIDEuIFJlZGlzdHJpYnV0aW9ucyBvZiBz b3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICBub3RpY2Us IHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisg KiAyLiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFi b3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQg dGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQorICogICAgZG9jdW1lbnRhdGlvbiBhbmQv b3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4KKyAqCisg KiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIEFQUExFIElOQy4gYGBBUyBJUycnIEFORCBB TlkKKyAqIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1Qg TElNSVRFRCBUTywgVEhFCisgKiBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZ IEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIKKyAqIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQu ICBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBJTkMuIE9SCisgKiBDT05UUklCVVRPUlMgQkUgTElB QkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwKKyAqIEVY RU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElN SVRFRCBUTywKKyAqIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7 IExPU1MgT0YgVVNFLCBEQVRBLCBPUgorICogUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBU SU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZIFRIRU9SWQorICogT0YgTElBQklMSVRZLCBX SEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAoSU5DTFVE SU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRI RSBVU0UKKyAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lC SUxJVFkgT0YgU1VDSCBEQU1BR0UuIAorICovCisKKyNpbmNsdWRlICJjb25maWcuaCIKKworI2lm ICFFTkFCTEUoSklUKSAmJiBDT01QSUxFUihNU1ZDKSAmJiBDUFUoWDg2XzY0KQorCisjaW5jbHVk ZSAiQ2FsbEZyYW1lLmgiCisjaW5jbHVkZSAiSlNDSlNWYWx1ZS5oIgorCituYW1lc3BhY2UgSlND IHsKKworLy8gVGhlIGZvbGxvd2luZyBpcyBhIHdvcmthcm91bmQgdGhhdCBpcyBvbmx5IG5lZWRl ZCBiZWNhdXNlIEpJVFN0dWJzTVNWQzY0LmFzbSBpcyBidWlsdAorLy8gdW5jb25kaXRpb25hbGx5 IGV2ZW4gd2hlbiB0aGUgSklUIGlzIGRpc2FibGUsIGFuZCBpdCByZWZlcmVuY2VzIHRoaXMgZnVu Y3Rpb24uIFdlIG9ubHkKKy8vIG5lZWQgdG8gcHJvdmlkZSBhIHN0dWIgdG8gc2F0aXNmeSB0aGUg bGlua2FnZS4gSXQgd2lsbCBuZXZlciBiZSBjYWxsZWQuCitleHRlcm4gIkMiIEVuY29kZWRKU1Zh bHVlIGdldEhvc3RDYWxsUmV0dXJuVmFsdWVXaXRoRXhlY1N0YXRlKEV4ZWNTdGF0ZSopCit7Cisg ICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShKU1ZhbHVlKCkpOworfQorCit9IC8vIG5hbWVzcGFj ZSBKU0MKKworI2VuZGlmIC8vICFFTkFCTEUoSklUKSAmJiBDT01QSUxFUihNU1ZDKSAmJiBDUFUo WDg2XzY0KQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJw cmV0ZXIuYXNtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dM ZXZlbEludGVycHJldGVyLmFzbQkocmV2aXNpb24gMTYwMDM0KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCSh3b3JraW5nIGNvcHkpCkBAIC00 MjEsMTIgKzQyMSwxNSBAQCBtYWNybyBkb1JldHVybigpCiAgICAgcmV0CiBlbmQKIAoraWYgQ19M T09QCitlbHNlCiAjIHN0dWIgdG8gY2FsbCBpbnRvIEphdmFTY3JpcHQKICMgRW5jb2RlZEpTVmFs dWUgY2FsbFRvSmF2YVNjcmlwdCh2b2lkKiBjb2RlLCBSZWdpc3RlciogdG9wT2ZTdGFjaykKICMg Tm90ZSwgaWYgdGhpcyBzdHViIG9yIG9uZSBvZiBpdCdzIHJlbGF0ZWQgbWFjcm9zIGlzIGNoYW5n ZWQsIG1ha2UgdGhlCiAjIGVxdWl2YWxlbnQgY2hhbmdlcyBpbiBqaXQvSklUU3R1YnNYODYuaCBh bmQvb3Igaml0L0pJVFN0dWJzTVNWQzY0LmFzbQogX2NhbGxUb0phdmFTY3JpcHQ6CiAgICAgZG9D YWxsVG9KYXZhU2NyaXB0KCkKK2VuZAogCiAjIEluZGljYXRlIHRoZSBiZWdpbm5pbmcgb2YgTExJ bnQuCiBfbGxpbnRfYmVnaW46CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93 TGV2ZWxJbnRlcnByZXRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuY3BwCShyZXZpc2lvbiAxNjAwMzQpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTMwOSw3ICszMDksNyBAQCBKU1ZhbHVlIENMb29wOjpleGVjdXRlKENhbGxGcmFt ZSogY2FsbEZyCiAgICAgLy8gMi4gMzIgYml0IHJlc3VsdCB2YWx1ZXMgd2lsbCBiZSBpbiB0aGUg bG93IDMyLWJpdCBvZiB0MC4KICAgICAvLyAzLiA2NCBiaXQgcmVzdWx0IHZhbHVlcyB3aWxsIGJl IGluIHQwLgogCi0gICAgQ0xvb3BSZWdpc3RlciB0MCwgdDEsIHQyLCB0MywgYTE7CisgICAgQ0xv b3BSZWdpc3RlciB0MCwgdDEsIHQyLCB0MzsKICNpZiBVU0UoSlNWQUxVRTY0KQogICAgIENMb29w UmVnaXN0ZXIgckJhc2VQQywgdGFnVHlwZU51bWJlciwgdGFnTWFzazsKICNlbmRpZgo=