125185 2013-12-03 14:30:26 -0800 jit/JITArithmetic.cpp doesn't build for non-X86 ports 2013-12-03 14:35:28 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 956111 0 msaboff 2013-12-03 14:30:26 -0800 For non X86 ports, JIT::emit_op_mod() declares and initializes result, op1 & op2, and doesn't use any of them. There UNUSED_PARAM() for op1 and op2, but not for result. The declarations and initializations along with the UNUSED_PARAM() can all be removed. 956118 1 218343 msaboff 2013-12-03 14:34:50 -0800 Created attachment 218343 Patch for landing 956120 2 msaboff 2013-12-03 14:35:28 -0800 Committed r160042: <http://trac.webkit.org/changeset/160042> 218343 2013-12-03 14:34:50 -0800 2013-12-03 14:34:50 -0800 Patch for landing 125185.patch text/plain 1384 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYwMDQxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTEyLTAzICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIGppdC9KSVRBcml0aG1ldGljLmNwcCBkb2Vzbid0IGJ1aWxkIGZvciBub24tWDg2IHBvcnRz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjUxODUK KworICAgICAgICBSdWJiZXIgc3RhbXBlZCBieSBNYXJrIEhhaG5lbmJlcmcuCisKKyAgICAgICAg UmVtb3ZlZCB1bnVzZWQgZGVjbGFyYXRpb25zIGFuZCByZWxhdGVkIFVOVVNFRF9QQVJBTSgpLgor CisgICAgICAgICogaml0L0pJVEFyaXRobWV0aWMuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OmVt aXRfb3BfbW9kKToKKwogMjAxMy0xMi0wMyAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29t PgogCiAgICAgICAgIE9iamVjdEFsbG9jYXRpb25Qcm9maWxlIGlzIHJhY3kgYW5kIHRoZSBERkcg c2hvdWxkIGJlIGNvb2wgd2l0aCB0aGF0CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0 L0pJVEFyaXRobWV0aWMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9q aXQvSklUQXJpdGhtZXRpYy5jcHAJKHJldmlzaW9uIDE2MDA0MCkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9qaXQvSklUQXJpdGhtZXRpYy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY2NywxMyAr NjY3LDYgQEAgdm9pZCBKSVQ6OmVtaXRTbG93X29wX21vZChJbnN0cnVjdGlvbiogYwogCiB2b2lk IEpJVDo6ZW1pdF9vcF9tb2QoSW5zdHJ1Y3Rpb24qIGN1cnJlbnRJbnN0cnVjdGlvbikKIHsKLSAg ICBpbnQgcmVzdWx0ID0gY3VycmVudEluc3RydWN0aW9uWzFdLnUub3BlcmFuZDsKLSAgICBpbnQg b3AxID0gY3VycmVudEluc3RydWN0aW9uWzJdLnUub3BlcmFuZDsKLSAgICBpbnQgb3AyID0gY3Vy cmVudEluc3RydWN0aW9uWzNdLnUub3BlcmFuZDsKLQotICAgIFVOVVNFRF9QQVJBTShvcDEpOwot ICAgIFVOVVNFRF9QQVJBTShvcDIpOwotCiAgICAgSklUU2xvd1BhdGhDYWxsIHNsb3dQYXRoQ2Fs bCh0aGlzLCBjdXJyZW50SW5zdHJ1Y3Rpb24sIHNsb3dfcGF0aF9tb2QpOwogICAgIHNsb3dQYXRo Q2FsbC5jYWxsKCk7CiB9Cg==