<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>125168</bug_id>
          
          <creation_ts>2013-12-03 10:53:12 -0800</creation_ts>
          <short_desc>[MIPS] Wrong register usage in LLInt op_catch.</short_desc>
          <delta_ts>2014-09-03 14:51:02 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>108664</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Balazs Kilvady">kilvadyb</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>fpizlo</cc>
    
    <cc>fu</cc>
    
    <cc>gergely</cc>
    
    <cc>ggaren</cc>
    
    <cc>jbriance</cc>
    
    <cc>mhahnenberg</cc>
    
    <cc>msaboff</cc>
    
    <cc>palfia</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>955981</commentid>
    <comment_count>0</comment_count>
    <who name="Balazs Kilvady">kilvadyb</who>
    <bug_when>2013-12-03 10:53:12 -0800</bug_when>
    <thetext>Earlier trampoline called lint_op_catch via register ra (return-from-call register) while new exception handler calls the catch op via t9 reg. This change caused 13 regressions in mozilla test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>955985</commentid>
    <comment_count>1</comment_count>
      <attachid>218311</attachid>
    <who name="Balazs Kilvady">kilvadyb</who>
    <bug_when>2013-12-03 11:02:56 -0800</bug_when>
    <thetext>Created attachment 218311
proposed patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>955986</commentid>
    <comment_count>2</comment_count>
      <attachid>218311</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2013-12-03 11:04:50 -0800</bug_when>
    <thetext>Comment on attachment 218311
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=218311&amp;action=review

&gt; Source/JavaScriptCore/offlineasm/mips.rb:-535
&gt; -            if /_prologue$/.match(node.name) || /^_llint_function_/.match(node.name)
&gt; +            if /_prologue$/.match(node.name) || /^_llint_function_/.match(node.name) || /_llint_op_catch/.match(node.name)
&gt;                  # Functions called from trampoline/JIT codes.
&gt;                  myList &lt;&lt; Instruction.new(node.codeOrigin, &quot;pichdr&quot;, [])
&gt; -            elsif /_llint_op_catch/.match(node.name)
&gt; -                # Exception cactcher entry point function.
&gt; -                myList &lt;&lt; Instruction.new(node.codeOrigin, &quot;pichdrra&quot;, [])

This is atrocious.  Are you seriously matching label names?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>955992</commentid>
    <comment_count>3</comment_count>
    <who name="Balazs Kilvady">kilvadyb</who>
    <bug_when>2013-12-03 11:12:31 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 218311 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=218311&amp;action=review
&gt; 
&gt; &gt; Source/JavaScriptCore/offlineasm/mips.rb:-535
&gt; &gt; -            if /_prologue$/.match(node.name) || /^_llint_function_/.match(node.name)
&gt; &gt; +            if /_prologue$/.match(node.name) || /^_llint_function_/.match(node.name) || /_llint_op_catch/.match(node.name)
&gt; &gt;                  # Functions called from trampoline/JIT codes.
&gt; &gt;                  myList &lt;&lt; Instruction.new(node.codeOrigin, &quot;pichdr&quot;, [])
&gt; &gt; -            elsif /_llint_op_catch/.match(node.name)
&gt; &gt; -                # Exception cactcher entry point function.
&gt; &gt; -                myList &lt;&lt; Instruction.new(node.codeOrigin, &quot;pichdrra&quot;, [])
&gt; 
&gt; This is atrocious.  Are you seriously matching label names?

Yes. On MIPS for PIC compatibility a special header (pichdr) needed. I didn&apos;t find a better way to add PIC header only to the &quot;entry point&quot; functions/ops.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>955993</commentid>
    <comment_count>4</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2013-12-03 11:15:17 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; (In reply to comment #2)
&gt; &gt; (From update of attachment 218311 [details] [details])
&gt; &gt; View in context: https://bugs.webkit.org/attachment.cgi?id=218311&amp;action=review
&gt; &gt; 
&gt; &gt; &gt; Source/JavaScriptCore/offlineasm/mips.rb:-535
&gt; &gt; &gt; -            if /_prologue$/.match(node.name) || /^_llint_function_/.match(node.name)
&gt; &gt; &gt; +            if /_prologue$/.match(node.name) || /^_llint_function_/.match(node.name) || /_llint_op_catch/.match(node.name)
&gt; &gt; &gt;                  # Functions called from trampoline/JIT codes.
&gt; &gt; &gt;                  myList &lt;&lt; Instruction.new(node.codeOrigin, &quot;pichdr&quot;, [])
&gt; &gt; &gt; -            elsif /_llint_op_catch/.match(node.name)
&gt; &gt; &gt; -                # Exception cactcher entry point function.
&gt; &gt; &gt; -                myList &lt;&lt; Instruction.new(node.codeOrigin, &quot;pichdrra&quot;, [])
&gt; &gt; 
&gt; &gt; This is atrocious.  Are you seriously matching label names?
&gt; 
&gt; Yes. On MIPS for PIC compatibility a special header (pichdr) needed. I didn&apos;t find a better way to add PIC header only to the &quot;entry point&quot; functions/ops.

This is really bad.  Please find a better way to do this before making the problem worse.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>956006</commentid>
    <comment_count>5</comment_count>
    <who name="Balazs Kilvady">kilvadyb</who>
    <bug_when>2013-12-03 11:34:02 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; (In reply to comment #3)
&gt; &gt; (In reply to comment #2)
&gt; &gt; &gt; (From update of attachment 218311 [details] [details] [details])
&gt; &gt; &gt; View in context: https://bugs.webkit.org/attachment.cgi?id=218311&amp;action=review
&gt; &gt; &gt; 
&gt; &gt; &gt; &gt; Source/JavaScriptCore/offlineasm/mips.rb:-535
&gt; &gt; &gt; &gt; -            if /_prologue$/.match(node.name) || /^_llint_function_/.match(node.name)
&gt; &gt; &gt; &gt; +            if /_prologue$/.match(node.name) || /^_llint_function_/.match(node.name) || /_llint_op_catch/.match(node.name)
&gt; &gt; &gt; &gt;                  # Functions called from trampoline/JIT codes.
&gt; &gt; &gt; &gt;                  myList &lt;&lt; Instruction.new(node.codeOrigin, &quot;pichdr&quot;, [])
&gt; &gt; &gt; &gt; -            elsif /_llint_op_catch/.match(node.name)
&gt; &gt; &gt; &gt; -                # Exception cactcher entry point function.
&gt; &gt; &gt; &gt; -                myList &lt;&lt; Instruction.new(node.codeOrigin, &quot;pichdrra&quot;, [])
&gt; &gt; &gt; 
&gt; &gt; &gt; This is atrocious.  Are you seriously matching label names?
&gt; &gt; 
&gt; &gt; Yes. On MIPS for PIC compatibility a special header (pichdr) needed. I didn&apos;t find a better way to add PIC header only to the &quot;entry point&quot; functions/ops.
&gt; 
&gt; This is really bad.  Please find a better way to do this before making the problem worse.
Thank you for the review. I dislike this solution also but PIC header is 3 instructions long so I didn&apos;t want to add it to all the LLInt ops when it is not necessary. I think there is no other sign of entry point code than the node.name from offlineasm/mips.rb. I could add PIC header to all the ops (like gcc does for every function). I will check the speed penalty of that solution.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>957198</commentid>
    <comment_count>6</comment_count>
      <attachid>218585</attachid>
    <who name="Balazs Kilvady">kilvadyb</who>
    <bug_when>2013-12-06 03:15:49 -0800</bug_when>
    <thetext>Created attachment 218585
Fixed patch. 

Added PIC header (.cpload($t9)) to all the LLInt ops. With this we can avoid filtering rutins by label name. The speed penalty is not serious by the SunSpider and v8 tests (although they aren&apos;t ideal for LLInt measuring, I think).
SunSpider: 5272.0ms -&gt; 5295.0ms
v8: 18751.0ms -&gt; 18893.0ms

With this patch the MIPS implementation has 0 regression in mozilla tests.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>957219</commentid>
    <comment_count>7</comment_count>
    <who name="Julien Brianceau">jbriance</who>
    <bug_when>2013-12-06 05:26:31 -0800</bug_when>
    <thetext>Patch looks good to me: it solves all remaining crashes in layout jsc tests on my mips board.

Moreover, it removes the following warnings when compiling the LLINT:

   [100%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/llint/LowLevelInterpreter.cpp.o
   /tmp/cc9i3yBA.s: Assembler messages:
   /tmp/cc9i3yBA.s:270: Warning: No .cprestore pseudo-op used in PIC code
   /tmp/cc9i3yBA.s:300: Warning: No .cprestore pseudo-op used in PIC code
   /tmp/cc9i3yBA.s:332: Warning: No .cprestore pseudo-op used in PIC code
   /tmp/cc9i3yBA.s:375: Warning: No .cprestore pseudo-op used in PIC code
   [...]


Although there&apos;s a small speed penalty, I think your 2nd patch is better (and more clean).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>957275</commentid>
    <comment_count>8</comment_count>
    <who name="Balazs Kilvady">kilvadyb</who>
    <bug_when>2013-12-06 09:59:49 -0800</bug_when>
    <thetext>(In reply to comment #7)
&gt; Patch looks good to me: it solves all remaining crashes in layout jsc tests on my mips board.
&gt; 
&gt; Moreover, it removes the following warnings when compiling the LLINT:
&gt; 
&gt;    [100%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/llint/LowLevelInterpreter.cpp.o
&gt;    /tmp/cc9i3yBA.s: Assembler messages:
&gt;    /tmp/cc9i3yBA.s:270: Warning: No .cprestore pseudo-op used in PIC code
&gt;    /tmp/cc9i3yBA.s:300: Warning: No .cprestore pseudo-op used in PIC code
&gt;    /tmp/cc9i3yBA.s:332: Warning: No .cprestore pseudo-op used in PIC code
&gt;    /tmp/cc9i3yBA.s:375: Warning: No .cprestore pseudo-op used in PIC code
&gt;    [...]
&gt; 
&gt; 
&gt; Although there&apos;s a small speed penalty, I think your 2nd patch is better (and more clean).

Thanks for reviewing and testing. The disappearing of the &quot;No .cprestore&quot; warning is a nice side effect as .cprestore is still not used in the LLInt ops. :) But anyway now the generated code seems to be more comfortable to the compiler.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>958707</commentid>
    <comment_count>9</comment_count>
    <who name="Balazs Kilvady">kilvadyb</who>
    <bug_when>2013-12-11 07:19:08 -0800</bug_when>
    <thetext>r160244 introduced a conditional branch from an LLInt op to an other. This breaks the &quot;PIC header everywhere&quot; patch. In mozilla test causes a regression:
ecma_2/FunctionObjects/apply-001-n.js
I am working on fixing this problem.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>958790</commentid>
    <comment_count>10</comment_count>
      <attachid>218975</attachid>
    <who name="Balazs Kilvady">kilvadyb</who>
    <bug_when>2013-12-11 10:48:18 -0800</bug_when>
    <thetext>Created attachment 218975
Fixed and rebased patch. 

Branch to other LLInt operations (to Labels, not to LocalLabels) fixed also. Rebased on r160432.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1033014</commentid>
    <comment_count>11</comment_count>
      <attachid>218975</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2014-09-03 14:13:45 -0700</bug_when>
    <thetext>Comment on attachment 218975
Fixed and rebased patch. 

I don&apos;t really know this platform. Since all the code is isolated to it, I don&apos;t think it can harm the rest of the project, so I&apos;ll say r+.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1033020</commentid>
    <comment_count>12</comment_count>
    <who name="Julien Brianceau">jbriance</who>
    <bug_when>2014-09-03 14:21:33 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; I don&apos;t really know this platform. Since all the code is isolated to it, I don&apos;t think it can harm the rest of the project, so I&apos;ll say r+.
Thanks. As discussed, I&apos;ll probably take a look at the mips port during next days, and this patch will help me to start from a clean state.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1033036</commentid>
    <comment_count>13</comment_count>
      <attachid>218975</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-09-03 14:50:58 -0700</bug_when>
    <thetext>Comment on attachment 218975
Fixed and rebased patch. 

Clearing flags on attachment: 218975

Committed r173232: &lt;http://trac.webkit.org/changeset/173232&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1033037</commentid>
    <comment_count>14</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-09-03 14:51:02 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>218311</attachid>
            <date>2013-12-03 11:02:56 -0800</date>
            <delta_ts>2013-12-06 03:15:49 -0800</delta_ts>
            <desc>proposed patch.</desc>
            <filename>catch.diff</filename>
            <type>text/plain</type>
            <size>3673</size>
            <attacher name="Balazs Kilvady">kilvadyb</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGIwNzU3YjMuLjE0NjNlYmQgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEyLTAzICBCYWxhenMgS2lsdmFk
eSAgPGtpbHZhZHliQGhvbWVqaW5uaS5jb20+CisKKyAgICAgICAgW01JUFNdIFdyb25nIHJlZ2lz
dGVyIHVzYWdlIGluIExMSW50IG9wX2NhdGNoLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1MTY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgRml4IHJlZ2lzdGVyIHVzYWdlIG9mIGxsaW50X29wX2NhdGNo
LgorCisgICAgICAgICogb2ZmbGluZWFzbS9pbnN0cnVjdGlvbnMucmI6CisgICAgICAgICogb2Zm
bGluZWFzbS9taXBzLnJiOgorCiAyMDEzLTEyLTAzICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZv
QG91dGxvb2suY29tPgogCiAgICAgICAgIHRlc3RhcGkgdGVzdCBjcmFzaGVzIG9uIFdpbmRvd3Mg
aW4gV1RGOjpWZWN0b3I8d2NoYXJfdCw2NCxXVEY6OlVuc2FmZVZlY3Rvck92ZXJmbG93Pjo6c2l6
ZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9pbnN0cnVj
dGlvbnMucmIgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9pbnN0cnVjdGlvbnMu
cmIKaW5kZXggNWEzNDYzZi4uNmFhNjU3MSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD
b3JlL29mZmxpbmVhc20vaW5zdHJ1Y3Rpb25zLnJiCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9vZmZsaW5lYXNtL2luc3RydWN0aW9ucy5yYgpAQCAtMjgwLDcgKzI4MCw2IEBAIE1JUFNfSU5T
VFJVQ1RJT05TID0KICAgICAic2x0IiwKICAgICAic2x0dSIsCiAgICAgInBpY2hkciIsCi0gICAg
InBpY2hkcnJhIgogICAgIF0KIAogU0g0X0lOU1RSVUNUSU9OUyA9CmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9taXBzLnJiIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL29mZmxpbmVhc20vbWlwcy5yYgppbmRleCAxNzhlN2Y1Li41NjZhNzc5IDEwMDY0NAotLS0g
YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9taXBzLnJiCisrKyBiL1NvdXJjZS9K
YXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL21pcHMucmIKQEAgLTYyLDcgKzYyLDYgQEAgTUlQU19U
RU1QX0dQUlMgPSBbU3BlY2lhbFJlZ2lzdGVyLm5ldygiJHQ1IiksIFNwZWNpYWxSZWdpc3Rlci5u
ZXcoIiR0NiIpLCBTcGVjaWEKIE1JUFNfWkVST19SRUcgPSBTcGVjaWFsUmVnaXN0ZXIubmV3KCIk
emVybyIpCiBNSVBTX0dQX1JFRyA9IFNwZWNpYWxSZWdpc3Rlci5uZXcoIiRncCIpCiBNSVBTX0dQ
U0FWRV9SRUcgPSBTcGVjaWFsUmVnaXN0ZXIubmV3KCIkczQiKQotTUlQU19KVU1QX1JFRyA9IFNw
ZWNpYWxSZWdpc3Rlci5uZXcoIiRyYSIpCiBNSVBTX0NBTExfUkVHID0gU3BlY2lhbFJlZ2lzdGVy
Lm5ldygiJHQ5IikKIE1JUFNfVEVNUF9GUFJTID0gW1NwZWNpYWxSZWdpc3Rlci5uZXcoIiRmMTYi
KV0KIE1JUFNfU0NSQVRDSF9GUFIgPSBTcGVjaWFsUmVnaXN0ZXIubmV3KCIkZjE4IikKQEAgLTQw
OCw4ICs0MDcsOCBAQCBkZWYgbWlwc0xvd2VyTWlzcGxhY2VkQWRkcmVzc2VzKGxpc3QpCiAgICAg
ICAgICAgICBjYXNlIG5vZGUub3Bjb2RlCiAgICAgICAgICAgICB3aGVuICJqbXAiCiAgICAgICAg
ICAgICAgICAgaWYgbm9kZS5vcGVyYW5kc1swXS5hZGRyZXNzPwotICAgICAgICAgICAgICAgICAg
ICBuZXdMaXN0IDw8IEluc3RydWN0aW9uLm5ldyhub2RlLm9wZXJhbmRzWzBdLmNvZGVPcmlnaW4s
ICJsb2FkaSIsIFtub2RlLm9wZXJhbmRzWzBdLCBNSVBTX0pVTVBfUkVHXSkKLSAgICAgICAgICAg
ICAgICAgICAgbmV3TGlzdCA8PCBJbnN0cnVjdGlvbi5uZXcobm9kZS5jb2RlT3JpZ2luLCBub2Rl
Lm9wY29kZSwgW01JUFNfSlVNUF9SRUddKQorICAgICAgICAgICAgICAgICAgICBuZXdMaXN0IDw8
IEluc3RydWN0aW9uLm5ldyhub2RlLm9wZXJhbmRzWzBdLmNvZGVPcmlnaW4sICJsb2FkaSIsIFtu
b2RlLm9wZXJhbmRzWzBdLCBNSVBTX0NBTExfUkVHXSkKKyAgICAgICAgICAgICAgICAgICAgbmV3
TGlzdCA8PCBJbnN0cnVjdGlvbi5uZXcobm9kZS5jb2RlT3JpZ2luLCBub2RlLm9wY29kZSwgW01J
UFNfQ0FMTF9SRUddKQogICAgICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICAgICAg
bmV3TGlzdCA8PCBJbnN0cnVjdGlvbi5uZXcobm9kZS5jb2RlT3JpZ2luLAogICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBub2RlLm9wY29kZSwKQEAgLTUyNywx
MiArNTI2LDkgQEAgZGVmIG1pcHNBZGRQSUNDb2RlKGxpc3QpCiAgICAgICAgIHwgbm9kZSB8CiAg
ICAgICAgIG15TGlzdCA8PCBub2RlCiAgICAgICAgIGlmIG5vZGUuaXNfYT8gTGFiZWwKLSAgICAg
ICAgICAgIGlmIC9fcHJvbG9ndWUkLy5tYXRjaChub2RlLm5hbWUpIHx8IC9eX2xsaW50X2Z1bmN0
aW9uXy8ubWF0Y2gobm9kZS5uYW1lKQorICAgICAgICAgICAgaWYgL19wcm9sb2d1ZSQvLm1hdGNo
KG5vZGUubmFtZSkgfHwgL15fbGxpbnRfZnVuY3Rpb25fLy5tYXRjaChub2RlLm5hbWUpIHx8IC9f
bGxpbnRfb3BfY2F0Y2gvLm1hdGNoKG5vZGUubmFtZSkKICAgICAgICAgICAgICAgICAjIEZ1bmN0
aW9ucyBjYWxsZWQgZnJvbSB0cmFtcG9saW5lL0pJVCBjb2Rlcy4KICAgICAgICAgICAgICAgICBt
eUxpc3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KG5vZGUuY29kZU9yaWdpbiwgInBpY2hkciIsIFtdKQot
ICAgICAgICAgICAgZWxzaWYgL19sbGludF9vcF9jYXRjaC8ubWF0Y2gobm9kZS5uYW1lKQotICAg
ICAgICAgICAgICAgICMgRXhjZXB0aW9uIGNhY3RjaGVyIGVudHJ5IHBvaW50IGZ1bmN0aW9uLgot
ICAgICAgICAgICAgICAgIG15TGlzdCA8PCBJbnN0cnVjdGlvbi5uZXcobm9kZS5jb2RlT3JpZ2lu
LCAicGljaGRycmEiLCBbXSkKICAgICAgICAgICAgIGVuZAogICAgICAgICBlbmQKICAgICB9CkBA
IC05MDEsMTAgKzg5Nyw3IEBAIGNsYXNzIEluc3RydWN0aW9uCiAgICAgICAgICAgICAkYXNtLnB1
dHMgInNsdHUgI3tvcGVyYW5kc1swXS5taXBzT3BlcmFuZH0sICN7b3BlcmFuZHNbMV0ubWlwc09w
ZXJhbmR9LCAje29wZXJhbmRzWzJdLm1pcHNPcGVyYW5kfSIKICAgICAgICAgd2hlbiAicGljaGRy
IgogICAgICAgICAgICAgJGFzbS5wdXRTdHIoIk9GRkxJTkVfQVNNX0NQTE9BRCgkMjUpIikKLSAg
ICAgICAgICAgICRhc20ucHV0cyAibW92ZSAkczQsICRncCIKLSAgICAgICAgd2hlbiAicGljaGRy
cmEiCi0gICAgICAgICAgICAkYXNtLnB1dFN0cigiT0ZGTElORV9BU01fQ1BMT0FEKCQzMSkiKQot
ICAgICAgICAgICAgJGFzbS5wdXRzICJtb3ZlICRzNCwgJGdwIgorICAgICAgICAgICAgJGFzbS5w
dXRzICJtb3ZlICN7TUlQU19HUFNBVkVfUkVHLm1pcHNPcGVyYW5kfSwgI3tNSVBTX0dQX1JFRy5t
aXBzT3BlcmFuZH0iCiAgICAgICAgIHdoZW4gIm1lbWZlbmNlIgogICAgICAgICAgICAgJGFzbS5w
dXRzICJzeW5jIgogICAgICAgICBlbHNlCg==
</data>
<flag name="review"
          id="241690"
          type_id="1"
          status="-"
          setter="fpizlo"
    />
    <flag name="commit-queue"
          id="241691"
          type_id="3"
          status="-"
          setter="fpizlo"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>218585</attachid>
            <date>2013-12-06 03:15:49 -0800</date>
            <delta_ts>2013-12-11 10:48:18 -0800</delta_ts>
            <desc>Fixed patch. </desc>
            <filename>pic.diff</filename>
            <type>text/plain</type>
            <size>8113</size>
            <attacher name="Balazs Kilvady">kilvadyb</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDRjNDM2N2QuLmVlOTcyN2MgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEyLTA2ICBCYWxhenMgS2lsdmFk
eSAgPGtpbHZhZHliQGhvbWVqaW5uaS5jb20+CisKKyAgICAgICAgW01JUFNdIFdyb25nIHJlZ2lz
dGVyIHVzYWdlIGluIExMSW50IG9wX2NhdGNoLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1MTY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgRml4IHJlZ2lzdGVyIHVzYWdlIGFuZCBhZGQgUElDIGhlYWRl
ciB0byBhbGwgdGhlIG9wcyBpbiBMTEludC4KKworICAgICAgICAqIG9mZmxpbmVhc20vaW5zdHJ1
Y3Rpb25zLnJiOgorICAgICAgICAqIG9mZmxpbmVhc20vbWlwcy5yYjoKKwogMjAxMy0xMi0wNSAg
TWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBKU0M6IFNpbXBs
aWZ5IGludGVyZmFjZSBiZXR3ZWVuIHRocm93IGFuZCBjYXRjaCBoYW5kbGVyCmRpZmYgLS1naXQg
YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9pbnN0cnVjdGlvbnMucmIgYi9Tb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9pbnN0cnVjdGlvbnMucmIKaW5kZXggNWEzNDYz
Zi4uZTBkYzhkMCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20v
aW5zdHJ1Y3Rpb25zLnJiCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2lu
c3RydWN0aW9ucy5yYgpAQCAtMjc1LDEyICsyNzUsMTIgQEAgUklTQ19JTlNUUlVDVElPTlMgPQog
CiBNSVBTX0lOU1RSVUNUSU9OUyA9CiAgICAgWworICAgICJsYSIsCiAgICAgIm1vdnoiLAogICAg
ICJtb3ZuIiwKICAgICAic2x0IiwKICAgICAic2x0dSIsCi0gICAgInBpY2hkciIsCi0gICAgInBp
Y2hkcnJhIgorICAgICJwaWNoZHIiCiAgICAgXQogCiBTSDRfSU5TVFJVQ1RJT05TID0KZGlmZiAt
LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL21pcHMucmIgYi9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9taXBzLnJiCmluZGV4IDE3OGU3ZjUuLmJkMWRkZTAg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL21pcHMucmIKKysr
IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vbWlwcy5yYgpAQCAtNjIsNyArNjIs
NiBAQCBNSVBTX1RFTVBfR1BSUyA9IFtTcGVjaWFsUmVnaXN0ZXIubmV3KCIkdDUiKSwgU3BlY2lh
bFJlZ2lzdGVyLm5ldygiJHQ2IiksIFNwZWNpYQogTUlQU19aRVJPX1JFRyA9IFNwZWNpYWxSZWdp
c3Rlci5uZXcoIiR6ZXJvIikKIE1JUFNfR1BfUkVHID0gU3BlY2lhbFJlZ2lzdGVyLm5ldygiJGdw
IikKIE1JUFNfR1BTQVZFX1JFRyA9IFNwZWNpYWxSZWdpc3Rlci5uZXcoIiRzNCIpCi1NSVBTX0pV
TVBfUkVHID0gU3BlY2lhbFJlZ2lzdGVyLm5ldygiJHJhIikKIE1JUFNfQ0FMTF9SRUcgPSBTcGVj
aWFsUmVnaXN0ZXIubmV3KCIkdDkiKQogTUlQU19URU1QX0ZQUlMgPSBbU3BlY2lhbFJlZ2lzdGVy
Lm5ldygiJGYxNiIpXQogTUlQU19TQ1JBVENIX0ZQUiA9IFNwZWNpYWxSZWdpc3Rlci5uZXcoIiRm
MTgiKQpAQCAtMzk4LDYgKzM5NywzMCBAQCBlbmQKICMgU3BlY2lhbGl6YXRpb24gb2YgbG93ZXJp
bmcgb2YgbWlzcGxhY2VkIGFkZHJlc3Nlcy4KICMKIAorY2xhc3MgTG9jYWxMYWJlbFJlZmVyZW5j
ZQorICAgIGRlZiByZWdpc3Rlcj8KKyAgICAgICAgZmFsc2UKKyAgICBlbmQKK2VuZAorCitkZWYg
bWlwc0FzUmVnaXN0ZXIocHJlTGlzdCwgcG9zdExpc3QsIG9wZXJhbmQsIG5lZWRSZXN0b3JlKQor
ICAgIHRtcCA9IE1JUFNfQ0FMTF9SRUcKKyAgICBpZiBvcGVyYW5kLmFkZHJlc3M/CisgICAgICAg
IHByZUxpc3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KG9wZXJhbmQuY29kZU9yaWdpbiwgImxvYWRwIiwg
W29wZXJhbmQsIE1JUFNfQ0FMTF9SRUddKQorICAgIGVsc2lmIG9wZXJhbmQuaXNfYT8gTGFiZWxS
ZWZlcmVuY2UKKyAgICAgICAgcHJlTGlzdCA8PCBJbnN0cnVjdGlvbi5uZXcob3BlcmFuZC5jb2Rl
T3JpZ2luLCAibGEiLCBbb3BlcmFuZCwgTUlQU19DQUxMX1JFR10pCisgICAgZWxzaWYgb3BlcmFu
ZC5yZWdpc3Rlcj8KKyAgICAgICAgcHJlTGlzdCA8PCBJbnN0cnVjdGlvbi5uZXcob3BlcmFuZC5j
b2RlT3JpZ2luLCAibW92ZSIsIFtvcGVyYW5kLCBNSVBTX0NBTExfUkVHXSkKKyAgICBlbHNlCisg
ICAgICAgIG5lZWRSZXN0b3JlID0gZmFsc2UKKyAgICAgICAgdG1wID0gb3BlcmFuZAorICAgIGVu
ZAorICAgIGlmIG5lZWRSZXN0b3JlCisgICAgICAgIHBvc3RMaXN0IDw8IEluc3RydWN0aW9uLm5l
dyhvcGVyYW5kLmNvZGVPcmlnaW4sICJtb3ZlIiwgW01JUFNfR1BTQVZFX1JFRywgTUlQU19HUF9S
RUddKQorICAgIGVuZAorICAgIHRtcAorZW5kCisKIGRlZiBtaXBzTG93ZXJNaXNwbGFjZWRBZGRy
ZXNzZXMobGlzdCkKICAgICBuZXdMaXN0ID0gW10KICAgICBsaXN0LmVhY2ggewpAQCAtNDA3LDMz
ICs0MzAsMTQgQEAgZGVmIG1pcHNMb3dlck1pc3BsYWNlZEFkZHJlc3NlcyhsaXN0KQogICAgICAg
ICAgICAgYW5ub3RhdGlvbiA9IG5vZGUuYW5ub3RhdGlvbgogICAgICAgICAgICAgY2FzZSBub2Rl
Lm9wY29kZQogICAgICAgICAgICAgd2hlbiAiam1wIgotICAgICAgICAgICAgICAgIGlmIG5vZGUu
b3BlcmFuZHNbMF0uYWRkcmVzcz8KLSAgICAgICAgICAgICAgICAgICAgbmV3TGlzdCA8PCBJbnN0
cnVjdGlvbi5uZXcobm9kZS5vcGVyYW5kc1swXS5jb2RlT3JpZ2luLCAibG9hZGkiLCBbbm9kZS5v
cGVyYW5kc1swXSwgTUlQU19KVU1QX1JFR10pCi0gICAgICAgICAgICAgICAgICAgIG5ld0xpc3Qg
PDwgSW5zdHJ1Y3Rpb24ubmV3KG5vZGUuY29kZU9yaWdpbiwgbm9kZS5vcGNvZGUsIFtNSVBTX0pV
TVBfUkVHXSkKLSAgICAgICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAgICAgICAgIG5ld0xp
c3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KG5vZGUuY29kZU9yaWdpbiwKLSAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbm9kZS5vcGNvZGUsCi0gICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFtyaXNjQXNSZWdpc3RlcihuZXdMaXN0
LCBwb3N0SW5zdHJ1Y3Rpb25zLCBub2RlLm9wZXJhbmRzWzBdLCAicCIsIGZhbHNlKV0pCi0gICAg
ICAgICAgICAgICAgZW5kCisgICAgICAgICAgICAgICAgbmV3TGlzdCA8PCBJbnN0cnVjdGlvbi5u
ZXcobm9kZS5jb2RlT3JpZ2luLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIG5vZGUub3Bjb2RlLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIFttaXBzQXNSZWdpc3RlcihuZXdMaXN0LCBbXSwgbm9kZS5vcGVyYW5kc1swXSwgZmFs
c2UpXSkKKwogICAgICAgICAgICAgd2hlbiAiY2FsbCIKLSAgICAgICAgICAgICAgICByZXN0b3Jl
R1AgPSBmYWxzZTsKLSAgICAgICAgICAgICAgICB0bXAgPSBNSVBTX0NBTExfUkVHCi0gICAgICAg
ICAgICAgICAgaWYgbm9kZS5vcGVyYW5kc1swXS5hZGRyZXNzPwotICAgICAgICAgICAgICAgICAg
ICBuZXdMaXN0IDw8IEluc3RydWN0aW9uLm5ldyhub2RlLm9wZXJhbmRzWzBdLmNvZGVPcmlnaW4s
ICJsb2FkcCIsIFtub2RlLm9wZXJhbmRzWzBdLCBNSVBTX0NBTExfUkVHXSkKLSAgICAgICAgICAg
ICAgICAgICAgcmVzdG9yZUdQID0gdHJ1ZTsKLSAgICAgICAgICAgICAgICBlbHNpZiBub2RlLm9w
ZXJhbmRzWzBdLmlzX2E/IExhYmVsUmVmZXJlbmNlCi0gICAgICAgICAgICAgICAgICAgIHRtcCA9
IG5vZGUub3BlcmFuZHNbMF0KLSAgICAgICAgICAgICAgICAgICAgcmVzdG9yZUdQID0gdHJ1ZTsK
LSAgICAgICAgICAgICAgICBlbHNpZiBub2RlLm9wZXJhbmRzWzBdLnJlZ2lzdGVyPwotICAgICAg
ICAgICAgICAgICAgICBuZXdMaXN0IDw8IEluc3RydWN0aW9uLm5ldyhub2RlLm9wZXJhbmRzWzBd
LmNvZGVPcmlnaW4sICJtb3ZlIiwgW25vZGUub3BlcmFuZHNbMF0sIE1JUFNfQ0FMTF9SRUddKQot
ICAgICAgICAgICAgICAgICAgICByZXN0b3JlR1AgPSB0cnVlOwotICAgICAgICAgICAgICAgIGVs
c2UKLSAgICAgICAgICAgICAgICAgICAgdG1wID0gbm9kZS5vcGVyYW5kc1swXQotICAgICAgICAg
ICAgICAgIGVuZAotICAgICAgICAgICAgICAgIG5ld0xpc3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KG5v
ZGUuY29kZU9yaWdpbiwgbm9kZS5vcGNvZGUsIFt0bXBdKQotICAgICAgICAgICAgICAgIGlmIHJl
c3RvcmVHUAotICAgICAgICAgICAgICAgICAgICBuZXdMaXN0IDw8IEluc3RydWN0aW9uLm5ldyhu
b2RlLmNvZGVPcmlnaW4sICJtb3ZlIiwgW01JUFNfR1BTQVZFX1JFRywgTUlQU19HUF9SRUddKQot
ICAgICAgICAgICAgICAgIGVuZAorICAgICAgICAgICAgICAgIG5ld0xpc3QgPDwgSW5zdHJ1Y3Rp
b24ubmV3KG5vZGUuY29kZU9yaWdpbiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBub2RlLm9wY29kZSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBbbWlwc0FzUmVnaXN0ZXIobmV3TGlzdCwgcG9zdEluc3RydWN0aW9ucywgbm9k
ZS5vcGVyYW5kc1swXSwgdHJ1ZSldKQogICAgICAgICAgICAgd2hlbiAic2x0IiwgInNsdHUiCiAg
ICAgICAgICAgICAgICAgbmV3TGlzdCA8PCBJbnN0cnVjdGlvbi5uZXcobm9kZS5jb2RlT3JpZ2lu
LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5vZGUub3Bjb2Rl
LApAQCAtNTE4LDcgKzUyMiw3IEBAIGNsYXNzIEFkZHJlc3MKIGVuZAogCiAjCi0jIEFkZCBQSUMg
Y29tcGF0aWJsZSBoZWFkZXIgY29kZSB0byBwcm9sb2d1ZS9lbnRyeSBydXRpbnMuCisjIEFkZCBQ
SUMgY29tcGF0aWJsZSBoZWFkZXIgY29kZSB0byBhbGwgdGhlIExMSW50IHJ1dGlucy4KICMKIAog
ZGVmIG1pcHNBZGRQSUNDb2RlKGxpc3QpCkBAIC01MjcsMTMgKzUzMSw3IEBAIGRlZiBtaXBzQWRk
UElDQ29kZShsaXN0KQogICAgICAgICB8IG5vZGUgfAogICAgICAgICBteUxpc3QgPDwgbm9kZQog
ICAgICAgICBpZiBub2RlLmlzX2E/IExhYmVsCi0gICAgICAgICAgICBpZiAvX3Byb2xvZ3VlJC8u
bWF0Y2gobm9kZS5uYW1lKSB8fCAvXl9sbGludF9mdW5jdGlvbl8vLm1hdGNoKG5vZGUubmFtZSkK
LSAgICAgICAgICAgICAgICAjIEZ1bmN0aW9ucyBjYWxsZWQgZnJvbSB0cmFtcG9saW5lL0pJVCBj
b2Rlcy4KLSAgICAgICAgICAgICAgICBteUxpc3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KG5vZGUuY29k
ZU9yaWdpbiwgInBpY2hkciIsIFtdKQotICAgICAgICAgICAgZWxzaWYgL19sbGludF9vcF9jYXRj
aC8ubWF0Y2gobm9kZS5uYW1lKQotICAgICAgICAgICAgICAgICMgRXhjZXB0aW9uIGNhY3RjaGVy
IGVudHJ5IHBvaW50IGZ1bmN0aW9uLgotICAgICAgICAgICAgICAgIG15TGlzdCA8PCBJbnN0cnVj
dGlvbi5uZXcobm9kZS5jb2RlT3JpZ2luLCAicGljaGRycmEiLCBbXSkKLSAgICAgICAgICAgIGVu
ZAorICAgICAgICAgICAgbXlMaXN0IDw8IEluc3RydWN0aW9uLm5ldyhub2RlLmNvZGVPcmlnaW4s
ICJwaWNoZHIiLCBbXSkKICAgICAgICAgZW5kCiAgICAgfQogICAgIG15TGlzdApAQCAtNjY2LDYg
KzY2NCwxNiBAQCBkZWYgZW1pdE1JUFNEb3VibGVCcmFuY2goYnJhbmNoT3Bjb2RlLCBuZWcsIG9w
ZXJhbmRzKQogICAgIGVuZAogZW5kCiAKK2RlZiBlbWl0TUlQU0p1bXBPckNhbGwob3Bjb2RlLCBv
cGVyYW5kKQorICAgIGlmIG9wZXJhbmQubGFiZWw/CisgICAgICAgIHJhaXNlICJEaXJlY3QgY2Fs
bC9qdW1wIHRvIGEgbm90IGxvY2FsIGxhYmVsLiIgdW5sZXNzIG9wZXJhbmQuaXNfYT8gTG9jYWxM
YWJlbFJlZmVyZW5jZQorICAgICAgICAkYXNtLnB1dHMgIiN7b3Bjb2RlfSAje29wZXJhbmQuYXNt
TGFiZWx9IgorICAgIGVsc2UKKyAgICAgICAgcmFpc2UgIkludmFsaWQgY2FsbC9qdW1wIHJlZ2lz
dGVyLiIgdW5sZXNzIG9wZXJhbmQgPT0gTUlQU19DQUxMX1JFRworICAgICAgICAkYXNtLnB1dHMg
IiN7b3Bjb2RlfXIgI3tNSVBTX0NBTExfUkVHLm1pcHNPcGVyYW5kfSIKKyAgICBlbmQKK2VuZAor
CiBjbGFzcyBJbnN0cnVjdGlvbgogICAgIGRlZiBsb3dlck1JUFMKICAgICAgICAgJGFzbS5jb21t
ZW50IGNvZGVPcmlnaW5TdHJpbmcKQEAgLTczNiw2ICs3NDQsOCBAQCBjbGFzcyBJbnN0cnVjdGlv
bgogICAgICAgICAgICAgJGFzbS5wdXRzICJsZGMxICN7bWlwc0ZsaXBwZWRPcGVyYW5kcyhvcGVy
YW5kcyl9IgogICAgICAgICB3aGVuICJzdG9yZWQiCiAgICAgICAgICAgICAkYXNtLnB1dHMgInNk
YzEgI3ttaXBzT3BlcmFuZHMob3BlcmFuZHMpfSIKKyAgICAgICAgd2hlbiAibGEiCisgICAgICAg
ICAgICAkYXNtLnB1dHMgImxhICN7b3BlcmFuZHNbMV0ubWlwc09wZXJhbmR9LCAje29wZXJhbmRz
WzBdLmFzbUxhYmVsfSIKICAgICAgICAgd2hlbiAiYWRkZCIKICAgICAgICAgICAgIGVtaXRNSVBT
KCJhZGQuZCIsIG9wZXJhbmRzKQogICAgICAgICB3aGVuICJkaXZkIgpAQCAtODMxLDE3ICs4NDEs
OSBAQCBjbGFzcyBJbnN0cnVjdGlvbgogICAgICAgICB3aGVuICJiaWx0ZXEiLCAiYnBsdGVxIiwg
ImJibHRlcSIKICAgICAgICAgICAgICRhc20ucHV0cyAiYmxlICN7bWlwc09wZXJhbmRzKG9wZXJh
bmRzWzAuLjFdKX0sICN7b3BlcmFuZHNbMl0uYXNtTGFiZWx9IgogICAgICAgICB3aGVuICJqbXAi
Ci0gICAgICAgICAgICBpZiBvcGVyYW5kc1swXS5sYWJlbD8KLSAgICAgICAgICAgICAgICAkYXNt
LnB1dHMgImogI3tvcGVyYW5kc1swXS5hc21MYWJlbH0iCi0gICAgICAgICAgICBlbHNlCi0gICAg
ICAgICAgICAgICAgJGFzbS5wdXRzICJqciAje29wZXJhbmRzWzBdLm1pcHNPcGVyYW5kfSIKLSAg
ICAgICAgICAgIGVuZAorICAgICAgICAgICAgZW1pdE1JUFNKdW1wT3JDYWxsKCJqIiwgb3BlcmFu
ZHNbMF0pCiAgICAgICAgIHdoZW4gImNhbGwiCi0gICAgICAgICAgICBpZiBvcGVyYW5kc1swXS5s
YWJlbD8KLSAgICAgICAgICAgICAgICAkYXNtLnB1dHMgImphbCAje29wZXJhbmRzWzBdLmFzbUxh
YmVsfSIKLSAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICAkYXNtLnB1dHMgImphbHIg
I3tvcGVyYW5kc1swXS5taXBzT3BlcmFuZH0iCi0gICAgICAgICAgICBlbmQKKyAgICAgICAgICAg
IGVtaXRNSVBTSnVtcE9yQ2FsbCgiamFsIiwgb3BlcmFuZHNbMF0pCiAgICAgICAgIHdoZW4gImJy
ZWFrIgogICAgICAgICAgICAgJGFzbS5wdXRzICJicmVhayIKICAgICAgICAgd2hlbiAicmV0IgpA
QCAtOTAwLDExICs5MDIsOCBAQCBjbGFzcyBJbnN0cnVjdGlvbgogICAgICAgICB3aGVuICJzbHR1
IiwgInNsdHViIgogICAgICAgICAgICAgJGFzbS5wdXRzICJzbHR1ICN7b3BlcmFuZHNbMF0ubWlw
c09wZXJhbmR9LCAje29wZXJhbmRzWzFdLm1pcHNPcGVyYW5kfSwgI3tvcGVyYW5kc1syXS5taXBz
T3BlcmFuZH0iCiAgICAgICAgIHdoZW4gInBpY2hkciIKLSAgICAgICAgICAgICRhc20ucHV0U3Ry
KCJPRkZMSU5FX0FTTV9DUExPQUQoJDI1KSIpCi0gICAgICAgICAgICAkYXNtLnB1dHMgIm1vdmUg
JHM0LCAkZ3AiCi0gICAgICAgIHdoZW4gInBpY2hkcnJhIgotICAgICAgICAgICAgJGFzbS5wdXRT
dHIoIk9GRkxJTkVfQVNNX0NQTE9BRCgkMzEpIikKLSAgICAgICAgICAgICRhc20ucHV0cyAibW92
ZSAkczQsICRncCIKKyAgICAgICAgICAgICRhc20ucHV0U3RyKCJPRkZMSU5FX0FTTV9DUExPQUQo
I3tNSVBTX0NBTExfUkVHLm1pcHNPcGVyYW5kfSkiKQorICAgICAgICAgICAgJGFzbS5wdXRzICJt
b3ZlICN7TUlQU19HUFNBVkVfUkVHLm1pcHNPcGVyYW5kfSwgI3tNSVBTX0dQX1JFRy5taXBzT3Bl
cmFuZH0iCiAgICAgICAgIHdoZW4gIm1lbWZlbmNlIgogICAgICAgICAgICAgJGFzbS5wdXRzICJz
eW5jIgogICAgICAgICBlbHNlCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>218975</attachid>
            <date>2013-12-11 10:48:18 -0800</date>
            <delta_ts>2014-09-03 14:50:58 -0700</delta_ts>
            <desc>Fixed and rebased patch. </desc>
            <filename>pic.diff</filename>
            <type>text/plain</type>
            <size>10210</size>
            <attacher name="Balazs Kilvady">kilvadyb</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDFiODY5NTUuLmMxMDY2MWMgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEyLTExICBCYWxhenMgS2lsdmFk
eSAgPGtpbHZhZHliQGhvbWVqaW5uaS5jb20+CisKKyAgICAgICAgW01JUFNdIFdyb25nIHJlZ2lz
dGVyIHVzYWdlIGluIExMSW50IG9wX2NhdGNoLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1MTY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgRml4IHJlZ2lzdGVyIHVzYWdlIGFuZCBhZGQgUElDIGhlYWRl
ciB0byBhbGwgdGhlIG9wcyBpbiBMTEludC4KKworICAgICAgICAqIG9mZmxpbmVhc20vaW5zdHJ1
Y3Rpb25zLnJiOgorICAgICAgICAqIG9mZmxpbmVhc20vbWlwcy5yYjoKKwogMjAxMy0xMi0xMCAg
RmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEdldCByaWQgb2YgZm9y
d2FyZCBleGl0IG9uIERvdWJsZUFzSW50MzIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9vZmZsaW5lYXNtL2luc3RydWN0aW9ucy5yYiBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9v
ZmZsaW5lYXNtL2luc3RydWN0aW9ucy5yYgppbmRleCA1YTM0NjNmLi5lMGRjOGQwIDEwMDY0NAot
LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9pbnN0cnVjdGlvbnMucmIKKysr
IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vaW5zdHJ1Y3Rpb25zLnJiCkBAIC0y
NzUsMTIgKzI3NSwxMiBAQCBSSVNDX0lOU1RSVUNUSU9OUyA9CiAKIE1JUFNfSU5TVFJVQ1RJT05T
ID0KICAgICBbCisgICAgImxhIiwKICAgICAibW92eiIsCiAgICAgIm1vdm4iLAogICAgICJzbHQi
LAogICAgICJzbHR1IiwKLSAgICAicGljaGRyIiwKLSAgICAicGljaGRycmEiCisgICAgInBpY2hk
ciIKICAgICBdCiAKIFNINF9JTlNUUlVDVElPTlMgPQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT
Y3JpcHRDb3JlL29mZmxpbmVhc20vbWlwcy5yYiBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZs
aW5lYXNtL21pcHMucmIKaW5kZXggOGZjOTZiZS4uNjE3MWY2YyAxMDA2NDQKLS0tIGEvU291cmNl
L0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vbWlwcy5yYgorKysgYi9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvb2ZmbGluZWFzbS9taXBzLnJiCkBAIC02Miw3ICs2Miw2IEBAIE1JUFNfVEVNUF9HUFJT
ID0gW1NwZWNpYWxSZWdpc3Rlci5uZXcoIiR0NSIpLCBTcGVjaWFsUmVnaXN0ZXIubmV3KCIkdDYi
KSwgU3BlY2lhCiBNSVBTX1pFUk9fUkVHID0gU3BlY2lhbFJlZ2lzdGVyLm5ldygiJHplcm8iKQog
TUlQU19HUF9SRUcgPSBTcGVjaWFsUmVnaXN0ZXIubmV3KCIkZ3AiKQogTUlQU19HUFNBVkVfUkVH
ID0gU3BlY2lhbFJlZ2lzdGVyLm5ldygiJHM0IikKLU1JUFNfSlVNUF9SRUcgPSBTcGVjaWFsUmVn
aXN0ZXIubmV3KCIkcmEiKQogTUlQU19DQUxMX1JFRyA9IFNwZWNpYWxSZWdpc3Rlci5uZXcoIiR0
OSIpCiBNSVBTX1RFTVBfRlBSUyA9IFtTcGVjaWFsUmVnaXN0ZXIubmV3KCIkZjE2IildCiBNSVBT
X1NDUkFUQ0hfRlBSID0gU3BlY2lhbFJlZ2lzdGVyLm5ldygiJGYxOCIpCkBAIC0xNjIsNiArMTYx
LDcwIEBAIGNsYXNzIEFic29sdXRlQWRkcmVzcwogZW5kCiAKICMKKyMgTmVnYXRlIGNvbmRpdGlv
biBvZiBicmFuY2hlcyB0byBsYWJlbHMuCisjCisKK2NsYXNzIEluc3RydWN0aW9uCisgICAgZGVm
IG1pcHNOZWdhdGVDb25kaXRpb24obGlzdCkKKyAgICAgICAgL14oYihhZGR8c3VifG9yfG11bHx0
KT8pKFtpcGJdKS8ubWF0Y2gob3Bjb2RlKQorICAgICAgICBjYXNlICR+LnBvc3RfbWF0Y2gKKyAg
ICAgICAgd2hlbiAiZXEiCisgICAgICAgICAgICBvcCA9ICJuZXEiCisgICAgICAgIHdoZW4gIm5l
cSIKKyAgICAgICAgICAgIG9wID0gImVxIgorICAgICAgICB3aGVuICJ6IgorICAgICAgICAgICAg
b3AgPSAibnoiCisgICAgICAgIHdoZW4gIm56IgorICAgICAgICAgICAgb3AgPSAieiIKKyAgICAg
ICAgd2hlbiAiZ3QiCisgICAgICAgICAgICBvcCA9ICJsdGVxIgorICAgICAgICB3aGVuICJndGVx
IgorICAgICAgICAgICAgb3AgPSAibHQiCisgICAgICAgIHdoZW4gImx0IgorICAgICAgICAgICAg
b3AgPSAiZ3RlcSIKKyAgICAgICAgd2hlbiAibHRlcSIKKyAgICAgICAgICAgIG9wID0gImd0Igor
ICAgICAgICB3aGVuICJhIgorICAgICAgICAgICAgb3AgPSAiYmVxIgorICAgICAgICB3aGVuICJi
IgorICAgICAgICAgICAgb3AgPSAiYWVxIgorICAgICAgICB3aGVuICJhZXEiCisgICAgICAgICAg
ICBvcCA9ICJiIgorICAgICAgICB3aGVuICJiZXEiCisgICAgICAgICAgICBvcCA9ICJhIgorICAg
ICAgICBlbHNlCisgICAgICAgICAgICByYWlzZSAiQ2FuJ3QgbmVnYXRlICN7b3Bjb2RlfSBicmFu
Y2guIgorICAgICAgICBlbmQKKyAgICAgICAgbm9CcmFuY2ggPSBMb2NhbExhYmVsLnVuaXF1ZSgi
bm9icmFuY2giKQorICAgICAgICBub0JyYW5jaFJlZiA9IExvY2FsTGFiZWxSZWZlcmVuY2UubmV3
KGNvZGVPcmlnaW4sIG5vQnJhbmNoKQorICAgICAgICB0b1JlZiA9IG9wZXJhbmRzWy0xXQorICAg
ICAgICBsaXN0IDw8IEluc3RydWN0aW9uLm5ldyhjb2RlT3JpZ2luLCAiI3skMX0jeyQzfSN7b3B9
Iiwgb3BlcmFuZHNbMC4uLTJdLnB1c2gobm9CcmFuY2hSZWYpLCBhbm5vdGF0aW9uKQorICAgICAg
ICBsaXN0IDw8IEluc3RydWN0aW9uLm5ldyhjb2RlT3JpZ2luLCAibGEiLCBbdG9SZWYsIE1JUFNf
Q0FMTF9SRUddKQorICAgICAgICBsaXN0IDw8IEluc3RydWN0aW9uLm5ldyhjb2RlT3JpZ2luLCAi
am1wIiwgW01JUFNfQ0FMTF9SRUddKQorICAgICAgICBsaXN0IDw8IG5vQnJhbmNoCisgICAgZW5k
CitlbmQKKworZGVmIG1pcHNMb3dlckZhckJyYW5jaE9wcyhsaXN0KQorICAgIG5ld0xpc3QgPSBb
XQorICAgIGxpc3QuZWFjaCB7CisgICAgICAgIHwgbm9kZSB8CisgICAgICAgIGlmIG5vZGUuaXNf
YT8gSW5zdHJ1Y3Rpb24KKyAgICAgICAgICAgIGFubm90YXRpb24gPSBub2RlLmFubm90YXRpb24K
KyAgICAgICAgICAgIGNhc2Ugbm9kZS5vcGNvZGUKKyAgICAgICAgICAgIHdoZW4gL15iKGFkZHxz
dWJ8b3J8bXVsfHQpPyhbaXBiXSkvCisgICAgICAgICAgICAgICAgaWYgbm9kZS5vcGVyYW5kc1st
MV0uaXNfYT8gTGFiZWxSZWZlcmVuY2UKKyAgICAgICAgICAgICAgICAgICAgbm9kZS5taXBzTmVn
YXRlQ29uZGl0aW9uKG5ld0xpc3QpCisgICAgICAgICAgICAgICAgICAgIG5leHQKKyAgICAgICAg
ICAgICAgICBlbmQKKyAgICAgICAgICAgIGVuZAorICAgICAgICBlbmQKKyAgICAgICAgbmV3TGlz
dCA8PCBub2RlCisgICAgfQorICAgIG5ld0xpc3QKK2VuZAorCisjCiAjIExvd2VyICdhbmQnIG1h
c2tlZCBicmFuY2hlcwogIwogCkBAIC00NDUsNiArNTA4LDMwIEBAIGVuZAogIyBTcGVjaWFsaXph
dGlvbiBvZiBsb3dlcmluZyBvZiBtaXNwbGFjZWQgYWRkcmVzc2VzLgogIwogCitjbGFzcyBMb2Nh
bExhYmVsUmVmZXJlbmNlCisgICAgZGVmIHJlZ2lzdGVyPworICAgICAgICBmYWxzZQorICAgIGVu
ZAorZW5kCisKK2RlZiBtaXBzQXNSZWdpc3RlcihwcmVMaXN0LCBwb3N0TGlzdCwgb3BlcmFuZCwg
bmVlZFJlc3RvcmUpCisgICAgdG1wID0gTUlQU19DQUxMX1JFRworICAgIGlmIG9wZXJhbmQuYWRk
cmVzcz8KKyAgICAgICAgcHJlTGlzdCA8PCBJbnN0cnVjdGlvbi5uZXcob3BlcmFuZC5jb2RlT3Jp
Z2luLCAibG9hZHAiLCBbb3BlcmFuZCwgTUlQU19DQUxMX1JFR10pCisgICAgZWxzaWYgb3BlcmFu
ZC5pc19hPyBMYWJlbFJlZmVyZW5jZQorICAgICAgICBwcmVMaXN0IDw8IEluc3RydWN0aW9uLm5l
dyhvcGVyYW5kLmNvZGVPcmlnaW4sICJsYSIsIFtvcGVyYW5kLCBNSVBTX0NBTExfUkVHXSkKKyAg
ICBlbHNpZiBvcGVyYW5kLnJlZ2lzdGVyPyBhbmQgb3BlcmFuZCAhPSBNSVBTX0NBTExfUkVHCisg
ICAgICAgIHByZUxpc3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KG9wZXJhbmQuY29kZU9yaWdpbiwgIm1v
dmUiLCBbb3BlcmFuZCwgTUlQU19DQUxMX1JFR10pCisgICAgZWxzZQorICAgICAgICBuZWVkUmVz
dG9yZSA9IGZhbHNlCisgICAgICAgIHRtcCA9IG9wZXJhbmQKKyAgICBlbmQKKyAgICBpZiBuZWVk
UmVzdG9yZQorICAgICAgICBwb3N0TGlzdCA8PCBJbnN0cnVjdGlvbi5uZXcob3BlcmFuZC5jb2Rl
T3JpZ2luLCAibW92ZSIsIFtNSVBTX0dQU0FWRV9SRUcsIE1JUFNfR1BfUkVHXSkKKyAgICBlbmQK
KyAgICB0bXAKK2VuZAorCiBkZWYgbWlwc0xvd2VyTWlzcGxhY2VkQWRkcmVzc2VzKGxpc3QpCiAg
ICAgbmV3TGlzdCA9IFtdCiAgICAgbGlzdC5lYWNoIHsKQEAgLTQ1NCwzMyArNTQxLDEzIEBAIGRl
ZiBtaXBzTG93ZXJNaXNwbGFjZWRBZGRyZXNzZXMobGlzdCkKICAgICAgICAgICAgIGFubm90YXRp
b24gPSBub2RlLmFubm90YXRpb24KICAgICAgICAgICAgIGNhc2Ugbm9kZS5vcGNvZGUKICAgICAg
ICAgICAgIHdoZW4gImptcCIKLSAgICAgICAgICAgICAgICBpZiBub2RlLm9wZXJhbmRzWzBdLmFk
ZHJlc3M/Ci0gICAgICAgICAgICAgICAgICAgIG5ld0xpc3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KG5v
ZGUub3BlcmFuZHNbMF0uY29kZU9yaWdpbiwgImxvYWRpIiwgW25vZGUub3BlcmFuZHNbMF0sIE1J
UFNfSlVNUF9SRUddKQotICAgICAgICAgICAgICAgICAgICBuZXdMaXN0IDw8IEluc3RydWN0aW9u
Lm5ldyhub2RlLmNvZGVPcmlnaW4sIG5vZGUub3Bjb2RlLCBbTUlQU19KVU1QX1JFR10pCi0gICAg
ICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAgICAgICBuZXdMaXN0IDw8IEluc3RydWN0
aW9uLm5ldyhub2RlLmNvZGVPcmlnaW4sCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgIG5vZGUub3Bjb2RlLAotICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBbcmlzY0FzUmVnaXN0ZXIobmV3TGlzdCwgcG9zdEluc3RydWN0
aW9ucywgbm9kZS5vcGVyYW5kc1swXSwgInAiLCBmYWxzZSldKQotICAgICAgICAgICAgICAgIGVu
ZAorICAgICAgICAgICAgICAgIG5ld0xpc3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KG5vZGUuY29kZU9y
aWdpbiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBub2RlLm9w
Y29kZSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBbbWlwc0Fz
UmVnaXN0ZXIobmV3TGlzdCwgW10sIG5vZGUub3BlcmFuZHNbMF0sIGZhbHNlKV0pCiAgICAgICAg
ICAgICB3aGVuICJjYWxsIgotICAgICAgICAgICAgICAgIHJlc3RvcmVHUCA9IGZhbHNlOwotICAg
ICAgICAgICAgICAgIHRtcCA9IE1JUFNfQ0FMTF9SRUcKLSAgICAgICAgICAgICAgICBpZiBub2Rl
Lm9wZXJhbmRzWzBdLmFkZHJlc3M/Ci0gICAgICAgICAgICAgICAgICAgIG5ld0xpc3QgPDwgSW5z
dHJ1Y3Rpb24ubmV3KG5vZGUub3BlcmFuZHNbMF0uY29kZU9yaWdpbiwgImxvYWRwIiwgW25vZGUu
b3BlcmFuZHNbMF0sIE1JUFNfQ0FMTF9SRUddKQotICAgICAgICAgICAgICAgICAgICByZXN0b3Jl
R1AgPSB0cnVlOwotICAgICAgICAgICAgICAgIGVsc2lmIG5vZGUub3BlcmFuZHNbMF0uaXNfYT8g
TGFiZWxSZWZlcmVuY2UKLSAgICAgICAgICAgICAgICAgICAgdG1wID0gbm9kZS5vcGVyYW5kc1sw
XQotICAgICAgICAgICAgICAgICAgICByZXN0b3JlR1AgPSB0cnVlOwotICAgICAgICAgICAgICAg
IGVsc2lmIG5vZGUub3BlcmFuZHNbMF0ucmVnaXN0ZXI/Ci0gICAgICAgICAgICAgICAgICAgIG5l
d0xpc3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KG5vZGUub3BlcmFuZHNbMF0uY29kZU9yaWdpbiwgIm1v
dmUiLCBbbm9kZS5vcGVyYW5kc1swXSwgTUlQU19DQUxMX1JFR10pCi0gICAgICAgICAgICAgICAg
ICAgIHJlc3RvcmVHUCA9IHRydWU7Ci0gICAgICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAg
ICAgICAgICB0bXAgPSBub2RlLm9wZXJhbmRzWzBdCi0gICAgICAgICAgICAgICAgZW5kCi0gICAg
ICAgICAgICAgICAgbmV3TGlzdCA8PCBJbnN0cnVjdGlvbi5uZXcobm9kZS5jb2RlT3JpZ2luLCBu
b2RlLm9wY29kZSwgW3RtcF0pCi0gICAgICAgICAgICAgICAgaWYgcmVzdG9yZUdQCi0gICAgICAg
ICAgICAgICAgICAgIG5ld0xpc3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KG5vZGUuY29kZU9yaWdpbiwg
Im1vdmUiLCBbTUlQU19HUFNBVkVfUkVHLCBNSVBTX0dQX1JFR10pCi0gICAgICAgICAgICAgICAg
ZW5kCisgICAgICAgICAgICAgICAgbmV3TGlzdCA8PCBJbnN0cnVjdGlvbi5uZXcobm9kZS5jb2Rl
T3JpZ2luLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5vZGUu
b3Bjb2RlLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFttaXBz
QXNSZWdpc3RlcihuZXdMaXN0LCBwb3N0SW5zdHJ1Y3Rpb25zLCBub2RlLm9wZXJhbmRzWzBdLCB0
cnVlKV0pCiAgICAgICAgICAgICB3aGVuICJzbHQiLCAic2x0dSIKICAgICAgICAgICAgICAgICBu
ZXdMaXN0IDw8IEluc3RydWN0aW9uLm5ldyhub2RlLmNvZGVPcmlnaW4sCiAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbm9kZS5vcGNvZGUsCkBAIC01NjUsNyArNjMy
LDcgQEAgY2xhc3MgQWRkcmVzcwogZW5kCiAKICMKLSMgQWRkIFBJQyBjb21wYXRpYmxlIGhlYWRl
ciBjb2RlIHRvIHByb2xvZ3VlL2VudHJ5IHJ1dGlucy4KKyMgQWRkIFBJQyBjb21wYXRpYmxlIGhl
YWRlciBjb2RlIHRvIGFsbCB0aGUgTExJbnQgcnV0aW5zLgogIwogCiBkZWYgbWlwc0FkZFBJQ0Nv
ZGUobGlzdCkKQEAgLTU3NCwxMyArNjQxLDcgQEAgZGVmIG1pcHNBZGRQSUNDb2RlKGxpc3QpCiAg
ICAgICAgIHwgbm9kZSB8CiAgICAgICAgIG15TGlzdCA8PCBub2RlCiAgICAgICAgIGlmIG5vZGUu
aXNfYT8gTGFiZWwKLSAgICAgICAgICAgIGlmIC9fcHJvbG9ndWUkLy5tYXRjaChub2RlLm5hbWUp
IHx8IC9eX2xsaW50X2Z1bmN0aW9uXy8ubWF0Y2gobm9kZS5uYW1lKQotICAgICAgICAgICAgICAg
ICMgRnVuY3Rpb25zIGNhbGxlZCBmcm9tIHRyYW1wb2xpbmUvSklUIGNvZGVzLgotICAgICAgICAg
ICAgICAgIG15TGlzdCA8PCBJbnN0cnVjdGlvbi5uZXcobm9kZS5jb2RlT3JpZ2luLCAicGljaGRy
IiwgW10pCi0gICAgICAgICAgICBlbHNpZiAvX2xsaW50X29wX2NhdGNoLy5tYXRjaChub2RlLm5h
bWUpCi0gICAgICAgICAgICAgICAgIyBFeGNlcHRpb24gY2FjdGNoZXIgZW50cnkgcG9pbnQgZnVu
Y3Rpb24uCi0gICAgICAgICAgICAgICAgbXlMaXN0IDw8IEluc3RydWN0aW9uLm5ldyhub2RlLmNv
ZGVPcmlnaW4sICJwaWNoZHJyYSIsIFtdKQotICAgICAgICAgICAgZW5kCisgICAgICAgICAgICBt
eUxpc3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KG5vZGUuY29kZU9yaWdpbiwgInBpY2hkciIsIFtdKQog
ICAgICAgICBlbmQKICAgICB9CiAgICAgbXlMaXN0CkBAIC02MDYsNiArNjY3LDcgQEAgY2xhc3Mg
U2VxdWVuY2UKICAgICAgICAgfQogCiAgICAgICAgIHJlc3VsdCA9IG1pcHNBZGRQSUNDb2RlKHJl
c3VsdCkKKyAgICAgICAgcmVzdWx0ID0gbWlwc0xvd2VyRmFyQnJhbmNoT3BzKHJlc3VsdCkKICAg
ICAgICAgcmVzdWx0ID0gbWlwc0xvd2VyU2ltcGxlQnJhbmNoT3BzKHJlc3VsdCkKICAgICAgICAg
cmVzdWx0ID0gcmlzY0xvd2VyU2ltcGxlQnJhbmNoT3BzKHJlc3VsdCkKICAgICAgICAgcmVzdWx0
ID0gcmlzY0xvd2VySGFyZEJyYW5jaE9wcyhyZXN1bHQpCkBAIC03MTQsNiArNzc2LDE2IEBAIGRl
ZiBlbWl0TUlQU0RvdWJsZUJyYW5jaChicmFuY2hPcGNvZGUsIG5lZywgb3BlcmFuZHMpCiAgICAg
ZW5kCiBlbmQKIAorZGVmIGVtaXRNSVBTSnVtcE9yQ2FsbChvcGNvZGUsIG9wZXJhbmQpCisgICAg
aWYgb3BlcmFuZC5sYWJlbD8KKyAgICAgICAgcmFpc2UgIkRpcmVjdCBjYWxsL2p1bXAgdG8gYSBu
b3QgbG9jYWwgbGFiZWwuIiB1bmxlc3Mgb3BlcmFuZC5pc19hPyBMb2NhbExhYmVsUmVmZXJlbmNl
CisgICAgICAgICRhc20ucHV0cyAiI3tvcGNvZGV9ICN7b3BlcmFuZC5hc21MYWJlbH0iCisgICAg
ZWxzZQorICAgICAgICByYWlzZSAiSW52YWxpZCBjYWxsL2p1bXAgcmVnaXN0ZXIuIiB1bmxlc3Mg
b3BlcmFuZCA9PSBNSVBTX0NBTExfUkVHCisgICAgICAgICRhc20ucHV0cyAiI3tvcGNvZGV9ciAj
e01JUFNfQ0FMTF9SRUcubWlwc09wZXJhbmR9IgorICAgIGVuZAorZW5kCisKIGNsYXNzIEluc3Ry
dWN0aW9uCiAgICAgZGVmIGxvd2VyTUlQUwogICAgICAgICAkYXNtLmNvbW1lbnQgY29kZU9yaWdp
blN0cmluZwpAQCAtNzg0LDYgKzg1Niw4IEBAIGNsYXNzIEluc3RydWN0aW9uCiAgICAgICAgICAg
ICAkYXNtLnB1dHMgImxkYzEgI3ttaXBzRmxpcHBlZE9wZXJhbmRzKG9wZXJhbmRzKX0iCiAgICAg
ICAgIHdoZW4gInN0b3JlZCIKICAgICAgICAgICAgICRhc20ucHV0cyAic2RjMSAje21pcHNPcGVy
YW5kcyhvcGVyYW5kcyl9IgorICAgICAgICB3aGVuICJsYSIKKyAgICAgICAgICAgICRhc20ucHV0
cyAibGEgI3tvcGVyYW5kc1sxXS5taXBzT3BlcmFuZH0sICN7b3BlcmFuZHNbMF0uYXNtTGFiZWx9
IgogICAgICAgICB3aGVuICJhZGRkIgogICAgICAgICAgICAgZW1pdE1JUFMoImFkZC5kIiwgb3Bl
cmFuZHMpCiAgICAgICAgIHdoZW4gImRpdmQiCkBAIC04NzksMTcgKzk1Myw5IEBAIGNsYXNzIElu
c3RydWN0aW9uCiAgICAgICAgIHdoZW4gImJpbHRlcSIsICJicGx0ZXEiLCAiYmJsdGVxIgogICAg
ICAgICAgICAgJGFzbS5wdXRzICJibGUgI3ttaXBzT3BlcmFuZHMob3BlcmFuZHNbMC4uMV0pfSwg
I3tvcGVyYW5kc1syXS5hc21MYWJlbH0iCiAgICAgICAgIHdoZW4gImptcCIKLSAgICAgICAgICAg
IGlmIG9wZXJhbmRzWzBdLmxhYmVsPwotICAgICAgICAgICAgICAgICRhc20ucHV0cyAiaiAje29w
ZXJhbmRzWzBdLmFzbUxhYmVsfSIKLSAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICAk
YXNtLnB1dHMgImpyICN7b3BlcmFuZHNbMF0ubWlwc09wZXJhbmR9IgotICAgICAgICAgICAgZW5k
CisgICAgICAgICAgICBlbWl0TUlQU0p1bXBPckNhbGwoImoiLCBvcGVyYW5kc1swXSkKICAgICAg
ICAgd2hlbiAiY2FsbCIKLSAgICAgICAgICAgIGlmIG9wZXJhbmRzWzBdLmxhYmVsPwotICAgICAg
ICAgICAgICAgICRhc20ucHV0cyAiamFsICN7b3BlcmFuZHNbMF0uYXNtTGFiZWx9IgotICAgICAg
ICAgICAgZWxzZQotICAgICAgICAgICAgICAgICRhc20ucHV0cyAiamFsciAje29wZXJhbmRzWzBd
Lm1pcHNPcGVyYW5kfSIKLSAgICAgICAgICAgIGVuZAorICAgICAgICAgICAgZW1pdE1JUFNKdW1w
T3JDYWxsKCJqYWwiLCBvcGVyYW5kc1swXSkKICAgICAgICAgd2hlbiAiYnJlYWsiCiAgICAgICAg
ICAgICAkYXNtLnB1dHMgImJyZWFrIgogICAgICAgICB3aGVuICJyZXQiCkBAIC05NDgsMTEgKzEw
MTQsOCBAQCBjbGFzcyBJbnN0cnVjdGlvbgogICAgICAgICB3aGVuICJzbHR1IiwgInNsdHViIgog
ICAgICAgICAgICAgJGFzbS5wdXRzICJzbHR1ICN7b3BlcmFuZHNbMF0ubWlwc09wZXJhbmR9LCAj
e29wZXJhbmRzWzFdLm1pcHNPcGVyYW5kfSwgI3tvcGVyYW5kc1syXS5taXBzT3BlcmFuZH0iCiAg
ICAgICAgIHdoZW4gInBpY2hkciIKLSAgICAgICAgICAgICRhc20ucHV0U3RyKCJPRkZMSU5FX0FT
TV9DUExPQUQoJDI1KSIpCi0gICAgICAgICAgICAkYXNtLnB1dHMgIm1vdmUgJHM0LCAkZ3AiCi0g
ICAgICAgIHdoZW4gInBpY2hkcnJhIgotICAgICAgICAgICAgJGFzbS5wdXRTdHIoIk9GRkxJTkVf
QVNNX0NQTE9BRCgkMzEpIikKLSAgICAgICAgICAgICRhc20ucHV0cyAibW92ZSAkczQsICRncCIK
KyAgICAgICAgICAgICRhc20ucHV0U3RyKCJPRkZMSU5FX0FTTV9DUExPQUQoI3tNSVBTX0NBTExf
UkVHLm1pcHNPcGVyYW5kfSkiKQorICAgICAgICAgICAgJGFzbS5wdXRzICJtb3ZlICN7TUlQU19H
UFNBVkVfUkVHLm1pcHNPcGVyYW5kfSwgI3tNSVBTX0dQX1JFRy5taXBzT3BlcmFuZH0iCiAgICAg
ICAgIHdoZW4gIm1lbWZlbmNlIgogICAgICAgICAgICAgJGFzbS5wdXRzICJzeW5jIgogICAgICAg
ICBlbHNlCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>